Vm-dev August 2021

vm-dev@lists.squeakfoundation.org

17 participants
161 discussions

[OpenSmalltalk/opensmalltalk-vm] 534349: Update image build scripts to include VectorEngine...
by David T Lewis 20 Aug '21

20 Aug '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 534349675a76377bc137ca280394cb0ce67f54ac https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/534349675a76377bc1… Author: David T. Lewis <lewis(a)mail.msen.com> Date: 2021-08-19 (Thu, 19 Aug 2021) Changed paths: M image/BuildPharo6VMMakerImage.st M image/BuildSqueakSpurTrunkVMMakerImage.st Log Message: ----------- Update image build scripts to include VectorEnginePlugin. Add the squeaksource mirror repository for Cuis VectorEnginePlugin to the BuildSqueakSpurTrunkVMMakerImage.st BuildPharo6VMMakerImage.st scripts. When building a new VMMaker image from scratch, the VectorEnginePlugin will be loaded and available for generating C source with the VMMaker tool.

2 1

[OpenSmalltalk/opensmalltalk-vm] d8576b: CogVM source as per VMMaker.oscog-eem.3041
by Eliot Miranda 20 Aug '21

20 Aug '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: d8576b00d1c15a921ac238f69d9ab4e201801c64 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d8576b00d1c15a921a… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-08-19 (Thu, 19 Aug 2021) Changed paths: M spur64src/vm/cogit.h M spur64src/vm/cogitARMv8.c M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitARMv8.c M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitARMv8.c M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M src/plugins/SqueakFFIPrims/ARM32FFIPlugin.c M src/plugins/SqueakFFIPrims/ARM64FFIPlugin.c M src/plugins/SqueakFFIPrims/IA32FFIPlugin.c M src/plugins/SqueakFFIPrims/X64SysVFFIPlugin.c M src/plugins/SqueakFFIPrims/X64Win64FFIPlugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/gcc3x-cointerp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3041 Cogit: nuke the one instance of a C ABI interpreter primitive, mcprimHashMultiply:. It now has a machien code implementation and so the interpreter version and its support machinery are now dead weight. Replace this by setting the FastCPrimitive flag for CompiledCode>>#objectAt:put:, primitiveObjectAtPut, which yields about a 4% speedup for e.g. Morph compileAll. ThreadedFFIPlugin: Complements FFI-Pools-mt34 and FFI-Kernel-mt.207. Current version of the FFI plugin is 1. Changes to the atomic-type codes or known classes in special-objects array should bump that version number so that image code can adapt.

1 0

VM Maker: VMMaker.oscog-eem.3042.mcz
by commits＠source.squeak.org 20 Aug '21

20 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3042.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3042 Author: eem Time: 19 August 2021, 5:10:02.37063 pm UUID: 495570eb-8448-4712-a12d-d587a67fe7db Ancestors: VMMaker.oscog-eem.3041 And nuke the now unused FastCPrimitiveUseCABIFlag flag. =============== Diff against VMMaker.oscog-eem.3041 =============== Item was changed: ----- Method: CoInterpreter class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants super initializeMiscConstants. COGVM := true. MinBackwardJumpCountForCompile := 40. MaxNumArgs := 15. PrimCallNeedsNewMethod := 1. PrimCallNeedsPrimitiveFunction := 2. PrimCallMayEndureCodeCompaction := 4. PrimCallCollectsProfileSamples := 8. PrimCallDoNotJIT := 16. PrimCallIsExternalCall := 32. "CheckAllocationFillerAfterPrimCall := 32. this has never been successfully used in all the years we've had it; nuking it" PrimCallOnSmalltalkStack := 64. "Speed up simple external prims by avoiding stack switch" PrimCallOnSmalltalkStackAlign2x := 128. "Align stack to a 2 x word size boundary, e.g. for MMX instructions etc" - FastCPrimitiveUseCABIFlag := 256. "Flags for use in export:flags:, shifted to overlap with the PrimCallXXX flags above" FastCPrimitiveFlag := 1. "a.k.a. PrimCallOnSmalltalkStack" FastCPrimitiveAlignForFloatsFlag := 2. "a.k.a. PrimCallOnSmalltalkStackAlign2x" FastCPrimitiveUseCABIFlag := 4. "a.k.a. FastCPrimitiveUseCABIFlag" PrimitiveMetadataFlagsShift := PrimCallOnSmalltalkStack highBit - FastCPrimitiveFlag highBit. "And to shift away the flags, to compute the accessor depth, use... c.f. NullSpurMetadata in sq.h" SpurPrimitiveAccessorDepthShift := 8. SpurPrimitiveFlagsMask := 1 << SpurPrimitiveAccessorDepthShift - 1. "the primitive trace log; a record of the last 256 named/external primitives or significant events invoked." PrimTraceLogSize := 256. "Room for 256 selectors. Must be 256 because we use a byte to hold the index" TraceBufferSize := 256 * 3. "Room for 256 events" TraceContextSwitch := self objectMemoryClass basicNew integerObjectOf: 1. TraceBlockActivation := self objectMemoryClass basicNew integerObjectOf: 2. TraceBlockCreation := self objectMemoryClass basicNew integerObjectOf: 3. TraceIncrementalGC := self objectMemoryClass basicNew integerObjectOf: 4. TraceFullGC := self objectMemoryClass basicNew integerObjectOf: 5. TraceCodeCompaction := self objectMemoryClass basicNew integerObjectOf: 6. TraceOwnVM := self objectMemoryClass basicNew integerObjectOf: 7. TraceDisownVM := self objectMemoryClass basicNew integerObjectOf: 8. TraceThreadSwitch := self objectMemoryClass basicNew integerObjectOf: 9. TracePreemptDisowningThread := self objectMemoryClass basicNew integerObjectOf: 10. TraceVMCallback := self objectMemoryClass basicNew integerObjectOf: 11. TraceVMCallbackReturn := self objectMemoryClass basicNew integerObjectOf: 12. TraceStackOverflow := self objectMemoryClass basicNew integerObjectOf: 13. TracePrimitiveFailure := self objectMemoryClass basicNew integerObjectOf: 14. TracePrimitiveRetry := self objectMemoryClass basicNew integerObjectOf: 15. TraceIsFromMachineCode := 1. TraceIsFromInterpreter := 2. CSCallbackEnter := 3. CSCallbackLeave := 4. CSEnterCriticalSection := 5. CSExitCriticalSection := 6. CSResume := 7. CSSignal := 8. CSSuspend := 9. CSWait := 10. CSYield := 11. CSCheckEvents := 12. CSThreadSchedulingLoop := 13. CSOwnVM := 14. CSThreadBind := 15. CSSwitchIfNeccessary := 16. TraceSources := CArrayAccessor on: #('?' 'm' 'i' 'callbackEnter' 'callbackLeave' 'enterCritical' 'exitCritical' 'resume' 'signal' 'suspend' 'wait' 'yield' 'eventcheck' 'threadsched' 'ownVM' 'bindToThread' 'switchIfNecessary'). "this is simulation only" RumpCStackSize := 4096! Item was changed: SharedPool subclass: #VMBasicConstants instanceVariableNames: '' + classVariableNames: 'BaseHeaderSize BytecodeSetHasExtensions BytesPerOop BytesPerWord COGMTVM COGVM CloneOnGC CloneOnScavenge DisownVMForFFICall DisownVMForThreading DoAssertionChecks DoExpensiveAssertionChecks FastCPrimitiveAlignForFloatsFlag FastCPrimitiveFlag GCCheckFreeSpace GCCheckImageSegment GCCheckPrimCall GCCheckShorten GCModeBecome GCModeFull GCModeIncremental GCModeNewSpace HashMultiplyConstant HashMultiplyMask IMMUTABILITY LowcodeVM MULTIPLEBYTECODESETS NewspeakVM PharoVM PrimErrBadArgument PrimErrBadIndex PrimErrBadMethod PrimErrBadNumArgs PrimErrBadReceiver PrimErrCallbackError PrimErrFFIException PrimErrGenericFailure PrimErrInappropriate PrimErrInternalError PrimErrLimitExceeded PrimErrNamedInternal PrimErrNeedCompaction PrimErrNoCMemory PrimErrNoMemory PrimErrNoModification PrimErrNotFound PrimErrOSError PrimErrObjectIsPinned PrimErrObjectMayMove PrimErrObjectMoved PrimErrObjectNotPinned PrimErrOperationFailed PrimErrUninitialized PrimErrUnsupported PrimErrWritePa stObject PrimNoErr PrimNumberHandlerMarker PrimNumberNoContextSwitchMarker PrimNumberUnwindMarker SPURVM STACKVM SistaVM TempVectReadBarrier VMBIGENDIAN' - classVariableNames: 'BaseHeaderSize BytecodeSetHasExtensions BytesPerOop BytesPerWord COGMTVM COGVM CloneOnGC CloneOnScavenge DisownVMForFFICall DisownVMForThreading DoAssertionChecks DoExpensiveAssertionChecks FastCPrimitiveAlignForFloatsFlag FastCPrimitiveFlag FastCPrimitiveUseCABIFlag GCCheckFreeSpace GCCheckImageSegment GCCheckPrimCall GCCheckShorten GCModeBecome GCModeFull GCModeIncremental GCModeNewSpace HashMultiplyConstant HashMultiplyMask IMMUTABILITY LowcodeVM MULTIPLEBYTECODESETS NewspeakVM PharoVM PrimErrBadArgument PrimErrBadIndex PrimErrBadMethod PrimErrBadNumArgs PrimErrBadReceiver PrimErrCallbackError PrimErrFFIException PrimErrGenericFailure PrimErrInappropriate PrimErrInternalError PrimErrLimitExceeded PrimErrNamedInternal PrimErrNeedCompaction PrimErrNoCMemory PrimErrNoMemory PrimErrNoModification PrimErrNotFound PrimErrOSError PrimErrObjectIsPinned PrimErrObjectMayMove PrimErrObjectMoved PrimErrObjectNotPinned PrimErrOperationFailed PrimErrUninitialized PrimErr Unsupported PrimErrWritePastObject PrimNoErr PrimNumberHandlerMarker PrimNumberNoContextSwitchMarker PrimNumberUnwindMarker SPURVM STACKVM SistaVM TempVectReadBarrier VMBIGENDIAN' poolDictionaries: '' category: 'VMMaker-Interpreter'! !VMBasicConstants commentStamp: '<historical>' prior: 0! I am a shared pool for basic constants upon which the VM as a whole depends. self ensureClassPool. self classPool declare: #BytesPerWord from: VMSqueakV3ObjectRepresentationConstants classPool. self classPool declare: #BaseHeaderSize from: VMSqueakV3ObjectRepresentationConstants classPool (ObjectMemory classPool keys select: [:k| k beginsWith: 'Byte']) do: [:k| self classPool declare: k from: ObjectMemory classPool]!

1 0

VM Maker: VMMaker.oscog-eem.3041.mcz
by commits＠source.squeak.org 20 Aug '21

20 Aug '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3041.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3041 Author: eem Time: 19 August 2021, 4:51:42.995965 pm UUID: d49739b7-03f7-49a6-817b-f6f232342ad7 Ancestors: VMMaker.oscog-mt.3040 Cogit: nuke the one instance of a C ABI interpreter primitive, mcprimHashMultiply:. It now has a machien code implementation and so the interpreter version and its support machinery are now dead weight. Replace this by setting the FastCPrimitive flag for CompiledCode>>#objectAt:put:, primitiveObjectAtPut, which is good for about a 4% speedup for e.g. Morph compileAll. =============== Diff against VMMaker.oscog-mt.3040 =============== Item was changed: StackInterpreterPrimitives subclass: #CoInterpreter instanceVariableNames: 'cogit cogMethodZone gcMode cogCodeSize desiredCogCodeSize heapBase lastCoggableInterpretedBlockMethod deferSmash deferredSmash primTraceLog primTraceLogIndex traceLog traceLogIndex traceSources cogCompiledCodeCompactionCalledFor statCodeCompactionCount statCodeCompactionUsecs lastUncoggableInterpretedBlockMethod flagInterpretedMethods maxLiteralCountForCompile minBackwardJumpCountForCompile CFramePointer CStackPointer CReturnAddress primTracePluginName' + classVariableNames: 'CSCallbackEnter CSCallbackLeave CSCheckEvents CSEnterCriticalSection CSExitCriticalSection CSOwnVM CSResume CSSignal CSSuspend CSSwitchIfNeccessary CSThreadBind CSThreadSchedulingLoop CSWait CSYield HasBeenReturnedFromMCPC HasBeenReturnedFromMCPCOop MFMethodFlagFrameIsMarkedFlag MinBackwardJumpCountForCompile PrimNumberObjectAtPut PrimTraceLogSize PrimitiveMetadataFlagsShift RumpCStackSize TraceBlockActivation TraceBlockCreation TraceBufferSize TraceCodeCompaction TraceContextSwitch TraceDisownVM TraceFullGC TraceIncrementalGC TraceIsFromInterpreter TraceIsFromMachineCode TraceOwnVM TracePreemptDisowningThread TracePrimitiveFailure TracePrimitiveRetry TraceSources TraceStackOverflow TraceThreadSwitch TraceVMCallback TraceVMCallbackReturn' - classVariableNames: 'CSCallbackEnter CSCallbackLeave CSCheckEvents CSEnterCriticalSection CSExitCriticalSection CSOwnVM CSResume CSSignal CSSuspend CSSwitchIfNeccessary CSThreadBind CSThreadSchedulingLoop CSWait CSYield HasBeenReturnedFromMCPC HasBeenReturnedFromMCPCOop MFMethodFlagFrameIsMarkedFlag MinBackwardJumpCountForCompile PrimNumberHashMultiply PrimTraceLogSize PrimitiveMetadataFlagsShift RumpCStackSize TraceBlockActivation TraceBlockCreation TraceBufferSize TraceCodeCompaction TraceContextSwitch TraceDisownVM TraceFullGC TraceIncrementalGC TraceIsFromInterpreter TraceIsFromMachineCode TraceOwnVM TracePreemptDisowningThread TracePrimitiveFailure TracePrimitiveRetry TraceSources TraceStackOverflow TraceThreadSwitch TraceVMCallback TraceVMCallbackReturn' poolDictionaries: 'CogMethodConstants VMStackFrameOffsets' category: 'VMMaker-JIT'! !CoInterpreter commentStamp: 'eem 3/31/2020 18:56' prior: 0! I am a variant of the StackInterpreter that can co-exist with the Cog JIT. I interpret unjitted methods, either because they have been found for the first time or because they are judged to be too big to JIT. See CogMethod class's comment for method interoperability. cogCodeSize - the current size of the machine code zone cogCompiledCodeCompactionCalledFor - a variable set when the machine code zone runs out of space, causing a machine code zone compaction at the next available opportunity cogMethodZone - the manager for the machine code zone (instance of CogMethodZone) cogit - the JIT (co-jit) (instance of SimpleStackBasedCogit, StackToRegisterMappoingCogit, etc) deferSmash - a flag causing deferral of smashes of the stackLimit around the call of functionSymbol (for assert checks) deferredSmash - a flag noting deferral of smashes of the stackLimit around the call of functionSymbol (for assert checks) desiredCogCodeSize - the desred size of the machine code zone, set at startup or via primitiveVMParameter to be written at snapshot time flagInterpretedMethods - true if methods that are interpreted shoudl have their flag bit set (used to identity methods that are interpreted because they're unjittable for some reason) gcMode - the variable holding the gcMode, used to inform the cogit of how to scan the machine code zone for oops on GC heapBase - the address in memory of the base of the objectMemory's heap, which is immediately above the machine code zone lastCoggableInterpretedBlockMethod - a variable used to invoke the cogit for a block mehtod being invoked repeatedly in the interpreter lastUncoggableInterpretedBlockMethod - a variable used to avoid invoking the cogit for an unjittable method encountered on block evaluation maxLiteralCountForCompile - the variable controlling which methods to jit. methods with a literal count above this value will not be jitted (on the grounds that large methods are typically used for initialization, and take up a lot of space in the code zone) minBackwardJumpCountForCompile - the variable controlling when to attempt to jit a method being interpreted. If as many backward jumps as this occur, the current method will be jitted primTraceLog - a small array implementing a crcular buffer logging the last N primitive invocations, GCs, code compactions, etc used for crash reporting primTraceLogIndex - the index into primTraceLog of the next entry reenterInterpreter - the jmpbuf used to jmp back into the interpreter when transitioning from machine code to the interpreter statCodeCompactionCount - the count of machine code zone compactions statCodeCompactionUsecs - the total microseconds spent in machine code zone compactions traceLog - a log of various events, used in debugging traceLogIndex - the index into traceLog of the next entry traceSources - the names associated with the codes of events in traceLog CFramePointer - if in use, the value of the C frame pointer on most recent entry to the interpreter after start-up or a callback. Used to establish the C stack when calling the run-time from generated machine code. CStackPointer - the value of the C stack pointer on most recent entry to the interpreter after start-up or a callback. Used to establish the C stack when calling the run-time from generated machine code. CReturnAddress - the return address for the function call which invoked the interpreter at start-up. Using this as teh return address when entering the interpreter via ceInvokeInterpeter maintains a valid stack. Since this is effevtively a constant it does not need to be saved and restored once set.! Item was changed: ----- Method: CoInterpreter class>>initializePrimitiveTable (in category 'initialization') ----- initializePrimitiveTable super initializePrimitiveTable. + PrimNumberObjectAtPut := 69. + self assert: (PrimitiveTable at: PrimNumberObjectAtPut + 1) = #primitiveObjectAtPut. - PrimNumberHashMultiply := 159. - self assert: (PrimitiveTable at: PrimNumberHashMultiply + 1) = #primitiveHashMultiply. #(216 253) do: [:pidx| self assert: (PrimitiveTable at: pidx + 1) = #primitiveFail]. self assert: (PrimitiveTable at: 215 + 1) = #primitiveFlushCacheByMethod. PrimitiveTable at: 253 + 1 put: #primitiveCollectCogCodeConstituents; at: 215 + 1 put: #primitiveVoidVMStateForMethod; at: 216 + 1 put: #primitiveMethodXray! Item was changed: ----- Method: CoInterpreter>>accessorDepthForExternalPrimitiveMethod: (in category 'plugin primitive support') ----- accessorDepthForExternalPrimitiveMethod: methodObj - <api> <option: #SpurMemoryManager> | flags lit | self assert: (self isLinkedExternalPrimitive: methodObj). lit := self literal: 0 ofMethod: methodObj. flags := objectMemory fetchPointer: ExternalCallLiteralFlagsIndex ofObject: lit. ^(objectMemory integerValueOf: flags) >>> SpurPrimitiveAccessorDepthShift! Item was added: + ----- Method: CoInterpreter>>accessorDepthForPrimitiveMethod: (in category 'cog jit support') ----- + accessorDepthForPrimitiveMethod: aMethodObj + <api> + <option: #SpurObjectMemory> + | primIndex | + primIndex := self primitiveIndexOf: aMethodObj. + ^primIndex = PrimNumberExternalCall + ifTrue: [self accessorDepthForExternalPrimitiveMethod: aMethodObj] + ifFalse: [self accessorDepthForPrimitiveIndex: primIndex]! Item was removed: - ----- Method: CoInterpreter>>mcprimFunctionForPrimitiveIndex: (in category 'cog jit support') ----- - mcprimFunctionForPrimitiveIndex: primIndex - <api> - primIndex = PrimNumberHashMultiply ifTrue: - [^self cCoerceSimple: #mcprimHashMultiply: to: #sqInt]. - self error: 'unknown mcprim'. - ^nil! Item was removed: - ----- Method: CoInterpreter>>mcprims (in category 'cog jit support') ----- - mcprims - <doNotGenerate> - "Answer all the short-cut machine code primitives that run on the Smalltalk stack, not the C stack." - ^#(mcprimHashMultiply:)! Item was changed: ----- Method: CoInterpreter>>primitivePropertyFlagsForSpur: (in category 'cog jit support') ----- primitivePropertyFlagsForSpur: primIndex <inline: true> "Answer any special requirements of the given primitive. Spur always needs to set primitiveFunctionPointer and newMethod so primitives can retry on failure due to forwarders." | baseFlags | + self cCode: [] inSmalltalk: [#(primitiveObjectAtPut primitiveExternalCall primitiveCalloutToFFI)]. "For senders..." + baseFlags := profileSemaphore = objectMemory nilObject + ifTrue: [0] + ifFalse: [PrimCallCollectsProfileSamples]. + primIndex = PrimNumberObjectAtPut ifTrue: + [^baseFlags + PrimCallOnSmalltalkStack]. + baseFlags := baseFlags + PrimCallNeedsPrimitiveFunction + PrimCallNeedsNewMethod. - self cCode: [] inSmalltalk: [#(mcprimHashMultiply: primitiveExternalCall primitiveCalloutToFFI)]. "For senders..." - primIndex = PrimNumberHashMultiply ifTrue: - [^PrimCallOnSmalltalkStack+FastCPrimitiveUseCABIFlag]. - baseFlags := PrimCallNeedsPrimitiveFunction + PrimCallNeedsNewMethod. - profileSemaphore ~= objectMemory nilObject ifTrue: - [baseFlags := baseFlags bitOr: PrimCallCollectsProfileSamples]. + (self isCalloutPrimitiveIndex: primIndex) ifTrue: "For callbacks & module unloading" + [^baseFlags + PrimCallMayEndureCodeCompaction + PrimCallIsExternalCall]. + (self isCodeCompactingPrimitiveIndex: primIndex) ifTrue: "For code reclamations" + [^baseFlags bitOr: PrimCallMayEndureCodeCompaction]. - (self isCalloutPrimitiveIndex: primIndex) "For callbacks & module unloading" - ifTrue: [baseFlags := baseFlags bitOr: PrimCallMayEndureCodeCompaction + PrimCallIsExternalCall] - ifFalse: - [(self isCodeCompactingPrimitiveIndex: primIndex) ifTrue: "For code reclamations" - [baseFlags := baseFlags bitOr: PrimCallMayEndureCodeCompaction]]. ^baseFlags! Item was removed: - ----- Method: CoInterpreterPrimitives>>mcprimHashMultiply: (in category 'arithmetic primitives') ----- - mcprimHashMultiply: receiverArg - "Machine code primitive for hash multiply. c.f. primitiveHashMultiply. - mcprims consume receiver and arguments as parameters and answer the - result on success, or set the primitive error code and answer 0 on failure." - "Implement 28-bit hashMultiply for SmallInteger and LargePositiveInteger receivers." - <api> - | value | - (objectMemory isIntegerObject: receiverArg) - ifTrue: [value := objectMemory integerValueOf: receiverArg] - ifFalse: - [| ok | - ok := objectMemory is: receiverArg instanceOf: (objectMemory splObj: ClassLargePositiveInteger) compactClassIndex: ClassLargePositiveIntegerCompactIndex. - ok ifFalse: - [self primitiveFailFor: PrimErrBadReceiver. - ^0]. - value := objectMemory byteSwapped32IfBigEndian: (objectMemory fetchLong32: 0 ofObject: receiverArg)]. - ^objectMemory integerObjectOf: (value * HashMultiplyConstant bitAnd: 16rFFFFFFF)! Item was removed: - ----- Method: CogVMSimulator>>mcprimFunctionForPrimitiveIndex: (in category 'cog jit support') ----- - mcprimFunctionForPrimitiveIndex: primIndex - ^self mapFunctionToAddress: (super mcprimFunctionForPrimitiveIndex: primIndex)! Item was removed: - ----- Method: CurrentImageCoInterpreterFacade>>mcprimFunctionForPrimitiveIndex: (in category 'accessing') ----- - mcprimFunctionForPrimitiveIndex: primIndex - ^self oopForObject: (coInterpreter mcprimFunctionForPrimitiveIndex: primIndex)! Item was removed: - ----- Method: SimpleStackBasedCogit>>compileMachineCodeInterpreterPrimitive: (in category 'primitive generators') ----- - compileMachineCodeInterpreterPrimitive: primitiveRoutine - "Compile a call to a machine-code convention interpreter primitive. Call the C routine - on the Smalltalk stack, assuming it consumes little or no stack space." - <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> - | jmpFail liveRegsMask | - "for now handle functions with less than 4 arguments; our C call marshalling machinery - extends up to 4 arguments only, and the first argument of an mcprim is the receiver." - self assert: methodOrBlockNumArgs <= 3. - liveRegsMask := (methodOrBlockNumArgs > self numRegArgs - or: [methodOrBlockNumArgs = 0]) - ifTrue: - [self registerMaskFor: ReceiverResultReg] - ifFalse: - [(self numRegArgs > 1 and: [methodOrBlockNumArgs > 1]) - ifFalse: [self registerMaskFor: ReceiverResultReg and: Arg0Reg] - ifTrue: [self registerMaskFor: ReceiverResultReg and: Arg0Reg and: Arg1Reg]]. - backEnd genSaveRegs: (liveRegsMask bitAnd: CallerSavedRegisterMask). - methodOrBlockNumArgs > self numRegArgs ifTrue: - ["Wrangle args into Arg0Reg, Arg1Reg, SendNumArgsReg & ClassReg" - "offset := self bitCountOf: (liveRegsMask bitAnd: CallerSavedRegisterMask)." - self shouldBeImplemented]. - backEnd - genMarshallNArgs: methodOrBlockNumArgs + 1 - arg: ReceiverResultReg - arg: Arg0Reg - arg: Arg1Reg - arg: SendNumArgsReg - "arg: ClassReg (when we extend C call marshalling to support 5 args for replaceFrom:to:with:startingAt:". - backEnd saveAndRestoreLinkRegUsingCalleeSavedRegNotLiveAtPointOfSendAround: - [self CallFullRT: primitiveRoutine asInteger]. - backEnd - genRemoveNArgsFromStack: methodOrBlockNumArgs + 1; - genRestoreRegs: (liveRegsMask bitAnd: CallerSavedRegisterMask). - self CmpCq: 0 R: ABIResultReg. - jmpFail := self JumpZero: 0. - backEnd genWriteCResultIntoReg: ReceiverResultReg. - self RetN: (methodOrBlockNumArgs > self numRegArgs - ifTrue: [methodOrBlockNumArgs + 1 * objectMemory wordSize] - ifFalse: [0]). - jmpFail jmpTarget: self Label. - ^0! Item was changed: ----- Method: SimpleStackBasedCogit>>compileOnStackExternalPrimitive:flags: (in category 'primitive generators') ----- compileOnStackExternalPrimitive: primitiveRoutine flags: flags "Compile a fast call of a C primitive using the current stack page, avoiding the stack switch except on failure. This convention still uses stackPointer and argumentCount to access operands. Push all operands to the stack, assign stackPointer, argumentCount, and zero primFailCode. Make the call (saving a LinkReg if required). Test for failure and return. On failure on Spur, if there is an accessor depth, assign framePointer and newMethod, do the stack switch, call checkForAndFollowForwardedPrimitiveState, and loop back if forwarders are found. Fall through to frame build." <option: #SpurObjectMemory> <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> | calleeSavedRegisterMask linkRegSaveRegister spRegSaveRegister jmp retry continueAfterProfileSample jumpToTakeSample | self assert: (objectRepresentation hasSpurMemoryManagerAPI and: [flags anyMask: PrimCallOnSmalltalkStack]). self deny: (backEnd hasVarBaseRegister and: [self register: VarBaseReg isInMask: ABICallerSavedRegisterMask]). (coInterpreter recordFastCCallPrimTraceForMethod: methodObj) ifTrue: [self genFastPrimTraceUsing: ClassReg and: SendNumArgsReg]. "Clear the primFailCode and set argumentCount" self MoveCq: 0 R: TempReg. self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. methodOrBlockNumArgs ~= 0 ifTrue: [self AddCq: methodOrBlockNumArgs R: TempReg]. "As small or smaller than move on most archs" self MoveR: TempReg Aw: coInterpreter argumentCountAddress. self genExternalizeStackPointerForFastPrimitiveCall. "We may need to save LinkReg and/or SPReg, and given the stack machinations it is much easier to save them in callee saved registers than on the stack itself." calleeSavedRegisterMask := ABICalleeSavedRegisterMask bitClear: (self registerMaskFor: ClassReg). backEnd hasLinkRegister ifTrue: [linkRegSaveRegister := self availableRegisterOrNoneIn: calleeSavedRegisterMask. self deny: linkRegSaveRegister = NoReg. self MoveR: LinkReg R: linkRegSaveRegister. calleeSavedRegisterMask := calleeSavedRegisterMask bitClear: (self registerMaskFor: linkRegSaveRegister)]. spRegSaveRegister := NoReg. (SPReg ~= NativeSPReg and: [(self isCalleeSavedReg: SPReg) not]) ifTrue: [spRegSaveRegister := self availableRegisterOrNoneIn: calleeSavedRegisterMask. self deny: spRegSaveRegister = NoReg. self MoveR: SPReg R: spRegSaveRegister]. retry := self Label. (flags anyMask: PrimCallOnSmalltalkStackAlign2x) ifTrue: [self AndCq: (objectMemory wordSize * 2 - 1) bitInvert R: SPReg R: NativeSPReg] ifFalse: [SPReg ~= NativeSPReg ifTrue: [backEnd genLoadNativeSPRegWithAlignedSPReg]]. backEnd genMarshallNArgs: 0 arg: 0 arg: 0 arg: 0 arg: 0. self CallFullRT: primitiveRoutine asInteger. backEnd genRemoveNArgsFromStack: 0. self MoveAw: coInterpreter primFailCodeAddress R: TempReg. spRegSaveRegister ~= NoReg ifTrue: [self MoveR: spRegSaveRegister R: SPReg]. self CmpCq: 0 R: TempReg. jmp := self JumpNonZero: 0. "Remember to restore the native stack pointer to point to the C stack, otherwise the Smalltalk frames will get overwritten on an interrupt." SPReg ~= NativeSPReg ifTrue: [backEnd genLoadCStackPointer]. "placing the test here attributes the tick to the primitive plus any checkForAndFollowForwardedPrimitiveState scanning, but attributes all of a failing primitive to the current method (in ceStackOverflow: on frame build)." (backEnd has64BitPerformanceCounter and: [flags anyMask: PrimCallCollectsProfileSamples]) ifTrue: [jumpToTakeSample := self genCheckForProfileTimerTick: (self registerMaskFor: NoReg)]. "At this point the primitive has cut back stackPointer to point to the result." continueAfterProfileSample := self MoveAw: coInterpreter stackPointerAddress R: TempReg. "get result and restore retpc" backEnd hasLinkRegister ifTrue: [self MoveMw: 0 r: TempReg R: ReceiverResultReg; AddCq: objectMemory wordSize R: TempReg R: SPReg; MoveR: linkRegSaveRegister R: LinkReg] ifFalse: [| retpcOffset | "The original retpc is (argumentCount + 1) words below stackPointer." retpcOffset := (methodOrBlockNumArgs + 1 * objectMemory wordSize) negated. self MoveMw: retpcOffset r: TempReg R: ClassReg; "get retpc" MoveR: TempReg R: SPReg; MoveMw: 0 r: TempReg R: ReceiverResultReg; MoveR: ClassReg Mw: 0 r: TempReg "put it back on stack for the return..."]. self RetN: 0. (backEnd has64BitPerformanceCounter and: [flags anyMask: PrimCallCollectsProfileSamples]) ifTrue: [jumpToTakeSample jmpTarget: self Label. self genTakeProfileSample. self Jump: continueAfterProfileSample]. jmp jmpTarget: self Label. + (coInterpreter accessorDepthForPrimitiveMethod: methodObj) >= 0 - (coInterpreter accessorDepthForExternalPrimitiveMethod: methodObj) >= 0 ifTrue: [| skip | "Given that following primitive state to the accessor depth is recursive, we're asking for trouble if we run the fixup on the Smalltalk stack page. Run it on the full C stack instead. This won't be a performance issue since primitive failure should be very rare." self MoveR: FPReg Aw: coInterpreter framePointerAddress. self MoveCw: primitiveRoutine asInteger R: TempReg. self MoveR: TempReg Aw: coInterpreter primitiveFunctionPointerAddress. methodLabel addDependent: (self annotateAbsolutePCRef: (self MoveCw: methodLabel asInteger R: ClassReg)). self MoveMw: (self offset: CogMethod of: #methodObject) r: ClassReg R: TempReg. self MoveR: TempReg Aw: coInterpreter newMethodAddress. self genLoadCStackPointersForPrimCall. backEnd genMarshallNArgs: 0 arg: 0 arg: 0 arg: 0 arg: 0. self CallFullRT: (self cCode: [#checkForAndFollowForwardedPrimitiveState asUnsignedIntegerPtr] inSmalltalk: [self simulatedTrampolineFor: #checkForAndFollowForwardedPrimitiveState]). backEnd genLoadStackPointersForPrimCall: ClassReg. self CmpCq: 0 R: ABIResultReg. skip := self JumpZero: 0. self MoveCq: 0 R: TempReg. self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. self Jump: retry. skip jmpTarget: self Label] ifFalse: "must reload SPReg to undo any alignment change," [(flags anyMask: PrimCallOnSmalltalkStackAlign2x) ifTrue: [backEnd genLoadStackPointersForPrimCall: ClassReg]]. "Remember to restore the native stack pointer to point to the C stack, otherwise the Smalltalk frames will get overwritten on an interrupt." SPReg ~= NativeSPReg ifTrue: [backEnd genLoadCStackPointer]. "The LinkRegister now contains the return address either of the primitive call or of checkForAndFollowForwardedPrimitiveState. It must be restored to the return address of the send invoking this primtiive method." backEnd hasLinkRegister ifTrue: [self MoveR: linkRegSaveRegister R: LinkReg]. "Finally remember to reload ReceiverResultReg if required. Even if arguments have been pushed, the prolog sequence assumes it is live." (self register: ReceiverResultReg isInMask: ABICallerSavedRegisterMask) ifTrue: [self MoveMw: (methodOrBlockNumArgs + (backEnd hasLinkRegister ifTrue: [0] ifFalse: [1])) * objectMemory wordSize r: SPReg R: ReceiverResultReg]. "continue to frame build..." ^0! Item was changed: ----- Method: SimpleStackBasedCogit>>compilePrimitive (in category 'primitive generators') ----- compilePrimitive "Compile a primitive. If possible, performance-critical primitives will be generated by their own routines (primitiveGenerator). Otherwise, if there is a primitive at all, we call the C routine with the usual stack-switching dance, test the primFailCode and then either return on success or continue to the method body." <inline: false> | primitiveDescriptor primitiveRoutine flags | <var: #primitiveDescriptor type: #'PrimitiveDescriptor *'> <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> primitiveIndex = 0 ifTrue: [^0]. "If a descriptor specifies an argument count (by numArgs >= 0) then it must match for the generated code to be correct. For example for speed many primitives use ResultReceiverReg instead of accessing the stack, so the receiver better be at numArgs down the stack. Use the interpreter version if not." ((primitiveDescriptor := self primitiveGeneratorOrNil) notNil and: [primitiveDescriptor primitiveGenerator notNil and: [(primitiveDescriptor primNumArgs < 0 "means generator doesn't care" or: [primitiveDescriptor primNumArgs = (coInterpreter argumentCountOf: methodObj)])]]) ifTrue: [| opcodeIndexAtPrimitive code | "Note opcodeIndex so that any arg load instructions for unimplemented primitives can be discarded." opcodeIndexAtPrimitive := opcodeIndex. code := objectRepresentation perform: primitiveDescriptor primitiveGenerator. (code < 0 and: [code ~= UnimplementedPrimitive]) ifTrue: "Generator failed, so no point continuing..." [^code]. "If the primitive can never fail then there is nothing more that needs to be done." code = UnfailingPrimitive ifTrue: [^0]. "If the machine code version handles all cases the only reason to call the interpreter primitive is to reap the primitive error code. Don't bother if it isn't used." (code = CompletePrimitive and: [(self methodUsesPrimitiveErrorCode: methodObj header: methodHeader) not]) ifTrue: [^0]. "Discard any arg load code generated by the primitive generator." code = UnimplementedPrimitive ifTrue: [opcodeIndex := opcodeIndexAtPrimitive]]. primitiveRoutine := coInterpreter functionPointerForCompiledMethod: methodObj primitiveIndex: primitiveIndex primitivePropertyFlagsInto: (self addressOf: flags put: [:val| flags := val]). (flags anyMask: PrimCallDoNotJIT) ifTrue: [^ShouldNotJIT]. (primitiveRoutine = 0 "no primitive" or: [primitiveRoutine = (self cCoerceSimple: #primitiveFail to: 'void (*)(void)')]) ifTrue: [^self genFastPrimFail]. + (objectRepresentation hasSpurMemoryManagerAPI + and: [flags anyMask: PrimCallOnSmalltalkStack]) ifTrue: + [^self compileOnStackExternalPrimitive: primitiveRoutine flags: flags]. - (flags anyMask: PrimCallOnSmalltalkStack) ifTrue: - [self deny: ((flags anyMask: FastCPrimitiveUseCABIFlag) and: [flags anyMask: PrimCallOnSmalltalkStackAlign2x]). - (flags anyMask: FastCPrimitiveUseCABIFlag) ifTrue: - [^self compileMachineCodeInterpreterPrimitive: (self cCoerceSimple: (coInterpreter mcprimFunctionForPrimitiveIndex: primitiveIndex) - to: 'void (*)(void)')]. - objectRepresentation hasSpurMemoryManagerAPI ifTrue: - [^self compileOnStackExternalPrimitive: primitiveRoutine flags: flags]]. minValidCallAddress := minValidCallAddress min: primitiveRoutine asUnsignedInteger. ^self compileInterpreterPrimitive: primitiveRoutine flags: flags!

1 0

Re: [Vm-dev] GC | Strong or weak reference to arguments on stack?
by Eliot Miranda 19 Aug '21

19 Aug '21

Hi Marcel, > On Aug 18, 2021, at 5:25 AM, Marcel Taeumel <marcel.taeumel(a)hpi.de> wrote: > > Hi all! > > I kind of thought that objects sitting as arguments on active stack frames form strong references. Indeed they must. > Yet, I have a kind of flaky callback test that raises doubts about this assumption. > > Here is an example: > lib qsort: array compare: [:a :b | (a - b) sign]. The block being nil inside the callback could imply that the lookup from thunk address to block yielded nil and be nothing to do with the stack no? > > Maybe it is some interference with GC and FFI callbacks ... Hmm... Anyway, sometimes, the block closure is already "nil" inside the callback when its time to evaluate... But mostly it works fine. :-) I can’t see what you’ve posted below. If displays as a white region. Can you post the stack? What’s the actual error message? If you look down the stack where does the nil block originate? > > Mysterious ;-) > > Best, > Marcel Eliot _,,,^..^,,,_ (phone)

2 1

GC | Strong or weak reference to arguments on stack?
by Marcel Taeumel 18 Aug '21

18 Aug '21

Hi all! I kind of thought that objects sitting as arguments on active stack frames form strong references. Yet, I have a kind of flaky callback test that raises doubts about this assumption. Here is an example: lib qsort: array compare: [:a :b | (a - b) sign]. Maybe it is some interference with GC and FFI callbacks ... Hmm... Anyway, sometimes, the block closure is already "nil" inside the callback when its time to evaluate... But mostly it works fine. :-) Best, Marcel

1 0

VM Maker: VMMaker.oscog-mt.3040.mcz
by commits＠source.squeak.org 17 Aug '21

17 Aug '21

Marcel Taeumel uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-mt.3040.mcz ==================== Summary ==================== Name: VMMaker.oscog-mt.3040 Author: mt Time: 17 August 2021, 12:17:08.912505 pm UUID: 1bacb016-6198-ae4c-8ada-6de9a5db8b55 Ancestors: VMMaker.oscog-mt.3039 Complements FFI-Pools-mt34 and FFI-Kernel-mt.207. Current version of the FFI plugin is 1. Changes to the atomic-type codes or known classes in special-objects array should bump that version number so that image code can adapt. =============== Diff against VMMaker.oscog-mt.3039 =============== Item was changed: ----- Method: FFIPlugin>>ffiAtomicArgByReference:Class: (in category 'callout support') ----- ffiAtomicArgByReference: oop Class: oopClass "Support for generic callout. Prepare a pointer reference to an atomic type for callout. Note: for type 'void*' we allow either one of ByteArray/String/Symbol or wordVariableSubclass." | atomicType isString | <inline: true> atomicType := self atomicTypeOf: ffiArgHeader. (atomicType = FFITypeBool) "No bools on input" ifTrue:[^self ffiFail: FFIErrorCoercionFailed]. + ((atomicType >> 1) = (FFITypeSignedChar8 >> 1)) ifTrue:["string value (char*)" - ((atomicType >> 1) = (FFITypeSignedChar >> 1)) ifTrue:["string value (char*)" "note: the only types allowed for passing into char* types are ByteArray, String, Symbol and *no* other byte indexed objects (e.g., CompiledMethod, LargeInteger). We only check for strings here and fall through to the byte* check otherwise." isString := interpreterProxy includesBehavior: oopClass ThatOf: interpreterProxy classString. isString ifTrue:["String/Symbol" "Strings must be allocated by the ffi support code" ^self ffiPushString: (self cCoerce: (interpreterProxy firstIndexableField: oop) to: 'int') OfLength: (interpreterProxy byteSizeOf: oop)]. "Fall through to byte* test" atomicType := FFITypeUnsignedInt8]. (atomicType = FFITypeVoid or:[(atomicType >> 1) = (FFITypeSignedInt8 >> 1)]) ifTrue:[ "byte* -- see comment on string above" oopClass = interpreterProxy classByteArray ifTrue:["ByteArray" ^self ffiPushPointer: (self cCoerce: (interpreterProxy firstIndexableField: oop) to:'int')]. isString := interpreterProxy includesBehavior: oopClass ThatOf: interpreterProxy classString. isString ifTrue:["String/Symbol" ^self ffiPushPointer: (self cCoerce: (interpreterProxy firstIndexableField: oop) to:'int')]. atomicType = FFITypeVoid ifFalse:[^self ffiFail: FFIErrorCoercionFailed]. "note: type void falls through" ]. (atomicType <= FFITypeSignedInt32 "void/short/int" or:[atomicType = FFITypeSingleFloat]) ifTrue:[ "require a word subclass to work" (interpreterProxy isWords: oop) ifTrue:[ ^self ffiPushPointer: (self cCoerce: (interpreterProxy firstIndexableField: oop) to:'int')]]. ^self ffiFail: FFIErrorCoercionFailed.! Item was changed: ----- Method: FFIPlugin>>ffiCreateReturnPointer: (in category 'callout support') ----- ffiCreateReturnPointer: retVal "Generic callout support. Create a pointer return value from an external function call" | atomicType retOop oop ptr classOop | <var: #ptr type:'int *'> interpreterProxy failed ifTrue:[^nil]. interpreterProxy pop: interpreterProxy methodArgumentCount+1. (ffiRetClass == interpreterProxy nilObject) ifTrue:[ "Create ExternalData upon return" atomicType := self atomicTypeOf: ffiRetHeader. + (atomicType >> 1) = (FFITypeSignedChar8 >> 1) ifTrue:["String return" - (atomicType >> 1) = (FFITypeSignedChar >> 1) ifTrue:["String return" ^self ffiReturnCStringFrom: retVal]. "generate external data" interpreterProxy pushRemappableOop: ffiRetOop. oop := interpreterProxy instantiateClass: interpreterProxy classExternalAddress indexableSize: 4. ptr := interpreterProxy firstIndexableField: oop. ptr at: 0 put: retVal. interpreterProxy pushRemappableOop: oop. "preserve for gc" retOop := interpreterProxy instantiateClass: interpreterProxy classExternalData indexableSize: 0. oop := interpreterProxy popRemappableOop. "external address" interpreterProxy storePointer: 0 ofObject: retOop withValue: oop. oop := interpreterProxy popRemappableOop. "return type" interpreterProxy storePointer: 1 ofObject: retOop withValue: oop. ^interpreterProxy push: retOop. ]. "non-atomic pointer return" interpreterProxy pushRemappableOop: ffiRetClass. "preserve for gc" (ffiRetHeader anyMask: FFIFlagStructure) ifTrue:[classOop := interpreterProxy classByteArray] ifFalse:[classOop := interpreterProxy classExternalAddress]. oop := interpreterProxy instantiateClass: classOop indexableSize: 4. ptr := interpreterProxy firstIndexableField: oop. ptr at: 0 put: retVal. ffiRetClass := interpreterProxy popRemappableOop. "return class" interpreterProxy pushRemappableOop: oop. "preserve for gc" retOop := interpreterProxy instantiateClass: ffiRetClass indexableSize: 0. oop := interpreterProxy popRemappableOop. "external address" interpreterProxy storePointer: 0 ofObject: retOop withValue: oop. ^interpreterProxy push: retOop.! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiAtomicArgByReference:Class:in: (in category 'callout support') ----- ffiAtomicArgByReference: oop Class: oopClass in: calloutState <var: #calloutState type: #'CalloutState *'> "Support for generic callout. Prepare a pointer reference to an atomic type for callout. Note: for type 'void*' we allow ByteArray/String/Symbol, wordVariableSubclass, Alien or ExternalAddress. for other types we allow ByteArray, wordVariableSubclass, Alien or ExternalAddress." | atomicType isString argIsAlien | <inline: #always> atomicType := self atomicTypeOf: calloutState ffiArgHeader. (atomicType = FFITypeBool) ifTrue: "No bools on input" [^FFIErrorCoercionFailed]. argIsAlien := (isString := interpreterProxy includesBehavior: oopClass ThatOf: interpreterProxy classString) ifTrue: [false] ifFalse: [interpreterProxy includesBehavior: oopClass ThatOf: interpreterProxy classAlien]. + ((atomicType >> 1) = (FFITypeSignedChar8 >> 1)) ifTrue:"string value (char*)" - ((atomicType >> 1) = (FFITypeSignedChar >> 1)) ifTrue:"string value (char*)" "note: the only types allowed for passing into char* types are ByteArray, String, Symbol, Alien and *no* other byte indexed objects (e.g., CompiledMethod, LargeInteger). We only check for strings here and fall through to the byte* check otherwise." [isString ifTrue:"String/Symbol" "Strings must be allocated by the ffi support code" [^self ffiPushString: (interpreterProxy firstIndexableField: oop) OfLength: (interpreterProxy byteSizeOf: oop) in: calloutState]. "Fall through to byte* test" atomicType := FFITypeUnsignedInt8]. self cppIf: COGMTVM ifTrue: ["Since all the following pass the address of the first indexable field we need to fail the call if it is threaded and the object is young, since it may move during the call." ((calloutState callFlags anyMask: FFICallFlagThreaded) and: [(argIsAlien not or: [self isDirectAlien: oop]) and: [interpreterProxy isYoung: oop]]) ifTrue: [^PrimErrObjectMayMove negated]]. (atomicType = FFITypeVoid or:[(atomicType >> 1) = (FFITypeSignedInt8 >> 1)]) ifTrue: "byte* -- see comment on string above" [(isString or: [oopClass = interpreterProxy classByteArray]) ifTrue: "String/Symbol/ByteArray" [^self ffiPushPointer: (interpreterProxy firstIndexableField: oop) in: calloutState]. (oopClass = interpreterProxy classExternalAddress) ifTrue: [^self ffiPushPointer: (self longAt: oop + interpreterProxy baseHeaderSize) in: calloutState]. argIsAlien ifTrue: [^self ffiPushPointer: (self pointerForOop: (self startOfData: oop)) in: calloutState]. atomicType = FFITypeVoid ifFalse: [^FFIErrorCoercionFailed]]. "note: type void falls through" "I can push pointers to any type (take for instance calls who receive int* output arguments, etc.) but I need to store them into a ByteArray, ExternalAddress or Alien" (atomicType <= FFITypeDoubleFloat) ifTrue: [((interpreterProxy isWords: oop) or: [oopClass = interpreterProxy classByteArray]) ifTrue: [^self ffiPushPointer: (interpreterProxy firstIndexableField: oop) in: calloutState]. (oopClass = interpreterProxy classExternalAddress) ifTrue: [^self ffiPushPointer: (self longAt: oop + interpreterProxy baseHeaderSize) in: calloutState]. argIsAlien ifTrue: [^self ffiPushPointer: (self pointerForOop: (self startOfData: oop)) in: calloutState]]. ^FFIErrorCoercionFailed! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiReturnPointer:ofType:in: (in category 'callout support') ----- ffiReturnPointer: retVal ofType: retType in: calloutState <var: #calloutState type: #'CalloutState *'> <var: #retVal type: #usqLong> "Generic callout support. Create a pointer return value from an external function call" | retClass atomicType retOop oop ptr classOop | <var: #ptr type: #'sqInt *'> retClass := interpreterProxy fetchPointer: 1 ofObject: retType. retClass = interpreterProxy nilObject ifTrue: ["Create ExternalData upon return" atomicType := self atomicTypeOf: calloutState ffiRetHeader. + (atomicType >> 1) = (FFITypeSignedChar8 >> 1) ifTrue: "String return" - (atomicType >> 1) = (FFITypeSignedChar >> 1) ifTrue: "String return" [retOop := self ffiReturnCStringFrom: (self cCoerceSimple: retVal to: #usqInt). ^retOop]. "generate external data" self remapOop: retType in: [oop := interpreterProxy instantiateClass: interpreterProxy classExternalAddress indexableSize: BytesPerWord. ptr := interpreterProxy firstIndexableField: oop. ptr at: 0 put: (self cCoerceSimple: retVal to: #sqInt). self remapOop: oop in: [retOop := interpreterProxy instantiateClass: interpreterProxy classExternalData indexableSize: 0]. interpreterProxy storePointer: 0 ofObject: retOop withValue: oop]. interpreterProxy storePointer: 1 ofObject: retOop withValue: retType. ^retOop]. "non-atomic pointer return" classOop := (calloutState ffiRetHeader anyMask: FFIFlagStructure) ifTrue:[interpreterProxy classByteArray] ifFalse:[interpreterProxy classExternalAddress]. self remapOop: retClass in: [oop := interpreterProxy instantiateClass: classOop indexableSize: BytesPerWord]. ptr := interpreterProxy firstIndexableField: oop. ptr at: 0 put: (self cCoerceSimple: retVal to: #sqInt). self remapOop: oop in: [retOop := interpreterProxy instantiateClass: retClass indexableSize: 0]. interpreterProxy storePointer: 0 ofObject: retOop withValue: oop. ^retOop! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiValidateExternalData:AtomicType: (in category 'callout support') ----- ffiValidateExternalData: oop AtomicType: atomicType "Validate if the given oop (an instance of ExternalData) can be passed as a pointer to the given atomic type." | ptrType specOop spec specType | <inline: true> ptrType := interpreterProxy fetchPointer: 1 ofObject: oop. ((interpreterProxy isPointers: ptrType) and: [(interpreterProxy slotSizeOf: ptrType) >= 2]) ifFalse: [^FFIErrorWrongType]. specOop := interpreterProxy fetchPointer: 0 ofObject: ptrType. ((interpreterProxy isWords: specOop) and: [(interpreterProxy slotSizeOf: specOop) > 0]) ifFalse: [^FFIErrorWrongType]. spec := interpreterProxy fetchPointer: 0 ofObject: specOop. (self isAtomicType: spec) ifFalse: [^FFIErrorWrongType]. specType := self atomicTypeOf: spec. specType ~= atomicType ifTrue: "Allow for signed/unsigned conversion but nothing else. See FFIConstants class>>#initializeTypeConstants" [(atomicType >= FFITypeUnsignedInt8 + and: [atomicType <= FFITypeSignedChar32 - and: [atomicType <= FFITypeSignedChar and: [(atomicType >> 1) = (specType >> 1)]]) ifFalse: [^FFIErrorCoercionFailed]]. ^0! Item was added: + ----- Method: ThreadedFFIPlugin>>primitivePluginVersion (in category 'primitives') ----- + primitivePluginVersion + "Answer the plugins current version to ensure compatibility with data structures shared between plugin an image code such as: + - Type codes in FFIConstants + - Known classes in the special-objects array" + <export: true flags: #FastCPrimitiveFlag> + ^ interpreterProxy methodReturnInteger: 1!

1 0

[OpenSmalltalk/opensmalltalk-vm] 66c0d5: dropRequestFileHandle must answer nilObject on fai...
by Eliot Miranda 17 Aug '21

17 Aug '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 66c0d57d35bf5f8ee00ca8e1493398d7436fe744 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/66c0d57d35bf5f8ee0… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-08-16 (Mon, 16 Aug 2021) Changed paths: M platforms/iOS/vm/OSX/sqSqueakOSXDropAPI.m Log Message: ----------- dropRequestFileHandle must answer nilObject on failure, not NULL. Fixed crashes with launch URI events on macOS.

1 0

Underscore for assignment in VMMaker and related plugins
by David T. Lewis 16 Aug '21

16 Aug '21

Background: By convention the assignment operator in modern day Squeak is ':=' and it Cuis it is '_'. The actual fonts are rendered nicely in either case for Cuis and Squeak. The VMs used for Cuis and Squeak consist of the VM proper along with various VM plugins such as OSProcessPlugin and VectorEnginePlugin. The VM plugins are written in Smalltalk ("slang") with supporting external code as needed. The Smalltalk code for each VM plugin is translated to C code, and the resulting C code is expected to be correct regardless of the dialect of Squeak/Cuis in which the plugin is written. The generated C code for a VM plugin is the same regardless of whether the Smalltalk source is written in the '_' or ':=' convention. However, mixing these two conventions in the same VMMaker image may be confusing, especially if the (Squeak) image has disabled its 'Allow underscore selectors' preference. OK, enough background. The question I want to present is this: The new VectorEnginePlugin is being developed in Cuis, and therefore uses the '_' convention in its Smalltalk source code. When building a new opensmalltalk-vm VMMaker image from primary sources, the 'Allow underscore selectors' preference' is disabled, presumably in order to catch VM plugin code that accidentally uses the '_' convention. However, in the case of VectorEnginePlugin, the use of '_' is intentional, and we can expect it to be used for current and future versions of the plugin Smalltalk code as development proceeds. So should we: 1) Relax the restriction and allow VectorEnginePlugin to be loaded without modification in a VMMaker image or: 2) Convert current and future versions of the VectorEnginePlugin Smalltalk to use ':=' for assigments prior to loading in a Squeak VMMaker image (method author/timestamps would be preserved). I personally prefer 1) but consider either option to be reasonable and doable. Comments? Preferences? Dave

4 9

VM Maker: VMMaker.oscog-mt.3039.mcz
by commits＠source.squeak.org 16 Aug '21

16 Aug '21

Marcel Taeumel uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-mt.3039.mcz ==================== Summary ==================== Name: VMMaker.oscog-mt.3039 Author: mt Time: 16 August 2021, 9:14:03.822631 am UUID: b082e313-a708-7f47-a7fd-5d96cb87a2df Ancestors: VMMaker.oscog-eem.3038 Complements FFI-Pools-mt.33 =============== Diff against VMMaker.oscog-eem.3038 =============== Item was changed: ----- Method: FFIPlugin>>ffiArgByValue: (in category 'callout support') ----- ffiArgByValue: oop "Support for generic callout. Prepare an argument by value for a callout." | atomicType intValue floatValue | <inline: true> <var: #floatValue type: 'double'> atomicType := self atomicTypeOf: ffiArgHeader. "check if the range is valid" (atomicType < 0 or:[atomicType > FFITypeDoubleFloat]) ifTrue:[^self ffiFail: FFIErrorBadAtomicType]. atomicType < FFITypeSingleFloat ifTrue:["integer types" + (atomicType >> 1) = (FFITypeSignedInt64 >> 1) - (atomicType >> 1) = (FFITypeSignedLongLong >> 1) ifTrue:[intValue := oop] "ffi support code must coerce longlong" ifFalse:[intValue := self ffiIntegerValueOf: oop]. "does all the coercions" interpreterProxy failed ifTrue:[^self ffiFail: FFIErrorCoercionFailed]. self dispatchOn: atomicType in: #( ffiPushVoid: ffiPushUnsignedInt: ffiPushUnsignedByte: ffiPushSignedByte: ffiPushUnsignedShort: ffiPushSignedShort: ffiPushUnsignedInt: ffiPushSignedInt: ffiPushUnsignedLongLongOop: ffiPushSignedLongLongOop: ffiPushUnsignedChar: ffiPushSignedChar:) with: intValue. ] ifFalse:[ "either float or double" floatValue := self ffiFloatValueOf: oop. interpreterProxy failed ifTrue:[^self ffiFail: FFIErrorCoercionFailed]. atomicType = FFITypeSingleFloat ifTrue:[self ffiPushSingleFloat: floatValue] ifFalse:[self ffiPushDoubleFloat: floatValue]. ]. ^0! Item was changed: ----- Method: FFIPlugin>>ffiAtomicArgByReference:Class: (in category 'callout support') ----- ffiAtomicArgByReference: oop Class: oopClass "Support for generic callout. Prepare a pointer reference to an atomic type for callout. Note: for type 'void*' we allow either one of ByteArray/String/Symbol or wordVariableSubclass." | atomicType isString | <inline: true> atomicType := self atomicTypeOf: ffiArgHeader. (atomicType = FFITypeBool) "No bools on input" ifTrue:[^self ffiFail: FFIErrorCoercionFailed]. ((atomicType >> 1) = (FFITypeSignedChar >> 1)) ifTrue:["string value (char*)" "note: the only types allowed for passing into char* types are ByteArray, String, Symbol and *no* other byte indexed objects (e.g., CompiledMethod, LargeInteger). We only check for strings here and fall through to the byte* check otherwise." isString := interpreterProxy includesBehavior: oopClass ThatOf: interpreterProxy classString. isString ifTrue:["String/Symbol" "Strings must be allocated by the ffi support code" ^self ffiPushString: (self cCoerce: (interpreterProxy firstIndexableField: oop) to: 'int') OfLength: (interpreterProxy byteSizeOf: oop)]. "Fall through to byte* test" + atomicType := FFITypeUnsignedInt8]. - atomicType := FFITypeUnsignedByte]. + (atomicType = FFITypeVoid or:[(atomicType >> 1) = (FFITypeSignedInt8 >> 1)]) ifTrue:[ - (atomicType = FFITypeVoid or:[(atomicType >> 1) = (FFITypeSignedByte >> 1)]) ifTrue:[ "byte* -- see comment on string above" oopClass = interpreterProxy classByteArray ifTrue:["ByteArray" ^self ffiPushPointer: (self cCoerce: (interpreterProxy firstIndexableField: oop) to:'int')]. isString := interpreterProxy includesBehavior: oopClass ThatOf: interpreterProxy classString. isString ifTrue:["String/Symbol" ^self ffiPushPointer: (self cCoerce: (interpreterProxy firstIndexableField: oop) to:'int')]. atomicType = FFITypeVoid ifFalse:[^self ffiFail: FFIErrorCoercionFailed]. "note: type void falls through" ]. + (atomicType <= FFITypeSignedInt32 "void/short/int" - (atomicType <= FFITypeSignedInt "void/short/int" or:[atomicType = FFITypeSingleFloat]) ifTrue:[ "require a word subclass to work" (interpreterProxy isWords: oop) ifTrue:[ ^self ffiPushPointer: (self cCoerce: (interpreterProxy firstIndexableField: oop) to:'int')]]. ^self ffiFail: FFIErrorCoercionFailed.! Item was changed: ----- Method: FFIPlugin>>ffiCreateReturnOop: (in category 'callout support') ----- ffiCreateReturnOop: retVal "Callout support. Return the appropriate oop for the given atomic value" | atomicType shift value mask byteSize | atomicType := self atomicTypeOf: ffiRetHeader. atomicType = FFITypeBool ifTrue:[ "Make sure bool honors the byte size requested" byteSize := ffiRetHeader bitAnd: FFIStructSizeMask. byteSize = 4 ifTrue:[value := retVal] ifFalse:[value := retVal bitAnd: 1 << (byteSize * 8) - 1]. value = 0 ifTrue:[^interpreterProxy falseObject] ifFalse:[^interpreterProxy trueObject]]. + atomicType <= FFITypeSignedInt32 ifTrue:[ - atomicType <= FFITypeSignedInt ifTrue:[ "these are all generall integer returns" + atomicType <= FFITypeSignedInt16 ifTrue:[ - atomicType <= FFITypeSignedShort ifTrue:[ "byte/short. first extract partial word, then sign extend" shift := (atomicType >> 1) * 8. "# of significant bits" value := retVal bitAnd: (1 << shift - 1). (atomicType anyMask: 1) ifTrue:[ "make the guy signed" mask := 1 << (shift-1). value := (value bitAnd: mask-1) - (value bitAnd: mask)]. ^interpreterProxy integerObjectOf: value]. "32bit integer return" (atomicType anyMask: 1) ifTrue:[^(interpreterProxy signed32BitIntegerFor: retVal)] "signed return" ifFalse:[^(interpreterProxy positive32BitIntegerFor: retVal)]]. "unsigned return" atomicType < FFITypeSingleFloat ifTrue:[ "longlong, char" + (atomicType >> 1) = (FFITypeSignedInt64 >> 1) - (atomicType >> 1) = (FFITypeSignedLongLong >> 1) ifTrue:[^self ffiCreateLongLongReturn: (atomicType anyMask: 1)] ifFalse:[^(interpreterProxy fetchPointer: (retVal bitAnd: 255) ofObject: interpreterProxy characterTable)]]. "float return" ^interpreterProxy floatObjectOf: (self ffiReturnFloatValue).! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiArgByValue:in: (in category 'callout support') ----- ffiArgByValue: oop in: calloutState "Support for generic callout. Prepare an argument by value for a callout." <var: #calloutState type: #'CalloutState *'> | atomicType intValue floatValue | <inline: true> <var: #floatValue type: #double> atomicType := self atomicTypeOf: calloutState ffiArgHeader. "check if the range is valid" (atomicType < 0 or:[atomicType > FFITypeDoubleFloat]) ifTrue:[^FFIErrorBadAtomicType]. atomicType < FFITypeSingleFloat ifTrue:["integer types" + (atomicType >> 1) = (FFITypeSignedInt64 >> 1) - (atomicType >> 1) = (FFITypeSignedLongLong >> 1) ifTrue:[intValue := oop] "ffi support code must coerce longlong" ifFalse:[intValue := self ffiIntegerValueOf: oop]. "does all the coercions" interpreterProxy failed ifTrue:[^FFIErrorCoercionFailed]. ^self dispatchOn: atomicType in: #( ffiPushVoid:in: ffiPushUnsignedInt:in: ffiPushUnsignedByte:in: ffiPushSignedByte:in: ffiPushUnsignedShort:in: ffiPushSignedShort:in: ffiPushUnsignedInt:in: ffiPushSignedInt:in: ffiPushUnsignedLongLongOop:in: ffiPushSignedLongLongOop:in: ffiPushUnsignedChar:in: ffiPushSignedChar:in:) with: intValue with: calloutState]. "either float or double" floatValue := self ffiFloatValueOf: oop. interpreterProxy failed ifTrue: [^FFIErrorCoercionFailed]. atomicType = FFITypeSingleFloat ifTrue: [^self ffiPushSingleFloat: floatValue in: calloutState] ifFalse:[^self ffiPushDoubleFloat: floatValue in: calloutState]! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiAtomicArgByReference:Class:in: (in category 'callout support') ----- ffiAtomicArgByReference: oop Class: oopClass in: calloutState <var: #calloutState type: #'CalloutState *'> "Support for generic callout. Prepare a pointer reference to an atomic type for callout. Note: for type 'void*' we allow ByteArray/String/Symbol, wordVariableSubclass, Alien or ExternalAddress. for other types we allow ByteArray, wordVariableSubclass, Alien or ExternalAddress." | atomicType isString argIsAlien | <inline: #always> atomicType := self atomicTypeOf: calloutState ffiArgHeader. (atomicType = FFITypeBool) ifTrue: "No bools on input" [^FFIErrorCoercionFailed]. argIsAlien := (isString := interpreterProxy includesBehavior: oopClass ThatOf: interpreterProxy classString) ifTrue: [false] ifFalse: [interpreterProxy includesBehavior: oopClass ThatOf: interpreterProxy classAlien]. ((atomicType >> 1) = (FFITypeSignedChar >> 1)) ifTrue:"string value (char*)" "note: the only types allowed for passing into char* types are ByteArray, String, Symbol, Alien and *no* other byte indexed objects (e.g., CompiledMethod, LargeInteger). We only check for strings here and fall through to the byte* check otherwise." [isString ifTrue:"String/Symbol" "Strings must be allocated by the ffi support code" [^self ffiPushString: (interpreterProxy firstIndexableField: oop) OfLength: (interpreterProxy byteSizeOf: oop) in: calloutState]. "Fall through to byte* test" + atomicType := FFITypeUnsignedInt8]. - atomicType := FFITypeUnsignedByte]. self cppIf: COGMTVM ifTrue: ["Since all the following pass the address of the first indexable field we need to fail the call if it is threaded and the object is young, since it may move during the call." ((calloutState callFlags anyMask: FFICallFlagThreaded) and: [(argIsAlien not or: [self isDirectAlien: oop]) and: [interpreterProxy isYoung: oop]]) ifTrue: [^PrimErrObjectMayMove negated]]. + (atomicType = FFITypeVoid or:[(atomicType >> 1) = (FFITypeSignedInt8 >> 1)]) ifTrue: - (atomicType = FFITypeVoid or:[(atomicType >> 1) = (FFITypeSignedByte >> 1)]) ifTrue: "byte* -- see comment on string above" [(isString or: [oopClass = interpreterProxy classByteArray]) ifTrue: "String/Symbol/ByteArray" [^self ffiPushPointer: (interpreterProxy firstIndexableField: oop) in: calloutState]. (oopClass = interpreterProxy classExternalAddress) ifTrue: [^self ffiPushPointer: (self longAt: oop + interpreterProxy baseHeaderSize) in: calloutState]. argIsAlien ifTrue: [^self ffiPushPointer: (self pointerForOop: (self startOfData: oop)) in: calloutState]. atomicType = FFITypeVoid ifFalse: [^FFIErrorCoercionFailed]]. "note: type void falls through" "I can push pointers to any type (take for instance calls who receive int* output arguments, etc.) but I need to store them into a ByteArray, ExternalAddress or Alien" (atomicType <= FFITypeDoubleFloat) ifTrue: [((interpreterProxy isWords: oop) or: [oopClass = interpreterProxy classByteArray]) ifTrue: [^self ffiPushPointer: (interpreterProxy firstIndexableField: oop) in: calloutState]. (oopClass = interpreterProxy classExternalAddress) ifTrue: [^self ffiPushPointer: (self longAt: oop + interpreterProxy baseHeaderSize) in: calloutState]. argIsAlien ifTrue: [^self ffiPushPointer: (self pointerForOop: (self startOfData: oop)) in: calloutState]]. ^FFIErrorCoercionFailed! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiCreateIntegralResultOop:ofAtomicType:in: (in category 'callout support') ----- ffiCreateIntegralResultOop: retVal ofAtomicType: atomicType in: calloutState <inline: #always> <var: #calloutState type: #'CalloutState *'> <var: #retVal type: #usqLong> "Callout support. Return the appropriate oop for the given atomic type" | shift value mask byteSize | <var: 'value' type: #usqLong> <var: 'mask' type: #usqLong> self assert: atomicType < FFITypeSingleFloat. atomicType = FFITypeBool ifTrue: ["Make sure bool honors the byte size requested" byteSize := calloutState ffiRetHeader bitAnd: FFIStructSizeMask. value := byteSize = (self sizeof: retVal) ifTrue:[retVal] ifFalse:[retVal bitAnd: 1 asUnsignedLongLong << (byteSize * 8) - 1]. ^value = 0 ifTrue:[interpreterProxy falseObject] ifFalse:[interpreterProxy trueObject]]. + atomicType <= FFITypeSignedInt32 ifTrue: - atomicType <= FFITypeSignedInt ifTrue: ["these are all generall integer returns" + atomicType <= (BytesPerWord = 8 ifTrue: [FFITypeSignedInt32] ifFalse: [FFITypeSignedInt16]) ifTrue: - atomicType <= (BytesPerWord = 8 ifTrue: [FFITypeSignedInt] ifFalse: [FFITypeSignedShort]) ifTrue: ["byte/short. first extract partial word, then sign extend" + shift := (BytesPerWord = 8 and: [atomicType >= FFITypeUnsignedInt32]) - shift := (BytesPerWord = 8 and: [atomicType >= FFITypeUnsignedInt]) ifTrue: [32] ifFalse: [(atomicType >> 1) * 8]. "# of significant bits" value := retVal bitAnd: (1 asUnsignedLongLong << shift - 1). (atomicType anyMask: 1) ifTrue: ["make the guy signed" mask := 1 asUnsignedLongLong << (shift-1). value := (value bitAnd: mask-1) - (value bitAnd: mask)]. ^interpreterProxy integerObjectOf: value]. "Word sized integer return" ^(atomicType anyMask: 1) ifTrue:[interpreterProxy signedMachineIntegerFor: retVal] "signed return" ifFalse:[interpreterProxy positiveMachineIntegerFor: retVal]]. "unsigned return" "longlong, char" + (atomicType >> 1) = (FFITypeSignedInt64 >> 1) ifTrue: - (atomicType >> 1) = (FFITypeSignedLongLong >> 1) ifTrue: [^(atomicType anyMask: 1) ifTrue: [interpreterProxy signed64BitIntegerFor: retVal] "signed return" ifFalse: [interpreterProxy positive64BitIntegerFor: retVal]]. self flag: 'we need a solution for wide characters; spur supports upto 30 bit characters'. ^interpreterProxy characterObjectOf: (retVal bitAnd: 16rFF)! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiValidateExternalData:AtomicType: (in category 'callout support') ----- ffiValidateExternalData: oop AtomicType: atomicType "Validate if the given oop (an instance of ExternalData) can be passed as a pointer to the given atomic type." | ptrType specOop spec specType | <inline: true> ptrType := interpreterProxy fetchPointer: 1 ofObject: oop. ((interpreterProxy isPointers: ptrType) and: [(interpreterProxy slotSizeOf: ptrType) >= 2]) ifFalse: [^FFIErrorWrongType]. specOop := interpreterProxy fetchPointer: 0 ofObject: ptrType. ((interpreterProxy isWords: specOop) and: [(interpreterProxy slotSizeOf: specOop) > 0]) ifFalse: [^FFIErrorWrongType]. spec := interpreterProxy fetchPointer: 0 ofObject: specOop. (self isAtomicType: spec) ifFalse: [^FFIErrorWrongType]. specType := self atomicTypeOf: spec. specType ~= atomicType ifTrue: "Allow for signed/unsigned conversion but nothing else. See FFIConstants class>>#initializeTypeConstants" + [(atomicType >= FFITypeUnsignedInt8 - [(atomicType >= FFITypeUnsignedByte and: [atomicType <= FFITypeSignedChar and: [(atomicType >> 1) = (specType >> 1)]]) ifFalse: [^FFIErrorCoercionFailed]]. ^0! Item was changed: ----- Method: ThreadedFFIPlugin>>primitiveStructureElementAlignment (in category 'primitives') ----- primitiveStructureElementAlignment "Answer the alignment of an element of an atomic type, or a structure, within a structure on the current platform." <export: true flags: #FastCPrimitiveFlag> | typeCode alignment | <var: 'alignment' type: #'void *'> typeCode := interpreterProxy stackValue: 0. ((interpreterProxy isIntegerObject: typeCode) + and: [((typeCode := interpreterProxy integerValueOf: typeCode) between: FFITypeUnsignedInt8 and: FFITypeDoubleFloat) - and: [((typeCode := interpreterProxy integerValueOf: typeCode) between: FFITypeUnsignedByte and: FFITypeDoubleFloat) or: [typeCode = FFIFlagStructure]]) ifFalse: [^self primitiveFailFor: PrimErrBadArgument]. alignment := typeCode caseOf: { + [FFITypeUnsignedInt8] -> [self structOffsetOf: 'structByte *' atomicTypeCode: FFITypeUnsignedInt8]. + [FFITypeSignedInt8] -> [self structOffsetOf: 'structByte *' atomicTypeCode: FFITypeSignedInt8]. + [FFITypeUnsignedInt16] -> [self structOffsetOf: 'structShort *' atomicTypeCode: FFITypeUnsignedInt16]. + [FFITypeSignedInt16] -> [self structOffsetOf: 'structShort *' atomicTypeCode: FFITypeSignedInt16]. + [FFITypeUnsignedInt32] -> [self structOffsetOf: 'structInt *' atomicTypeCode: FFITypeUnsignedInt32]. + [FFITypeSignedInt32] -> [self structOffsetOf: 'structInt *' atomicTypeCode: FFITypeSignedInt32]. + [FFITypeUnsignedInt64] -> [self structOffsetOf: 'structLongLong *' atomicTypeCode: FFITypeUnsignedInt64]. + [FFITypeSignedInt64] -> [self structOffsetOf: 'structLongLong *' atomicTypeCode: FFITypeSignedInt64]. - [FFITypeUnsignedByte] -> [self structOffsetOf: 'structByte *' atomicTypeCode: FFITypeUnsignedByte]. - [FFITypeSignedByte] -> [self structOffsetOf: 'structByte *' atomicTypeCode: FFITypeUnsignedByte]. - [FFITypeUnsignedShort] -> [self structOffsetOf: 'structShort *' atomicTypeCode: FFITypeUnsignedShort]. - [FFITypeSignedShort] -> [self structOffsetOf: 'structShort *' atomicTypeCode: FFITypeUnsignedShort]. - [FFITypeUnsignedInt] -> [self structOffsetOf: 'structInt *' atomicTypeCode: FFITypeUnsignedInt]. - [FFITypeSignedInt] -> [self structOffsetOf: 'structInt *' atomicTypeCode: FFITypeUnsignedInt]. - [FFITypeUnsignedLongLong] -> [self structOffsetOf: 'structLongLong *' atomicTypeCode: FFITypeUnsignedLongLong]. - [FFITypeSignedLongLong] -> [self structOffsetOf: 'structLongLong *' atomicTypeCode: FFITypeUnsignedLongLong]. [FFITypeSingleFloat] -> [self structOffsetOf: 'structFloat *' atomicTypeCode: FFITypeSingleFloat]. [FFITypeDoubleFloat] -> [self structOffsetOf: 'structDouble *' atomicTypeCode: FFITypeDoubleFloat]. } otherwise: [self structOffsetOf: 'structStruct *' atomicTypeCode: FFIFlagStructure]. ^interpreterProxy methodReturnInteger: alignment asUnsignedIntegerPtr!

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev August 2021