Vm-dev August 2022

vm-dev@lists.squeakfoundation.org

11 participants
75 discussions

VM Maker: VMMaker.oscog-eem.3239.mcz
by commits＠source.squeak.org 02 Aug '22

02 Aug '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3239.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3239 Author: eem Time: 2 August 2022, 11:38:13.454341 am UUID: 0e58a24c-1ebf-4b6d-b796-1ee9681e3f32 Ancestors: VMMaker.oscog-eem.3238 ThreadedFFIPlugin: Add __riscv et al to the set of names defined at compile time. =============== Diff against VMMaker.oscog-eem.3238 =============== Item was changed: ----- Method: VMBasicConstants class>>namesDefinedAtCompileTime (in category 'C translation') ----- namesDefinedAtCompileTime "Answer the set of names for variables that should be defined at compile time. Some of these get default values during simulation, and hence get defaulted in the various initializeMiscConstants methods. But that they have values should /not/ cause the code generator to do dead code elimination based on their default values. In particular, methods marked with <option: ANameDefinedAtCompileTime> will be emitted within #if defined(ANameDefinedAtCompileTime)...#endif. And of course this is backwards. We'd like to define names that are defined at translation time. But doing so would entail defining (or referencing) hundreds of class and pool variables. This way + is marginally more manageable." - is more manageable" ^#(VMBIGENDIAN IMMUTABILITY STACKVM COGVM COGMTVM SPURVM PharoVM "Pharo vs Squeak" TerfVM VM_TICKER "Terf vs Squeak & Qwaq/Teleplace/Terf high-priority thread support" EnforceAccessControl "Newspeak" CheckRememberedInTrampoline "IMMUTABILITY" BIT_IDENTICAL_FLOATING_POINT PLATFORM_SPECIFIC_FLOATING_POINT "Alternatives for using fdlibm for floating-point" ITIMER_HEARTBEAT "older linux's woultn't allow a higher priority thread, hence no threaded heartbeat." TestingPrimitives OBSOLETE_ALIEN_PRIMITIVES "Ancient crap in the IA32ABI plugin" LLDB "As of lldb-370.0.42 Swift-3.1, passing function parameters to printOopsSuchThat fails with Internal error [IRForTarget]: Couldn't rewrite one of the arguments of a function call. Turning off link time optimization with -fno-lto has no effect. hence we define some debugging functions as being <option: LLDB>" LRPCheck "Optional checking for long running primitives" "ThreadedFFIPlugin related" ALLOCA_LIES_SO_SETSP_BEFORE_CALL PLATFORM_API_USES_CALLEE_POPS_CONVENTION SQUEAK_BUILTIN_PLUGIN STACK_ALIGN_BYTES "processor related" + __ARM_ARCH__ __arm__ __arm32__ ARM32 + __arm64__ __arm64 __aarch64__ ARM64 - __ARM_ARCH__ __arm__ __arm32__ ARM32 __arm64__ ARM64 - _M_I386 _X86_ i386 i486 i586 i686 __i386__ __386__ X86 I386 - x86_64 __amd64 __x86_64 __amd64__ __x86_64__ _M_AMD64 _M_X64 - __mips__ __mips __powerpc __powerpc__ __powerpc64__ __POWERPC__ __ppc__ __ppc64__ __PPC__ __PPC64__ + __riscv__ __riscv64__ __riscv __riscv64 __sparc__ __sparc __sparc_v8__ __sparc_v9__ __sparcv8 __sparcv9 + _M_I386 _X86_ i386 i486 i586 i686 __i386__ __386__ X86 I386 + x86_64 __amd64 __x86_64 __amd64__ __x86_64__ _M_AMD64 _M_X64 "Compiler brand related" - __ACK__ __CC_ARM __clang__ __GNUC__ _MSC_VER __ICC - __SUNPRO_C "os related" ACORN - _AIX __ANDROID__ __APPLE__ __BEOS__ + EPLAN9 + __FreeBSD__ __NetBSD__ __OpenBSD__ __linux__ __MACH__ __MINGW32__ - __FreeBSD__ __NetBSD__ __OpenBSD__ __osf__ - - EPLAN9 __unix__ __unix UNIX WIN32 _WIN32 _WIN32_WCE WIN64 _WIN64 _WIN64_WCE)!

1 0

VM Maker: VMMaker.oscog-eem.3238.mcz
by commits＠source.squeak.org 02 Aug '22

02 Aug '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3238.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3238 Author: eem Time: 2 August 2022, 11:19:29.444062 am UUID: 4b576e04-5ba8-4fc4-93c9-efdc751e9877 Ancestors: VMMaker.oscog-eem.3237 ...close, but no cigar. =============== Diff against VMMaker.oscog-eem.3237 =============== Item was changed: ----- Method: CCodeGenerator>>addMethodFor:selector: (in category 'utilities') ----- addMethodFor: aClass selector: selector "Add the given method to the code base and answer its translation or nil if it shouldn't be translated." | method tmethod | method := aClass compiledMethodAt: selector. (method pragmaAt: #doNotGenerate) ifNotNil: ["only remove a previous method if this one overrides it, i.e. this is a subclass method. If the existing method is in a different hierarchy this method must be merely a redeirect." (methods at: selector ifAbsent: []) ifNotNil: [:tm| (aClass includesBehavior: tm definingClass) ifTrue: [self removeMethodForSelector: selector]]. ^nil]. method isSubclassResponsibility ifTrue: [^nil]. (self shouldIncludeMethodFor: aClass selector: selector) ifFalse: [^nil]. tmethod := self compileToTMethodSelector: selector in: aClass. "Even though we exclude initialize methods, we must consider their global variable usage, otherwise globals may be incorrectly localized." selector == #initialize ifTrue: [self checkForGlobalUsage: (tmethod allReferencedVariablesUsing: self) in: tmethod. ^nil]. self addMethod: tmethod. "If the method has a macro then add the macro. But keep the method for analysis purposes (e.g. its variable accesses)." (method pragmaAt: #cmacro:) ifNotNil: [:pragma| self addMacro: (pragma argumentAt: 1) for: selector. (inlineList includes: selector) ifTrue: [inlineList := inlineList copyWithout: selector]]. (method pragmaAt: #cmacro) ifNotNil: [:pragma| | literal | "Method should be just foo ^const" self assert: (self isValidMacroMethod: method). + literal := (method isQuick or: [method numArgs = 1]) - literal := method isQuick ifTrue: [method decompile quickMethodReturnLiteral] ifFalse: [method literalAt: 1]. self addMacro: '() ', (method isReturnField ifTrue: [literal] ifFalse: [self cLiteralFor: literal value name: method selector]) for: selector. (inlineList includes: selector) ifTrue: [inlineList := inlineList copyWithout: selector]]. ^tmethod!

1 0

VM Maker: VMMaker.oscog-eem.3237.mcz
by commits＠source.squeak.org 02 Aug '22

02 Aug '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3237.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3237 Author: eem Time: 2 August 2022, 11:06:07.859999 am UUID: d381a92b-8419-48d2-9d18-23ae821f8800 Ancestors: VMMaker.oscog-eem.3236 ...and deal with the validation regression entailed by ObjectMemory>>isForwarded: =============== Diff against VMMaker.oscog-eem.3236 =============== Item was changed: ----- Method: CCodeGenerator>>addMethodFor:selector: (in category 'utilities') ----- addMethodFor: aClass selector: selector "Add the given method to the code base and answer its translation or nil if it shouldn't be translated." | method tmethod | method := aClass compiledMethodAt: selector. (method pragmaAt: #doNotGenerate) ifNotNil: ["only remove a previous method if this one overrides it, i.e. this is a subclass method. If the existing method is in a different hierarchy this method must be merely a redeirect." (methods at: selector ifAbsent: []) ifNotNil: [:tm| (aClass includesBehavior: tm definingClass) ifTrue: [self removeMethodForSelector: selector]]. ^nil]. method isSubclassResponsibility ifTrue: [^nil]. (self shouldIncludeMethodFor: aClass selector: selector) ifFalse: [^nil]. tmethod := self compileToTMethodSelector: selector in: aClass. "Even though we exclude initialize methods, we must consider their global variable usage, otherwise globals may be incorrectly localized." selector == #initialize ifTrue: [self checkForGlobalUsage: (tmethod allReferencedVariablesUsing: self) in: tmethod. ^nil]. self addMethod: tmethod. "If the method has a macro then add the macro. But keep the method for analysis purposes (e.g. its variable accesses)." (method pragmaAt: #cmacro:) ifNotNil: [:pragma| self addMacro: (pragma argumentAt: 1) for: selector. (inlineList includes: selector) ifTrue: [inlineList := inlineList copyWithout: selector]]. (method pragmaAt: #cmacro) ifNotNil: [:pragma| | literal | "Method should be just foo ^const" + self assert: (self isValidMacroMethod: method). - self assert: (method numArgs = 0 and: [method numLiterals = 3 or: [method isQuick]]). literal := method isQuick ifTrue: [method decompile quickMethodReturnLiteral] ifFalse: [method literalAt: 1]. self addMacro: '() ', (method isReturnField ifTrue: [literal] ifFalse: [self cLiteralFor: literal value name: method selector]) for: selector. (inlineList includes: selector) ifTrue: [inlineList := inlineList copyWithout: selector]]. ^tmethod! Item was added: + ----- Method: CCodeGenerator>>isValidMacroMethod: (in category 'utilities') ----- + isValidMacroMethod: method + | statements value | + method numArgs = 0 ifTrue: + [^method numLiterals = 3 "the value, the pragma and the methodClass" or: [method isQuick]]. + "foo: arg ^constant is a useful exception" + ^(statements := method methodNode block statements) size = 1 + and: [statements first isReturn + and: [(value := statements first expr) isLiteralNode + or: [value isVariableNode + and: [#('true' 'false' 'nil') includes: value key]]]]!

1 0

VM Maker: VMMaker.oscog-eem.3236.mcz
by commits＠source.squeak.org 02 Aug '22

02 Aug '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3236.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3236 Author: eem Time: 2 August 2022, 10:44:55.758739 am UUID: 84f6abb0-16f4-4566-9af4-1271286f3061 Ancestors: VMMaker.oscog-eem.3235 ...and the same for ObjectMemory>>isForwarded: =============== Diff against VMMaker.oscog-eem.3235 =============== Item was changed: ----- Method: ObjectMemory>>isForwarded: (in category 'interpreter access') ----- isForwarded: oop + "Compatibility wth SpurMemoryManager. In ObjectMemory, + no forwarding pointers are visible to the execution engine." - "Compatibility wth SpurMemoryManager. In ObjectMemory, no forwarding pointers - are visible to the VM." <api> + <cmacro> + <inline: #always> - <cmacro: '(oop) false'> - <inline: true> ^false!

1 0

VM Maker: VMMaker.oscog-eem.3235.mcz
by commits＠source.squeak.org 02 Aug '22

02 Aug '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3235.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3235 Author: eem Time: 2 August 2022, 10:37:25.594485 am UUID: 9592c817-2a86-489b-abdf-60838525c8ab Ancestors: VMMaker.oscog-eem.3234 ...and hence redefine numRegArgs to use cmacro, not cmacro:. =============== Diff against VMMaker.oscog-eem.3234 =============== Item was changed: ----- Method: CogObjectRepresentationForSpur>>numRegArgs (in category 'calling convention') ----- numRegArgs "Define how many register arguments a StackToRegisterMappingCogit can and should use with the receiver. The value must be 0, 1 or 2. Note that a SimpleStackBasedCogit always has 0 register args (although the receiver is passed in a register). The Spur object representation is simple enough that implementing at:put: is straight-forward and hence 2 register args are worth while. The method must be inlined in CoInterpreter, and dead code eliminated so that the register-popping enilopmarts such as enterRegisterArgCogMethod:- at:receiver: do not have to be implemented in SimpleStackBasedCogit." <api> <option: #StackToRegisterMappingCogit> + <cmacro> "to allow inlining optimization across the CoInterpreter/Cogit api..." - <cmacro: '() 2'> "to allow inlining optimization across the CoInterpreter/Cogit api..." ^2! Item was changed: ----- Method: CogObjectRepresentationForSqueakV3>>numRegArgs (in category 'calling convention') ----- numRegArgs "Define how many register arguments a StackToRegisterMappingCogit can and should use with the receiver. The value must be 0, 1 or 2. Note that a SimpleStackBasedCogit always has 0 register args (although the receiver is passed in a register). CogObjectRepresentationForSqueakV3 only implements at most 1-arg primitives, because the complexity of the object representation makes it difficult to implement at:put:, the most performance-critical 2-argument primitive.. The method must be inlined in CoInterpreter, and dead code eliminated so that the register-popping enilopmarts such as enterRegisterArgCogMethod:- at:receiver: do not have to be implemented in SimpleStackBasedCogit." <api> <option: #StackToRegisterMappingCogit> + <cmacro> "to allow inlining optimization across the CoInterpreter/Cogit api..." - <cmacro: '() 1'> "to allow inlining optimization across the CoInterpreter/Cogit api..." ^1! Item was changed: ----- Method: SimpleStackBasedCogit>>numRegArgs (in category 'testing') ----- numRegArgs <api> + <cmacro> "to allow inlining optimization across the CoInterpreter/Cogit api..." - <cmacro: '() 0'> "to allow inlining optimization across the CoInterpreter/Cogit api..." ^0!

1 0

VM Maker: VMMaker.oscog-eem.3234.mcz
by commits＠source.squeak.org 02 Aug '22

02 Aug '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3234.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3234 Author: eem Time: 2 August 2022, 10:26:11.98735 am UUID: 32fdb3bb-ea3a-4a14-9755-2ad589a8d3c2 Ancestors: VMMaker.oscog-eem.3233 Slang: Fix an inlining regression in VMMaker.oscog-eem.3233. We still want to inline methods marked as macros for inlining across the cointerp/cogit boundary (e.g. shiftForWord). So distinguish between cmacro: methods (no inlining) and cmacro methods (inlining is fine). =============== Diff against VMMaker.oscog-eem.3233 =============== Item was changed: ----- Method: CCodeGenerator>>isConstantNode:valueInto: (in category 'utilities') ----- isConstantNode: aNode valueInto: aBlock "Answer if aNode evaluates to a constant, and if so, evaluate aBlock with the value of that constant." aNode isConstant ifTrue: [(aNode isDefine and: [self defineAtCompileTime: aNode name]) ifTrue: [^false]. aBlock value: aNode value. ^true]. (aNode isVariable and: [aNode name = #nil]) ifTrue: [aBlock value: nil. ^true]. aNode isSend ifTrue: [(self anyMethodNamed: aNode selector) ifNil: [(VMBasicConstants valueOfBasicSelector: aNode selector) ifNotNil: [:value| aBlock value: value. ^true]. aNode constantNumbericValueOrNil ifNotNil: [:value| aBlock value: value. ^true]] ifNotNil: [:m| + (m isMacroWithDefinition not - (m definedAsMacro not and: [m statements size = 1 and: [m statements last isReturn]]) ifTrue: [^self isConstantNode: m statements last expression valueInto: aBlock]]]. ^false! Item was changed: ----- Method: CCodeGenerator>>isMacroSelector: (in category 'utilities') ----- isMacroSelector: sel + "Answer if the given selector is one of the selectors implemented as a macro in platform header files." - "Answer if the given selector is one of the selectors implemented as a macro in platform header fiels." ^(self isKernelSelector: sel) or: [(VMBasicConstants mostBasicConstantSelectors includes: sel) or: [(self methodNamed: sel) ifNil: [false] ifNotNil: [:m| m definedAsMacro]]]! Item was added: + ----- Method: TMethod>>isMacroWithDefinition (in category 'testing') ----- + isMacroWithDefinition + "Answer if the method has a macro that has a definition, rather than being defined as a macro. + c.f. definedAsMacro. + Certain api methods are defined as cmacro (isMacroWithDefinition is false) so that their value can be defined, + e.g. shiftForWord. Many others are defined as macros proper, with a defintiion. The former is simply for + optimization and does not imply we want to disable inlining based on them. But we *do* want to disable + inlining of methods that are isMacroWithDefinition. hence the distinction." + ^properties notNil + and: [(properties includesKey: #cmacro:)]!

1 0

VM Maker: VMMaker.oscog-eem.3233.mcz
by commits＠source.squeak.org 02 Aug '22

02 Aug '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3233.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3233 Author: eem Time: 2 August 2022, 10:08:41.069769 am UUID: 60028028-036a-4aca-a304-29e77d6adc7d Ancestors: VMMaker.oscog-eem.3232 Slang: Abstract checking for names defineAtCompileTime: so that the VMPluginCodeGenerator can ask the pluyginClass and ence that BytesPerWord is considered defined at compile time, except within the ThreadedFFIPlugins. ThreadedFFIPlugin: Now that ffiCall:ArgArrayOrNil:NumArgs: is inlined, also inline ffiReturnType:, avoiding unnecessary duplication. =============== Diff against VMMaker.oscog-eem.3232 =============== Item was added: + ----- Method: CCodeGenerator>>defineAtCompileTime: (in category 'C translation support') ----- + defineAtCompileTime: name + ^(vmClass ifNil: VMBasicConstants) defineAtCompileTime: name! Item was changed: ----- Method: CCodeGenerator>>emitCConstants:on: (in category 'C code generator') ----- emitCConstants: constList on: aStream "Store the global variable declarations on the given stream." constList isEmpty ifTrue: [^self]. aStream cr; nextPutAll: '/*** Constants ***/'; cr. (self sortStrings: constList) do: [:varName| | node default value | node := constants at: varName. node name isEmpty ifFalse: ["If the definition includes a C comment, or looks like a conditional, take it as is, otherwise convert the value from Smalltalk to C. Allow the class to provide an alternative definition, either of just the value or the whole shebang." default := (node value isString and: [(node value includesSubstring: '/*') or: [(node value includesSubstring: ' ? ') and: [node value includesSubstring: ' : ']]]) ifTrue: [node value] ifFalse: [self cLiteralFor: node value name: varName]. default = #undefined ifTrue: [aStream nextPutAll: '#undef '; nextPutAll: node name; cr] ifFalse: [value := vmClass ifNotNil: [(vmClass specialValueForConstant: node name default: default) ifNotNil: [:specialDef| specialDef] ifNil: [default]] ifNil: [default]. + (self defineAtCompileTime: node name) - ((vmClass ifNil: VMBasicConstants) defineAtCompileTime: node name) ifTrue: [self putConditionalDefineOf: node name as: value comment: 'Allow this to be overridden on the compiler command line' on: aStream] ifFalse: [self putDefineOf: node name as: value on: aStream]]]]. aStream cr! Item was changed: ----- Method: CCodeGenerator>>isConstantNode:valueInto: (in category 'utilities') ----- isConstantNode: aNode valueInto: aBlock "Answer if aNode evaluates to a constant, and if so, evaluate aBlock with the value of that constant." aNode isConstant ifTrue: [(aNode isDefine + and: [self defineAtCompileTime: aNode name]) ifTrue: - and: [(vmClass ifNil: [VMBasicConstants]) defineAtCompileTime: aNode name]) ifTrue: [^false]. aBlock value: aNode value. ^true]. (aNode isVariable and: [aNode name = #nil]) ifTrue: [aBlock value: nil. ^true]. aNode isSend ifTrue: [(self anyMethodNamed: aNode selector) ifNil: [(VMBasicConstants valueOfBasicSelector: aNode selector) ifNotNil: [:value| aBlock value: value. ^true]. aNode constantNumbericValueOrNil ifNotNil: [:value| aBlock value: value. ^true]] ifNotNil: [:m| (m definedAsMacro not and: [m statements size = 1 and: [m statements last isReturn]]) ifTrue: [^self isConstantNode: m statements last expression valueInto: aBlock]]]. ^false! Item was changed: ----- Method: CCodeGenerator>>nilOrBooleanConditionFor: (in category 'utilities') ----- nilOrBooleanConditionFor: nodeOrNil "If nodeOrNil is one of the conditional sends for which we do translation-time dead code elimination (i.e. cppIf:ifTrue: et al or ifTrue: et al) and the conditional does evaluate to a translation-time boolean constant, answer that constant, otherwise answer nil. Used to prune dead code, either for code generaton or dead variable elimination." generateDeadCode ifTrue: [^nil]. nodeOrNil ifNil: [^nil]. nodeOrNil isSend ifFalse: [^nil]. (#(ifTrue: ifFalse: ifTrue:ifFalse: ifFalse:ifTrue:) includes: nodeOrNil selector) ifTrue: [^self nilOrBooleanConstantReceiverOf: nodeOrNil receiver]. (#(and: or:) includes: nodeOrNil selector) ifTrue: [^self nilOrBooleanConstantReceiverOf: nodeOrNil]. (#(cppIf:ifTrue: cppIf:ifTrue:ifFalse:) includes: nodeOrNil selector) ifTrue: [| maybeName value | (vmClass notNil and: [nodeOrNil args first isConstant and: [(value := nodeOrNil args first value) isSymbol + and: [(self defineAtCompileTime: value) not - and: [((vmClass ifNil: [VMBasicConstants]) defineAtCompileTime: value) not and: [(vmClass bindingOf: value) notNil]]]]) ifTrue: [self logger nextPutAll: 'Warning: cppIf: reference to '; store: value; nextPutAll: ' when variable of same name exists.'; cr]. maybeName := nodeOrNil args first isConstant ifTrue: [nodeOrNil args first nameOrValue]. ^(optionsDictionary notNil and: [nodeOrNil args first isConstant and: [(#(true false) includes: (optionsDictionary at: maybeName ifAbsent: [nil])) + and: [(self defineAtCompileTime: maybeName) not]]]) ifTrue: - and: [((vmClass ifNil: [VMBasicConstants]) defineAtCompileTime: maybeName) not]]]) ifTrue: [optionsDictionary at: nodeOrNil args first name]]. ^nil! Item was changed: ----- Method: CCodeGenerator>>shouldIncludeMethodFor:selector: (in category 'utilities') ----- shouldIncludeMethodFor: aClass selector: selector "Answer whether a method should be translated. Process optional methods by interpreting the argument to the option: pragma as either a Cogit class name or a class variable name or a variable name in VMBasicConstants. Exclude methods with the doNotGenerate pragma." | options notOptions | (aClass >> selector pragmaAt: #doNotGenerate) ifNotNil: [^false]. "where is pragmasAt: ??" options := (aClass >> selector) pragmas select: [:p| p keyword == #option:] thenCollect: [:p| p argumentAt: 1]. notOptions := (aClass >> selector) pragmas select: [:p| p keyword == #notOption:] thenCollect: [:p| p argumentAt: 1]. (options notEmpty or: [notOptions notEmpty]) ifTrue: + ["Anything defined at compile time must be included." + ((options anySatisfy: [:option| self defineAtCompileTime: option]) + or: [notOptions anySatisfy: [:option| self defineAtCompileTime: option]]) ifTrue: - ["Anything defined at compile tiome must be included." - ((options anySatisfy: [:option| (vmClass ifNil: [VMBasicConstants]) defineAtCompileTime: option]) - or: [notOptions anySatisfy: [:option| (vmClass ifNil: [VMBasicConstants]) defineAtCompileTime: option]]) ifTrue: [^true]. "We have to include the method if either - any one of the options is false (because we want #if option...) - any one of the notOptions is true (because we want #if !!option...) - all of the options is true and all of the notOptions are false (because they have all been satisfied)" ^((options anySatisfy: [:option| (self optionIsTrue: option in: aClass) not]) and: [notOptions anySatisfy: [:option| (self optionIsFalse: option in: aClass) not]]) or: [(options allSatisfy: [:option| self optionIsTrue: option in: aClass]) and: [notOptions allSatisfy: [:option| self optionIsFalse: option in: aClass]]]]. ^true! Item was added: + ----- Method: InterpreterPlugin class>>defineAtCompileTime: (in category 'translation') ----- + defineAtCompileTime: name + "BytesPerWord is defined at compile time for most plugins." + ^name = #BytesPerWord + or: [VMBasicConstants defineAtCompileTime: name]! Item was changed: ----- Method: ThreadedARM32FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double, double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" | myThreadIndex atomicType floatRet intRet | <var: #floatRet type: #double> <var: #intRet type: #usqLong> <inline: #always> myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 0)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 2)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 4)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 6)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 8)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 10)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 12)) to: #'double *') at: 0) _: ((self cCoerceSimple: (self addressOf: (calloutState floatRegisters at: 14)) to: #'double *') at: 0)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [atomicType = FFITypeSingleFloat ifTrue: [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'float (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3)] ifFalse: "atomicType = FFITypeDoubleFloat" [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3)]. "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. ^interpreterProxy floatObjectOf: floatRet]. intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqIntptr_t (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: + [| returnType | + "Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent - ["Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." + returnType := self ffiReturnType: specOnStack. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: + [^self ffiReturnPointer: intRet ofType: returnType in: calloutState]. + ^self ffiReturnStruct: (self addressOf: intRet) ofType: returnType in: calloutState]. - [^self ffiReturnPointer: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. - ^self ffiReturnStruct: (self addressOf: intRet) ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double, double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" | myThreadIndex atomicType floatRet intRet structRet specSize | <var: #floatRet type: 'union { struct { float floats[8]; } f; struct dprr { double doubles[4]; } d; }'> <var: #structRet type: #SixteenByteReturnII> <var: #intRet type: #usqLong> <inline: #always> self cCode: [] inSmalltalk: [floatRet := ByteArray new: 32]. "Just a hack to placate the Smalltalk compiler; these should be proper struct types..." myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: (calloutState floatRegisters at: 0) _: (calloutState floatRegisters at: 1) _: (calloutState floatRegisters at: 2) _: (calloutState floatRegisters at: 3) _: (calloutState floatRegisters at: 4) _: (calloutState floatRegisters at: 5) _: (calloutState floatRegisters at: 6) _: (calloutState floatRegisters at: 7)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. ((atomicType >> 1) = (FFITypeSingleFloat >> 1) or: [(calloutState ffiRetHeader bitAnd: FFIFlagPointer+FFIFlagStructure) = FFIFlagStructure and: [self structIsHomogenousFloatArrayOfSize: (calloutState ffiRetHeader bitAnd: FFIStructSizeMask) typeSpec: (self cCoerce: (interpreterProxy firstIndexableField: calloutState ffiRetSpec) to: #'unsigned int *') ofLength: (specSize := interpreterProxy byteSizeOf: calloutState ffiRetSpec) / (self sizeof: #'unsigned int')]]) ifTrue: [floatRet d: (self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'struct dprr (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7)). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. atomicType = FFITypeDoubleFloat ifTrue: [^interpreterProxy floatObjectOf: (floatRet d doubles at: 0)]. atomicType = FFITypeSingleFloat ifTrue: [^interpreterProxy floatObjectOf: (floatRet f floats at: 0)]. "If the struct is a vector of floats then move float[2] to float[1], float[4] to float[2] and float[6] to float[3], to pack the float data in the double fields. We can tell if the struct is composed of floats if its size is less than the spec size, since the spec size is (1 + n fields) * 4 bytes, and the struct size is n fields * 4 bytes for floats and n fields * 8 bytes for doubles. We can't access the spec post call because it may have moved." specSize > calloutState structReturnSize ifTrue: [floatRet f floats at: 1 put: (floatRet f floats at: 2). floatRet f floats at: 2 put: (floatRet f floats at: 4). floatRet f floats at: 3 put: (floatRet f floats at: 6)]. ^self ffiReturnStruct: (self addressOf: floatRet) ofType: (self ffiReturnType: specOnStack) in: calloutState]. "Integer and Structure returns..." "If struct address used for return value, call is special; struct return pointer must be in x8" (self mustReturnStructOnStack: calloutState structReturnSize) ifTrue: [intRet := 0. self setReturnRegister: (self cCoerceSimple: calloutState limit to: #sqLong) "stack alloca'd struct" andCall: (self cCoerceSimple: procAddr to: #sqLong) withArgsArray: (self cCoerceSimple: (self addressOf: calloutState integerRegisters) to: #sqLong)] ifFalse: [structRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'SixteenByteReturnII (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7). intRet := structRet a]. "X1" "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: + [| returnType | + "Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent - ["Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." + returnType := self ffiReturnType: specOnStack. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: + [^self ffiReturnPointer: intRet ofType: returnType in: calloutState]. - [^self ffiReturnPointer: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiReturnStruct: (((self returnStructInRegisters: calloutState) ifTrue: [self cCoerceSimple: (self addressOf: structRet) to: #'char *'] ifFalse: [calloutState limit])) + ofType: returnType - ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was added: + ----- Method: ThreadedFFIPlugin class>>defineAtCompileTime: (in category 'translation') ----- + defineAtCompileTime: name + "BytesPerWord is defined at compile time for most plugins, but not for the FFI plugins." + ^VMBasicConstants defineAtCompileTime: name! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiReturnType: (in category 'symbol loading') ----- ffiReturnType: specOnStack "Answer the return type object for the current invocation" + <inline: #always> | specLiteral argTypes | specLiteral := specOnStack ifTrue: [interpreterProxy stackValue: 1] ifFalse: [interpreterProxy literal: 0 ofMethod: interpreterProxy primitiveMethod]. argTypes := interpreterProxy fetchPointer: ExternalFunctionArgTypesIndex ofObject: specLiteral. ^interpreterProxy fetchPointer: 0 ofObject: argTypes! Item was changed: ----- Method: ThreadedIA32FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" | myThreadIndex atomicType floatRet intRet | <var: #floatRet type: #double> <var: #intRet type: #usqLong> "Support up to int64_t or uint64_t" <inline: #always> myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)()'). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. ^interpreterProxy floatObjectOf: floatRet]. intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqLong (*)()'). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: + [| returnType | + "Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent - ["Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." + returnType := self ffiReturnType: specOnStack. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: + [^self ffiReturnPointer: intRet ofType: returnType in: calloutState]. + ^self ffiReturnStruct: (self addressOf: intRet) ofType: returnType in: calloutState]. - [^self ffiReturnPointer: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. - ^self ffiReturnStruct: (self addressOf: intRet) ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was changed: ----- Method: ThreadedRiscV64FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double, double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" | myThreadIndex atomicType floatRet intRet structRet specSize | <var: #doubleRet type: #double> <var: #floatRet type: 'union { struct { float floats[8]; } f; struct dprr { double doubles[4]; } d; }'> <var: #structRet type: #SixteenByteReturnII> <var: #intRet type: #usqLong> <inline: #always> self cCode: [] inSmalltalk: [floatRet := ByteArray new: 32]. "Just a hack to placate the Smalltalk compiler; these should be proper struct types..." myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterIndex > 0 ifTrue: [self loadFloatRegs: (calloutState floatRegisters at: 0) _: (calloutState floatRegisters at: 1) _: (calloutState floatRegisters at: 2) _: (calloutState floatRegisters at: 3) _: (calloutState floatRegisters at: 4) _: (calloutState floatRegisters at: 5) _: (calloutState floatRegisters at: 6) _: (calloutState floatRegisters at: 7)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. "float or double returns" atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [| doubleRet | atomicType = FFITypeDoubleFloat ifTrue: [doubleRet := (self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7))] ifFalse: [doubleRet := (self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'float (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7))]. "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. ^self floatObjectOf: doubleRet]. "homogenous array of float/double returns" ((calloutState ffiRetHeader bitAnd: FFIFlagPointer+FFIFlagStructure) = FFIFlagStructure and: [self structIsHomogenousFloatArrayOfSize: (calloutState ffiRetHeader bitAnd: FFIStructSizeMask) typeSpec: (self cCoerce: (interpreterProxy firstIndexableField: calloutState ffiRetSpec) to: #'unsigned int *') ofLength: (specSize := interpreterProxy byteSizeOf: calloutState ffiRetSpec) / (self sizeof: #'unsigned int')]) ifTrue: [floatRet d: (self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'struct dprr (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7)). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. "If the struct is a vector of floats then move float[2] to float[1], float[4] to float[2] and float[6] to float[3], to pack the float data in the double fields. We can tell if the struct is composed of floats if its size is less than the spec size, since the spec size is (1 + n fields) * 4 bytes, and the struct size is n fields * 4 bytes for floats and n fields * 8 bytes for doubles. We can't access the spec post call because it may have moved." specSize > calloutState structReturnSize ifTrue: [floatRet f floats at: 1 put: (floatRet f floats at: 2). floatRet f floats at: 2 put: (floatRet f floats at: 4). floatRet f floats at: 3 put: (floatRet f floats at: 6)]. ^self ffiReturnStruct: (self addressOf: floatRet) ofType: (self ffiReturnType: specOnStack) in: calloutState]. "Integer and Structure returns..." (self mustReturnStructOnStack: calloutState structReturnSize) ifTrue: [intRet := 0. self setReturnRegister: (self cCoerceSimple: calloutState limit to: #sqLong) "stack alloca'd struct" andCall: (self cCoerceSimple: procAddr to: #sqLong) withArgsArray: (self cCoerceSimple: (self addressOf: calloutState integerRegisters) to: #sqLong)] ifFalse: [structRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'SixteenByteReturnII (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3) with: (calloutState integerRegisters at: 4) with: (calloutState integerRegisters at: 5) with: (calloutState integerRegisters at: 6) with: (calloutState integerRegisters at: 7). intRet := structRet a]. "X1" "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: + [| returnType | + "Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent - ["Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." + returnType := self ffiReturnType: specOnStack. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: + [^self ffiReturnPointer: intRet ofType: returnType in: calloutState]. - [^self ffiReturnPointer: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiReturnStruct: (((self returnStructInRegisters: calloutState) ifTrue: [self cCoerceSimple: (self addressOf: structRet) to: #'char *'] ifFalse: [calloutState limit])) + ofType: returnType - ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was changed: ----- Method: ThreadedX64Win64FFIPlugin>>ffiCalloutTo:SpecOnStack:in: (in category 'callout support') ----- ffiCalloutTo: procAddr SpecOnStack: specOnStack in: calloutState <var: #procAddr type: #'void *'> <var: #calloutState type: #'CalloutState *'> <var: #loadFloatRegs declareC: 'extern void loadFloatRegs(double, double, double, double)'> "Go out, call this guy and create the return value. This *must* be inlined because of the alloca of the outgoing stack frame in ffiCall:WithFlags:NumArgs:Args:AndTypes:" | myThreadIndex atomicType floatRet intRet | <var: #floatRet type: #double> <var: #intRet type: #usqLong> <inline: #always> myThreadIndex := interpreterProxy disownVM: (self disownFlagsFor: calloutState). calloutState floatRegisterSignature > 0 ifTrue: [self loadFloatRegs: (calloutState floatRegisters at: 0) _: (calloutState floatRegisters at: 1) _: (calloutState floatRegisters at: 2) _: (calloutState floatRegisters at: 3)]. (self allocaLiesSoSetSpBeforeCall or: [self mustAlignStack]) ifTrue: [self setsp: calloutState argVector]. atomicType := self atomicTypeOf: calloutState ffiRetHeader. (atomicType >> 1) = (FFITypeSingleFloat >> 1) ifTrue: [atomicType = FFITypeSingleFloat ifTrue: [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'float (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3)] ifFalse: "atomicType = FFITypeDoubleFloat" [floatRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'double (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3)]. "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. ^interpreterProxy floatObjectOf: floatRet]. intRet := self dispatchFunctionPointer: (self cCoerceSimple: procAddr to: 'usqIntptr_t (*)(sqIntptr_t, sqIntptr_t, sqIntptr_t, sqIntptr_t)') with: (calloutState integerRegisters at: 0) with: (calloutState integerRegisters at: 1) with: (calloutState integerRegisters at: 2) with: (calloutState integerRegisters at: 3). "undo any callee argument pops because it may confuse stack management with the alloca." (self isCalleePopsConvention: calloutState callFlags) ifTrue: [self setsp: calloutState argVector]. interpreterProxy ownVM: myThreadIndex. (calloutState ffiRetHeader anyMask: FFIFlagPointer+FFIFlagStructure) ifTrue: + [| returnType | + "Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent - ["Note: Order is important here since FFIFlagPointer + FFIFlagStructure is used to represent 'typedef void* VoidPointer' and VoidPointer must be returned as pointer *not* as struct." + returnType := self ffiReturnType: specOnStack. (calloutState ffiRetHeader anyMask: FFIFlagPointer) ifTrue: + [^self ffiReturnPointer: intRet ofType: returnType in: calloutState]. + ^self ffiReturnStruct: (self addressOf: intRet) ofType: returnType in: calloutState]. - [^self ffiReturnPointer: intRet ofType: (self ffiReturnType: specOnStack) in: calloutState]. - ^self ffiReturnStruct: (self addressOf: intRet) ofType: (self ffiReturnType: specOnStack) in: calloutState]. ^self ffiCreateIntegralResultOop: intRet ofAtomicType: atomicType in: calloutState! Item was added: + ----- Method: VMPluginCodeGenerator>>defineAtCompileTime: (in category 'C translation support') ----- + defineAtCompileTime: name + ^pluginClass + ifNotNil: [:pc| pc defineAtCompileTime: name] + ifNil: [super defineAtCompileTime: name]!

1 0

VM Maker: VMMaker.oscog-eem.3232.mcz
by commits＠source.squeak.org 02 Aug '22

02 Aug '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3232.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3232 Author: eem Time: 2 August 2022, 9:40:11.234938 am UUID: 054d025b-2745-4f1f-8a8b-af032b6c9841 Ancestors: VMMaker.oscog-eem.3231 ThreadedFFIPlugins: Do inline ffiCall:ArgArrayOrNil:NumArgs:. We should err on teh side of speed. The code size shouldn't affect icache performance because the primitiveCalloutWithArgs path is used very rarely in practice. Have all plugins assign BytesPerWord in their initialize methods, to inline positiveMachineIntegerFor: et al. Override InterpreterPlugin class>>#shouldGenerateDeadCode since these are very platform-specific and the dead code decision well under control. Slang: fix isConstantNode:valueInto: to not be fooled by/ignore the cmacro part of macro methods. Initialize generateDeadCode in VMPluginCodeGenerator>>#pluginClass: =============== Diff against VMMaker.oscog-eem.3231 =============== Item was changed: ----- Method: CCodeGenerator>>isConstantNode:valueInto: (in category 'utilities') ----- isConstantNode: aNode valueInto: aBlock "Answer if aNode evaluates to a constant, and if so, evaluate aBlock with the value of that constant." aNode isConstant ifTrue: [(aNode isDefine and: [(vmClass ifNil: [VMBasicConstants]) defineAtCompileTime: aNode name]) ifTrue: [^false]. aBlock value: aNode value. ^true]. (aNode isVariable and: [aNode name = #nil]) ifTrue: [aBlock value: nil. ^true]. aNode isSend ifTrue: [(self anyMethodNamed: aNode selector) ifNil: [(VMBasicConstants valueOfBasicSelector: aNode selector) ifNotNil: [:value| aBlock value: value. ^true]. aNode constantNumbericValueOrNil ifNotNil: [:value| aBlock value: value. ^true]] ifNotNil: [:m| + (m definedAsMacro not + and: [m statements size = 1 + and: [m statements last isReturn]]) ifTrue: - (m statements size = 1 - and: [m statements last isReturn]) ifTrue: [^self isConstantNode: m statements last expression valueInto: aBlock]]]. ^false! Item was changed: ----- Method: ThreadedARM32FFIPlugin class>>initialize (in category 'class initialization') ----- initialize super initialize. + BytesPerWord := 4. NumIntRegArgs := 4. NumFloatRegArgs := 16! Item was changed: ----- Method: ThreadedARM64FFIPlugin class>>initialize (in category 'class initialization') ----- initialize super initialize. + BytesPerWord := 8. NumIntRegArgs := 8. NumFloatRegArgs := 8! Item was changed: ----- Method: ThreadedFFIPlugin class>>initialize (in category 'class initialization') ----- initialize "c.f. ExternalFunction allInstVarNames old: #('handle' 'flags' 'argTypes') new: #('handle' 'flags' 'argTypes' 'stackSize')" ExternalFunctionAddressIndex := 0. ExternalFunctionFlagsIndex := 1. ExternalFunctionArgTypesIndex := 2. ExternalFunctionStackSizeIndex := 3. "c.f. e.g. CoInterpreter class initializeMiscConstants" MaxNumArgs := 15. DefaultMaxStackSize := 1024 * 16. PluginVersionInfo := CCodeGenerator shortMonticelloDescriptionForClass: self. + PluginVersionInfo := PluginVersionInfo allButFirst: (PluginVersionInfo indexOf: Character space) - 1. + + BytesPerWord := #subclassResponsibility "i.e. every subclass must define this explicitly"! - PluginVersionInfo := PluginVersionInfo allButFirst: (PluginVersionInfo indexOf: Character space) - 1! Item was added: + ----- Method: ThreadedFFIPlugin class>>shouldGenerateDeadCode (in category 'translation') ----- + shouldGenerateDeadCode + "Answer if the code generator should generate dead code, e.g. in false ifTrue: [dead] ifFalse: [live]. + Since plugin source is shared between different VM builds it is unsafe to assume any code is dead. + However, theThreadedFFIPlugin is much more platform-specific and we've done a lot of work on + inlining, so code which depends on defined-at-compiled-time constants should not be considered + dead. So..." + + ^false! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiCall:ArgArrayOrNil:NumArgs: (in category 'callout support') ----- ffiCall: externalFunction ArgArrayOrNil: argArrayOrNil NumArgs: nArgs "Generic callout. Does the actual work. If argArrayOrNil is nil it takes args from the stack and the spec from the method. If argArrayOrNil is not nil takes args from argArrayOrNil and the spec from the receiver." | flags argTypeArray address argType oop argSpec argClass err theCalloutState calloutState requiredStackSize stackSize allocation result primNumArgs | + <inline: #always> - <inline: false> <var: #theCalloutState type: #'CalloutState'> <var: #calloutState type: #'CalloutState *'> <var: #allocation type: #'char *'> primNumArgs := interpreterProxy methodArgumentCount. (interpreterProxy is: externalFunction KindOfClass: interpreterProxy classExternalFunction) ifFalse: [^self ffiFail: FFIErrorNotFunction]. "Load and check the values in the externalFunction before we call out" flags := interpreterProxy fetchInteger: ExternalFunctionFlagsIndex ofObject: externalFunction. interpreterProxy failed ifTrue: [^self ffiFail: FFIErrorBadArgs]. "This must come early for compatibility with the old FFIPlugin. Image-level code may assume the function pointer is loaded eagerly. Thanks to Nicolas Cellier." address := self ffiLoadCalloutAddress: externalFunction. interpreterProxy failed ifTrue: [^0 "error code already set by ffiLoadCalloutAddress:"]. argTypeArray := interpreterProxy fetchPointer: ExternalFunctionArgTypesIndex ofObject: externalFunction. "must be array of arg types" ((interpreterProxy isArray: argTypeArray) and: [(interpreterProxy slotSizeOf: argTypeArray) = (nArgs + 1)]) ifFalse: [^self ffiFail: FFIErrorBadArgs]. "check if the calling convention is supported" self cppIf: COGMTVM ifTrue: [(self ffiSupportsCallingConvention: (flags bitAnd: FFICallTypesMask)) ifFalse: [^self ffiFail: FFIErrorCallType]] ifFalse: "not masking causes threaded calls to fail, which is as they should if the plugin is not threaded." [(self ffiSupportsCallingConvention: flags) ifFalse: [^self ffiFail: FFIErrorCallType]]. requiredStackSize := self externalFunctionHasStackSizeSlot ifTrue: [interpreterProxy fetchInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction] ifFalse: [-1]. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: (argArrayOrNil isNil ifTrue: [PrimErrBadMethod] ifFalse: [PrimErrBadReceiver])]. stackSize := requiredStackSize < 0 ifTrue: [DefaultMaxStackSize] ifFalse: [requiredStackSize]. self cCode: [] inSmalltalk: [theCalloutState := self class calloutStateClass new]. calloutState := self addressOf: theCalloutState. self cCode: [self memset: calloutState _: 0 _: (self sizeof: #CalloutState)]. calloutState callFlags: flags. "Fetch return type and args" argType := interpreterProxy fetchPointer: 0 ofObject: argTypeArray. argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. argClass := interpreterProxy fetchPointer: 1 ofObject: argType. (err := self ffiCheckReturn: argSpec With: argClass in: calloutState) ~= 0 ifTrue: [^self ffiFail: err]. "cannot return" "alloca the outgoing stack frame, leaving room for marshalling args, and including space for the return struct, if any. Additional space reserved for saving register args like mandated by Win64 X64 or PPC ABI, will be managed by the call itself" allocation := self alloca: stackSize + calloutState structReturnSize + self cStackAlignment. self mustAlignStack ifTrue: [allocation := self cCoerce: (allocation asUnsignedIntegerPtr bitClear: self cStackAlignment - 1) to: #'char *']. calloutState argVector: allocation; currentArg: allocation; limit: allocation + stackSize. (self nonRegisterStructReturnIsViaImplicitFirstArgument and: [calloutState structReturnSize > 0 and: [(self returnStructInRegisters: calloutState) not]]) ifTrue: [err := self ffiPushPointer: calloutState limit in: calloutState. err ~= 0 ifTrue: [self cleanupCalloutState: calloutState. self cppIf: COGMTVM ifTrue: [err = PrimErrObjectMayMove negated ifTrue: [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." ^self ffiFail: err]]. 1 to: nArgs do: [:i| argType := interpreterProxy fetchPointer: i ofObject: argTypeArray. argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. argClass := interpreterProxy fetchPointer: 1 ofObject: argType. + oop := argArrayOrNil + ifNil: [interpreterProxy stackValue: nArgs - i] + ifNotNil: [interpreterProxy fetchPointer: i - 1 ofObject: argArrayOrNil]. - oop := argArrayOrNil isNil - ifTrue: [interpreterProxy stackValue: nArgs - i] - ifFalse: [interpreterProxy fetchPointer: i - 1 ofObject: argArrayOrNil]. err := self ffiArgument: oop Spec: argSpec Class: argClass in: calloutState. err ~= 0 ifTrue: [self cleanupCalloutState: calloutState. self cppIf: COGMTVM ifTrue: [err = PrimErrObjectMayMove negated ifTrue: [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." ^self ffiFail: err]]. "coercion failed or out of stack space" "Failures must be reported back from ffiArgument:Spec:Class:in:. Should not fail from here on in." self assert: interpreterProxy failed not. self ffiLogCallout: externalFunction. (requiredStackSize < 0 and: [self externalFunctionHasStackSizeSlot]) ifTrue: [stackSize := calloutState currentArg - calloutState argVector. interpreterProxy storeInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction withValue: stackSize]. "Go out and call this guy" result := self ffiCalloutTo: address SpecOnStack: argArrayOrNil notNil in: calloutState. self cleanupCalloutState: calloutState. "Can not safely use argumentCount (via e.g. methodReturnValue:) since it may have been changed by a callback." interpreterProxy pop: primNumArgs + 1 thenPush: result. ^result! Item was added: + ----- Method: ThreadedIA32FFIPlugin class>>initialize (in category 'class initialization') ----- + initialize + super initialize. + BytesPerWord := 4! Item was removed: - ----- Method: ThreadedRiscV64FFIPlugin class>>initialize (in category 'class initialization') ----- - initialize - super initialize. - NumIntRegArgs := 8. - NumFloatRegArgs := 8! Item was changed: ----- Method: ThreadedX64FFIPlugin class>>initialize (in category 'class initialization') ----- initialize + BytesPerWord := WordSize := 8. - WordSize := 8. NumIntRegArgs := 6. NumFloatRegArgs := 8! Item was changed: ----- Method: ThreadedX64SysVFFIPlugin class>>initialize (in category 'class initialization') ----- initialize + super initialize. - WordSize := 8. NumIntRegArgs := 6. NumFloatRegArgs := 8! Item was changed: ----- Method: ThreadedX64Win64FFIPlugin class>>initialize (in category 'class initialization') ----- initialize + super initialize. - WordSize := 8. NumIntRegArgs := 4. NumFloatRegArgs := 4! Item was changed: ----- Method: VMBasicConstants class>>namesDefinedAtCompileTime (in category 'C translation') ----- namesDefinedAtCompileTime "Answer the set of names for variables that should be defined at compile time. Some of these get default values during simulation, and hence get defaulted in the various initializeMiscConstants methods. But that they have values should /not/ cause the code generator to do dead code elimination based on their default values. In particular, methods marked with <option: ANameDefinedAtCompileTime> will be emitted within #if defined(ANameDefinedAtCompileTime)...#endif. And of course this is backwards. We'd like to define names that are defined at translation time. But doing so would entail defining (or referencing) hundreds of class and pool variables. This way is more manageable" ^#(VMBIGENDIAN IMMUTABILITY STACKVM COGVM COGMTVM SPURVM PharoVM "Pharo vs Squeak" TerfVM VM_TICKER "Terf vs Squeak & Qwaq/Teleplace/Terf high-priority thread support" EnforceAccessControl "Newspeak" CheckRememberedInTrampoline "IMMUTABILITY" BIT_IDENTICAL_FLOATING_POINT PLATFORM_SPECIFIC_FLOATING_POINT "Alternatives for using fdlibm for floating-point" ITIMER_HEARTBEAT "older linux's woultn't allow a higher priority thread, hence no threaded heartbeat." TestingPrimitives OBSOLETE_ALIEN_PRIMITIVES "Ancient crap in the IA32ABI plugin" LLDB "As of lldb-370.0.42 Swift-3.1, passing function parameters to printOopsSuchThat fails with Internal error [IRForTarget]: Couldn't rewrite one of the arguments of a function call. Turning off link time optimization with -fno-lto has no effect. hence we define some debugging functions as being <option: LLDB>" LRPCheck "Optional checking for long running primitives" + "ThreadedFFIPlugin related" + ALLOCA_LIES_SO_SETSP_BEFORE_CALL PLATFORM_API_USES_CALLEE_POPS_CONVENTION SQUEAK_BUILTIN_PLUGIN STACK_ALIGN_BYTES + "processor related" __ARM_ARCH__ __arm__ __arm32__ ARM32 __arm64__ ARM64 _M_I386 _X86_ i386 i486 i586 i686 __i386__ __386__ X86 I386 x86_64 __amd64 __x86_64 __amd64__ __x86_64__ _M_AMD64 _M_X64 __mips__ __mips __powerpc __powerpc__ __powerpc64__ __POWERPC__ __ppc__ __ppc64__ __PPC__ __PPC64__ __sparc__ __sparc __sparc_v8__ __sparc_v9__ __sparcv8 __sparcv9 "Compiler brand related" __ACK__ __CC_ARM __clang__ __GNUC__ _MSC_VER __ICC __SUNPRO_C "os related" ACORN _AIX __ANDROID__ __APPLE__ __BEOS__ __linux__ __MACH__ __MINGW32__ __FreeBSD__ __NetBSD__ __OpenBSD__ __osf__ EPLAN9 __unix__ __unix UNIX WIN32 _WIN32 _WIN32_WCE WIN64 _WIN64 _WIN64_WCE)! Item was changed: ----- Method: VMPluginCodeGenerator>>pluginClass: (in category 'public') ----- pluginClass: aPluginClass "Set the plugin class and name when generating plugins. And for run-time use, answer the name string." | packageId | pluginClass := aPluginClass. + aPluginClass ifNotNil: + [generateDeadCode := aPluginClass shouldGenerateDeadCode]. packageId := self shortMonticelloDescriptionForClass: pluginClass. (packageId beginsWith: pluginClass name) ifTrue: [packageId := packageId allButFirst: pluginClass name size]. (packageId beginsWith: pluginClass moduleName) ifTrue: [packageId := packageId allButFirst: pluginClass moduleName size]. ^self declareModuleName: pluginClass moduleNameAndVersion, packageId!

1 0

VM Maker: VMMaker.oscog-eem.3231.mcz
by commits＠source.squeak.org 02 Aug '22

02 Aug '22

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3231.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3231 Author: eem Time: 2 August 2022, 8:32:42.653469 am UUID: d0507db9-2a9c-40e6-9274-8e05bf0a2483 Ancestors: VMMaker.oscog-eem.3230 Fix nonRegisterStructReturnIsViaImplicitFirstArgument for ThreadedRiscV64FFIPlugin. Make it inline always on all of them, along with a few others. Delete the ARMv8 and RISCV versions of ffiCall:ArgArrayOrNil:NumArgs:, which were added as a misunderstanding. Mark ffiCall:ArgArrayOrNil:NumArgs: as inline: false. It saves about 10k, sharing the code between primitiveCallout & primitiveCalloutWithArgs. =============== Diff against VMMaker.oscog-eem.3230 =============== Item was changed: ----- Method: InterpreterPlugin>>isAlien: (in category 'alien support') ----- isAlien: oop "Answer if oop is an Alien. We could ask if isWordsOrBytes: first, but that doesn't help. We still have to do the is:KindOf: walk. We're not interested in fast falsehood, but as fast as possible truth, and with the current API this is it." + <inline: #always> - <inline: true> ^interpreterProxy is: oop KindOfClass: interpreterProxy classAlien! Item was removed: - ----- Method: ThreadedARM64FFIPlugin>>ffiCall:ArgArrayOrNil:NumArgs: (in category 'callout support') ----- - ffiCall: externalFunction ArgArrayOrNil: argArrayOrNil NumArgs: nArgs - "Generic callout. Does the actual work. If argArrayOrNil is nil it takes args from the stack - and the spec from the method. If argArrayOrNil is not nil takes args from argArrayOrNil - and the spec from the receiver." - | flags argTypeArray address argType oop argSpec argClass err theCalloutState calloutState requiredStackSize stackSize allocation result primNumArgs | - <inline: false> - <var: #theCalloutState type: #'CalloutState'> - <var: #calloutState type: #'CalloutState *'> - <var: #allocation type: #'char *'> - - primNumArgs := interpreterProxy methodArgumentCount. - (interpreterProxy is: externalFunction KindOfClass: interpreterProxy classExternalFunction) ifFalse: - [^self ffiFail: FFIErrorNotFunction]. - "Load and check the values in the externalFunction before we call out" - flags := interpreterProxy fetchInteger: ExternalFunctionFlagsIndex ofObject: externalFunction. - interpreterProxy failed ifTrue: - [^self ffiFail: FFIErrorBadArgs]. - - "This must come early for compatibility with the old FFIPlugin. Image-level code - may assume the function pointer is loaded eagerly. Thanks to Nicolas Cellier." - address := self ffiLoadCalloutAddress: externalFunction. - interpreterProxy failed ifTrue: - [^0 "error code already set by ffiLoadCalloutAddress:"]. - - argTypeArray := interpreterProxy fetchPointer: ExternalFunctionArgTypesIndex ofObject: externalFunction. - "must be array of arg types" - ((interpreterProxy isArray: argTypeArray) - and: [(interpreterProxy slotSizeOf: argTypeArray) = (nArgs + 1)]) ifFalse: - [^self ffiFail: FFIErrorBadArgs]. - "check if the calling convention is supported" - self cppIf: COGMTVM - ifTrue: - [(self ffiSupportsCallingConvention: (flags bitAnd: FFICallTypesMask)) ifFalse: - [^self ffiFail: FFIErrorCallType]] - ifFalse: "not masking causes threaded calls to fail, which is as they should if the plugin is not threaded." - [(self ffiSupportsCallingConvention: flags) ifFalse: - [^self ffiFail: FFIErrorCallType]]. - - requiredStackSize := self externalFunctionHasStackSizeSlot - ifTrue: [interpreterProxy - fetchInteger: ExternalFunctionStackSizeIndex - ofObject: externalFunction] - ifFalse: [-1]. - interpreterProxy failed ifTrue: - [^interpreterProxy primitiveFailFor: (argArrayOrNil isNil - ifTrue: [PrimErrBadMethod] - ifFalse: [PrimErrBadReceiver])]. - stackSize := requiredStackSize < 0 ifTrue: [DefaultMaxStackSize] ifFalse: [requiredStackSize]. - self cCode: [] inSmalltalk: [theCalloutState := self class calloutStateClass new]. - calloutState := self addressOf: theCalloutState. - self cCode: [self memset: calloutState _: 0 _: (self sizeof: #CalloutState)]. - calloutState callFlags: flags. - "Fetch return type and args" - argType := interpreterProxy fetchPointer: 0 ofObject: argTypeArray. - argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. - argClass := interpreterProxy fetchPointer: 1 ofObject: argType. - (err := self ffiCheckReturn: argSpec With: argClass in: calloutState) ~= 0 ifTrue: - [^self ffiFail: err]. "cannot return" - "alloca the outgoing stack frame, leaving room for marshalling args, and including space for the return struct, if any. - Additional space reserved for saving register args like mandated by Win64 X64 or PPC ABI, will be managed by the call itself" - allocation := self alloca: stackSize + calloutState structReturnSize + self cStackAlignment. - self mustAlignStack ifTrue: - [allocation := self cCoerce: (allocation asUnsignedIntegerPtr bitClear: self cStackAlignment - 1) to: #'char *']. - calloutState - argVector: allocation; - currentArg: allocation; - limit: allocation + stackSize. - 1 to: nArgs do: - [:i| - argType := interpreterProxy fetchPointer: i ofObject: argTypeArray. - argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. - argClass := interpreterProxy fetchPointer: 1 ofObject: argType. - oop := argArrayOrNil isNil - ifTrue: [interpreterProxy stackValue: nArgs - i] - ifFalse: [interpreterProxy fetchPointer: i - 1 ofObject: argArrayOrNil]. - err := self ffiArgument: oop Spec: argSpec Class: argClass in: calloutState. - err ~= 0 ifTrue: - [self cleanupCalloutState: calloutState. - self cppIf: COGMTVM ifTrue: - [err = PrimErrObjectMayMove negated ifTrue: - [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." - ^self ffiFail: err]]. "coercion failed or out of stack space" - "Failures must be reported back from ffiArgument:Spec:Class:in:. - Should not fail from here on in." - self assert: interpreterProxy failed not. - self ffiLogCallout: externalFunction. - (requiredStackSize < 0 - and: [self externalFunctionHasStackSizeSlot]) ifTrue: - [stackSize := calloutState currentArg - calloutState argVector. - interpreterProxy storeInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction withValue: stackSize]. - "Go out and call this guy" - result := self ffiCalloutTo: address SpecOnStack: argArrayOrNil notNil in: calloutState. - self cleanupCalloutState: calloutState. - "Can not safely use argumentCount (via e.g. methodReturnValue:) since it may have been changed by a callback." - interpreterProxy pop: primNumArgs + 1 thenPush: result. - ^result! Item was changed: ----- Method: ThreadedARM64FFIPlugin>>nonRegisterStructReturnIsViaImplicitFirstArgument (in category 'marshalling') ----- nonRegisterStructReturnIsViaImplicitFirstArgument "Answer if a struct returned in memory is returned to the + referent of a pointer passed as an implicit first argument. + It almost always is, but isn't in ARMv8 and RISCV 64 ABIs." + <inline: #always> - referent of a pointer passed as an implciit first argument. - It almost always is. Subclasses can override if not." ^false! Item was changed: ----- Method: ThreadedFFICalloutStateForX64>>incrementFloatRegisterIndex (in category 'accessing') ----- incrementFloatRegisterIndex + <inline: #always> ^floatRegisterIndex := floatRegisterIndex + 1! Item was changed: ----- Method: ThreadedFFICalloutStateForX64>>incrementIntegerRegisterIndex (in category 'accessing') ----- incrementIntegerRegisterIndex + <inline: #always> ^integerRegisterIndex := integerRegisterIndex + 1! Item was changed: ----- Method: ThreadedFFICalloutStateForX64Win64>>incrementFloatRegisterIndex (in category 'accessing') ----- incrementFloatRegisterIndex "There are only 4 args passed by register int or float. So we can't distinguish the float index from the integer index. So we have to increment both. Consequently, floatRegisterIndex cannot be used anymore to detect presence of float parameter. However, we set a signature bitmap indicating which register position is used to pass a float. IMPLEMENTATION NOTES: There are code generator hacks that bypass the accessors. So we cannot just redefine the method floatRegisterIndex as ^integerRegisterIndex. Instead we must maintain the two indices" + <inline: #always> floatRegisterSignature := floatRegisterSignature + (1 << floatRegisterIndex). ^integerRegisterIndex := floatRegisterIndex := floatRegisterIndex + 1! Item was changed: ----- Method: ThreadedFFICalloutStateForX64Win64>>incrementIntegerRegisterIndex (in category 'accessing') ----- incrementIntegerRegisterIndex "There are only 4 args passed by register int or float. So we can't distinguish the float index from the integer index. So we have to increment both. IMPLEMENTATION NOTES: There are code generator hacks that bypass the accessors. So we cannot just redefine the method floatRegisterIndex as ^integerRegisterIndex. Instead we must maintain the two indices" + <inline: #always> ^floatRegisterIndex := integerRegisterIndex := integerRegisterIndex + 1! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiCall:ArgArrayOrNil:NumArgs: (in category 'callout support') ----- ffiCall: externalFunction ArgArrayOrNil: argArrayOrNil NumArgs: nArgs "Generic callout. Does the actual work. If argArrayOrNil is nil it takes args from the stack and the spec from the method. If argArrayOrNil is not nil takes args from argArrayOrNil and the spec from the receiver." | flags argTypeArray address argType oop argSpec argClass err theCalloutState calloutState requiredStackSize stackSize allocation result primNumArgs | + <inline: false> - <inline: true> <var: #theCalloutState type: #'CalloutState'> <var: #calloutState type: #'CalloutState *'> <var: #allocation type: #'char *'> primNumArgs := interpreterProxy methodArgumentCount. (interpreterProxy is: externalFunction KindOfClass: interpreterProxy classExternalFunction) ifFalse: [^self ffiFail: FFIErrorNotFunction]. "Load and check the values in the externalFunction before we call out" flags := interpreterProxy fetchInteger: ExternalFunctionFlagsIndex ofObject: externalFunction. interpreterProxy failed ifTrue: [^self ffiFail: FFIErrorBadArgs]. "This must come early for compatibility with the old FFIPlugin. Image-level code may assume the function pointer is loaded eagerly. Thanks to Nicolas Cellier." address := self ffiLoadCalloutAddress: externalFunction. interpreterProxy failed ifTrue: [^0 "error code already set by ffiLoadCalloutAddress:"]. argTypeArray := interpreterProxy fetchPointer: ExternalFunctionArgTypesIndex ofObject: externalFunction. "must be array of arg types" ((interpreterProxy isArray: argTypeArray) and: [(interpreterProxy slotSizeOf: argTypeArray) = (nArgs + 1)]) ifFalse: [^self ffiFail: FFIErrorBadArgs]. "check if the calling convention is supported" self cppIf: COGMTVM ifTrue: [(self ffiSupportsCallingConvention: (flags bitAnd: FFICallTypesMask)) ifFalse: [^self ffiFail: FFIErrorCallType]] ifFalse: "not masking causes threaded calls to fail, which is as they should if the plugin is not threaded." [(self ffiSupportsCallingConvention: flags) ifFalse: [^self ffiFail: FFIErrorCallType]]. requiredStackSize := self externalFunctionHasStackSizeSlot ifTrue: [interpreterProxy fetchInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction] ifFalse: [-1]. interpreterProxy failed ifTrue: [^interpreterProxy primitiveFailFor: (argArrayOrNil isNil ifTrue: [PrimErrBadMethod] ifFalse: [PrimErrBadReceiver])]. stackSize := requiredStackSize < 0 ifTrue: [DefaultMaxStackSize] ifFalse: [requiredStackSize]. self cCode: [] inSmalltalk: [theCalloutState := self class calloutStateClass new]. calloutState := self addressOf: theCalloutState. self cCode: [self memset: calloutState _: 0 _: (self sizeof: #CalloutState)]. calloutState callFlags: flags. "Fetch return type and args" argType := interpreterProxy fetchPointer: 0 ofObject: argTypeArray. argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. argClass := interpreterProxy fetchPointer: 1 ofObject: argType. (err := self ffiCheckReturn: argSpec With: argClass in: calloutState) ~= 0 ifTrue: [^self ffiFail: err]. "cannot return" "alloca the outgoing stack frame, leaving room for marshalling args, and including space for the return struct, if any. Additional space reserved for saving register args like mandated by Win64 X64 or PPC ABI, will be managed by the call itself" allocation := self alloca: stackSize + calloutState structReturnSize + self cStackAlignment. self mustAlignStack ifTrue: [allocation := self cCoerce: (allocation asUnsignedIntegerPtr bitClear: self cStackAlignment - 1) to: #'char *']. calloutState argVector: allocation; currentArg: allocation; limit: allocation + stackSize. + (self nonRegisterStructReturnIsViaImplicitFirstArgument + and: [calloutState structReturnSize > 0 - (calloutState structReturnSize > 0 - and: [self nonRegisterStructReturnIsViaImplicitFirstArgument and: [(self returnStructInRegisters: calloutState) not]]) ifTrue: [err := self ffiPushPointer: calloutState limit in: calloutState. err ~= 0 ifTrue: [self cleanupCalloutState: calloutState. self cppIf: COGMTVM ifTrue: [err = PrimErrObjectMayMove negated ifTrue: [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." ^self ffiFail: err]]. 1 to: nArgs do: [:i| argType := interpreterProxy fetchPointer: i ofObject: argTypeArray. argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. argClass := interpreterProxy fetchPointer: 1 ofObject: argType. oop := argArrayOrNil isNil ifTrue: [interpreterProxy stackValue: nArgs - i] ifFalse: [interpreterProxy fetchPointer: i - 1 ofObject: argArrayOrNil]. err := self ffiArgument: oop Spec: argSpec Class: argClass in: calloutState. err ~= 0 ifTrue: [self cleanupCalloutState: calloutState. self cppIf: COGMTVM ifTrue: [err = PrimErrObjectMayMove negated ifTrue: [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." ^self ffiFail: err]]. "coercion failed or out of stack space" "Failures must be reported back from ffiArgument:Spec:Class:in:. Should not fail from here on in." self assert: interpreterProxy failed not. self ffiLogCallout: externalFunction. (requiredStackSize < 0 and: [self externalFunctionHasStackSizeSlot]) ifTrue: [stackSize := calloutState currentArg - calloutState argVector. interpreterProxy storeInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction withValue: stackSize]. "Go out and call this guy" result := self ffiCalloutTo: address SpecOnStack: argArrayOrNil notNil in: calloutState. self cleanupCalloutState: calloutState. "Can not safely use argumentCount (via e.g. methodReturnValue:) since it may have been changed by a callback." interpreterProxy pop: primNumArgs + 1 thenPush: result. ^result! Item was changed: ----- Method: ThreadedFFIPlugin>>ffiSupportsCallingConvention: (in category 'callout support') ----- ffiSupportsCallingConvention: aCallingConvention "Check that the calling convention is valid. This test also filters out attempts to do a threaded call in the non-threaded VM/plugin combinatioin." + <inline: #always> - <inline: true> ^aCallingConvention = FFICallTypeCDecl or: [aCallingConvention = FFICallTypeApi]! Item was changed: ----- Method: ThreadedFFIPlugin>>isDirectAlien: (in category 'primitive support') ----- isDirectAlien: oop + <inline: #always> self assert: (self isAlien: oop). ^(self sizeField: oop) > 0! Item was changed: ----- Method: ThreadedFFIPlugin>>isFloatAtomicType: (in category 'primitive support') ----- isFloatAtomicType: atomicTypeCode + <inline: #always> - <inline: true> "(atomicTypeCode >> 1) = (FFITypeSingleFloat >> 1)" ^atomicTypeCode >> 1 = 6 ! Item was changed: ----- Method: ThreadedFFIPlugin>>nonRegisterStructReturnIsViaImplicitFirstArgument (in category 'marshalling-struct') ----- nonRegisterStructReturnIsViaImplicitFirstArgument "Answer if a struct returned in memory is returned to the + referent of a pointer passed as an implicit first argument. - referent of a pointer passed as an implciit first argument. It almost always is. Subclasses can override if not." + <inline: #always> ^true! Item was removed: - ----- Method: ThreadedRiscV64FFIPlugin>>ffiCall:ArgArrayOrNil:NumArgs: (in category 'callout support') ----- - ffiCall: externalFunction ArgArrayOrNil: argArrayOrNil NumArgs: nArgs - "Generic callout. Does the actual work. If argArrayOrNil is nil it takes args from the stack - and the spec from the method. If argArrayOrNil is not nil takes args from argArrayOrNil - and the spec from the receiver." - | flags argTypeArray address argType oop argSpec argClass err theCalloutState calloutState requiredStackSize stackSize allocation result primNumArgs | - <inline: false> - <var: #theCalloutState type: #'CalloutState'> - <var: #calloutState type: #'CalloutState *'> - <var: #allocation type: #'char *'> - - primNumArgs := interpreterProxy methodArgumentCount. - (interpreterProxy is: externalFunction KindOfClass: interpreterProxy classExternalFunction) ifFalse: - [^self ffiFail: FFIErrorNotFunction]. - "Load and check the values in the externalFunction before we call out" - flags := interpreterProxy fetchInteger: ExternalFunctionFlagsIndex ofObject: externalFunction. - interpreterProxy failed ifTrue: - [^self ffiFail: FFIErrorBadArgs]. - - "This must come early for compatibility with the old FFIPlugin. Image-level code - may assume the function pointer is loaded eagerly. Thanks to Nicolas Cellier." - address := self ffiLoadCalloutAddress: externalFunction. - interpreterProxy failed ifTrue: - [^0 "error code already set by ffiLoadCalloutAddress:"]. - - argTypeArray := interpreterProxy fetchPointer: ExternalFunctionArgTypesIndex ofObject: externalFunction. - "must be array of arg types" - ((interpreterProxy isArray: argTypeArray) - and: [(interpreterProxy slotSizeOf: argTypeArray) = (nArgs + 1)]) ifFalse: - [^self ffiFail: FFIErrorBadArgs]. - "check if the calling convention is supported" - self cppIf: COGMTVM - ifTrue: - [(self ffiSupportsCallingConvention: (flags bitAnd: FFICallTypesMask)) ifFalse: - [^self ffiFail: FFIErrorCallType]] - ifFalse: "not masking causes threaded calls to fail, which is as they should if the plugin is not threaded." - [(self ffiSupportsCallingConvention: flags) ifFalse: - [^self ffiFail: FFIErrorCallType]]. - - requiredStackSize := self externalFunctionHasStackSizeSlot - ifTrue: [interpreterProxy - fetchInteger: ExternalFunctionStackSizeIndex - ofObject: externalFunction] - ifFalse: [-1]. - interpreterProxy failed ifTrue: - [^interpreterProxy primitiveFailFor: (argArrayOrNil isNil - ifTrue: [PrimErrBadMethod] - ifFalse: [PrimErrBadReceiver])]. - stackSize := requiredStackSize < 0 ifTrue: [DefaultMaxStackSize] ifFalse: [requiredStackSize]. - self cCode: [] inSmalltalk: [theCalloutState := self class calloutStateClass new]. - calloutState := self addressOf: theCalloutState. - self cCode: [self memset: calloutState _: 0 _: (self sizeof: #CalloutState)]. - calloutState callFlags: flags. - "Fetch return type and args" - argType := interpreterProxy fetchPointer: 0 ofObject: argTypeArray. - argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. - argClass := interpreterProxy fetchPointer: 1 ofObject: argType. - (err := self ffiCheckReturn: argSpec With: argClass in: calloutState) ~= 0 ifTrue: - [^self ffiFail: err]. "cannot return" - "alloca the outgoing stack frame, leaving room for marshalling args, and including space for the return struct, if any. - Additional space reserved for saving register args like mandated by Win64 X64 or PPC ABI, will be managed by the call itself" - allocation := self alloca: stackSize + calloutState structReturnSize + self cStackAlignment. - self mustAlignStack ifTrue: - [allocation := self cCoerce: (allocation asUnsignedIntegerPtr bitClear: self cStackAlignment - 1) to: #'char *']. - calloutState - argVector: allocation; - currentArg: allocation; - limit: allocation + stackSize. - "This next bit overrides the ARM64 code to pass return struct pointer in A0" - (calloutState structReturnSize > 0 - and: [self nonRegisterStructReturnIsViaImplicitFirstArgument - and: [(self returnStructInRegisters: calloutState) not]]) ifTrue: - [err := self ffiPushPointer: calloutState limit in: calloutState. - err ~= 0 ifTrue: - [self cleanupCalloutState: calloutState. - self cppIf: COGMTVM ifTrue: - [err = PrimErrObjectMayMove negated ifTrue: - [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." - ^self ffiFail: err]]. - "Aside from the bit above, code identical with arm64" - 1 to: nArgs do: - [:i| - argType := interpreterProxy fetchPointer: i ofObject: argTypeArray. - argSpec := interpreterProxy fetchPointer: 0 ofObject: argType. - argClass := interpreterProxy fetchPointer: 1 ofObject: argType. - oop := argArrayOrNil isNil - ifTrue: [interpreterProxy stackValue: nArgs - i] - ifFalse: [interpreterProxy fetchPointer: i - 1 ofObject: argArrayOrNil]. - err := self ffiArgument: oop Spec: argSpec Class: argClass in: calloutState. - err ~= 0 ifTrue: - [self cleanupCalloutState: calloutState. - self cppIf: COGMTVM ifTrue: - [err = PrimErrObjectMayMove negated ifTrue: - [^PrimErrObjectMayMove]]. "N.B. Do not fail if object may move because caller will GC and retry." - ^self ffiFail: err]]. "coercion failed or out of stack space" - "Failures must be reported back from ffiArgument:Spec:Class:in:. - Should not fail from here on in." - self assert: interpreterProxy failed not. - self ffiLogCallout: externalFunction. - (requiredStackSize < 0 - and: [self externalFunctionHasStackSizeSlot]) ifTrue: - [stackSize := calloutState currentArg - calloutState argVector. - interpreterProxy storeInteger: ExternalFunctionStackSizeIndex ofObject: externalFunction withValue: stackSize]. - "Go out and call this guy" - result := self ffiCalloutTo: address SpecOnStack: argArrayOrNil notNil in: calloutState. - self cleanupCalloutState: calloutState. - "Can not safely use argumentCount (via e.g. methodReturnValue:) since it may have been changed by a callback." - interpreterProxy pop: primNumArgs + 1 thenPush: result. - ^result! Item was removed: - ----- Method: ThreadedRiscV64FFIPlugin>>nonRegisterStructReturnIsViaImplicitFirstArgument (in category 'marshalling') ----- - nonRegisterStructReturnIsViaImplicitFirstArgument - "Answer if a struct returned in memory is returned to the - referent of a pointer passed as an implciit first argument. - It almost always is. Subclasses can override if not." - ^true!

1 0

[OpenSmalltalk/opensmalltalk-vm] Refixed slip in mvm (PR #646)
by Ken Dickey 02 Aug '22

02 Aug '22

Elided 1 line (TARGET_ARCH) You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646 -- Commit Summary -- * Refixed slip in mvm -- File Changes -- M building/linux64riscv/squeak.stack.spur/build/mvm (1) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646.diff -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/646 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/pull/646(a)github.com>

2 10

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev August 2022