Vm-dev January 2023

vm-dev@lists.squeakfoundation.org

17 participants
74 discussions

VM Maker: VMMaker.oscog.seperateMarking-WoC.3311.mcz
by commits＠source.squeak.org 14 Jan '23

14 Jan '23

Tom Braun uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog.seperateMarking-WoC.3311.mcz ==================== Summary ==================== Name: VMMaker.oscog.seperateMarking-WoC.3311 Author: WoC Time: 14 January 2023, 4:54:00.77254 pm UUID: ffbdd1a4-a1ff-4a71-b10a-ad0765ed5251 Ancestors: VMMaker.oscog.seperateMarking-eem.3310 prevent compaction to try to create objects of size 8 byte as this is currently not possible =============== Diff against VMMaker.oscog.seperateMarking-eem.3310 =============== Item was added: + ----- Method: SpurIncrementalCompactingSweeper>>canTolerateObjStartingAt:sized:inSegment: (in category 'as yet unclassified') ----- + canTolerateObjStartingAt: address sized: numBytes inSegment: segInfo + "do not copy and object that would overflow the segment or leave only 8 bytes, as the smallest + object size is 16 bytes and we would violate heap parsability (until slim bridges or another hack + mitigating this limitation comes around)" + + <var: 'segInfo' type: #'SpurSegmentInfo *'> + + | bridgeAddress | + bridgeAddress := segInfo segLimit - manager bridgeSize. + ^ (self oop: address + numBytes isLessThan: bridgeAddress) + and: [address + numBytes + 8 ~= bridgeAddress]! Item was changed: ----- Method: SpurIncrementalCompactingSweeper>>compactSegment:freeStart:segIndex: (in category 'incremental compact') ----- compactSegment: segInfo freeStart: initialFreeStart segIndex: segIndex <var: 'segInfo' type: #'SpurSegmentInfo *'> | fillStart | fillStart := initialFreeStart. self deny: segIndex = 0. "Cannot compact seg 0" manager segmentManager allEntitiesInSegment: segInfo exceptTheLastBridgeDo: [:entity | (manager isFreeObject: entity) ifTrue: [manager detachFreeObject: entity. currentsCycleSeenObjectCount := currentsCycleSeenObjectCount + 1. "To avoid confusing too much Spur (especially the leak/free checks), we mark the free chunk as a word object." manager set: entity classIndexTo: manager wordSizeClassIndexPun formatTo: manager wordIndexableFormat] ifFalse: [ (manager isPinned: entity) ifTrue: [manager debugger]. (manager isMarked: entity) ifTrue: [| bytesToCopy | "note: we copy even forwarders if they are marked so they cannot get lost" manager makeWhite: entity. "I really hat that this can happen :( . The marker will keep track of which segments contain pinned objects. If the pinned object is created during sweeping and compacting, we cannot know about it while working at our plan we did at the start of sweeping and compacting" (manager isPinned: entity) ifTrue: [self abortCompactionAt: entity in: segInfo]. bytesToCopy := manager bytesInBody: entity. + (self canTolerateObjStartingAt: fillStart sized: bytesToCopy inSegment: segmentToFill) - (self would: fillStart + bytesToCopy overflowSegment: segmentToFill) ifFalse: [ self abortCompactionAt: entity in: segInfo. ^ fillStart]. "let's make copying more expensive. Number is just a guess" currentsCycleSeenObjectCount := currentsCycleSeenObjectCount + 100. self migrate: entity sized: bytesToCopy to: fillStart. fillStart := fillStart + bytesToCopy. self assert: (self oop: fillStart isLessThan: (segmentToFill segLimit - manager bridgeSize))] ifFalse: [self handleUnmarkedEntity: entity]]]. "we want to advance to the next segment from the bridge" currentObject := currentSegmentsBridge. ^ fillStart! Item was added: + ----- Method: SpurIncrementalCompactingSweeper>>isSegmentBeingPartiallyCompacted: (in category 'testing') ----- + isSegmentBeingPartiallyCompacted: segInfo + + <var: 'segInfo' type: #'SpurSegmentInfo *'> + "Swizzle is abused to note a segment as being compacted. + swizzle = 0 -> not compacted + swizzle = 1 -> compacted + swizzle > 7 -> aborted compaction; swizzle is set to the objOop of the object after the compacted part" + ^ segInfo swizzle > 7! Item was changed: ----- Method: SpurIncrementalCompactingSweeper>>occupyRestOfFreeCompactedIntoSegment (in category 'incremental compact') ----- occupyRestOfFreeCompactedIntoSegment + "we cannot create objects of size 8. To set currentCopyToPointer 8 byte before the bridge should be prevented by the + code in the copying logic, but better save than sorry" + self assert: (currentCopyToPointer + 8 ~= segmentToFill segLimit - manager bridgeSize). + "do not overwrite the bridge" (self oop: currentCopyToPointer isGreaterThanOrEqualTo: segmentToFill segLimit - manager bridgeSize) ifTrue: [^ self]. manager initFreeChunkWithBytes: segmentToFill segSize - manager bridgeSize + segmentToFill segStart - currentCopyToPointer at: currentCopyToPointer. "avoid confusing spur, especially for leak checks" manager set: (manager objectStartingAt: currentCopyToPointer) classIndexTo: manager wordSizeClassIndexPun formatTo: manager wordIndexableFormat! Item was changed: ----- Method: SpurIncrementalCompactingSweeper>>setFreeChunkOfCompactedIntoSegment (in category 'incremental compact') ----- setFreeChunkOfCompactedIntoSegment shouldCompact ifFalse: [^ self]. "do not overwrite the bridge" (self oop: currentCopyToPointer isGreaterThanOrEqualTo: segmentToFill segLimit - manager bridgeSize) ifTrue: [^ self]. self assert: segmentToFill notNil. + "we cannot create an object sized 8 bytes. 16 bytes is the minimum dictated by Spur" + self assert: currentCopyToPointer + 8 ~= (segmentToFill segLimit - manager bridgeSize). - self assert: (self oop: currentCopyToPointer isLessThan: segmentToFill segLimit - manager bridgeSize). coInterpreter cr; print: 'after compaction freeing from: '; printHex: currentCopyToPointer; + print: ' to: '; printHex: segmentToFill segLimit - manager bridgeSize ; - print: ' to: '; printHex: segmentToFill segStart + segmentToFill segSize - manager bridgeSize + segmentToFill segStart - currentCopyToPointer ; tab; flush. + + self assert: (manager isFreeObject: (manager objectStartingAt: currentCopyToPointer)) not. + (manager isFreeObject: (manager objectStartingAt: currentCopyToPointer)) not + ifFalse: [manager debugger]. manager addFreeChunkWithBytes: segmentToFill segSize - manager bridgeSize + segmentToFill segStart - currentCopyToPointer at: currentCopyToPointer. "we have compacted into segmentToFill. It is now not empty anymore and we need to look for a new one" segmentToFill := nil ! Item was removed: - ----- Method: SpurIncrementalCompactingSweeper>>would:overflowSegment: (in category 'compaction planning') ----- - would: address overflowSegment: segInfo - - ^ (self oop: address isLessThan: (segInfo segLimit - manager bridgeSize))!

1 0

VM Maker: VMMaker.oscog.seperateMarking-eem.3310.mcz
by commits＠source.squeak.org 14 Jan '23

14 Jan '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog.seperateMarking-eem.3310.mcz ==================== Summary ==================== Name: VMMaker.oscog.seperateMarking-eem.3310 Author: eem Time: 13 January 2023, 6:56:28.097354 pm UUID: 4f39f2f8-0df2-415e-9afd-3a77200483d8 Ancestors: VMMaker.oscog.seperateMarking-eem.3309 Merge VMMaker.oscog-eem.3296 through 3300 Include a small suite of VM benchmark primitives to measure the time taken by operations that are too short-lived to want to time them (because timing can have significant overhead). =============== Diff against VMMaker.oscog.seperateMarking-eem.3309 =============== Item was added: + ----- Method: CoInterpreter class>>benchmarkFollowForwardersInStackZone (in category 'benchmarks') ----- + benchmarkFollowForwardersInStackZone + "Answer the elapsed time in microseconds for followForwardingPointersInStackZone." + + | ticksPerMicrosecond | + ticksPerMicrosecond := Time highResClockTicksPerMillisecond / 1000.0. + ^self primitiveBenchmarkFollowForwardersInStackZone / ticksPerMicrosecond + + "self benchmarkFollowForwardersInStackZone"! Item was added: + ----- Method: CoInterpreter class>>benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone (in category 'benchmarks') ----- + benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone + "Answer the elapsed time in microseconds for followForwardingPointersOfReceiverAndTemporariesInStackZone." + + | ticksPerMicrosecond | + ticksPerMicrosecond := Time highResClockTicksPerMillisecond / 1000.0. + ^self primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone / ticksPerMicrosecond + + "self benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone" + "| goDeep | + goDeep := #defined. + goDeep := [:depth| | laurel hardy | + depth < 1 + ifTrue: + [laurel := OrderedCollection new. + hardy := laurel copy. + 10 timesRepeat: + [laurel add: self benchmarkFollowForwardersInStackZone. + hardy add: self benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone]. + { laurel. hardy } collect: [:stats| stats average roundTo: 0.001]] + ifFalse: + [goDeep value: depth - 1]]. + goDeep value: 1000"! Item was added: + ----- Method: CoInterpreter class>>primitiveBenchmarkFollowForwardersInStackZone (in category 'benchmarks') ----- + primitiveBenchmarkFollowForwardersInStackZone + "Answer the elapsed value of the high-performance clock for followForwardingPointersInStackZone" + + <primitive: 'primitiveBenchmarkFollowForwardersInStackZone' module: '' error: ec> + ^self primitiveFailed + + "self primitiveBenchmarkFollowForwardersInStackZone"! Item was added: + ----- Method: CoInterpreter class>>primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone (in category 'benchmarks') ----- + primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone + "Answer the elapsed value of the high-performance clock for followForwardingPointersOfReceiverAndTemporariesInStackZone" + + <primitive: 'primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone' module: '' error: ec> + ^self primitiveFailed + + "self primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone"! Item was added: + ----- Method: CoInterpreter>>followForwardingPointersInStackZone (in category 'object memory support') ----- + followForwardingPointersInStackZone + "Spur's become: is lazy, turning the becommed object into a forwarding object to the other. + The read-barrier is minimised by arranging that forwarding pointers will fail a method cache + probe, since notionally objects' internals are accessed only via sending messages to them, + the exception is primitives that access the internals of the non-receiver argument(s). + + To avoid a read barrier on bytecode, literal and inst var fetch and non-local return, we scan + the receivers (including the stacked receiver for non-local return) and method references + in the stack zone and follow any forwarded ones. This is of course way cheaper than + scanning all of memory as in the old become. + + Override to handle machine code frames" + | theIPPtr | + <inline: false> + + stackPage ifNil: "the system must be snapshotting; nothing to do..." + [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). + self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. + ^self]. + + self externalWriteBackHeadFramePointers. + + 0 to: numStackPages - 1 do: + [:i| | thePage theSP theFP callerFP oop offset | + thePage := stackPages stackPageAt: i. + thePage isFree ifFalse: + [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). + theFP := thePage headFP. + "Skip the instruction pointer on top of stack of inactive pages." + theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. + [self assert: (thePage addressIsInPage: theFP). + self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). + (self isMachineCodeFrame: theFP) + ifTrue: + [oop := stackPages longAt: theFP + FoxMFReceiver. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + FoxMFReceiver + put: (objectMemory followForwarded: oop)]. + self assert: (objectMemory isForwarded: (self mframeHomeMethod: theFP) methodObject) not] + ifFalse: + [oop := stackPages longAt: theFP + FoxIFReceiver. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + FoxIFReceiver + put: (objectMemory followForwarded: oop)]. + oop := self iframeMethod: theFP. + (objectMemory isForwarded: oop) ifTrue: + [| newOop | + newOop := objectMemory followForwarded: oop. + offset := newOop - oop. + (theIPPtr notNil + and: [(stackPages longAt: theIPPtr) > oop]) ifTrue: + [stackPages + longAt: theIPPtr + put: (stackPages longAt: theIPPtr) + offset]. + stackPages + longAt: theFP + FoxIFSavedIP + put: (stackPages longAt: theFP + FoxIFSavedIP) + offset. + stackPages + longAt: theFP + FoxMethod + put: (oop := newOop)]]. + ((self frameHasContext: theFP) + and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: + [stackPages + longAt: theFP + FoxThisContext + put: (objectMemory followForwarded: (self frameContext: theFP))]. + offset := self frameStackedReceiverOffset: theFP. + oop := stackPages longAt: theFP + offset. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + offset + put: (objectMemory followForwarded: oop)]. + (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: + [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. + theFP := callerFP]. + "And finally follow the saved context and the caller context." + theSP := thePage baseAddress - objectMemory wordSize. + [theSP <= thePage baseAddress] whileTrue: + [oop := stackPages longAt: theSP. + (objectMemory isForwarded: oop) ifTrue: + [stackPages longAt: theSP put: (objectMemory followForwarded: oop)]. + theSP := theSP + objectMemory wordSize]]]! Item was removed: - ----- Method: CoInterpreter>>followForwardingPointersInStackZone: (in category 'object memory support') ----- - followForwardingPointersInStackZone: theBecomeEffectsFlags - "Spur's become: is lazy, turning the becommed object into a forwarding object to the other. - The read-barrier is minimised by arranging that forwarding pointers will fail a method cache - probe, since notionally objects' internals are accessed only via sending messages to them, - the exception is primitives that access the internals of the non-receiver argument(s). - - To avoid a read barrier on bytecode, literal and inst var fetch and non-local return, we scan - the receivers (including the stacked receiver for non-local return) and method references - in the stack zone and follow any forwarded ones. This is of course way cheaper than - scanning all of memory as in the old become. - - Override to handle machine code frames" - | theIPPtr | - <inline: false> - - (theBecomeEffectsFlags anyMask: BecameCompiledMethodFlag) ifTrue: - [(objectMemory isForwarded: method) ifTrue: - [theIPPtr := instructionPointer > method ifTrue: [instructionPointer - method]. - method := objectMemory followForwarded: method. - theIPPtr ifNotNil: [instructionPointer := method + theIPPtr]]. - (objectMemory isOopForwarded: newMethod) ifTrue: - [newMethod := objectMemory followForwarded: newMethod]]. - - stackPage ifNil: "the system must be snapshotting; nothing to do..." - [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). - self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. - ^self]. - - self externalWriteBackHeadFramePointers. - - 0 to: numStackPages - 1 do: - [:i| | thePage theSP theFP callerFP oop offset | - thePage := stackPages stackPageAt: i. - thePage isFree ifFalse: - [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). - theFP := thePage headFP. - "Skip the instruction pointer on top of stack of inactive pages." - theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. - [self assert: (thePage addressIsInPage: theFP). - self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). - (self isMachineCodeFrame: theFP) - ifTrue: - [oop := stackPages longAt: theFP + FoxMFReceiver. - (objectMemory isOopForwarded: oop) ifTrue: - [stackPages - longAt: theFP + FoxMFReceiver - put: (objectMemory followForwarded: oop)]. - self assert: (objectMemory isForwarded: (self mframeHomeMethod: theFP) methodObject) not] - ifFalse: - [oop := stackPages longAt: theFP + FoxIFReceiver. - (objectMemory isOopForwarded: oop) ifTrue: - [stackPages - longAt: theFP + FoxIFReceiver - put: (objectMemory followForwarded: oop)]. - oop := self iframeMethod: theFP. - (objectMemory isForwarded: oop) ifTrue: - [| newOop | - newOop := objectMemory followForwarded: oop. - offset := newOop - oop. - (theIPPtr notNil - and: [(stackPages longAt: theIPPtr) > oop]) ifTrue: - [stackPages - longAt: theIPPtr - put: (stackPages longAt: theIPPtr) + offset]. - stackPages - longAt: theFP + FoxIFSavedIP - put: (stackPages longAt: theFP + FoxIFSavedIP) + offset. - stackPages - longAt: theFP + FoxMethod - put: (oop := newOop)]]. - ((self frameHasContext: theFP) - and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: - [stackPages - longAt: theFP + FoxThisContext - put: (objectMemory followForwarded: (self frameContext: theFP))]. - offset := self frameStackedReceiverOffset: theFP. - oop := stackPages longAt: theFP + offset. - (objectMemory isOopForwarded: oop) ifTrue: - [stackPages - longAt: theFP + offset - put: (objectMemory followForwarded: oop)]. - (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: - [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. - theFP := callerFP]. - "And finally follow the saved context and the caller context." - theSP := thePage baseAddress - objectMemory wordSize. - [theSP <= thePage baseAddress] whileTrue: - [oop := stackPages longAt: theSP. - (objectMemory isForwarded: oop) ifTrue: - [stackPages longAt: theSP put: (objectMemory followForwarded: oop)]. - theSP := theSP + objectMemory wordSize]]]! Item was added: + ----- Method: CoInterpreter>>followForwardingPointersOfReceiverAndTemporariesInStackZone (in category 'object memory support') ----- + followForwardingPointersOfReceiverAndTemporariesInStackZone + "A more thorough version of followForwardingPointersInStackZone that also follows all temporaries (but not stack contents after the temps). + This would allow removal of the TempVectReadBarrier" + <option: #VMBenchmarks> + | theIPPtr | + <inline: false> + + stackPage ifNil: "the system must be snapshotting; nothing to do..." + [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). + self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. + ^self]. + + self externalWriteBackHeadFramePointers. + + 0 to: numStackPages - 1 do: + [:i| | thePage theSP theFP callerFP oop offset frameRcvrOffset methodHeader | + thePage := stackPages stackPageAt: i. + thePage isFree ifFalse: + [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). + theFP := thePage headFP. + "Skip the instruction pointer on top of stack of inactive pages." + theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. + [self assert: (thePage addressIsInPage: theFP). + self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). + (self isMachineCodeFrame: theFP) + ifTrue: + [oop := stackPages longAt: theFP + FoxMFReceiver. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + FoxMFReceiver + put: (objectMemory followForwarded: oop)]. + self assert: (objectMemory isForwarded: (self mframeHomeMethod: theFP) methodObject) not. + frameRcvrOffset := theFP + FoxMFReceiver. + methodHeader := (self mframeHomeMethod: theFP) methodHeader] + ifFalse: + [oop := stackPages longAt: theFP + FoxIFReceiver. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + FoxIFReceiver + put: (objectMemory followForwarded: oop)]. + oop := self iframeMethod: theFP. + (objectMemory isForwarded: oop) ifTrue: + [| newOop | + newOop := objectMemory followForwarded: oop. + offset := newOop - oop. + (theIPPtr notNil + and: [(stackPages longAt: theIPPtr) > oop]) ifTrue: + [stackPages + longAt: theIPPtr + put: (stackPages longAt: theIPPtr) + offset]. + stackPages + longAt: theFP + FoxIFSavedIP + put: (stackPages longAt: theFP + FoxIFSavedIP) + offset. + stackPages + longAt: theFP + FoxMethod + put: (oop := newOop)]. + frameRcvrOffset := theFP + FoxIFReceiver. + methodHeader := objectMemory methodHeaderOf: oop]. + theSP := frameRcvrOffset - ((self temporaryCountOfMethodHeader: methodHeader) * objectMemory wordSize). + [theSP <= frameRcvrOffset] whileTrue: + [oop := stackPages longAt: theSP. + (objectMemory isOopForwarded: oop) ifTrue: + [oop := objectMemory followForwarded: oop. + stackPages longAt: theSP put: oop]. + theSP := theSP + objectMemory wordSize]. + + ((self frameHasContext: theFP) + and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: + [stackPages + longAt: theFP + FoxThisContext + put: (objectMemory followForwarded: (self frameContext: theFP))]. + offset := self frameStackedReceiverOffset: theFP. + oop := stackPages longAt: theFP + offset. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + offset + put: (objectMemory followForwarded: oop)]. + (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: + [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. + theFP := callerFP]. + "And finally follow the saved context and the caller context." + theSP := thePage baseAddress - objectMemory wordSize. + [theSP <= thePage baseAddress] whileTrue: + [oop := stackPages longAt: theSP. + (objectMemory isForwarded: oop) ifTrue: + [stackPages longAt: theSP put: (objectMemory followForwarded: oop)]. + theSP := theSP + objectMemory wordSize]]]! Item was added: + ----- Method: CoInterpreter>>isFullBlockMethod: (in category 'compiled methods') ----- + isFullBlockMethod: aMethodObj + "Answer if the argument is a full block method or not. Full block methods + (as introduced by the SistaV1BytecodeSet) are used to implement block + closures and have a reference to their enclosing block or method as their + last literal. Compiled methods have a class association as their last literal." + <api> + <inline: false> + ^objectMemory isOopCompiledMethod: (self ultimateLiteralOf: aMethodObj)! Item was added: + ----- Method: CoInterpreterPrimitives>>primitiveBenchmarkFollowForwardersInStackZone (in category 'benchmark primitives') ----- + primitiveBenchmarkFollowForwardersInStackZone + <option: #VMBenchmarks> + <export: true> + self primitiveReturnTimeTakenFor: + [self followForwardingPointersInStackZone]! Item was added: + ----- Method: CoInterpreterPrimitives>>primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone (in category 'benchmark primitives') ----- + primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone + <option: #VMBenchmarks> + <export: true> + self primitiveReturnTimeTakenFor: + [self followForwardingPointersOfReceiverAndTemporariesInStackZone]! Item was added: + ----- Method: CoInterpreterPrimitives>>primitiveBenchmarkJITReceiver (in category 'benchmark primitives') ----- + primitiveBenchmarkJITReceiver + <option: #VMBenchmarks> + <option: #SistaV1BytecodeSet> + <export: true> + | receiverMethod cloneMethod | + receiverMethod := self stackTop. + (objectMemory isOopCompiledMethod: receiverMethod) ifFalse: + [^self primitiveFailFor: PrimErrBadReceiver]. + (self isFullBlockMethod: receiverMethod) ifTrue: + [^self primitiveFailFor: PrimErrUnsupported]. + cloneMethod := objectMemory cloneObject: receiverMethod. + cloneMethod ifNil: + [^self primitiveFailFor: PrimErrNoMemory]. + self primitiveReturnTimeTakenFor: + [(cogit cog: cloneMethod selector: (self maybeSelectorOfMethod: cloneMethod)) ifNil: + [^self primitiveFailFor: PrimErrOperationFailed]. + cogit freeCogMethod: (self cogMethodOf: cloneMethod)]! Item was added: + ----- Method: CoInterpreterPrimitives>>primitiveReturnTimeTakenFor: (in category 'benchmark primitives') ----- + primitiveReturnTimeTakenFor: aBlock + <option: #VMBenchmarks> + <inline: #always> + | then | + <var: 'then' type: #usqLong> + then := self ioHighResClock. + aBlock value. + self methodReturnValue: (self positive64BitIntegerFor: self ioHighResClock - then)! Item was changed: ----- Method: Cogit>>cog:selector: (in category 'jit - api') ----- cog: aMethodObj selector: aSelectorOop "Attempt to produce a machine code method for the bytecode method object aMethodObj. N.B. If there is no code memory available do *NOT* attempt to reclaim the method zone. Certain clients (e.g. ceSICMiss:) depend on the zone remaining constant across method generation." <api> <returnTypeC: #'CogMethod *'> | selector cogMethod | <var: #cogMethod type: #'CogMethod *'> (self exclude: aMethodObj selector: aSelectorOop) ifTrue: [^nil]. "In Newspeak we support anonymous accessors and hence tolerate the same method being cogged multiple times. But only if the method class association is nil." NewspeakVM ifTrue: [(coInterpreter methodHasCogMethod: aMethodObj) ifTrue: [cogMethod := coInterpreter cogMethodOf: aMethodObj. self deny: cogMethod selector = aSelectorOop. cogMethod selector = aSelectorOop ifTrue: [^cogMethod]. (coInterpreter methodClassAssociationOf: aMethodObj) ~= objectMemory nilObject ifTrue: [self cCode: 'extern void *firstIndexableField(sqInt)'. "Slang, au natural" self warnMultiple: cogMethod selectors: aSelectorOop. ^nil]]] ifFalse: [self deny: (coInterpreter methodHasCogMethod: aMethodObj)]. - self deny: (objectMemory isOopCompiledMethod: (coInterpreter ultimateLiteralOf: aMethodObj)). selector := aSelectorOop = objectMemory nilObject ifTrue: [coInterpreter maybeSelectorOfMethod: aMethodObj] ifFalse: [aSelectorOop]. "coInterpreter stringOf: selector" selector ifNotNil: [coInterpreter compilationBreakpoint: selector isMNUCase: false]. aMethodObj = breakMethod ifTrue: [self halt: 'Compilation of breakMethod']. NewspeakVM ifTrue: [cogMethod := methodZone findPreviouslyCompiledVersionOf: aMethodObj with: aSelectorOop. cogMethod ifNotNil: [(coInterpreter methodHasCogMethod: aMethodObj) not ifTrue: [self assert: (coInterpreter rawHeaderOf: aMethodObj) = cogMethod methodHeader. cogMethod methodObject: aMethodObj. coInterpreter rawHeaderOf: aMethodObj put: cogMethod asInteger]. ^cogMethod]]. + objectRepresentation ensureNoForwardedLiteralsIn: aMethodObj. "If the generators for the alternate bytecode set are missing then interpret." (coInterpreter methodUsesAlternateBytecodeSet: aMethodObj) ifTrue: [(self numElementsIn: generatorTable) <= 256 ifTrue: [^nil]. bytecodeSetOffset := 256] ifFalse: [bytecodeSetOffset := 0]. + self deny: (coInterpreter isFullBlockMethod: aMethodObj). - objectRepresentation ensureNoForwardedLiteralsIn: aMethodObj. methodObj := aMethodObj. methodHeader := objectMemory methodHeaderOf: aMethodObj. receiverTags := -1. "lazy initialization" cogMethod := self compileCogMethod: aSelectorOop. (cogMethod asInteger between: MaxNegativeErrorCode and: -1) ifTrue: [cogMethod asInteger = InsufficientCodeSpace ifTrue: [coInterpreter callForCogCompiledCodeCompaction]. self maybeFreeCounters. "Right now no errors should be reported, so nothing more to do." "self reportError: (self cCoerceSimple: cogMethod to: #sqInt)." ^nil]. "self cCode: '' inSmalltalk: [coInterpreter printCogMethod: cogMethod. ""coInterpreter symbolicMethod: aMethodObj."" self assertValidMethodMap: cogMethod." "self disassembleMethod: cogMethod." "printInstructions := clickConfirm := true""]." ^cogMethod! Item was changed: ----- Method: Cogit>>cogFullBlockMethod:numCopied: (in category 'jit - api') ----- cogFullBlockMethod: aMethodObj numCopied: numCopied "Attempt to produce a machine code method for the bytecode method object aMethodObj. N.B. If there is no code memory available do *NOT* attempt to reclaim the method zone. Certain clients (e.g. ceSICMiss:) depend on the zone remaining constant across method generation." <api> <option: #SistaV1BytecodeSet> <returnTypeC: #'CogMethod *'> | cogMethod | <var: #cogMethod type: #'CogMethod *'> (self exclude: aMethodObj) ifTrue: [^nil]. self deny: (coInterpreter methodHasCogMethod: aMethodObj). - self assert: (objectMemory isOopCompiledMethod: (coInterpreter ultimateLiteralOf: aMethodObj)). aMethodObj = breakMethod ifTrue: [self halt: 'Compilation of breakMethod']. + objectRepresentation ensureNoForwardedLiteralsIn: aMethodObj. "If the generators for the alternate bytecode set are missing then interpret." (coInterpreter methodUsesAlternateBytecodeSet: aMethodObj) ifTrue: [(self numElementsIn: generatorTable) <= 256 ifTrue: [^nil]. bytecodeSetOffset := 256] ifFalse: [bytecodeSetOffset := 0]. + self assert: (coInterpreter isFullBlockMethod: aMethodObj). - objectRepresentation ensureNoForwardedLiteralsIn: aMethodObj. methodObj := aMethodObj. methodHeader := objectMemory methodHeaderOf: aMethodObj. receiverTags := -1. "lazy initialization" cogMethod := self compileCogFullBlockMethod: numCopied. (cogMethod asInteger between: MaxNegativeErrorCode and: -1) ifTrue: [cogMethod asInteger = InsufficientCodeSpace ifTrue: [coInterpreter callForCogCompiledCodeCompaction]. self maybeFreeCounters. "Right now no errors should be reported, so nothing more to do." "self reportError: (self cCoerceSimple: cogMethod to: #sqInt)." ^nil]. "self cCode: '' inSmalltalk: [coInterpreter printCogMethod: cogMethod. ""coInterpreter symbolicMethod: aMethodObj."" self assertValidMethodMap: cogMethod." "self disassembleMethod: cogMethod." "printInstructions := clickConfirm := true""]." ^cogMethod! Item was added: + ----- Method: CompiledCode>>benchmarkJITReceiver (in category '*VMMaker-benchmarks') ----- + benchmarkJITReceiver + "Answer the elapsed time in microseconds to jit the receiver." + + | ticksPerMicrosecond | + ticksPerMicrosecond := Time highResClockTicksPerMillisecond / 1000.0. + ^self primitiveBenchmarkJITReceiver / ticksPerMicrosecond + + "| methods times nBytecodes nLiterals | + methods := self methodDict values. + times := methods collect: [:m| m benchmarkJITReceiver]. + nLiterals := methods collect: #numLiterals. + nBytecodes := methods collect: [:m| m isQuick ifTrue: [1] ifFalse: [m endPC - m initialPC + 1]]. + {times. nLiterals. nBytecodes} collect: [:stats| {stats min. stats max. stats average asFloat} collect: [:stat| stat roundTo: 0.001]]" + + "On an Apple MacBook Pro (16-inch, 2021), Apple M1 Max, Cores: 10 (8 performance and 2 efficiency): + + ((Array withAllSuperclasses copyUpThrough: Collection) collect: [:c| c methodDict values]) fold: #, + ((2.375 87.466 7.672) (2 28 4.682) (1 299 17.996)) + + CompiledCode methodDict values + ((2.25 35.961 7.883) (2 20 5.938) (1 106 17.464)) + + ((LargeNegativeInteger withAllSuperclasses copyUpThrough: Magnitude) collect: [:c| c methodDict values]) fold: #, + ((1.458 148.429 8.951) (2 51 5.405) (1 569 22.580))"! Item was added: + ----- Method: CompiledCode>>primitiveBenchmarkJITReceiver (in category '*VMMaker-benchmarks') ----- + primitiveBenchmarkJITReceiver + "Answer the elapsed value of the high-performance clock for jitting the receiver." + + <primitive: 'primitiveBenchmarkJITReceiver' module: '' error: ec> + ^self primitiveFailed + + "(self methodDict values collect: [:m| m primitiveBenchmarkJITReceiver]) asSet asArray sort"! Item was added: + ----- Method: StackInterpreter>>followForwardingPointersInStackZone (in category 'object memory support') ----- + followForwardingPointersInStackZone + "Spur's become: is lazy, turning the becommed object into a forwarding object to the other. + The read-barrier is minimised by arranging that forwarding pointers will fail a method cache + probe, since notionally objects' internals are accessed only via sending messages to them, + the exception is primitives that access the internals of the non-receiver argument(s). + + To avoid a read barrier on bytecode, literal and inst var fetch and non-local return, we scan + the receivers (including the stacked receiver for non-local return) and method references + in the stack zone and follow any forwarded ones. This is of course way cheaper than + scanning all of memory as in the old become." + | theIPPtr | + <inline: false> + + stackPage ifNil: "the system must be snapshotting; nothing to do..." + [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). + self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. + ^self]. + + self externalWriteBackHeadFramePointers. + + 0 to: numStackPages - 1 do: + [:i| | thePage theFP callerFP offset oop | + thePage := stackPages stackPageAt: i. + thePage isFree ifFalse: + [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). + theFP := thePage headFP. + "Skip the instruction pointer on top of stack of inactive pages." + theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. + [self assert: (thePage addressIsInPage: theFP). + self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). + oop := stackPages longAt: theFP + FoxReceiver. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + FoxReceiver + put: (objectMemory followForwarded: oop)]. + ((self frameHasContext: theFP) + and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: + [stackPages + longAt: theFP + FoxThisContext + put: (objectMemory followForwarded: (self frameContext: theFP))]. + oop := self frameMethod: theFP. + (objectMemory isForwarded: oop) ifTrue: + [| newOop delta | + newOop := objectMemory followForwarded: oop. + theIPPtr ifNotNil: + [self assert: (stackPages longAt: theIPPtr) > (self frameMethod: theFP). + delta := newOop - oop. + stackPages + longAt: theIPPtr + put: (stackPages longAt: theIPPtr) + delta]. + stackPages + longAt: theFP + FoxMethod + put: (oop := newOop)]. + offset := self frameStackedReceiverOffset: theFP. + oop := stackPages longAt: theFP + offset. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + offset + put: (objectMemory followForwarded: oop)]. + (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: + [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. + theFP := callerFP]. + "And finally follow the caller context." + self assert: theFP = thePage baseFP. + oop := self frameCallerContext: theFP. + (objectMemory isForwarded: oop) ifTrue: + [self frameCallerContext: theFP put: (objectMemory followForwarded: oop)]]]! Item was removed: - ----- Method: StackInterpreter>>followForwardingPointersInStackZone: (in category 'object memory support') ----- - followForwardingPointersInStackZone: theBecomeEffectsFlags - "Spur's become: is lazy, turning the becommed object into a forwarding object to the other. - The read-barrier is minimised by arranging that forwarding pointers will fail a method cache - probe, since notionally objects' internals are accessed only via sending messages to them, - the exception is primitives that access the internals of the non-receiver argument(s). - - To avoid a read barrier on bytecode, literal and inst var fetch and non-local return, we scan - the receivers (including the stacked receiver for non-local return) and method references - in the stack zone and follow any forwarded ones. This is of course way cheaper than - scanning all of memory as in the old become." - | theIPPtr | - <inline: false> - - (theBecomeEffectsFlags anyMask: BecameCompiledMethodFlag) ifTrue: - [(objectMemory isForwarded: method) ifTrue: - [theIPPtr := instructionPointer - method. - method := objectMemory followForwarded: method. - instructionPointer := method + theIPPtr]. - (objectMemory isOopForwarded: newMethod) ifTrue: - [newMethod := objectMemory followForwarded: newMethod]]. - - stackPage ifNil: "the system must be snapshotting; nothing to do..." - [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). - self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. - ^self]. - - self externalWriteBackHeadFramePointers. - - 0 to: numStackPages - 1 do: - [:i| | thePage theFP callerFP offset oop | - thePage := stackPages stackPageAt: i. - thePage isFree ifFalse: - [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). - theFP := thePage headFP. - "Skip the instruction pointer on top of stack of inactive pages." - theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. - [self assert: (thePage addressIsInPage: theFP). - self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). - oop := stackPages longAt: theFP + FoxReceiver. - (objectMemory isOopForwarded: oop) ifTrue: - [stackPages - longAt: theFP + FoxReceiver - put: (objectMemory followForwarded: oop)]. - ((self frameHasContext: theFP) - and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: - [stackPages - longAt: theFP + FoxThisContext - put: (objectMemory followForwarded: (self frameContext: theFP))]. - oop := self frameMethod: theFP. - (objectMemory isForwarded: oop) ifTrue: - [| newOop delta | - newOop := objectMemory followForwarded: oop. - theIPPtr ifNotNil: - [self assert: (stackPages longAt: theIPPtr) > (self frameMethod: theFP). - delta := newOop - oop. - stackPages - longAt: theIPPtr - put: (stackPages longAt: theIPPtr) + delta]. - stackPages - longAt: theFP + FoxMethod - put: (oop := newOop)]. - offset := self frameStackedReceiverOffset: theFP. - oop := stackPages longAt: theFP + offset. - (objectMemory isOopForwarded: oop) ifTrue: - [stackPages - longAt: theFP + offset - put: (objectMemory followForwarded: oop)]. - (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: - [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. - theFP := callerFP]. - "And finally follow the caller context." - self assert: theFP = thePage baseFP. - oop := self frameCallerContext: theFP. - (objectMemory isForwarded: oop) ifTrue: - [self frameCallerContext: theFP put: (objectMemory followForwarded: oop)]]]! Item was changed: ----- Method: StackInterpreter>>spurPostBecomeAction: (in category 'object memory support') ----- spurPostBecomeAction: theBecomeEffectsFlags "Insulate the stack zone from the effects of a become. All receivers must be unfollowed for two reasons: 1. inst var access is direct with no read barrier 2. super sends (always to the receiver) have no class check and so don't trap for forwarded receivers. This is an issue for primitives that assume their receiver is valid and don't validate. Super sends require an explicit check to ensure receivers in super sends are unforwarded. e.g. super doSomethingWith: (self become: other) forwards the receiver self pushed on the stack. So we could avoid following non-pointer receivers. But this is too tricky, Instead, we always follow receivers. Methods must be unfollowed since bytecode access is direct with no read barrier. But this only needs to be done if the becomeEffectsFlags indicate that a CompiledMethod was becommed. The scheduler state must be followed, but only if the becomeEffectsFlags indicate that a pointer object was becommed." <option: #SpurObjectMemory> <inline: false> "For VM profiling" self flushAtCache. theBecomeEffectsFlags ~= 0 ifTrue: + [(theBecomeEffectsFlags anyMask: BecameActiveClassFlag) ifTrue: + [self flushBecommedClassesInMethodCache]. - [(theBecomeEffectsFlags anyMask: BecameCompiledMethodFlag) ifTrue: - [self followForwardedMethodsInMethodCache. - self followForwardedMethodsInMethodZone]. "for CoInterpreter; must precede followForwardingPointersInStackZone:" - (theBecomeEffectsFlags anyMask: BecameActiveClassFlag) ifTrue: - [self flushBecommedClassesInMethodCache. - self flushBecommedClassesInMethodZone]. "for CoInterpreter" (theBecomeEffectsFlags anyMask: BecamePointerObjectFlag) ifTrue: [self followForwardingPointersInScheduler. self followForwardingPointersInSpecialObjectsArray]. (theBecomeEffectsFlags anyMask: BecamePointerObjectFlag + BecameCompiledMethodFlag) ifTrue: + [self followForwardingPointersInProfileState. + (theBecomeEffectsFlags anyMask: BecameCompiledMethodFlag) ifTrue: + [self followForwardedMethodsInMethodCache. + self followMethodNewMethodAndInstructionPointer]]]. + self followForwardingPointersInStackZone! - [self followForwardingPointersInProfileState]]. - self followForwardingPointersInStackZone: theBecomeEffectsFlags! Item was changed: ----- Method: VMBasicConstants class>>nonUnderscoreNamesDefinedAtCompileTime (in category 'C translation') ----- nonUnderscoreNamesDefinedAtCompileTime "Answer the set of names for variables that should be defined at compile time (excepting those that begin with underscore, which we assume are defined at compile time). Some of these get default values during simulation, and hence get defaulted in the various initializeMiscConstants methods. But that they have values should /not/ cause the code generator to do dead code elimination based on their default values. In particular, methods marked with <option: ANameDefinedAtCompileTime> will be emitted within #if defined(ANameDefinedAtCompileTime)...#endif. And of course this is backwards. We'd like to define names that are defined at translation time. But doing so would entail defining (or referencing) hundreds of class and pool variables. This way is marginally more manageable." ^#(VMBIGENDIAN IMMUTABILITY STACKVM COGVM COGMTVM SPURVM PharoVM "Pharo vs Squeak" + TerfVM VM_TICKER "Terf vs Squeak & Qwaq/Teleplace/Terf/Virtend high-priority thread support" + VMBenchmarks "Primitives to measure the duration of fleeting operations" - TerfVM VM_TICKER "Terf vs Squeak & Qwaq/Teleplace/Terf high-priority thread support" EnforceAccessControl "Newspeak" CheckRememberedInTrampoline "IMMUTABILITY" BIT_IDENTICAL_FLOATING_POINT PLATFORM_SPECIFIC_FLOATING_POINT "Alternatives for using fdlibm for floating-point" + ITIMER_HEARTBEAT "older linux's woultn't allow a higher priority thread, hence no threaded heartbeat." - ITIMER_HEARTBEAT "older linux's woultn't allow a higher priority thread, hence no threaded heartbeat." TestingPrimitives + OBSOLETE_ALIEN_PRIMITIVES "Ancient crap in the IA32ABI plugin" - OBSOLETE_ALIEN_PRIMITIVES "Ancient crap in the IA32ABI plugin" LLDB "As of lldb-370.0.42 Swift-3.1, passing function parameters to printOopsSuchThat fails with Internal error [IRForTarget]: Couldn't rewrite one of the arguments of a function call. Turning off link time optimization with -fno-lto has no effect. hence we define some debugging functions as being <option: LLDB>" LRPCheck "Optional checking for long running primitives" "Plugin related" SQUEAK_BUILTIN_PLUGIN "ThreadedFFIPlugin related" ALLOCA_LIES_SO_SETSP_BEFORE_CALL PLATFORM_API_USES_CALLEE_POPS_CONVENTION STACK_ALIGN_BYTES + "processor related; see ThreadedFFIPlugin & src/plugins/SqueakFFIPrims/SqueakFFIPrims.c" - "processor related" ARM32 ARM64 i386 i486 i586 i686 X86 I386 x86_64 "os related" ACORN EPLAN9 UNIX WIN32 WIN64)!

1 0

VM Maker: VMMaker.oscog.seperateMarking-eem.3309.mcz
by commits＠source.squeak.org 14 Jan '23

14 Jan '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog.seperateMarking-eem.3309.mcz ==================== Summary ==================== Name: VMMaker.oscog.seperateMarking-eem.3309 Author: eem Time: 13 January 2023, 6:48:34.890025 pm UUID: 92a86a31-7815-40fa-bab6-337e9b517938 Ancestors: VMMaker.oscog.seperateMarking-eem.3308 Merge VMMaker.oscog-eem.3295 Change cloneObject: to answer nil on failure rather than 0, to match instantiateClass:indexableSize: et al. Make sure all uses of cloneObject: in plugins test the result appropriately. =============== Diff against VMMaker.oscog.seperateMarking-eem.3308 =============== Item was changed: ----- Method: CogObjectRepresentationFor32BitSpur>>genFetchRegArgsForPerformWithArguments: (in category 'primitive generators') ----- genFetchRegArgsForPerformWithArguments: sizeReg + "The arguments are imn an array in Arg1Reg. Its size is in sizeReg. - "The arguments are in an array in Arg1Reg. Its size is in sizeReg. Load Arg0Reg and Arg1Reg with the first two slots. Since objects always have at least one slot and are aligned to 64-bits it is safe to load both args without checking." cogit MoveMw: objectMemory baseHeaderSize r: Arg1Reg R: Arg0Reg; MoveMw: objectMemory baseHeaderSize + self wordSize r: Arg1Reg R: Arg1Reg. ^0! Item was changed: ----- Method: CroquetPlugin>>primitiveOrthoNormInverseMatrix (in category 'transforms') ----- primitiveOrthoNormInverseMatrix <export: true> <primitiveMetadata: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> | srcOop dstOop src dst x y z rx ry rz | <var: #x type: #double> <var: #y type: #double> <var: #z type: #double> <var: #rx type: #double> <var: #ry type: #double> <var: #rz type: #double> srcOop := interpreterProxy stackValue: 0. ((interpreterProxy isWords: srcOop) and:[(interpreterProxy slotSizeOf: srcOop) = 16]) ifFalse: [^interpreterProxy primitiveFail]. dstOop := interpreterProxy cloneObject: srcOop. + dstOop ifNil: - dstOop = 0 ifTrue: [^interpreterProxy primitiveFail]. "reload srcOop in case of GC" self cppIf: #SPURVM ifFalse: [srcOop := interpreterProxy stackValue: 0]. src := self cCoerce: (interpreterProxy firstIndexableField: srcOop) to: #'float *'. dst := self cCoerce: (interpreterProxy firstIndexableField: dstOop) to: #'float *'. "Transpose upper 3x3 matrix" "dst at: 0 put: (src at: 0)." dst at: 1 put: (src at: 4). dst at: 2 put: (src at: 8). dst at: 4 put: (src at: 1). "dst at: 5 put: (src at: 5)." dst at: 6 put: (src at: 9). dst at: 8 put: (src at: 2). dst at: 9 put: (src at: 6). "dst at: 10 put: (src at: 10)." "Compute inverse translation vector" x := src at: 3. y := src at: 7. z := src at: 11. rx := (x * (dst at: 0)) + (y * (dst at: 1)) + (z * (dst at: 2)). ry := (x * (dst at: 4)) + (y * (dst at: 5)) + (z * (dst at: 6)). rz := (x * (dst at: 8)) + (y * (dst at: 9)) + (z * (dst at: 10)). dst at: 3 put: 0.0 - rx. dst at: 7 put: 0.0 - ry. dst at: 11 put: 0.0 - rz. ^interpreterProxy methodReturnValue: dstOop! Item was changed: ----- Method: CroquetPlugin>>primitiveTransformDirection (in category 'transforms') ----- primitiveTransformDirection <export: true> <primitiveMetadata: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> | x y z rx ry rz matrix vertex v3Oop | <var: #x type: #double> <var: #y type: #double> <var: #z type: #double> <var: #rx type: #double> <var: #ry type: #double> <var: #rz type: #double> matrix := self stackMatrix: 1. v3Oop := interpreterProxy stackValue: 0. (matrix notNil and: [(interpreterProxy isWords: v3Oop) and:[(interpreterProxy slotSizeOf: v3Oop) = 3]]) ifFalse: [^interpreterProxy primitiveFail]. vertex := self cCoerce: (interpreterProxy firstIndexableField: v3Oop) to: #'float *'. x := vertex at: 0. y := vertex at: 1. z := vertex at: 2. rx := (x * (matrix at: 0)) + (y * (matrix at: 1)) + (z * (matrix at: 2)). ry := (x * (matrix at: 4)) + (y * (matrix at: 5)) + (z * (matrix at: 6)). rz := (x * (matrix at: 8)) + (y * (matrix at: 9)) + (z * (matrix at: 10)). v3Oop := interpreterProxy cloneObject: v3Oop. + v3Oop ifNil: - v3Oop = 0 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoMemory]. vertex := self cCoerce: (interpreterProxy firstIndexableField: v3Oop) to: #'float *'. vertex at: 0 put: rx. vertex at: 1 put: ry. vertex at: 2 put: rz. ^interpreterProxy methodReturnValue: v3Oop! Item was changed: ----- Method: CroquetPlugin>>primitiveTransformVector3 (in category 'transforms') ----- primitiveTransformVector3 <export: true> <primitiveMetadata: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> | x y z rx ry rz rw matrix vertex v3Oop | <var: #x type: #double> <var: #y type: #double> <var: #z type: #double> <var: #rx type: #double> <var: #ry type: #double> <var: #rz type: #double> <var: #rw type: #double> matrix := self stackMatrix: 1. v3Oop := interpreterProxy stackValue: 0. (matrix notNil and: [(interpreterProxy isWords: v3Oop) and:[(interpreterProxy slotSizeOf: v3Oop) = 3]]) ifFalse: [^interpreterProxy primitiveFail]. vertex := self cCoerce: (interpreterProxy firstIndexableField: v3Oop) to: #'float *'. x := vertex at: 0. y := vertex at: 1. z := vertex at: 2. rx := (x * (matrix at: 0)) + (y * (matrix at: 1)) + (z * (matrix at: 2)) + (matrix at: 3). ry := (x * (matrix at: 4)) + (y * (matrix at: 5)) + (z * (matrix at: 6)) + (matrix at: 7). rz := (x * (matrix at: 8)) + (y * (matrix at: 9)) + (z * (matrix at: 10)) + (matrix at: 11). rw := (x * (matrix at: 12)) + (y * (matrix at: 13)) + (z * (matrix at: 14)) + (matrix at: 15). v3Oop := interpreterProxy cloneObject: v3Oop. + v3Oop ifNil: - v3Oop = 0 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoMemory]. vertex := self cCoerce: (interpreterProxy firstIndexableField: v3Oop) to: #'float *'. rw = 1.0 ifTrue:[ vertex at: 0 put: rx. vertex at: 1 put: ry. vertex at: 2 put: rz. ] ifFalse:[ rw = 0.0 ifTrue:[rw := 0.0] ifFalse:[rw := 1.0 / rw]. vertex at: 0 put: rx * rw. vertex at: 1 put: ry * rw. vertex at: 2 put: rz * rw. ]. ^interpreterProxy methodReturnValue: v3Oop! Item was changed: ----- Method: CroquetPlugin>>primitiveTransposeMatrix (in category 'transforms') ----- primitiveTransposeMatrix - | srcOop dstOop src dst | <export: true> + <primitiveMetadata: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> + | srcOop dstOop src dst | + <var: #src type: #'float *'> + <var: #dst type: #'float *'> - <var: #src declareC:'float *src'> - <var: #dst declareC:'float *dst'> + srcOop := interpreterProxy stackValue: 0. + ((interpreterProxy isWords: srcOop) and:[(interpreterProxy slotSizeOf: srcOop) = 16]) ifFalse: + [^interpreterProxy primitiveFail]. - interpreterProxy methodArgumentCount = 0 - ifFalse:[^interpreterProxy primitiveFail]. - srcOop := interpreterProxy stackObjectValue: 0. - interpreterProxy failed ifTrue:[^nil]. - ((interpreterProxy isWords: srcOop) and:[(interpreterProxy slotSizeOf: srcOop) = 16]) - ifFalse:[^interpreterProxy primitiveFail]. dstOop := interpreterProxy cloneObject: srcOop. + dstOop ifNil: + [^interpreterProxy primitiveFailFor: PrimErrNoMemory]. + self cppIf: #SPURVM "reload srcOop in case of GC" + ifFalse: [srcOop := interpreterProxy stackValue: 0]. - "reload srcOop in case of GC" - srcOop := interpreterProxy stackObjectValue: 0. src := interpreterProxy firstIndexableField: srcOop. dst := interpreterProxy firstIndexableField: dstOop. "dst at: 0 put: (src at: 0)." dst at: 1 put: (src at: 4). dst at: 2 put: (src at: 8). dst at: 3 put: (src at: 12). dst at: 4 put: (src at: 1). "dst at: 5 put: (src at: 5)." dst at: 6 put: (src at: 9). dst at: 7 put: (src at: 13). dst at: 8 put: (src at: 2). dst at: 9 put: (src at: 6). "dst at: 10 put: (src at: 10)." dst at: 11 put: (src at: 14). dst at: 12 put: (src at: 3). dst at: 13 put: (src at: 7). dst at: 14 put: (src at: 11). "dst at: 15 put: (src at: 15)." + interpreterProxy methodReturnValue: dstOop! - interpreterProxy pop: 1. - ^interpreterProxy push: dstOop. - ! Item was changed: ----- Method: Interpreter>>primitiveClone (in category 'object access primitives') ----- primitiveClone "Return a shallow copy of the receiver." | newCopy | newCopy := self cloneObject: self stackTop. + newCopy ifNil: "not enough memory most likely" - newCopy = 0 ifTrue: "not enough memory most likely" [^self primitiveFail]. self pop: argumentCount + 1 thenPush: newCopy! Item was changed: + ----- Method: InterpreterPrimitives>>primitiveClone (in category 'object access primitives') ----- - ----- Method: InterpreterPrimitives>>primitiveClone (in category 'instantiation primitives') ----- primitiveClone "Return a shallow copy of the receiver." | rcvr newCopy | rcvr := self stackTop. (objectMemory isImmediate: rcvr) ifTrue: [newCopy := rcvr] ifFalse: [(argumentCount = 0 or: [(objectMemory isForwarded: rcvr) not]) + ifTrue: [newCopy := objectMemory cloneObject: rcvr]. + newCopy ifNil: "not enough memory most likely" + [^self primitiveFailFor: PrimErrNoMemory]]. + self methodReturnValue: newCopy! - ifTrue: [newCopy := objectMemory cloneObject: rcvr] - ifFalse: [newCopy := 0]. - newCopy = 0 ifTrue: "not enough memory most likely" - [^self primitiveFail]]. - self pop: argumentCount + 1 thenPush: newCopy! Item was changed: ----- Method: NewObjectMemory>>allocateChunkAfterGC: (in category 'allocation') ----- allocateChunkAfterGC: byteSize "Garbage collect and then allocate a chunk of the given size. Sender must be sure that the requested size includes enough space for the header word(s)." | newChunk enoughSpace | <inline: true> <var: #newChunk type: #usqInt> enoughSpace := self sufficientSpaceToAllocate: byteSize. enoughSpace ifFalse: ["signal that space is running low, but proceed with allocation if possible" self setSignalLowSpaceFlagAndSaveProcess]. (self oop: freeStart + byteSize isGreaterThan: reserveStart) ifTrue: + [^nil "Allocation failed. Client should e.g. fail the primtive"]. - [^0 "Allocation failed. Client should e.g. fail the primtive"]. "if we get here, there is enough space for allocation to succeed " newChunk := freeStart. freeStart := freeStart + byteSize. ^self oopForPointer: newChunk! Item was changed: ----- Method: NewObjectMemory>>cloneObject: (in category 'allocation') ----- cloneObject: obj "Return a shallow copy of the given object. May cause GC. Assume: Oop is a real object, not a small integer. Override to assert it's not a married context and maybe fix cloned methods." | extraHdrBytes bytes newChunk remappedOop fromIndex toIndex lastFrom newOop header hash | <inline: false> <var: #lastFrom type: #usqInt> <var: #fromIndex type: #usqInt> self assert: ((self isContext: obj) not or: [(coInterpreter isMarriedOrWidowedContext: obj) not]). self assert: (self isNonIntegerObject: obj). extraHdrBytes := self extraHeaderBytes: obj. bytes := self sizeBitsOf: obj. bytes := bytes + extraHdrBytes. "allocate space for the copy, remapping obj in case of a GC" self pushRemappableOop: obj. + "check it is safe to allocate this much memory. Return nil if not" + (self sufficientSpaceToAllocate: 2500 + bytes) ifFalse:[^nil]. - "check it is safe to allocate this much memory. Return 0 if not" - (self sufficientSpaceToAllocate: 2500 + bytes) ifFalse:[^0]. newChunk := self allocateChunk: bytes. remappedOop := self popRemappableOop. "copy old to new including all header words" toIndex := newChunk - self wordSize. "loop below uses pre-increment" fromIndex := (remappedOop - extraHdrBytes) - self wordSize. lastFrom := fromIndex + bytes. [fromIndex < lastFrom] whileTrue: [self longAt: (toIndex := toIndex + self wordSize) put: (self longAt: (fromIndex := fromIndex + self wordSize))]. newOop := newChunk + extraHdrBytes. "convert from chunk to oop" "fix base header: compute new hash and clear Mark and Root bits" hash := self newObjectHash. header := (self longAt: newOop) bitAnd: 16r1FFFF. "use old ccIndex, format, size, and header-type fields" header := header bitOr: ((hash << HashBitsOffset) bitAnd: HashBits). self longAt: newOop put: header. (self isCompiledMethodHeader: header) ifTrue: [coInterpreter maybeFixClonedCompiledMethod: newOop]. ^newOop ! Item was changed: ----- Method: ObjectMemory>>cloneObject: (in category 'allocation') ----- cloneObject: obj "Return a shallow copy of the given object. May cause GC" "Assume: Oop is a real object, not a small integer." | extraHdrBytes bytes newChunk remappedOop fromIndex toIndex lastFrom newOop header hash | <inline: false> <var: #lastFrom type: #usqInt> <var: #fromIndex type: #usqInt> self assert: (self isNonIntegerObject: obj). extraHdrBytes := self extraHeaderBytes: obj. bytes := self sizeBitsOf: obj. bytes := bytes + extraHdrBytes. "allocate space for the copy, remapping obj in case of a GC" self pushRemappableOop: obj. + "check it is safe to allocate this much memory. Return nil if not" + (self sufficientSpaceToAllocate: 2500 + bytes) ifFalse:[^nil]. - "check it is safe to allocate this much memory. Return 0 if not" - (self sufficientSpaceToAllocate: 2500 + bytes) ifFalse:[^0]. newChunk := self allocateChunk: bytes. remappedOop := self popRemappableOop. "copy old to new including all header words" toIndex := newChunk - self wordSize. "loop below uses pre-increment" fromIndex := (remappedOop - extraHdrBytes) - self wordSize. lastFrom := fromIndex + bytes. [fromIndex < lastFrom] whileTrue: [self longAt: (toIndex := toIndex + self wordSize) put: (self longAt: (fromIndex := fromIndex + self wordSize))]. newOop := newChunk + extraHdrBytes. "convert from chunk to oop" "fix base header: compute new hash and clear Mark and Root bits" hash := self newObjectHash. header := (self longAt: newOop) bitAnd: 16r1FFFF. "use old ccIndex, format, size, and header-type fields" header := header bitOr: ((hash << HashBitsOffset) bitAnd: HashBits). self longAt: newOop put: header. ^newOop ! Item was changed: ----- Method: SpurMemoryManager>>cloneObject: (in category 'allocation') ----- cloneObject: objOop | numSlots fmt newObj | numSlots := self numSlotsOf: objOop. fmt := self formatOf: objOop. numSlots > self maxSlotsForNewSpaceAlloc ifTrue: [newObj := self allocateSlotsInOldSpace: numSlots format: fmt classIndex: (self classIndexOf: objOop)] ifFalse: [newObj := self allocateSlots: numSlots format: fmt classIndex: (self classIndexOf: objOop)]. + newObj ifNotNil: + [(self isPointersFormat: fmt) + ifTrue: + [| hasYoung | + hasYoung := false. + 0 to: numSlots - 1 do: + [:i| | oop | + oop := self fetchPointer: i ofObject: objOop. + (self isNonImmediate: oop) ifTrue: + [(self isForwarded: oop) ifTrue: + [oop := self followForwarded: oop]. + ((self isNonImmediate: oop) + and: [self isYoungObject: oop]) ifTrue: + [hasYoung := true]]. + self storePointerUnchecked: i + ofObject: newObj + withValue: oop]. + (hasYoung + and: [(self isYoungObject: newObj) not]) ifTrue: + [scavenger remember: newObj]] + ifFalse: + [0 to: numSlots - 1 do: + [:i| + self storePointerUnchecked: i + ofObject: newObj + withValue: (self fetchPointer: i ofObject: objOop)]. + fmt >= self firstCompiledMethodFormat ifTrue: + [coInterpreter maybeFixClonedCompiledMethod: newObj. + ((self isOldObject: newObj) + and: [(self isYoungObject: objOop) or: [self isRemembered: objOop]]) ifTrue: + [scavenger remember: newObj]]]]. - newObj ifNil: - [^0]. - (self isPointersFormat: fmt) - ifTrue: - [| hasYoung | - hasYoung := false. - 0 to: numSlots - 1 do: - [:i| | oop | - oop := self fetchPointer: i ofObject: objOop. - (self isNonImmediate: oop) ifTrue: - [(self isForwarded: oop) ifTrue: - [oop := self followForwarded: oop]. - ((self isNonImmediate: oop) - and: [self isYoungObject: oop]) ifTrue: - [hasYoung := true]]. - self storePointerUnchecked: i - ofObject: newObj - withValue: oop]. - (hasYoung - and: [(self isYoungObject: newObj) not]) ifTrue: - [scavenger remember: newObj]] - ifFalse: - [0 to: numSlots - 1 do: - [:i| - self storePointerUnchecked: i - ofObject: newObj - withValue: (self fetchPointer: i ofObject: objOop)]. - fmt >= self firstCompiledMethodFormat ifTrue: - [coInterpreter maybeFixClonedCompiledMethod: newObj. - ((self isOldObject: newObj) - and: [(self isYoungObject: objOop) or: [self isRemembered: objOop]]) ifTrue: - [scavenger remember: newObj]]]. ^newObj! Item was changed: ----- Method: SpurMemoryManager>>outOfPlaceBecome:and:copyHashFlag: (in category 'become implementation') ----- outOfPlaceBecome: obj1 and: obj2 copyHashFlag: copyHashFlag <inline: #never> "in an effort to fix a compiler bug with two-way become post r3427" + "Allocate two new objects, n1 & n2. Copy the contents appropriately. Convert obj1 and obj2 + into forwarding objects pointing to n2 and n1 respectively. No need to check if cloneObject: + succeeds because an earlier pass over objects ensured that there is enough memory." - "Allocate two new objects, n1 & n2. Copy the contents appropriately. Convert - obj1 and obj2 into forwarding objects pointing to n2 and n1 respectively" | clone1 clone2 | clone1 := (self isContextNonImm: obj1) ifTrue: [coInterpreter cloneContext: obj1] ifFalse: [self cloneObject: obj1]. clone2 := (self isContextNonImm: obj2) ifTrue: [coInterpreter cloneContext: obj2] ifFalse: [self cloneObject: obj2]. (self isObjImmutable: obj1) ifTrue: [self setIsImmutableOf: clone1 to: true]. (self isObjImmutable: obj2) ifTrue: [self setIsImmutableOf: clone2 to: true]. copyHashFlag ifTrue: [self setHashBitsOf: clone1 to: (self rawHashBitsOf: obj1). self setHashBitsOf: clone2 to: (self rawHashBitsOf: obj2)] ifFalse: [self setHashBitsOf: clone1 to: (self rawHashBitsOf: obj2). self setHashBitsOf: clone2 to: (self rawHashBitsOf: obj1)]. self forward: obj1 to: clone2; forward: obj2 to: clone1. ((self isYoungObject: obj1) ~= (self isYoungObject: clone2) or: [(self isYoungObject: obj2) ~= (self isYoungObject: clone1)]) ifTrue: [becomeEffectsFlags := becomeEffectsFlags bitOr: OldBecameNewFlag]! Item was changed: ----- Method: StackInterpreterPrimitives>>cloneContext: (in category 'primitive support') ----- cloneContext: aContext | sz cloned spouseFP sp | <var: #spouseFP type: #'char *'> sz := objectMemory numSlotsOf: aContext. cloned := objectMemory eeInstantiateMethodContextSlots: sz. + self deny: cloned = 0. + 0 to: StackPointerIndex do: + [:i| + objectMemory + storePointerUnchecked: i + ofObject: cloned + withValue: (self externalInstVar: i ofContext: aContext)]. + MethodIndex to: ReceiverIndex do: + [:i| + objectMemory + storePointerUnchecked: i + ofObject: cloned + withValue: (objectMemory fetchPointer: i ofObject: aContext)]. + (self isStillMarriedContext: aContext) + ifTrue: + [spouseFP := self frameOfMarriedContext: aContext. + sp := (self stackPointerIndexForFrame: spouseFP) - 1. + 0 to: sp do: + [:i| + objectMemory + storePointerUnchecked: i + CtxtTempFrameStart + ofObject: cloned + withValue: (self temporary: i in: spouseFP)]] + ifFalse: + [sp := (self fetchStackPointerOf: aContext) - 1. + 0 to: sp do: + [:i| + objectMemory + storePointerUnchecked: i + CtxtTempFrameStart + ofObject: cloned + withValue: (objectMemory fetchPointer: i + CtxtTempFrameStart ofObject: aContext)]]. - cloned ~= 0 ifTrue: - [0 to: StackPointerIndex do: - [:i| - objectMemory - storePointerUnchecked: i - ofObject: cloned - withValue: (self externalInstVar: i ofContext: aContext)]. - MethodIndex to: ReceiverIndex do: - [:i| - objectMemory - storePointerUnchecked: i - ofObject: cloned - withValue: (objectMemory fetchPointer: i ofObject: aContext)]. - (self isStillMarriedContext: aContext) - ifTrue: - [spouseFP := self frameOfMarriedContext: aContext. - sp := (self stackPointerIndexForFrame: spouseFP) - 1. - 0 to: sp do: - [:i| - objectMemory - storePointerUnchecked: i + CtxtTempFrameStart - ofObject: cloned - withValue: (self temporary: i in: spouseFP)]] - ifFalse: - [sp := (self fetchStackPointerOf: aContext) - 1. - 0 to: sp do: - [:i| - objectMemory - storePointerUnchecked: i + CtxtTempFrameStart - ofObject: cloned - withValue: (objectMemory fetchPointer: i + CtxtTempFrameStart ofObject: aContext)]]]. ^cloned! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveClone (in category 'object access primitives') ----- primitiveClone "Return a shallow copy of the receiver. Special-case non-single contexts (because of context-to-stack mapping). Can't fail for contexts cuz of image context instantiation code (sigh)." <primitiveMetadata: #(PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod)> "because of cloneContext: below" | rcvr newCopy | rcvr := self stackTop. (objectMemory isImmediate: rcvr) ifTrue: [newCopy := rcvr] ifFalse: [(objectMemory isContextNonImm: rcvr) ifTrue: + [self externalWriteBackHeadFramePointers. + newCopy := self cloneContext: rcvr] - [newCopy := self cloneContext: rcvr] ifFalse: [(argumentCount = 0 or: [(objectMemory isForwarded: rcvr) not]) + ifTrue: [newCopy := objectMemory cloneObject: rcvr]]. + newCopy ifNil: - ifTrue: [newCopy := objectMemory cloneObject: rcvr] - ifFalse: [newCopy := 0]]. - newCopy = 0 ifTrue: [^self primitiveFailFor: PrimErrNoMemory]]. self methodReturnValue: newCopy!

1 0

VM Maker: VMMaker.oscog.seperateMarking-eem.3308.mcz
by commits＠source.squeak.org 14 Jan '23

14 Jan '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog.seperateMarking-eem.3308.mcz ==================== Summary ==================== Name: VMMaker.oscog.seperateMarking-eem.3308 Author: eem Time: 13 January 2023, 6:44:34.267653 pm UUID: 8ceb1c5c-2147-4d19-b6b0-860d4a68b7d0 Ancestors: VMMaker.oscog.seperateMarking-WoC.3307 Merge VMMaker.oscog-eem.3283/3301 (machine code primitive for perform:withArguments:) =============== Diff against VMMaker.oscog.seperateMarking-WoC.3307 =============== Item was changed: ----- Method: CogARMv8Compiler>>decodeN:imms:immr: (in category 'generate machine code - support') ----- decodeN: n imms: imms immr: immr "See aarch64/instrs/integer/bitmasks/DecodeBitMasks J1-7389." <returnTypeC: #usqInt> | bits immediate mask rotation width | <var: 'mask' type: #usqInt> self assert: ((n between: 0 and: 1) and: [(imms between: 0 and: 63) and: [immr between: 0 and: 63]]). "For logical immediates an all-ones value of S is reserved since it would generate a useless all-ones result (many times)" imms = 63 ifTrue: [^self cCode: [0] inSmalltalk: [#undefined]]. n = 1 ifTrue: [width := 64. mask := 16rffffffffffffffff. bits := imms. rotation := immr] ifFalse: [imms < 16r20 ifTrue: [width := 32. bits := imms] ifFalse: [ imms < 16r30 ifTrue: [width := 16. bits := imms bitAnd: 16rF] ifFalse: [ imms < 16r38 ifTrue: [width := 8. bits := imms bitAnd: 16r7] ifFalse: [ imms < 16r3C ifTrue: [width := 4. bits := imms bitAnd: 16r3] ifFalse: [ imms < 16r3E ifTrue: [width := 2. bits := imms bitAnd: 16r1] ifFalse: [self error: 'invalid logical immediate']]]]]. mask := 1 << width - 1. rotation := immr bitAnd: width - 1]. width - 1 = bits ifTrue: [^0]. immediate := (1 << (bits + 1)) - 1. rotation > 0 ifTrue: + [immediate := immediate << (width - rotation)]. - [immediate := immediate << (width - rotation) - 1]. (width between: 2 and: 32) ifTrue: [immediate := (immediate bitShift: width) bitOr: immediate]. ^immediate! Item was added: + ----- Method: CogARMv8Compiler>>deconstructBitwiseImmediateInsruction: (in category 'debugging') ----- + deconstructBitwiseImmediateInsruction: v + <doNotGenerate> + ^{#n. v >> 22 bitAnd: 1. #imms. v >> 10 bitAnd: 16r3F. (v >> 10 bitAnd: 16r3F) hex. #immr. v >> 16 bitAnd: 16r3F. (v >> 16 bitAnd: 16r3F) hex } + + "self basicNew deconstructBitwiseImmediateInsruction: 16r321a3be0"! Item was changed: ----- Method: CogARMv8Compiler>>isImmNImmSImmREncodableBitmask:ifTrue:ifFalse: (in category 'generate machine code - support') ----- isImmNImmSImmREncodableBitmask: constant ifTrue: trinaryBlock "[:n :imms :immr|...]" ifFalse: nullaryBlock "See DecodeBitMasks J1-7389. See https://dinfuehr.github.io/blog/encoding-of-immediate-values-on-aarch64/ This method is adapted from The LLVM Compiler Infrastructure, AArch64AddressingModes.h processLogicalImmediate" <inline: #always> | imm size mask numLeadingOnes numTrailingOnes immr n nImms rotateCount | <var: 'mask' type: #usqInt> <var: 'nImms' type: #usqInt> (constant between: -1 and: 0) ifTrue: [^nullaryBlock value]. imm := self cCode: [constant] inSmalltalk: [constant signedIntToLong64]. "First, determine the element size." size := 32. [mask := 1 << size - 1. + (imm bitAnd: mask) ~= ((imm >> size) bitAnd: mask) - (imm bitAnd: mask) ~= (imm >> size) ifTrue: [size := size * 2. false] ifFalse: [size > 2]] whileTrue: [size := size / 2]. "Second, determine the rotation to make the element be: 0^m 1^n." mask := 1 << 64 - 1 >> (64 - size). imm := imm bitAnd: mask. (self isShiftedMask: imm) ifTrue: [rotateCount := self countTrailingZeros: imm. numTrailingOnes := self countTrailingOnes: imm >> rotateCount] ifFalse: [imm := imm bitOr: mask bitInvert64. (self isShiftedMask: imm) ifFalse: [^nullaryBlock value]. numLeadingOnes := self countLeadingOnes: imm. rotateCount := 64 - numLeadingOnes. numTrailingOnes := numLeadingOnes + (self countTrailingOnes: imm) - (64 - size)]. "Encode in Immr the number of RORs it would take to get *from* 0^m 1^n to our target value, where I is the number of RORs to go the opposite direction." self assert: size > rotateCount. "rotateCount should be smaller than element size" immr := size - rotateCount bitAnd: size - 1. "If size has a 1 in the n'th bit, create a value that has zeroes in bits [0, n] and ones above that." nImms := self cCode: [(size - 1) bitInvert64 << 1] inSmalltalk: [(size - 1) bitInvert64 << 1 bitAnd: 16rFFFFFFFFFFFFFFFF]. "Or the CTO value into the low bits, which must be below the Nth bit mentioned above." nImms := nImms bitOr: numTrailingOnes - 1. "Extract the seventh bit and toggle it to create the N field." n := ((nImms >> 6) bitAnd: 1) bitXor: 1. nImms := nImms bitAnd: 16r3F. self assert: (self decodeN: n imms: nImms immr: immr) = constant signedIntToLong64. ^trinaryBlock value: n value: nImms value: immr ! Item was changed: ----- Method: CogBytecodeFixup>>printStateOn: (in category 'debug printing') ----- printStateOn: aStream <doNotGenerate> + targetInstruction ifNil: + [^self]. + aStream space; nextPut: $(. targetInstruction ifNotNil: + [aStream space; print: targetInstruction]. + instructionIndex ifNotNil: + [aStream nextPutAll: ' ix '; print: instructionIndex]. + bcpc ifNotNil: + [aStream nextPutAll: ' bc '; print: bcpc]. + aStream nextPut: $)! - [aStream space; nextPut: $(; print: targetInstruction; nextPutAll: ' bc '; print: bcpc; nextPut: $)]! Item was added: + ----- Method: CogObjectRepresentationFor32BitSpur>>genFetchRegArgsForPerformWithArguments: (in category 'primitive generators') ----- + genFetchRegArgsForPerformWithArguments: sizeReg + "The arguments are in an array in Arg1Reg. Its size is in sizeReg. + Load Arg0Reg and Arg1Reg with the first two slots. + Since objects always have at least one slot and are aligned to 64-bits + it is safe to load both args without checking." + + cogit + MoveMw: objectMemory baseHeaderSize r: Arg1Reg R: Arg0Reg; + MoveMw: objectMemory baseHeaderSize + self wordSize r: Arg1Reg R: Arg1Reg. + ^0! Item was added: + ----- Method: CogObjectRepresentationFor64BitSpur>>genFetchRegArgsForPerformWithArguments: (in category 'primitive generators') ----- + genFetchRegArgsForPerformWithArguments: sizeReg + "The arguments are in an array in Arg1Reg. Its size is in sizeReg. + Load Arg0Reg and Arg1Reg with the first two slots, as appropriate. + Since objects always have at least one slot it is safe to load arg0 without checking. + But the array could be at the end of memory so we must check that it has two + slots before it is safe to access the second slot." + + | skip | + cogit MoveMw: objectMemory baseHeaderSize r: Arg1Reg R: Arg0Reg. + cogit CmpCq: 2 R: sizeReg. + skip := cogit JumpLess: 0. + cogit MoveMw: objectMemory baseHeaderSize + self wordSize r: Arg1Reg R: Arg1Reg. + skip jmpTarget: cogit Label. + ^0! Item was added: + ----- Method: CogObjectRepresentationForSpur>>genFetchRegArgsForPerformWithArguments: (in category 'primitive generators') ----- + genFetchRegArgsForPerformWithArguments: sizeReg + "The arguments are in an array in Arg1Reg. Its size is in sizeReg. + Load Arg0Reg and Arg1Reg with the first two slots." + ^self subclassResponsibility! Item was added: + ----- Method: CogObjectRepresentationForSpur>>genPrimitivePerformWithArguments (in category 'primitive generators') ----- + genPrimitivePerformWithArguments + <doNotGenerate> + ^cogit genPrimitivePerformWithArguments! Item was changed: ----- Method: CogSSBytecodeFixup>>printStateOn: (in category 'debug printing') ----- printStateOn: aStream <doNotGenerate> (targetInstruction isNil and: [simStackPtr isNil]) ifTrue: [^self]. aStream space; nextPut: $(. targetInstruction ifNotNil: [aStream space; print: targetInstruction]. + instructionIndex ifNotNil: + [aStream nextPutAll: ' ix '; print: instructionIndex]. simStackPtr ifNotNil: [aStream nextPutAll: ' sp '; print: simStackPtr]. bcpc ifNotNil: [aStream nextPutAll: ' bc '; print: bcpc]. aStream nextPut: $)! Item was changed: ----- Method: Cogit class>>initializeErrorCodes (in category 'class initialization') ----- initializeErrorCodes "External errors, returned to or from cog:selector:" NotFullyInitialized := -1. InsufficientCodeSpace := -2. MethodTooBig := -4. YoungSelectorInPIC := -5. EncounteredUnknownBytecode := -6. + UnimplementedPrimitive := -7. "Answered by a primitive generator that always falls back on the interpreter primitive." - UnimplementedPrimitive := -7. ShouldNotJIT := -8. MaxNegativeErrorCode := ShouldNotJIT. "Internal errors returned by generator routines to other generator routines" BadRegisterSet := 1. UnimplementedOperation := 2. "Internal successes answered by CogObjectRepresentation to JIT, etc" + UnfailingPrimitive := 3. "Answered by a primitive generator for a primitive that will never fail, and hence does not need to fall back on the interpreter primitive." + CompletePrimitive := 4 "Answered by a primitive generator that does not need to fall back on the interpreter primitive except for an error code. + The fall back code will only be generated if the method being jitted uses the error code."! - UnfailingPrimitive := 3. "Answered by a primitive generator for a primitive that will never fail" - CompletePrimitive := 4 "Answered by a primitive generator that does not bneed to fall back on the interpreter primitive except for an error code."! Item was changed: ----- Method: Cogit>>MoveMb:r:R: (in category 'abstract instructions') ----- MoveMb: offset r: baseReg R: destReg + "N.B. This instruction is guaranteed to zero-extend the byte into destReg + iff backEnd byteReadsZeroExtend." - "N.B. This instruction is guaranteed to zero-extend the byte into destReg." <inline: true> <returnTypeC: #'AbstractInstruction *'> ^self gen: MoveMbrR quickConstant: offset operand: baseReg operand: destReg! Item was added: + ----- Method: Cogit>>genPrimitivePerformWithArguments (in category 'primitive generators') ----- + genPrimitivePerformWithArguments + "Generate an in-line perform:withArguments: primitive. The lookup code requires the selector to be in Arg0Reg + and the array to be in Arg1Reg. The primitive will only handle cases 0 to numRegArgs. Is it worth it you ask? + Here are arguemnt count requencies for a short run of Croquet/Virtend which show that even for V3, with only + one rtegister arg, it very much is (but we wimp out on V3 cuz of the complexity of checking the Array): + [0] = 253743 52.5% + [1] = 116117 24%/76.5% + [2] = 99876 20.7%/97.2% + [3] = 12837 2.7%/99.9% + [4] = 209 + [5] = 84 + [6] = 2 + [7] = 313 + [8] = 0 + [9] = 0 + [10] = 0 + [11] = 1 + [12] = 0 + [13] = 0 + [14] = 0 + [15] = 0" + ^UnimplementedPrimitive! Item was changed: ----- Method: Cogit>>maybeBreakGeneratingInstructionWithIndex: (in category 'simulation only') ----- maybeBreakGeneratingInstructionWithIndex: index "Variation on maybeBreakAt: that only works for integer abstract instruction indexes, so we can have break blocks that stop at any pc, except when generating." <cmacro: '(i) 0'> "Simulation only; void in C" + (InitializationOptions at: #instructionIndex ifAbsent: nil) ifNotNil: + [:breakIndexOrIndices| + (breakIndexOrIndices isCollection + ifTrue: [breakIndexOrIndices includes: index] + ifFalse: [breakIndexOrIndices = index]) ifTrue: + [self halt]]! - (InitializationOptions at: #instructionIndex ifAbsent: nil) ifNotNil: [:breakIndex| index = breakIndex ifTrue: [self halt]]! Item was changed: ----- Method: SimpleStackBasedCogit class>>initializePrimitiveTableForNewsqueak (in category 'class initialization') ----- initializePrimitiveTableForNewsqueak "Initialize the table of primitive generators. This does not include normal primitives implemented in the coInterpreter. N.B. primitives that don't have an explicit arg count (the integer following the generator) may be variadic." "SimpleStackBasedCogit initializePrimitiveTableForNewsqueak" MaxCompiledPrimitiveIndex := self objectRepresentationClass wordSize = 8 ifTrue: [575] ifFalse: [575]. primitiveTable := CArrayAccessor on: (Array new: MaxCompiledPrimitiveIndex + 1). self table: primitiveTable from: #( "Integer Primitives (0-19)" (1 genPrimitiveAdd 1) (2 genPrimitiveSubtract 1) (3 genPrimitiveLessThan 1) (4 genPrimitiveGreaterThan 1) (5 genPrimitiveLessOrEqual 1) (6 genPrimitiveGreaterOrEqual 1) (7 genPrimitiveEqual 1) (8 genPrimitiveNotEqual 1) (9 genPrimitiveMultiply 1) (10 genPrimitiveDivide 1) (11 genPrimitiveMod 1) (12 genPrimitiveDiv 1) (13 genPrimitiveQuo 1) (14 genPrimitiveBitAnd 1) (15 genPrimitiveBitOr 1) (16 genPrimitiveBitXor 1) (17 genPrimitiveBitShift 1) "(18 primitiveMakePoint)" "(19 primitiveFail)" "Guard primitive for simulation -- *must* fail" "LargeInteger Primitives (20-39)" "(20 primitiveFail)" "(21 primitiveAddLargeIntegers)" "(22 primitiveSubtractLargeIntegers)" "(23 primitiveLessThanLargeIntegers)" "(24 primitiveGreaterThanLargeIntegers)" "(25 primitiveLessOrEqualLargeIntegers)" "(26 primitiveGreaterOrEqualLargeIntegers)" "(27 primitiveEqualLargeIntegers)" "(28 primitiveNotEqualLargeIntegers)" "(29 primitiveMultiplyLargeIntegers)" "(30 primitiveDivideLargeIntegers)" "(31 primitiveModLargeIntegers)" "(32 primitiveDivLargeIntegers)" "(33 primitiveQuoLargeIntegers)" "(34 primitiveBitAndLargeIntegers)" "(35 primitiveBitOrLargeIntegers)" "(36 primitiveBitXorLargeIntegers)" "(37 primitiveBitShiftLargeIntegers)" "Float Primitives (38-59)" "(38 genPrimitiveFloatAt)" "(39 genPrimitiveFloatAtPut)" (40 genPrimitiveAsFloat 0) (41 genPrimitiveFloatAdd 1) (42 genPrimitiveFloatSubtract 1) (43 genPrimitiveFloatLessThan 1) (44 genPrimitiveFloatGreaterThan 1) (45 genPrimitiveFloatLessOrEqual 1) (46 genPrimitiveFloatGreaterOrEqual 1) (47 genPrimitiveFloatEqual 1) (48 genPrimitiveFloatNotEqual 1) (49 genPrimitiveFloatMultiply 1) (50 genPrimitiveFloatDivide 1) "(51 genPrimitiveTruncated)" "(52 genPrimitiveFractionalPart)" "(53 genPrimitiveExponent)" "(54 genPrimitiveTimesTwoPower)" (55 genPrimitiveFloatSquareRoot 0) "(56 genPrimitiveSine)" "(57 genPrimitiveArctan)" "(58 genPrimitiveLogN)" "(59 genPrimitiveExp)" "Subscript and Stream Primitives (60-67)" (60 genPrimitiveAt 1) (61 genPrimitiveAtPut 2) (62 genPrimitiveSize 0) (63 genPrimitiveStringAt 1) (64 genPrimitiveStringAtPut 2) "The stream primitives no longer pay their way; normal Smalltalk code is faster." (65 genFastPrimFail)"was primitiveNext" (66 genFastPrimFail) "was primitiveNextPut" (67 genFastPrimFail) "was primitiveAtEnd" "StorageManagement Primitives (68-79)" (68 genPrimitiveObjectAt 1) "Good for debugger/InstructionStream performance" "(69 primitiveObjectAtPut)" (70 genPrimitiveNew) "For VMMirror support 1 argument instantiateFixedClass: as well as baiscNew" (71 genPrimitiveNewWithArg) "For VMMirror support 2 argument instantiateVariableClass:withSize: as well as baiscNew:" "(72 primitiveArrayBecomeOneWay)" "Blue Book: primitiveBecome" "(73 primitiveInstVarAt)" "(74 primitiveInstVarAtPut)" (75 genPrimitiveIdentityHash 0) "(76 primitiveStoreStackp)" "Blue Book: primitiveAsObject" "(77 primitiveSomeInstance)" "(78 primitiveNextInstance)" (79 genPrimitiveNewMethod 2) "Control Primitives (80-89)" "(80 primitiveFail)" "Blue Book: primitiveBlockCopy" "(81 primitiveFail)" "Blue Book: primitiveValue" "(82 primitiveFail)" "Blue Book: primitiveValueWithArgs" (83 genPrimitivePerform) + (84 genPrimitivePerformWithArguments 2) - "(84 primitivePerformWithArgs)" "(85 primitiveSignal)" "(86 primitiveWait)" "(87 primitiveResume)" "(88 primitiveSuspend)" "(89 primitiveFlushCache)" "System Primitives (110-119)" (110 genPrimitiveIdentical 1) (111 genPrimitiveClass) "For objectClass: and VMMirror support 1 argument classOf: as well as class" "(112 primitiveBytesLeft)" "(113 primitiveQuit)" "(114 primitiveExitToDebugger)" "(115 primitiveChangeClass)" "Blue Book: primitiveOopsLeft" "(116 primitiveFlushCacheByMethod)" "(117 primitiveExternalCall)" "(118 primitiveDoPrimitiveWithArgs)" "(119 primitiveFlushCacheSelective)" (148 genPrimitiveShallowCopy 0) "a.k.a. clone" (165 genPrimitiveIntegerAt 1) "Signed version of genPrimitiveAt" (166 genPrimitiveIntegerAtPut 2) "Signed version of genPrimitiveAtPut" (169 genPrimitiveNotIdentical 1) (170 genPrimitiveAsCharacter) "SmallInteger>>asCharacter, Character class>>value:" (171 genPrimitiveImmediateAsInteger 0) "Character>>asInteger/hash/identityHash, SmallFloat64>>identityHash" "(173 primitiveSlotAt 1)" "(174 primitiveSlotAtPut 2)" (175 genPrimitiveIdentityHash 0) "Behavior>>identityHash" "Old closure primitives" "(186 primitiveFail)" "was primitiveClosureValue" "(187 primitiveFail)" "was primitiveClosureValueWithArgs" "Perform method directly" "(188 primitiveExecuteMethodArgsArray)" "(189 primitiveExecuteMethod)" "Unwind primitives" "(195 primitiveFindNextUnwindContext)" "(196 primitiveTerminateTo)" "(197 primitiveFindHandlerContext)" (198 genFastPrimFail "primitiveMarkUnwindMethod") (199 genFastPrimFail "primitiveMarkHandlerMethod") "new closure primitives" "(200 primitiveClosureCopyWithCopiedValues)" (201 genPrimitiveClosureValue 0) "value" (202 genPrimitiveClosureValue 1) "value:" (203 genPrimitiveClosureValue 2) "value:value:" (204 genPrimitiveClosureValue 3) "value:value:value:" (205 genPrimitiveClosureValue 4) "value:value:value:value:" "(206 genPrimitiveClosureValueWithArgs)" "valueWithArguments:" "(210 primitiveContextAt)" "(211 primitiveContextAtPut)" "(212 primitiveContextSize)" "(218 primitiveDoNamedPrimitiveWithArgs)" "(219 primitiveFail)" "reserved for Cog primitives" "(220 primitiveFail)" "reserved for Cog primitives" (221 genPrimitiveClosureValue 0) "valueNoContextSwitch" (222 genPrimitiveClosureValue 1) "valueNoContextSwitch:" "SmallFloat primitives (540-559)" (541 genPrimitiveSmallFloatAdd 1) (542 genPrimitiveSmallFloatSubtract 1) (543 genPrimitiveSmallFloatLessThan 1) (544 genPrimitiveSmallFloatGreaterThan 1) (545 genPrimitiveSmallFloatLessOrEqual 1) (546 genPrimitiveSmallFloatGreaterOrEqual 1) (547 genPrimitiveSmallFloatEqual 1) (548 genPrimitiveSmallFloatNotEqual 1) (549 genPrimitiveSmallFloatMultiply 1) (550 genPrimitiveSmallFloatDivide 1) "(551 genPrimitiveSmallFloatTruncated 0)" "(552 genPrimitiveSmallFloatFractionalPart 0)" "(553 genPrimitiveSmallFloatExponent 0)" "(554 genPrimitiveSmallFloatTimesTwoPower 1)" (555 genPrimitiveSmallFloatSquareRoot 0) "(556 genPrimitiveSmallFloatSine 0)" "(557 genPrimitiveSmallFloatArctan 0)" "(558 genPrimitiveSmallFloatLogN 0)" "(559 genPrimitiveSmallFloatExp 0)" (575 genPrimitiveHighBit 0) )! Item was changed: ----- Method: SimpleStackBasedCogit class>>initializePrimitiveTableForSqueak (in category 'class initialization') ----- initializePrimitiveTableForSqueak "Initialize the table of primitive generators. This does not include normal primitives implemented in the coInterpreter. N.B. primitives that don't have an explicit arg count (the integer following the generator) may be variadic." "SimpleStackBasedCogit initializePrimitiveTableForSqueak" MaxCompiledPrimitiveIndex := 582. primitiveTable := CArrayAccessor on: (Array new: MaxCompiledPrimitiveIndex + 1). self table: primitiveTable from: #( "Integer Primitives (0-19)" (1 genPrimitiveAdd 1) (2 genPrimitiveSubtract 1) (3 genPrimitiveLessThan 1) (4 genPrimitiveGreaterThan 1) (5 genPrimitiveLessOrEqual 1) (6 genPrimitiveGreaterOrEqual 1) (7 genPrimitiveEqual 1) (8 genPrimitiveNotEqual 1) (9 genPrimitiveMultiply 1) (10 genPrimitiveDivide 1) (11 genPrimitiveMod 1) (12 genPrimitiveDiv 1) (13 genPrimitiveQuo 1) (14 genPrimitiveBitAnd 1) (15 genPrimitiveBitOr 1) (16 genPrimitiveBitXor 1) (17 genPrimitiveBitShift 1) (18 genPrimitiveMakePoint 1) "this is here mainly to remove noise from printPrimTraceLog()" "(19 primitiveFail)" "Guard primitive for simulation -- *must* fail" "LargeInteger Primitives (20-39)" "(20 primitiveFail)" "(21 primitiveAddLargeIntegers)" "(22 primitiveSubtractLargeIntegers)" "(23 primitiveLessThanLargeIntegers)" "(24 primitiveGreaterThanLargeIntegers)" "(25 primitiveLessOrEqualLargeIntegers)" "(26 primitiveGreaterOrEqualLargeIntegers)" "(27 primitiveEqualLargeIntegers)" "(28 primitiveNotEqualLargeIntegers)" "(29 primitiveMultiplyLargeIntegers)" "(30 primitiveDivideLargeIntegers)" "(31 primitiveModLargeIntegers)" "(32 primitiveDivLargeIntegers)" "(33 primitiveQuoLargeIntegers)" "(34 primitiveBitAndLargeIntegers)" "(35 primitiveBitOrLargeIntegers)" "(36 primitiveBitXorLargeIntegers)" "(37 primitiveBitShiftLargeIntegers)" "Float Primitives (38-59)" "(38 genPrimitiveFloatAt)" "(39 genPrimitiveFloatAtPut)" (40 genPrimitiveAsFloat 0) (41 genPrimitiveFloatAdd 1) (42 genPrimitiveFloatSubtract 1) (43 genPrimitiveFloatLessThan 1) (44 genPrimitiveFloatGreaterThan 1) (45 genPrimitiveFloatLessOrEqual 1) (46 genPrimitiveFloatGreaterOrEqual 1) (47 genPrimitiveFloatEqual 1) (48 genPrimitiveFloatNotEqual 1) (49 genPrimitiveFloatMultiply 1) (50 genPrimitiveFloatDivide 1) "(51 genPrimitiveTruncated)" "(52 genPrimitiveFractionalPart)" "(53 genPrimitiveExponent)" "(54 genPrimitiveTimesTwoPower)" (55 genPrimitiveFloatSquareRoot 0) "(56 genPrimitiveSine)" "(57 genPrimitiveArctan)" "(58 genPrimitiveLogN)" "(59 genPrimitiveExp)" "Subscript and Stream Primitives (60-67)" (60 genPrimitiveAt 1) (61 genPrimitiveAtPut 2) (62 genPrimitiveSize 0) (63 genPrimitiveStringAt 1) (64 genPrimitiveStringAtPut 2) "The stream primitives no longer pay their way; normal Smalltalk code is faster." (65 genFastPrimFail)"was primitiveNext" (66 genFastPrimFail) "was primitiveNextPut" (67 genFastPrimFail) "was primitiveAtEnd" "StorageManagement Primitives (68-79)" (68 genPrimitiveObjectAt 1) "Good for debugger/InstructionStream performance" "(69 primitiveObjectAtPut)" (70 genPrimitiveNew 0) (71 genPrimitiveNewWithArg 1) "(72 primitiveArrayBecomeOneWay)" "Blue Book: primitiveBecome" "(73 primitiveInstVarAt)" "(74 primitiveInstVarAtPut)" (75 genPrimitiveIdentityHash 0) "(76 primitiveStoreStackp)" "Blue Book: primitiveAsObject" "(77 primitiveSomeInstance)" "(78 primitiveNextInstance)" (79 genPrimitiveNewMethod 2) "Control Primitives (80-89)" "(80 primitiveFail)" "Blue Book: primitiveBlockCopy" "(81 primitiveFail)" "Blue Book: primitiveValue" "(82 primitiveFail)" "Blue Book: primitiveValueWithArgs" (83 genPrimitivePerform) + (84 genPrimitivePerformWithArguments 2) - "(84 primitivePerformWithArgs)" "(85 primitiveSignal)" "(86 primitiveWait)" "(87 primitiveResume)" "(88 primitiveSuspend)" "(89 primitiveFlushCache)" "(90 primitiveMousePoint)" "(91 primitiveTestDisplayDepth)" "Blue Book: primitiveCursorLocPut" "(92 primitiveSetDisplayMode)" "Blue Book: primitiveCursorLink" "(93 primitiveInputSemaphore)" "(94 primitiveGetNextEvent)" "Blue Book: primitiveSampleInterval" "(95 primitiveInputWord)" "(96 primitiveFail)" "primitiveCopyBits" "(97 primitiveSnapshot)" "(98 primitiveStoreImageSegment)" "(99 primitiveLoadImageSegment)" "(100 primitivePerformInSuperclass)" "Blue Book: primitiveSignalAtTick" "(101 primitiveBeCursor)" "(102 primitiveBeDisplay)" "(103 primitiveScanCharacters)" "(104 primitiveFail)" "primitiveDrawLoop" (105 genPrimitiveStringReplace) "(106 primitiveScreenSize)" "(107 primitiveMouseButtons)" "(108 primitiveKbdNext)" "(109 primitiveKbdPeek)" "System Primitives (110-119)" (110 genPrimitiveIdentical 1) (111 genPrimitiveClass) "Support both class and Context>>objectClass:" "(112 primitiveBytesLeft)" "(113 primitiveQuit)" "(114 primitiveExitToDebugger)" "(115 primitiveChangeClass)" "Blue Book: primitiveOopsLeft" "(116 primitiveFlushCacheByMethod)" "(117 primitiveExternalCall)" "(118 primitiveDoPrimitiveWithArgs)" "(119 primitiveFlushCacheSelective)" (148 genPrimitiveShallowCopy 0) "a.k.a. clone" (158 genPrimitiveStringCompareWith 1) (159 genPrimitiveHashMultiply 0) (165 genPrimitiveIntegerAt 1) "Signed version of genPrimitiveAt" (166 genPrimitiveIntegerAtPut 2) "Signed version of genPrimitiveAtPut" (169 genPrimitiveNotIdentical 1) (170 genPrimitiveAsCharacter) "SmallInteger>>asCharacter, Character class>>value:" (171 genPrimitiveImmediateAsInteger 0) "Character>>asInteger/hash/identityHash, SmallFloat64>>identityHash" (173 genPrimitiveSlotAt 1) "Good for micro-benchmark performance, and for reducing noise in Croquet primitive trace logs" (174 genPrimitiveSlotAtPut 2) "ditto" (175 genPrimitiveIdentityHash 0) "Behavior>>identityHash" "Old closure primitives" "(186 primitiveFail)" "was primitiveClosureValue" "(187 primitiveFail)" "was primitiveClosureValueWithArgs" "Perform method directly" "(188 primitiveExecuteMethodArgsArray)" "(189 primitiveExecuteMethod)" "Unwind primitives" "(195 primitiveFindNextUnwindContext)" "(196 primitiveTerminateTo)" "(197 primitiveFindHandlerContext)" (198 genFastPrimFail "primitiveMarkUnwindMethod") (199 genFastPrimFail "primitiveMarkHandlerMethod") "new closure primitives" "(200 primitiveClosureCopyWithCopiedValues)" (201 genPrimitiveClosureValue 0) "value" (202 genPrimitiveClosureValue 1) "value:" (203 genPrimitiveClosureValue 2) "value:value:" (204 genPrimitiveClosureValue 3) "value:value:value:" (205 genPrimitiveClosureValue 4) "value:value:value:value:" "(206 genPrimitiveClosureValueWithArgs)" "valueWithArguments:" (207 genPrimitiveFullClosureValue) "value[:value:value:value:] et al" "(208 genPrimitiveFullClosureValueWithArgs)" "valueWithArguments:" (209 genPrimitiveFullClosureValue) "valueNoContextSwitch[:value:] et al" "(210 primitiveContextAt)" "(211 primitiveContextAtPut)" "(212 primitiveContextSize)" "(218 primitiveDoNamedPrimitiveWithArgs)" "(219 primitiveFail)" "reserved for Cog primitives" "(220 primitiveFail)" "reserved for Cog primitives" (221 genPrimitiveClosureValue 0) "valueNoContextSwitch" (222 genPrimitiveClosureValue 1) "valueNoContextSwitch:" "SmallFloat primitives (540-559)" (541 genPrimitiveSmallFloatAdd 1) (542 genPrimitiveSmallFloatSubtract 1) (543 genPrimitiveSmallFloatLessThan 1) (544 genPrimitiveSmallFloatGreaterThan 1) (545 genPrimitiveSmallFloatLessOrEqual 1) (546 genPrimitiveSmallFloatGreaterOrEqual 1) (547 genPrimitiveSmallFloatEqual 1) (548 genPrimitiveSmallFloatNotEqual 1) (549 genPrimitiveSmallFloatMultiply 1) (550 genPrimitiveSmallFloatDivide 1) "(551 genPrimitiveSmallFloatTruncated 0)" "(552 genPrimitiveSmallFloatFractionalPart 0)" "(553 genPrimitiveSmallFloatExponent 0)" "(554 genPrimitiveSmallFloatTimesTwoPower 1)" (555 genPrimitiveSmallFloatSquareRoot 0) "(556 genPrimitiveSmallFloatSine 0)" "(557 genPrimitiveSmallFloatArctan 0)" "(558 genPrimitiveSmallFloatLogN 0)" "(559 genPrimitiveSmallFloatExp 0)" "(568 primitiveSuspendBackingUpV1) 0)" (575 genPrimitiveHighBit 0) "(578 primitiveSuspendBackingUpV2 0)" "(580 primitivePinnedNewInOldSpace 0)" "(581 primitivePinnedNewWithArgInOldSpace 1)" (582 genPrimitiveUninitializedNewWithArg 1) "reserved for (583 primitivePinnedUninitializedNewWithArgInOldSpace 1)" )! Item was added: + ----- Method: SimpleStackBasedCogit>>genLoadcmNumArgsOf:into: (in category 'primitive generators') ----- + genLoadcmNumArgsOf: cogMethodReg into: targetReg + "Currently cmNumArgs is the first byte following the objectHeader." + <inline: true> + backEnd byteReadsZeroExtend ifFalse: + [self MoveCq: 0 R: targetReg]. + self MoveMb: objectRepresentation wordSize r: cogMethodReg R: targetReg! Item was added: + ----- Method: SimpleStackBasedCogit>>genLookupForPerformWithArguments (in category 'primitive generators') ----- + genLookupForPerformWithArguments + "Compile the code for a probe of the first-level method cache for the perform:withArguments: primitive. + The selector is assumed to be in Arg0Reg an d the array in Arg1Reg. Fall back to the interpreter if + the size of the array is greater than numRegArgs." + <inline: true> + | jumpImmArray jumpSelectorMiss jumpClassMiss jumpInterpret jumpBadNumArgs1 jumpBadNumArgs2 itsAHit cacheBaseReg | + + "N.B. Can't assume TempReg already contains the tag because a method can + of course be invoked via the unchecked entry-point, e.g. as does perform:." + jumpImmArray := objectRepresentation genJumpImmediate: Arg1Reg. + objectRepresentation genGetInlineCacheClassTagFrom: ReceiverResultReg into: SendNumArgsReg forEntry: false. + + + self flag: #lookupInMethodCacheSel:classTag:. "so this method shows up as a sender of lookupInMethodCacheSel:class:" + + cacheBaseReg := NoReg. + (backEnd isWithinMwOffsetRange: coInterpreter methodCacheAddress) ifFalse: + [self MoveCq: coInterpreter methodCacheAddress R: (cacheBaseReg := Extra0Reg)]. + + "Do first of three probes. See CoInterpreter>>lookupInMethodCacheSel:classTag:" + jumpSelectorMiss := self compilePerformMethodCacheProbeFor: Arg0Reg withShift: 0 baseRegOrNone: cacheBaseReg. + jumpClassMiss := self JumpNonZero: 0. + + "Fetch the method, and check if it is cogged." + itsAHit := self MoveMw: (cacheBaseReg = NoReg + ifTrue: [coInterpreter methodCacheAddress + (MethodCacheMethod << objectMemory shiftForWord)] + ifFalse: [MethodCacheMethod << objectMemory shiftForWord]) + r: ClassReg + R: SendNumArgsReg. + "If the method is not compiled fall back on the interpreter primitive." + objectRepresentation genLoadSlot: HeaderIndex sourceReg: SendNumArgsReg destReg: ClassReg. + jumpInterpret := objectRepresentation genJumpImmediate: ClassReg. + "check the argument count; if it's wrong fall back on the interpreter primitive." + self genLoadcmNumArgsOf: ClassReg into: SendNumArgsReg. + objectRepresentation genGetRawSlotSizeOfNonImm: Arg1Reg into: TempReg. + self CmpR: TempReg R: SendNumArgsReg. + jumpBadNumArgs1 := self JumpNonZero: 0. + self CmpCq: self numRegArgs R: SendNumArgsReg. + jumpBadNumArgs2 := self JumpGreater: 0. + + "Fetch arguments and jump to the method's unchecked entry-point." + objectRepresentation genFetchRegArgsForPerformWithArguments: TempReg. + self AddCq: cmNoCheckEntryOffset R: ClassReg. + self JumpR: ClassReg. + + "First probe missed. Do second of three probes. Shift hash right one and retry." + jumpSelectorMiss jmpTarget: (jumpClassMiss jmpTarget: self Label). + jumpSelectorMiss := self compilePerformMethodCacheProbeFor: Arg0Reg withShift: 1 baseRegOrNone: cacheBaseReg. + self JumpZero: itsAHit. + + "Second probe missed. Do last probe. Shift hash right two and retry." + jumpSelectorMiss jmpTarget: self Label. + jumpSelectorMiss := self compilePerformMethodCacheProbeFor: Arg0Reg withShift: 2 baseRegOrNone: cacheBaseReg. + self JumpZero: itsAHit. + + "Last probe missed/not jitted/bad num args. Caller will generate the call to fall back on the interpreter primitive." + jumpImmArray jmpTarget: + (jumpSelectorMiss jmpTarget: + (jumpInterpret jmpTarget: + (jumpBadNumArgs1 jmpTarget: + (jumpBadNumArgs2 jmpTarget: self Label)))). + ^0! Item was added: + ----- Method: SimpleStackBasedCogit>>genPrimitivePerformWithArguments (in category 'primitive generators') ----- + genPrimitivePerformWithArguments + "Generate an in-line perform:withArguments: primitive. The lookup code requires the selector to be in Arg0Reg + and the array to be in Arg1Reg. The primitive will only handle cases 0 to numRegArgs. Is it worth it you ask? + Here are arguemnt count requencies for a short run of Croquet/Virtend which show that even for V3, with only + one rtegister arg, it very much is (but we wimp out on V3 cuz of the complexity of checking the Array): + [0] = 253743 52.5% + [1] = 116117 24%/76.5% + [2] = 99876 20.7%/97.2% + [3] = 12837 2.7%/99.9% + [4] = 209 + [5] = 84 + [6] = 2 + [7] = 313 + [8] = 0 + [9] = 0 + [10] = 0 + [11] = 1 + [12] = 0 + [13] = 0 + [14] = 0 + [15] = 0" + <option: #SpurObjectMemory> + self MoveMw: (backEnd hasLinkRegister + ifTrue: [1] + ifFalse: [2]) * objectMemory wordSize + r: SPReg + R: Arg0Reg; + MoveMw: (backEnd hasLinkRegister + ifTrue: [2] + ifFalse: [3]) * objectMemory wordSize + r: SPReg + R: Arg1Reg. + ^self genLookupForPerformWithArguments! Item was added: + ----- Method: StackToRegisterMappingCogit>>genPrimitivePerformWithArguments (in category 'primitive generators') ----- + genPrimitivePerformWithArguments + "Generate an in-line perform:withArguments: primitive. The lookup code requires the selector to be in Arg0Reg + and the array to be in Arg1Reg. The primitive will only handle cases 0 to numRegArgs. Is it worth it you ask? + Here are arguemnt count requencies for a short run of Croquet/Virtend which show that even for V3, with only + one rtegister arg, it very much is (but we wimp out on V3 cuz of the complexity of checking the Array): + [0] = 253743 52.5% + [1] = 116117 24%/76.5% + [2] = 99876 20.7%/97.2% + [3] = 12837 2.7%/99.9% + [4] = 209 + [5] = 84 + [6] = 2 + [7] = 313 + [8] = 0 + [9] = 0 + [10] = 0 + [11] = 1 + [12] = 0 + [13] = 0 + [14] = 0 + [15] = 0" + <option: #SpurObjectMemory> + ^self genLookupForPerformWithArguments!

1 0

VM Maker: VMMaker.oscog-eem.3301.mcz
by commits＠source.squeak.org 14 Jan '23

14 Jan '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3301.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3301 Author: eem Time: 13 January 2023, 6:41:01.001136 pm UUID: c43e2ae6-7086-4eba-b250-9362025ee10c Ancestors: VMMaker.oscog-eem.3300 speeling rorres =============== Diff against VMMaker.oscog-eem.3300 =============== Item was changed: ----- Method: CogObjectRepresentationFor32BitSpur>>genFetchRegArgsForPerformWithArguments: (in category 'primitive generators') ----- genFetchRegArgsForPerformWithArguments: sizeReg + "The arguments are in an array in Arg1Reg. Its size is in sizeReg. - "The arguments are imn an array in Arg1Reg. Its size is in sizeReg. Load Arg0Reg and Arg1Reg with the first two slots. Since objects always have at least one slot and are aligned to 64-bits it is safe to load both args without checking." cogit MoveMw: objectMemory baseHeaderSize r: Arg1Reg R: Arg0Reg; MoveMw: objectMemory baseHeaderSize + self wordSize r: Arg1Reg R: Arg1Reg. ^0! Item was changed: ----- Method: CogObjectRepresentationFor64BitSpur>>genFetchRegArgsForPerformWithArguments: (in category 'primitive generators') ----- genFetchRegArgsForPerformWithArguments: sizeReg + "The arguments are in an array in Arg1Reg. Its size is in sizeReg. - "The arguments are imn an array in Arg1Reg. Its size is in sizeReg. Load Arg0Reg and Arg1Reg with the first two slots, as appropriate. Since objects always have at least one slot it is safe to load arg0 without checking. + But the array could be at the end of memory so we must check that it has two - But the array could be at teh end of memory so we must check taht it has two slots before it is safe to access the second slot." | skip | cogit MoveMw: objectMemory baseHeaderSize r: Arg1Reg R: Arg0Reg. cogit CmpCq: 2 R: sizeReg. skip := cogit JumpLess: 0. cogit MoveMw: objectMemory baseHeaderSize + self wordSize r: Arg1Reg R: Arg1Reg. skip jmpTarget: cogit Label. ^0! Item was changed: ----- Method: CogObjectRepresentationForSpur>>genFetchRegArgsForPerformWithArguments: (in category 'primitive generators') ----- genFetchRegArgsForPerformWithArguments: sizeReg + "The arguments are in an array in Arg1Reg. Its size is in sizeReg. - "The arguments are imn an array in Arg1Reg. Its size is in sizeReg. Load Arg0Reg and Arg1Reg with the first two slots." ^self subclassResponsibility!

1 0

VM Maker: VMMaker.oscog-eem.3300.mcz
by commits＠source.squeak.org 14 Jan '23

14 Jan '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3300.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3300 Author: eem Time: 13 January 2023, 3:00:06.641275 pm UUID: 3f65e3af-f9b2-4e1a-b881-f9272c7bde04 Ancestors: VMMaker.oscog-eem.3299 capture a few JIT timings =============== Diff against VMMaker.oscog-eem.3299 =============== Item was changed: ----- Method: CompiledCode>>benchmarkJITReceiver (in category '*VMMaker-benchmarks') ----- benchmarkJITReceiver "Answer the elapsed time in microseconds to jit the receiver." | ticksPerMicrosecond | ticksPerMicrosecond := Time highResClockTicksPerMillisecond / 1000.0. ^self primitiveBenchmarkJITReceiver / ticksPerMicrosecond "| methods times nBytecodes nLiterals | methods := self methodDict values. times := methods collect: [:m| m benchmarkJITReceiver]. nLiterals := methods collect: #numLiterals. nBytecodes := methods collect: [:m| m isQuick ifTrue: [1] ifFalse: [m endPC - m initialPC + 1]]. + {times. nLiterals. nBytecodes} collect: [:stats| {stats min. stats max. stats average asFloat} collect: [:stat| stat roundTo: 0.001]]" + + "On an Apple MacBook Pro (16-inch, 2021), Apple M1 Max, Cores: 10 (8 performance and 2 efficiency): + + ((Array withAllSuperclasses copyUpThrough: Collection) collect: [:c| c methodDict values]) fold: #, + ((2.375 87.466 7.672) (2 28 4.682) (1 299 17.996)) + + CompiledCode methodDict values + ((2.25 35.961 7.883) (2 20 5.938) (1 106 17.464)) + + ((LargeNegativeInteger withAllSuperclasses copyUpThrough: Magnitude) collect: [:c| c methodDict values]) fold: #, + ((1.458 148.429 8.951) (2 51 5.405) (1 569 22.580))"! - {times. nLiterals. nBytecodes} collect: [:stats| {stats min. stats max. stats average asFloat} collect: [:stat| stat roundTo: 0.001]]"!

1 0

VM Maker: VMMaker.oscog.seperateMarking-WoC.3307.mcz
by commits＠source.squeak.org 13 Jan '23

13 Jan '23

Tom Braun uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog.seperateMarking-WoC.3307.mcz ==================== Summary ==================== Name: VMMaker.oscog.seperateMarking-WoC.3307 Author: WoC Time: 13 January 2023, 11:54:30.540799 pm UUID: 6e8d75d9-7bc1-4831-9411-3ef7529c3978 Ancestors: VMMaker.oscog.seperateMarking-WoC.3306 reset the compacted info of partially compacted segments correctly =============== Diff against VMMaker.oscog.seperateMarking-WoC.3306 =============== Item was changed: ----- Method: SpurIncrementalCompactingSweeper>>assertNoSegmentBeingCompacted (in category 'as yet unclassified') ----- assertNoSegmentBeingCompacted "Assertion only - no segment is being claimed at this point. All being compacted bits get cleared during sweeping when setting the occupation of the segments" | segInfo | <var: 'segInfo' type: #'SpurSegmentInfo *'> 0 to: manager numSegments - 1 do: [:i| segInfo := manager segInfoAt: i. + self deny: ((self isSegmentBeingCompacted: segInfo) or: [self isSegmentBeingPartiallyCompacted: segInfo]). + ((self isSegmentBeingCompacted: segInfo) or: [self isSegmentBeingPartiallyCompacted: segInfo]) - self deny: (self isSegmentBeingCompacted: segInfo). - (self isSegmentBeingCompacted: segInfo) ifTrue: [self cCode: 'raise(SIGINT)']].! Item was changed: ----- Method: SpurIncrementalCompactingSweeper>>freePastSegmentsAndSetSegmentToFill (in category 'api') ----- freePastSegmentsAndSetSegmentToFill "The first segment being claimed met becomes the segmentToFill. The others are just freed." <var: 'segInfo' type: #'SpurSegmentInfo *'> 0 to: manager numSegments - 1 do: [:i| | segInfo | segInfo := manager segInfoAt: i. (self wasSegmentsCompactionAborted: segInfo) ifTrue: [ | freeUntil chunkBytes | freeUntil := manager startOfObject: (self getEndOfCompaction: segInfo). chunkBytes := freeUntil - segInfo segStart. "maybe we could not even move one object out of the segment. Make sure we do not produce an invalid free chunk" chunkBytes > 0 ifTrue: [coInterpreter cr; print: 'partially freeing segment from: '; printHex: segInfo segStart; print: ' to: '; printHex: freeUntil ;tab; flush. manager addFreeChunkWithBytes: chunkBytes + at: segInfo segStart]. + + self unmarkSegmentAsBeingCompacted: segInfo]. - at: segInfo segStart]]. (self isSegmentBeingCompacted: segInfo) ifTrue: [ | freeChunk chunkBytes | self assert: (manager segmentManager allObjectsAreForwardedInSegment: segInfo includingFreeSpace: false). self assert: (manager noElementOfFreeSpaceIsInSegment: segInfo). coInterpreter cr; print: 'freeing segment from: '; printHex: segInfo segStart; print: ' to: '; printHex: segInfo segStart + segInfo segSize ;tab; flush. chunkBytes := segInfo segSize - manager bridgeSize. freeChunk := manager addFreeChunkWithBytes: chunkBytes at: segInfo segStart. self unmarkSegmentAsBeingCompacted: segInfo. segmentToFill ifNil: [manager detachFreeObject: freeChunk. segmentToFill := segInfo. self assertSegmentToFillIsInSegmentsArray]]]! Item was changed: ----- Method: VMClass class>>openSpurMultiWindowBrowser (in category 'utilities') ----- openSpurMultiWindowBrowser "Answer a new multi-window browser on the Spur classes, the Cog StackInterpreter classes, and the support classes" "self openSpurMultiWindowBrowser" | b | b := Browser open. + #( SpurIncrementalGarbageCollector SpurMemoryManager + CCodeGenerator TMethod StackInterpreter + Spur32BitMemoryManager Spur64BitMemoryManager - #( SpurMemoryManager Spur32BitMemoryManager Spur64BitMemoryManager SpurGenerationScavenger SpurSegmentManager Spur32BitMMLESimulator SpurGenerationScavengerSimulator SpurMarker SpurAllAtOnceMarker SpurIncrementalMarker SpurCompactor SpurPlanningCompactor SpurHybridCompactor SpurIncrementalCompactor SpurIncrementalSweepAndCompact + InterpreterPrimitives StackInterpreterPrimitives + VMStructType VMMaker ) - InterpreterPrimitives StackInterpreter StackInterpreterPrimitives - VMStructType VMMaker CCodeGenerator TMethod) do: [:className| (Smalltalk classNamed: className) ifNotNil: [:class| b selectCategoryForClass: class; selectClass: class]] separatedBy: [b multiWindowState addNewWindow]. b multiWindowState selectWindowIndex: 1!

1 0

VM Maker: VMMaker.oscog.seperateMarking-WoC.3306.mcz
by commits＠source.squeak.org 13 Jan '23

13 Jan '23

Tom Braun uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog.seperateMarking-WoC.3306.mcz ==================== Summary ==================== Name: VMMaker.oscog.seperateMarking-WoC.3306 Author: WoC Time: 13 January 2023, 11:51:31.762314 pm UUID: a08da09c-f639-428b-8c8e-6c1459ec92d2 Ancestors: VMMaker.oscog.seperateMarking-WoC.3305 protect bridge from beeing overwritten during compaction =============== Diff against VMMaker.oscog.seperateMarking-WoC.3305 =============== Item was changed: ----- Method: SpurIncrementalCompactingSweeper>>occupyRestOfFreeCompactedIntoSegment (in category 'incremental compact') ----- occupyRestOfFreeCompactedIntoSegment + "do not overwrite the bridge" + (self oop: currentCopyToPointer isGreaterThanOrEqualTo: segmentToFill segLimit - manager bridgeSize) + ifTrue: [^ self]. + manager initFreeChunkWithBytes: segmentToFill segSize - manager bridgeSize + segmentToFill segStart - currentCopyToPointer at: currentCopyToPointer. "avoid confusing spur, especially for leak checks" manager set: (manager objectStartingAt: currentCopyToPointer) classIndexTo: manager wordSizeClassIndexPun formatTo: manager wordIndexableFormat! Item was changed: ----- Method: SpurIncrementalCompactingSweeper>>setFreeChunkOfCompactedIntoSegment (in category 'incremental compact') ----- setFreeChunkOfCompactedIntoSegment shouldCompact ifFalse: [^ self]. + "do not overwrite the bridge" + (self oop: currentCopyToPointer isGreaterThanOrEqualTo: segmentToFill segLimit - manager bridgeSize) + ifTrue: [^ self]. self assert: segmentToFill notNil. + self assert: (self oop: currentCopyToPointer isLessThan: segmentToFill segLimit - manager bridgeSize). - self assert: (self oop: currentCopyToPointer isLessThan: (segmentToFill segLimit - manager bridgeSize)). coInterpreter cr; print: 'after compaction freeing from: '; printHex: currentCopyToPointer; + print: ' to: '; printHex: segmentToFill segStart + segmentToFill segSize - manager bridgeSize + segmentToFill segStart - currentCopyToPointer ; - print: ' to: '; printHex: segmentToFill segSize - manager bridgeSize + segmentToFill segStart - currentCopyToPointer ; tab; flush. manager addFreeChunkWithBytes: segmentToFill segSize - manager bridgeSize + segmentToFill segStart - currentCopyToPointer at: currentCopyToPointer. "we have compacted into segmentToFill. It is now not empty anymore and we need to look for a new one" segmentToFill := nil !

1 0

[OpenSmalltalk/opensmalltalk-vm] [ci skip] updated the link for Cuis community (PR #661)
by Vic 13 Jan '23

13 Jan '23

[ci skip] from http://www.cuis-smalltalk.org/ (dead by all appearances), to https://cuis.st/community You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/661 -- Commit Summary -- * updated the link for Cuis community [ci skip] -- File Changes -- M README.md (2) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/661.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/661.diff -- Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/661 You are receiving this because you are subscribed to this thread. Message ID: <OpenSmalltalk/opensmalltalk-vm/pull/661(a)github.com>

2 2

[OpenSmalltalk/opensmalltalk-vm] 17a646: updated the link for Cuis community [ci skip]
by Eliot Miranda 13 Jan '23

13 Jan '23

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 17a64668525d537853efd1b0ab351f4456631095 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/17a64668525d537853… Author: Vic <35498248+VictorelPetrovich(a)users.noreply.github.com> Date: 2023-01-13 (Fri, 13 Jan 2023) Changed paths: M README.md Log Message: ----------- updated the link for Cuis community [ci skip] from http://www.cuis-smalltalk.org/ (dead by all appearances), to https://cuis.st/community [ci skip] Commit: d0155467b5368e29513d6f663828a9df1d6811b7 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d0155467b5368e2951… Author: Vic <35498248+VictorelPetrovich(a)users.noreply.github.com> Date: 2023-01-13 (Fri, 13 Jan 2023) Changed paths: M CONTRIBUTING.md Log Message: ----------- updated link for Cuis community [ci skip] Commit: 4e2ed7ff9c6862c39cad22ec1f944c772602183f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/4e2ed7ff9c6862c39c… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2023-01-13 (Fri, 13 Jan 2023) Changed paths: M CONTRIBUTING.md M README.md Log Message: ----------- Merge pull request #661 from VictorelPetrovich/patch-1 [ci skip] updated the link for Cuis community Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/959b8c524746...4e…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev January 2023