Vm-dev January 2023

vm-dev@lists.squeakfoundation.org

17 participants
74 discussions

VM Maker: VMMaker.oscog-eem.3299.mcz
by commits＠source.squeak.org 13 Jan '23

13 Jan '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3299.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3299 Author: eem Time: 13 January 2023, 2:24:26.105002 pm UUID: 35ad78ad-0942-4eac-8933-d519dee50a12 Ancestors: VMMaker.oscog-eem.3298 Add a useful comment to benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone to compare it to benchmarkFollowForwardersInStackZone. Here's the comparison, on a MacBook Pro (16-inch, 2021), Apple M1 Max, Cores: 10 (8 performance and 2 efficiency): 11.176 usecs average for ollowForwardersInStackZone 14.501 usecs average for followForwardingPointersOfReceiverAndTemporariesInStackZone And here's stats for jitting all of CompiledCode's methods: min max average 2.417 79.257 9.674 usecs to JIT 2 20 5.938 number of literals 1 106 17.464 number of bytecodes =============== Diff against VMMaker.oscog-eem.3298 =============== Item was changed: ----- Method: CoInterpreter class>>benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone (in category 'benchmarks') ----- benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone "Answer the elapsed time in microseconds for followForwardingPointersOfReceiverAndTemporariesInStackZone." | ticksPerMicrosecond | ticksPerMicrosecond := Time highResClockTicksPerMillisecond / 1000.0. ^self primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone / ticksPerMicrosecond + "self benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone" + "| goDeep | + goDeep := #defined. + goDeep := [:depth| | laurel hardy | + depth < 1 + ifTrue: + [laurel := OrderedCollection new. + hardy := laurel copy. + 10 timesRepeat: + [laurel add: self benchmarkFollowForwardersInStackZone. + hardy add: self benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone]. + { laurel. hardy } collect: [:stats| stats average roundTo: 0.001]] + ifFalse: + [goDeep value: depth - 1]]. + goDeep value: 1000"! - "self benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone"!

1 0

[OpenSmalltalk/opensmalltalk-vm] f88396: CogVM source as per VMMaker.oscog-eem.3298
by Eliot Miranda 13 Jan '23

13 Jan '23

Branch: refs/heads/virtend Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f8839669304932afd957b46907f7cb061f6e1e05 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f8839669304932afd9… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2023-01-13 (Fri, 13 Jan 2023) Changed paths: M src/spur32.cog/cogit.h M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.sista/cogit.h M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.sista/cogit.h M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3298 Fix a slip in followForwardingPointersOfReceiverAndTemporariesInStackZone, which has no business calling markAndTrace: :-)

1 0

[OpenSmalltalk/opensmalltalk-vm] 959b8c: CogVM source as per VMMaker.oscog-eem.3298
by Eliot Miranda 13 Jan '23

13 Jan '23

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 959b8c524746b49fb71029465bfe23c44aa9d6eb https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/959b8c524746b49fb7… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2023-01-13 (Fri, 13 Jan 2023) Changed paths: M src/spur32.cog/cogit.h M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.sista/cogit.h M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.sista/cogit.h M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3298 Fix a slip in followForwardingPointersOfReceiverAndTemporariesInStackZone, which has no business calling markAndTrace: :-)

1 0

VM Maker: VMMaker.oscog-eem.3298.mcz
by commits＠source.squeak.org 13 Jan '23

13 Jan '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3298.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3298 Author: eem Time: 13 January 2023, 1:46:48.324039 pm UUID: 835282e6-0e94-4101-a82d-46bd16786302 Ancestors: VMMaker.oscog-eem.3297 Add the benchmarks. Fix a slip in followForwardingPointersOfReceiverAndTemporariesInStackZone, which has no business calling markAndTrace: :-) =============== Diff against VMMaker.oscog-eem.3297 =============== Item was added: + ----- Method: CoInterpreter class>>benchmarkFollowForwardersInStackZone (in category 'benchmarks') ----- + benchmarkFollowForwardersInStackZone + "Answer the elapsed time in microseconds for followForwardingPointersInStackZone." + + | ticksPerMicrosecond | + ticksPerMicrosecond := Time highResClockTicksPerMillisecond / 1000.0. + ^self primitiveBenchmarkFollowForwardersInStackZone / ticksPerMicrosecond + + "self benchmarkFollowForwardersInStackZone"! Item was added: + ----- Method: CoInterpreter class>>benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone (in category 'benchmarks') ----- + benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone + "Answer the elapsed time in microseconds for followForwardingPointersOfReceiverAndTemporariesInStackZone." + + | ticksPerMicrosecond | + ticksPerMicrosecond := Time highResClockTicksPerMillisecond / 1000.0. + ^self primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone / ticksPerMicrosecond + + "self benchmarkFollowForwardingPointersOfReceiverAndTemporariesInStackZone"! Item was added: + ----- Method: CoInterpreter class>>primitiveBenchmarkFollowForwardersInStackZone (in category 'benchmarks') ----- + primitiveBenchmarkFollowForwardersInStackZone + "Answer the elapsed value of the high-performance clock for followForwardingPointersInStackZone" + + <primitive: 'primitiveBenchmarkFollowForwardersInStackZone' module: '' error: ec> + ^self primitiveFailed + + "self primitiveBenchmarkFollowForwardersInStackZone"! Item was added: + ----- Method: CoInterpreter class>>primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone (in category 'benchmarks') ----- + primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone + "Answer the elapsed value of the high-performance clock for followForwardingPointersOfReceiverAndTemporariesInStackZone" + + <primitive: 'primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone' module: '' error: ec> + ^self primitiveFailed + + "self primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone"! Item was changed: ----- Method: CoInterpreter>>followForwardingPointersOfReceiverAndTemporariesInStackZone (in category 'object memory support') ----- followForwardingPointersOfReceiverAndTemporariesInStackZone "A more thorough version of followForwardingPointersInStackZone that also follows all temporaries (but not stack contents after the temps). This would allow removal of the TempVectReadBarrier" <option: #VMBenchmarks> | theIPPtr | <inline: false> stackPage ifNil: "the system must be snapshotting; nothing to do..." [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. ^self]. self externalWriteBackHeadFramePointers. 0 to: numStackPages - 1 do: [:i| | thePage theSP theFP callerFP oop offset frameRcvrOffset methodHeader | thePage := stackPages stackPageAt: i. thePage isFree ifFalse: [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). theFP := thePage headFP. "Skip the instruction pointer on top of stack of inactive pages." theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. [self assert: (thePage addressIsInPage: theFP). self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). (self isMachineCodeFrame: theFP) ifTrue: [oop := stackPages longAt: theFP + FoxMFReceiver. (objectMemory isOopForwarded: oop) ifTrue: [stackPages longAt: theFP + FoxMFReceiver put: (objectMemory followForwarded: oop)]. self assert: (objectMemory isForwarded: (self mframeHomeMethod: theFP) methodObject) not. frameRcvrOffset := theFP + FoxMFReceiver. methodHeader := (self mframeHomeMethod: theFP) methodHeader] ifFalse: [oop := stackPages longAt: theFP + FoxIFReceiver. (objectMemory isOopForwarded: oop) ifTrue: [stackPages longAt: theFP + FoxIFReceiver put: (objectMemory followForwarded: oop)]. oop := self iframeMethod: theFP. (objectMemory isForwarded: oop) ifTrue: [| newOop | newOop := objectMemory followForwarded: oop. offset := newOop - oop. (theIPPtr notNil and: [(stackPages longAt: theIPPtr) > oop]) ifTrue: [stackPages longAt: theIPPtr put: (stackPages longAt: theIPPtr) + offset]. stackPages longAt: theFP + FoxIFSavedIP put: (stackPages longAt: theFP + FoxIFSavedIP) + offset. stackPages longAt: theFP + FoxMethod put: (oop := newOop)]. frameRcvrOffset := theFP + FoxIFReceiver. methodHeader := objectMemory methodHeaderOf: oop]. theSP := frameRcvrOffset - ((self temporaryCountOfMethodHeader: methodHeader) * objectMemory wordSize). [theSP <= frameRcvrOffset] whileTrue: [oop := stackPages longAt: theSP. (objectMemory isOopForwarded: oop) ifTrue: [oop := objectMemory followForwarded: oop. stackPages longAt: theSP put: oop]. - (objectMemory isImmediate: oop) ifFalse: - [objectMemory markAndTrace: oop]. theSP := theSP + objectMemory wordSize]. ((self frameHasContext: theFP) and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: [stackPages longAt: theFP + FoxThisContext put: (objectMemory followForwarded: (self frameContext: theFP))]. offset := self frameStackedReceiverOffset: theFP. oop := stackPages longAt: theFP + offset. (objectMemory isOopForwarded: oop) ifTrue: [stackPages longAt: theFP + offset put: (objectMemory followForwarded: oop)]. (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. theFP := callerFP]. "And finally follow the saved context and the caller context." theSP := thePage baseAddress - objectMemory wordSize. [theSP <= thePage baseAddress] whileTrue: [oop := stackPages longAt: theSP. (objectMemory isForwarded: oop) ifTrue: [stackPages longAt: theSP put: (objectMemory followForwarded: oop)]. theSP := theSP + objectMemory wordSize]]]! Item was added: + ----- Method: CompiledCode>>benchmarkJITReceiver (in category '*VMMaker-benchmarks') ----- + benchmarkJITReceiver + "Answer the elapsed time in microseconds to jit the receiver." + + | ticksPerMicrosecond | + ticksPerMicrosecond := Time highResClockTicksPerMillisecond / 1000.0. + ^self primitiveBenchmarkJITReceiver / ticksPerMicrosecond + + "| methods times nBytecodes nLiterals | + methods := self methodDict values. + times := methods collect: [:m| m benchmarkJITReceiver]. + nLiterals := methods collect: #numLiterals. + nBytecodes := methods collect: [:m| m isQuick ifTrue: [1] ifFalse: [m endPC - m initialPC + 1]]. + {times. nLiterals. nBytecodes} collect: [:stats| {stats min. stats max. stats average asFloat} collect: [:stat| stat roundTo: 0.001]]"! Item was added: + ----- Method: CompiledCode>>primitiveBenchmarkJITReceiver (in category '*VMMaker-benchmarks') ----- + primitiveBenchmarkJITReceiver + "Answer the elapsed value of the high-performance clock for jitting the receiver." + + <primitive: 'primitiveBenchmarkJITReceiver' module: '' error: ec> + ^self primitiveFailed + + "(self methodDict values collect: [:m| m primitiveBenchmarkJITReceiver]) asSet asArray sort"!

1 0

[OpenSmalltalk/opensmalltalk-vm] f185ad: CogVM source as per VMMaker.oscog-eem.3297/Balloon...
by Eliot Miranda 13 Jan '23

13 Jan '23

Branch: refs/heads/virtend Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: f185ad87ad2fe97cc5ba61929b1f0cbac07583e8 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/f185ad87ad2fe97cc5… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2023-01-13 (Fri, 13 Jan 2023) Changed paths: M src/plugins/CroquetPlugin/CroquetPlugin.c M src/plugins/Squeak3D/Squeak3D.c M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cogitARMv5.c M src/spur32.cog.lowcode/cogitIA32.c M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogit.h M src/spur32.cog/cogitARMv5.c M src/spur32.cog/cogitIA32.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogit.h M src/spur32.sista/cogitARMv5.c M src/spur32.sista/cogitIA32.c M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cogitARMv8.c M src/spur64.cog.lowcode/cogitX64SysV.c M src/spur64.cog.lowcode/cogitX64WIN64.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cogitARMv8.c M src/spur64.cog/cogitX64SysV.c M src/spur64.cog/cogitX64WIN64.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogit.h M src/spur64.sista/cogitARMv8.c M src/spur64.sista/cogitX64SysV.c M src/spur64.sista/cogitX64WIN64.c M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cogit.h M src/v3.cog/cogitARMv5.c M src/v3.cog/cogitIA32.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3297/Balloon3D-Plugins-eem.20 Include a small suite of VM benchmark primitives to measure the time taken by operations that are too short-lived to want to time them (because timing can have significant overhead). Add an abstraction for identifying full block methods and use it in asserts. Refactor followForwardingPointersInStackZone: to followForwardingPointersInStackZone since it makes no use of the becomeEffectFlags argument. Make sure all uses of cloneObject: in plugins test the result appropriately. Make sure the head frame pointers are written back when cloning a context in primitiveClone. Simplify the TempVectReadBarrier testing in Stack/CoInterpreter, adding one method and deleting four, and testing TempVectReadBarrier in a single method only (albeit one that is overridden in CoInterpreter). Given that better forwarding machinery was written over time, use a slightly better form for dealing with potential forwarding in the pushFullClosure bytecode, and neaten StackInterpreter>>pushLiteralVariable:/storeLiteralVariable:withValue: to use it.

1 0

[OpenSmalltalk/opensmalltalk-vm] 143b72: CogVM source as per VMMaker.oscog-eem.3297/Balloon...
by Eliot Miranda 13 Jan '23

13 Jan '23

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 143b725584f080a045c7f2cff88a58978f650620 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/143b725584f080a045… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2023-01-13 (Fri, 13 Jan 2023) Changed paths: M src/plugins/CroquetPlugin/CroquetPlugin.c M src/plugins/Squeak3D/Squeak3D.c M src/spur32.cog.lowcode/cogit.h M src/spur32.cog.lowcode/cogitARMv5.c M src/spur32.cog.lowcode/cogitIA32.c M src/spur32.cog.lowcode/cointerp.c M src/spur32.cog.lowcode/cointerp.h M src/spur32.cog.lowcode/gcc3x-cointerp.c M src/spur32.cog/cogit.h M src/spur32.cog/cogitARMv5.c M src/spur32.cog/cogitIA32.c M src/spur32.cog/cointerp.c M src/spur32.cog/cointerp.h M src/spur32.cog/cointerpmt.c M src/spur32.cog/cointerpmt.h M src/spur32.cog/gcc3x-cointerp.c M src/spur32.cog/gcc3x-cointerpmt.c M src/spur32.sista/cogit.h M src/spur32.sista/cogitARMv5.c M src/spur32.sista/cogitIA32.c M src/spur32.sista/cointerp.c M src/spur32.sista/cointerp.h M src/spur32.sista/gcc3x-cointerp.c M src/spur32.stack.lowcode/gcc3x-interp.c M src/spur32.stack.lowcode/interp.c M src/spur32.stack/gcc3x-interp.c M src/spur32.stack/interp.c M src/spur32.stack/validImage.c M src/spur64.cog.lowcode/cogit.h M src/spur64.cog.lowcode/cogitARMv8.c M src/spur64.cog.lowcode/cogitX64SysV.c M src/spur64.cog.lowcode/cogitX64WIN64.c M src/spur64.cog.lowcode/cointerp.c M src/spur64.cog.lowcode/cointerp.h M src/spur64.cog.lowcode/gcc3x-cointerp.c M src/spur64.cog/cogit.h M src/spur64.cog/cogitARMv8.c M src/spur64.cog/cogitX64SysV.c M src/spur64.cog/cogitX64WIN64.c M src/spur64.cog/cointerp.c M src/spur64.cog/cointerp.h M src/spur64.cog/cointerpmt.c M src/spur64.cog/cointerpmt.h M src/spur64.cog/gcc3x-cointerp.c M src/spur64.cog/gcc3x-cointerpmt.c M src/spur64.sista/cogit.h M src/spur64.sista/cogitARMv8.c M src/spur64.sista/cogitX64SysV.c M src/spur64.sista/cogitX64WIN64.c M src/spur64.sista/cointerp.c M src/spur64.sista/cointerp.h M src/spur64.sista/gcc3x-cointerp.c M src/spur64.stack.lowcode/gcc3x-interp.c M src/spur64.stack.lowcode/interp.c M src/spur64.stack/gcc3x-interp.c M src/spur64.stack/interp.c M src/spur64.stack/validImage.c M src/v3.cog/cogit.h M src/v3.cog/cogitARMv5.c M src/v3.cog/cogitIA32.c M src/v3.cog/cointerp.c M src/v3.cog/cointerp.h M src/v3.cog/gcc3x-cointerp.c M src/v3.stack/gcc3x-interp.c M src/v3.stack/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.3297/Balloon3D-Plugins-eem.20 Include a small suite of VM benchmark primitives to measure the time taken by operations that are too short-lived to want to time them (because timing can have significant overhead). Add an abstraction for identifying full block methods and use it in asserts. Refactor followForwardingPointersInStackZone: to followForwardingPointersInStackZone since it makes no use of the becomeEffectFlags argument. Make sure all uses of cloneObject: in plugins test the result appropriately. Make sure the head frame pointers are written back when cloning a context in primitiveClone. Simplify the TempVectReadBarrier testing in Stack/CoInterpreter, adding one method and deleting four, and testing TempVectReadBarrier in a single method only (albeit one that is overridden in CoInterpreter). Given that better forwarding machinery was written over time, use a slightly better form for dealing with potential forwarding in the pushFullClosure bytecode, and neaten StackInterpreter>>pushLiteralVariable:/storeLiteralVariable:withValue: to use it.

1 0

VM Maker: VMMaker.oscog-eem.3297.mcz
by commits＠source.squeak.org 13 Jan '23

13 Jan '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3297.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3297 Author: eem Time: 13 January 2023, 12:20:47.721672 pm UUID: 052ff1ab-c36e-496e-9d02-5c15f1bd3b1b Ancestors: VMMaker.oscog-eem.3296 Oops! Use the right API for freeing teh generated method in primitiveBenchmarkJITReceiver =============== Diff against VMMaker.oscog-eem.3296 =============== Item was changed: ----- Method: CoInterpreterPrimitives>>primitiveBenchmarkJITReceiver (in category 'benchmark primitives') ----- primitiveBenchmarkJITReceiver <option: #VMBenchmarks> <option: #SistaV1BytecodeSet> <export: true> | receiverMethod cloneMethod | receiverMethod := self stackTop. (objectMemory isOopCompiledMethod: receiverMethod) ifFalse: [^self primitiveFailFor: PrimErrBadReceiver]. (self isFullBlockMethod: receiverMethod) ifTrue: [^self primitiveFailFor: PrimErrUnsupported]. cloneMethod := objectMemory cloneObject: receiverMethod. cloneMethod ifNil: [^self primitiveFailFor: PrimErrNoMemory]. self primitiveReturnTimeTakenFor: [(cogit cog: cloneMethod selector: (self maybeSelectorOfMethod: cloneMethod)) ifNil: [^self primitiveFailFor: PrimErrOperationFailed]. + cogit freeCogMethod: (self cogMethodOf: cloneMethod)]! - cogit freeMethod: (self cogMethodOf: cloneMethod)]!

1 0

VM Maker: VMMaker.oscog-eem.3296.mcz
by commits＠source.squeak.org 13 Jan '23

13 Jan '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3296.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3296 Author: eem Time: 13 January 2023, 12:17:25.933827 pm UUID: 5669e2ed-ee0c-4eff-8d0c-db34220135d2 Ancestors: VMMaker.oscog-eem.3295 Include a small suite of VM benchmark primitives to measure the time taken by operations that are too short-lived to want to time them (because timing can have significant overhead). Add an abstraction for identifying full block methods and use it in some asserts, etc. Refactor followForwardingPointersInStackZone: to followForwardingPointersInStackZone since it makes no use of the becomeEffectFlags argument. =============== Diff against VMMaker.oscog-eem.3295 =============== Item was added: + ----- Method: CoInterpreter>>followForwardingPointersInStackZone (in category 'object memory support') ----- + followForwardingPointersInStackZone + "Spur's become: is lazy, turning the becommed object into a forwarding object to the other. + The read-barrier is minimised by arranging that forwarding pointers will fail a method cache + probe, since notionally objects' internals are accessed only via sending messages to them, + the exception is primitives that access the internals of the non-receiver argument(s). + + To avoid a read barrier on bytecode, literal and inst var fetch and non-local return, we scan + the receivers (including the stacked receiver for non-local return) and method references + in the stack zone and follow any forwarded ones. This is of course way cheaper than + scanning all of memory as in the old become. + + Override to handle machine code frames" + | theIPPtr | + <inline: false> + + stackPage ifNil: "the system must be snapshotting; nothing to do..." + [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). + self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. + ^self]. + + self externalWriteBackHeadFramePointers. + + 0 to: numStackPages - 1 do: + [:i| | thePage theSP theFP callerFP oop offset | + thePage := stackPages stackPageAt: i. + thePage isFree ifFalse: + [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). + theFP := thePage headFP. + "Skip the instruction pointer on top of stack of inactive pages." + theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. + [self assert: (thePage addressIsInPage: theFP). + self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). + (self isMachineCodeFrame: theFP) + ifTrue: + [oop := stackPages longAt: theFP + FoxMFReceiver. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + FoxMFReceiver + put: (objectMemory followForwarded: oop)]. + self assert: (objectMemory isForwarded: (self mframeHomeMethod: theFP) methodObject) not] + ifFalse: + [oop := stackPages longAt: theFP + FoxIFReceiver. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + FoxIFReceiver + put: (objectMemory followForwarded: oop)]. + oop := self iframeMethod: theFP. + (objectMemory isForwarded: oop) ifTrue: + [| newOop | + newOop := objectMemory followForwarded: oop. + offset := newOop - oop. + (theIPPtr notNil + and: [(stackPages longAt: theIPPtr) > oop]) ifTrue: + [stackPages + longAt: theIPPtr + put: (stackPages longAt: theIPPtr) + offset]. + stackPages + longAt: theFP + FoxIFSavedIP + put: (stackPages longAt: theFP + FoxIFSavedIP) + offset. + stackPages + longAt: theFP + FoxMethod + put: (oop := newOop)]]. + ((self frameHasContext: theFP) + and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: + [stackPages + longAt: theFP + FoxThisContext + put: (objectMemory followForwarded: (self frameContext: theFP))]. + offset := self frameStackedReceiverOffset: theFP. + oop := stackPages longAt: theFP + offset. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + offset + put: (objectMemory followForwarded: oop)]. + (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: + [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. + theFP := callerFP]. + "And finally follow the saved context and the caller context." + theSP := thePage baseAddress - objectMemory wordSize. + [theSP <= thePage baseAddress] whileTrue: + [oop := stackPages longAt: theSP. + (objectMemory isForwarded: oop) ifTrue: + [stackPages longAt: theSP put: (objectMemory followForwarded: oop)]. + theSP := theSP + objectMemory wordSize]]]! Item was removed: - ----- Method: CoInterpreter>>followForwardingPointersInStackZone: (in category 'object memory support') ----- - followForwardingPointersInStackZone: theBecomeEffectsFlags - "Spur's become: is lazy, turning the becommed object into a forwarding object to the other. - The read-barrier is minimised by arranging that forwarding pointers will fail a method cache - probe, since notionally objects' internals are accessed only via sending messages to them, - the exception is primitives that access the internals of the non-receiver argument(s). - - To avoid a read barrier on bytecode, literal and inst var fetch and non-local return, we scan - the receivers (including the stacked receiver for non-local return) and method references - in the stack zone and follow any forwarded ones. This is of course way cheaper than - scanning all of memory as in the old become. - - Override to handle machine code frames" - | theIPPtr | - <inline: false> - - stackPage ifNil: "the system must be snapshotting; nothing to do..." - [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). - self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. - ^self]. - - self externalWriteBackHeadFramePointers. - - 0 to: numStackPages - 1 do: - [:i| | thePage theSP theFP callerFP oop offset | - thePage := stackPages stackPageAt: i. - thePage isFree ifFalse: - [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). - theFP := thePage headFP. - "Skip the instruction pointer on top of stack of inactive pages." - theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. - [self assert: (thePage addressIsInPage: theFP). - self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). - (self isMachineCodeFrame: theFP) - ifTrue: - [oop := stackPages longAt: theFP + FoxMFReceiver. - (objectMemory isOopForwarded: oop) ifTrue: - [stackPages - longAt: theFP + FoxMFReceiver - put: (objectMemory followForwarded: oop)]. - self assert: (objectMemory isForwarded: (self mframeHomeMethod: theFP) methodObject) not] - ifFalse: - [oop := stackPages longAt: theFP + FoxIFReceiver. - (objectMemory isOopForwarded: oop) ifTrue: - [stackPages - longAt: theFP + FoxIFReceiver - put: (objectMemory followForwarded: oop)]. - oop := self iframeMethod: theFP. - (objectMemory isForwarded: oop) ifTrue: - [| newOop | - newOop := objectMemory followForwarded: oop. - offset := newOop - oop. - (theIPPtr notNil - and: [(stackPages longAt: theIPPtr) > oop]) ifTrue: - [stackPages - longAt: theIPPtr - put: (stackPages longAt: theIPPtr) + offset]. - stackPages - longAt: theFP + FoxIFSavedIP - put: (stackPages longAt: theFP + FoxIFSavedIP) + offset. - stackPages - longAt: theFP + FoxMethod - put: (oop := newOop)]]. - ((self frameHasContext: theFP) - and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: - [stackPages - longAt: theFP + FoxThisContext - put: (objectMemory followForwarded: (self frameContext: theFP))]. - offset := self frameStackedReceiverOffset: theFP. - oop := stackPages longAt: theFP + offset. - (objectMemory isOopForwarded: oop) ifTrue: - [stackPages - longAt: theFP + offset - put: (objectMemory followForwarded: oop)]. - (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: - [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. - theFP := callerFP]. - "And finally follow the saved context and the caller context." - theSP := thePage baseAddress - objectMemory wordSize. - [theSP <= thePage baseAddress] whileTrue: - [oop := stackPages longAt: theSP. - (objectMemory isForwarded: oop) ifTrue: - [stackPages longAt: theSP put: (objectMemory followForwarded: oop)]. - theSP := theSP + objectMemory wordSize]]]! Item was added: + ----- Method: CoInterpreter>>followForwardingPointersOfReceiverAndTemporariesInStackZone (in category 'object memory support') ----- + followForwardingPointersOfReceiverAndTemporariesInStackZone + "A more thorough version of followForwardingPointersInStackZone that also follows all temporaries (but not stack contents after the temps). + This would allow removal of the TempVectReadBarrier" + <option: #VMBenchmarks> + | theIPPtr | + <inline: false> + + stackPage ifNil: "the system must be snapshotting; nothing to do..." + [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). + self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. + ^self]. + + self externalWriteBackHeadFramePointers. + + 0 to: numStackPages - 1 do: + [:i| | thePage theSP theFP callerFP oop offset frameRcvrOffset methodHeader | + thePage := stackPages stackPageAt: i. + thePage isFree ifFalse: + [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). + theFP := thePage headFP. + "Skip the instruction pointer on top of stack of inactive pages." + theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. + [self assert: (thePage addressIsInPage: theFP). + self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). + (self isMachineCodeFrame: theFP) + ifTrue: + [oop := stackPages longAt: theFP + FoxMFReceiver. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + FoxMFReceiver + put: (objectMemory followForwarded: oop)]. + self assert: (objectMemory isForwarded: (self mframeHomeMethod: theFP) methodObject) not. + frameRcvrOffset := theFP + FoxMFReceiver. + methodHeader := (self mframeHomeMethod: theFP) methodHeader] + ifFalse: + [oop := stackPages longAt: theFP + FoxIFReceiver. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + FoxIFReceiver + put: (objectMemory followForwarded: oop)]. + oop := self iframeMethod: theFP. + (objectMemory isForwarded: oop) ifTrue: + [| newOop | + newOop := objectMemory followForwarded: oop. + offset := newOop - oop. + (theIPPtr notNil + and: [(stackPages longAt: theIPPtr) > oop]) ifTrue: + [stackPages + longAt: theIPPtr + put: (stackPages longAt: theIPPtr) + offset]. + stackPages + longAt: theFP + FoxIFSavedIP + put: (stackPages longAt: theFP + FoxIFSavedIP) + offset. + stackPages + longAt: theFP + FoxMethod + put: (oop := newOop)]. + frameRcvrOffset := theFP + FoxIFReceiver. + methodHeader := objectMemory methodHeaderOf: oop]. + theSP := frameRcvrOffset - ((self temporaryCountOfMethodHeader: methodHeader) * objectMemory wordSize). + [theSP <= frameRcvrOffset] whileTrue: + [oop := stackPages longAt: theSP. + (objectMemory isOopForwarded: oop) ifTrue: + [oop := objectMemory followForwarded: oop. + stackPages longAt: theSP put: oop]. + (objectMemory isImmediate: oop) ifFalse: + [objectMemory markAndTrace: oop]. + theSP := theSP + objectMemory wordSize]. + + ((self frameHasContext: theFP) + and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: + [stackPages + longAt: theFP + FoxThisContext + put: (objectMemory followForwarded: (self frameContext: theFP))]. + offset := self frameStackedReceiverOffset: theFP. + oop := stackPages longAt: theFP + offset. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + offset + put: (objectMemory followForwarded: oop)]. + (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: + [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. + theFP := callerFP]. + "And finally follow the saved context and the caller context." + theSP := thePage baseAddress - objectMemory wordSize. + [theSP <= thePage baseAddress] whileTrue: + [oop := stackPages longAt: theSP. + (objectMemory isForwarded: oop) ifTrue: + [stackPages longAt: theSP put: (objectMemory followForwarded: oop)]. + theSP := theSP + objectMemory wordSize]]]! Item was added: + ----- Method: CoInterpreter>>isFullBlockMethod: (in category 'compiled methods') ----- + isFullBlockMethod: aMethodObj + "Answer if the argument is a full block method or not. Full block methods + (as introduced by the SistaV1BytecodeSet) are used to implement block + closures and have a reference to their enclosing block or method as their + last literal. Compiled methods have a class association as their last literal." + <api> + <inline: false> + ^objectMemory isOopCompiledMethod: (self ultimateLiteralOf: aMethodObj)! Item was changed: + ----- Method: CoInterpreter>>markAndTraceMachineCodeMethod: (in category 'object memory support') ----- - ----- Method: CoInterpreter>>markAndTraceMachineCodeMethod: (in category 'gc -- mark and sweep') ----- markAndTraceMachineCodeMethod: aCogMethod <var: #aCogMethod type: #'CogBlockMethod *'> | homeMethod | <var: #homeMethod type: #'CogMethod *'> homeMethod := self asCogHomeMethod: aCogMethod. objectMemory markAndTrace: homeMethod methodObject! Item was added: + ----- Method: CoInterpreterPrimitives>>primitiveBenchmarkFollowForwardersInStackZone (in category 'benchmark primitives') ----- + primitiveBenchmarkFollowForwardersInStackZone + <option: #VMBenchmarks> + <export: true> + self primitiveReturnTimeTakenFor: + [self followForwardingPointersInStackZone]! Item was added: + ----- Method: CoInterpreterPrimitives>>primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone (in category 'benchmark primitives') ----- + primitiveBenchmarkFollowForwardersOfReceiverAndTemporariesInStackZone + <option: #VMBenchmarks> + <export: true> + self primitiveReturnTimeTakenFor: + [self followForwardingPointersOfReceiverAndTemporariesInStackZone]! Item was added: + ----- Method: CoInterpreterPrimitives>>primitiveBenchmarkJITReceiver (in category 'benchmark primitives') ----- + primitiveBenchmarkJITReceiver + <option: #VMBenchmarks> + <option: #SistaV1BytecodeSet> + <export: true> + | receiverMethod cloneMethod | + receiverMethod := self stackTop. + (objectMemory isOopCompiledMethod: receiverMethod) ifFalse: + [^self primitiveFailFor: PrimErrBadReceiver]. + (self isFullBlockMethod: receiverMethod) ifTrue: + [^self primitiveFailFor: PrimErrUnsupported]. + cloneMethod := objectMemory cloneObject: receiverMethod. + cloneMethod ifNil: + [^self primitiveFailFor: PrimErrNoMemory]. + self primitiveReturnTimeTakenFor: + [(cogit cog: cloneMethod selector: (self maybeSelectorOfMethod: cloneMethod)) ifNil: + [^self primitiveFailFor: PrimErrOperationFailed]. + cogit freeMethod: (self cogMethodOf: cloneMethod)]! Item was added: + ----- Method: CoInterpreterPrimitives>>primitiveReturnTimeTakenFor: (in category 'benchmark primitives') ----- + primitiveReturnTimeTakenFor: aBlock + <option: #VMBenchmarks> + <inline: #always> + | then | + <var: 'then' type: #usqLong> + then := self ioHighResClock. + aBlock value. + self methodReturnValue: (self positive64BitIntegerFor: self ioHighResClock - then)! Item was changed: ----- Method: Cogit>>cog:selector: (in category 'jit - api') ----- cog: aMethodObj selector: aSelectorOop "Attempt to produce a machine code method for the bytecode method object aMethodObj. N.B. If there is no code memory available do *NOT* attempt to reclaim the method zone. Certain clients (e.g. ceSICMiss:) depend on the zone remaining constant across method generation." <api> <returnTypeC: #'CogMethod *'> | selector cogMethod | <var: #cogMethod type: #'CogMethod *'> (self exclude: aMethodObj selector: aSelectorOop) ifTrue: [^nil]. "In Newspeak we support anonymous accessors and hence tolerate the same method being cogged multiple times. But only if the method class association is nil." NewspeakVM ifTrue: [(coInterpreter methodHasCogMethod: aMethodObj) ifTrue: [cogMethod := coInterpreter cogMethodOf: aMethodObj. self deny: cogMethod selector = aSelectorOop. cogMethod selector = aSelectorOop ifTrue: [^cogMethod]. (coInterpreter methodClassAssociationOf: aMethodObj) ~= objectMemory nilObject ifTrue: [self cCode: 'extern void *firstIndexableField(sqInt)'. "Slang, au natural" self warnMultiple: cogMethod selectors: aSelectorOop. ^nil]]] ifFalse: [self deny: (coInterpreter methodHasCogMethod: aMethodObj)]. selector := aSelectorOop = objectMemory nilObject ifTrue: [coInterpreter maybeSelectorOfMethod: aMethodObj] ifFalse: [aSelectorOop]. "coInterpreter stringOf: selector" selector ifNotNil: [coInterpreter compilationBreakpoint: selector isMNUCase: false]. aMethodObj = breakMethod ifTrue: [self halt: 'Compilation of breakMethod']. NewspeakVM ifTrue: [cogMethod := methodZone findPreviouslyCompiledVersionOf: aMethodObj with: aSelectorOop. cogMethod ifNotNil: [(coInterpreter methodHasCogMethod: aMethodObj) not ifTrue: [self assert: (coInterpreter rawHeaderOf: aMethodObj) = cogMethod methodHeader. cogMethod methodObject: aMethodObj. coInterpreter rawHeaderOf: aMethodObj put: cogMethod asInteger]. ^cogMethod]]. objectRepresentation ensureNoForwardedLiteralsIn: aMethodObj. "If the generators for the alternate bytecode set are missing then interpret." (coInterpreter methodUsesAlternateBytecodeSet: aMethodObj) ifTrue: [(self numElementsIn: generatorTable) <= 256 ifTrue: [^nil]. bytecodeSetOffset := 256] ifFalse: [bytecodeSetOffset := 0]. + self deny: (coInterpreter isFullBlockMethod: aMethodObj). - self deny: (objectMemory isOopCompiledMethod: (coInterpreter ultimateLiteralOf: aMethodObj)). methodObj := aMethodObj. methodHeader := objectMemory methodHeaderOf: aMethodObj. receiverTags := -1. "lazy initialization" cogMethod := self compileCogMethod: aSelectorOop. (cogMethod asInteger between: MaxNegativeErrorCode and: -1) ifTrue: [cogMethod asInteger = InsufficientCodeSpace ifTrue: [coInterpreter callForCogCompiledCodeCompaction]. self maybeFreeCounters. "Right now no errors should be reported, so nothing more to do." "self reportError: (self cCoerceSimple: cogMethod to: #sqInt)." ^nil]. "self cCode: '' inSmalltalk: [coInterpreter printCogMethod: cogMethod. ""coInterpreter symbolicMethod: aMethodObj."" self assertValidMethodMap: cogMethod." "self disassembleMethod: cogMethod." "printInstructions := clickConfirm := true""]." ^cogMethod! Item was changed: ----- Method: Cogit>>cogFullBlockMethod:numCopied: (in category 'jit - api') ----- cogFullBlockMethod: aMethodObj numCopied: numCopied "Attempt to produce a machine code method for the bytecode method object aMethodObj. N.B. If there is no code memory available do *NOT* attempt to reclaim the method zone. Certain clients (e.g. ceSICMiss:) depend on the zone remaining constant across method generation." <api> <option: #SistaV1BytecodeSet> <returnTypeC: #'CogMethod *'> | cogMethod | <var: #cogMethod type: #'CogMethod *'> (self exclude: aMethodObj) ifTrue: [^nil]. self deny: (coInterpreter methodHasCogMethod: aMethodObj). aMethodObj = breakMethod ifTrue: [self halt: 'Compilation of breakMethod']. objectRepresentation ensureNoForwardedLiteralsIn: aMethodObj. "If the generators for the alternate bytecode set are missing then interpret." (coInterpreter methodUsesAlternateBytecodeSet: aMethodObj) ifTrue: [(self numElementsIn: generatorTable) <= 256 ifTrue: [^nil]. bytecodeSetOffset := 256] ifFalse: [bytecodeSetOffset := 0]. + self assert: (coInterpreter isFullBlockMethod: aMethodObj). - self assert: (objectMemory isOopCompiledMethod: (coInterpreter ultimateLiteralOf: aMethodObj)). methodObj := aMethodObj. methodHeader := objectMemory methodHeaderOf: aMethodObj. receiverTags := -1. "lazy initialization" cogMethod := self compileCogFullBlockMethod: numCopied. (cogMethod asInteger between: MaxNegativeErrorCode and: -1) ifTrue: [cogMethod asInteger = InsufficientCodeSpace ifTrue: [coInterpreter callForCogCompiledCodeCompaction]. self maybeFreeCounters. "Right now no errors should be reported, so nothing more to do." "self reportError: (self cCoerceSimple: cogMethod to: #sqInt)." ^nil]. "self cCode: '' inSmalltalk: [coInterpreter printCogMethod: cogMethod. ""coInterpreter symbolicMethod: aMethodObj."" self assertValidMethodMap: cogMethod." "self disassembleMethod: cogMethod." "printInstructions := clickConfirm := true""]." ^cogMethod! Item was added: + ----- Method: StackInterpreter>>followForwardingPointersInStackZone (in category 'object memory support') ----- + followForwardingPointersInStackZone + "Spur's become: is lazy, turning the becommed object into a forwarding object to the other. + The read-barrier is minimised by arranging that forwarding pointers will fail a method cache + probe, since notionally objects' internals are accessed only via sending messages to them, + the exception is primitives that access the internals of the non-receiver argument(s). + + To avoid a read barrier on bytecode, literal and inst var fetch and non-local return, we scan + the receivers (including the stacked receiver for non-local return) and method references + in the stack zone and follow any forwarded ones. This is of course way cheaper than + scanning all of memory as in the old become." + | theIPPtr | + <inline: false> + + stackPage ifNil: "the system must be snapshotting; nothing to do..." + [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). + self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. + ^self]. + + self externalWriteBackHeadFramePointers. + + 0 to: numStackPages - 1 do: + [:i| | thePage theFP callerFP offset oop | + thePage := stackPages stackPageAt: i. + thePage isFree ifFalse: + [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). + theFP := thePage headFP. + "Skip the instruction pointer on top of stack of inactive pages." + theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. + [self assert: (thePage addressIsInPage: theFP). + self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). + oop := stackPages longAt: theFP + FoxReceiver. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + FoxReceiver + put: (objectMemory followForwarded: oop)]. + ((self frameHasContext: theFP) + and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: + [stackPages + longAt: theFP + FoxThisContext + put: (objectMemory followForwarded: (self frameContext: theFP))]. + oop := self frameMethod: theFP. + (objectMemory isForwarded: oop) ifTrue: + [| newOop delta | + newOop := objectMemory followForwarded: oop. + theIPPtr ifNotNil: + [self assert: (stackPages longAt: theIPPtr) > (self frameMethod: theFP). + delta := newOop - oop. + stackPages + longAt: theIPPtr + put: (stackPages longAt: theIPPtr) + delta]. + stackPages + longAt: theFP + FoxMethod + put: (oop := newOop)]. + offset := self frameStackedReceiverOffset: theFP. + oop := stackPages longAt: theFP + offset. + (objectMemory isOopForwarded: oop) ifTrue: + [stackPages + longAt: theFP + offset + put: (objectMemory followForwarded: oop)]. + (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: + [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. + theFP := callerFP]. + "And finally follow the caller context." + self assert: theFP = thePage baseFP. + oop := self frameCallerContext: theFP. + (objectMemory isForwarded: oop) ifTrue: + [self frameCallerContext: theFP put: (objectMemory followForwarded: oop)]]]! Item was removed: - ----- Method: StackInterpreter>>followForwardingPointersInStackZone: (in category 'object memory support') ----- - followForwardingPointersInStackZone: theBecomeEffectsFlags - "Spur's become: is lazy, turning the becommed object into a forwarding object to the other. - The read-barrier is minimised by arranging that forwarding pointers will fail a method cache - probe, since notionally objects' internals are accessed only via sending messages to them, - the exception is primitives that access the internals of the non-receiver argument(s). - - To avoid a read barrier on bytecode, literal and inst var fetch and non-local return, we scan - the receivers (including the stacked receiver for non-local return) and method references - in the stack zone and follow any forwarded ones. This is of course way cheaper than - scanning all of memory as in the old become." - | theIPPtr | - <inline: false> - - stackPage ifNil: "the system must be snapshotting; nothing to do..." - [self assert: (stackPages mostRecentlyUsedPage isNil or: [stackPages mostRecentlyUsedPage isFree]). - self cCode: [] inSmalltalk: [self assert: stackPages allPagesFree]. - ^self]. - - self externalWriteBackHeadFramePointers. - - 0 to: numStackPages - 1 do: - [:i| | thePage theFP callerFP offset oop | - thePage := stackPages stackPageAt: i. - thePage isFree ifFalse: - [self assert: (self ifCurrentStackPageHasValidHeadPointers: thePage). - theFP := thePage headFP. - "Skip the instruction pointer on top of stack of inactive pages." - theIPPtr := thePage = stackPage ifFalse: [thePage headSP asUnsignedInteger]. - [self assert: (thePage addressIsInPage: theFP). - self assert: (theIPPtr isNil or: [thePage addressIsInPage: theIPPtr asVoidPointer]). - oop := stackPages longAt: theFP + FoxReceiver. - (objectMemory isOopForwarded: oop) ifTrue: - [stackPages - longAt: theFP + FoxReceiver - put: (objectMemory followForwarded: oop)]. - ((self frameHasContext: theFP) - and: [(objectMemory isForwarded: (self frameContext: theFP))]) ifTrue: - [stackPages - longAt: theFP + FoxThisContext - put: (objectMemory followForwarded: (self frameContext: theFP))]. - oop := self frameMethod: theFP. - (objectMemory isForwarded: oop) ifTrue: - [| newOop delta | - newOop := objectMemory followForwarded: oop. - theIPPtr ifNotNil: - [self assert: (stackPages longAt: theIPPtr) > (self frameMethod: theFP). - delta := newOop - oop. - stackPages - longAt: theIPPtr - put: (stackPages longAt: theIPPtr) + delta]. - stackPages - longAt: theFP + FoxMethod - put: (oop := newOop)]. - offset := self frameStackedReceiverOffset: theFP. - oop := stackPages longAt: theFP + offset. - (objectMemory isOopForwarded: oop) ifTrue: - [stackPages - longAt: theFP + offset - put: (objectMemory followForwarded: oop)]. - (callerFP := self frameCallerFP: theFP) ~= 0] whileTrue: - [theIPPtr := (theFP + FoxCallerSavedIP) asUnsignedInteger. - theFP := callerFP]. - "And finally follow the caller context." - self assert: theFP = thePage baseFP. - oop := self frameCallerContext: theFP. - (objectMemory isForwarded: oop) ifTrue: - [self frameCallerContext: theFP put: (objectMemory followForwarded: oop)]]]! Item was changed: ----- Method: StackInterpreter>>spurPostBecomeAction: (in category 'object memory support') ----- spurPostBecomeAction: theBecomeEffectsFlags "Insulate the stack zone from the effects of a become. All receivers must be unfollowed for two reasons: 1. inst var access is direct with no read barrier 2. super sends (always to the receiver) have no class check and so don't trap for forwarded receivers. This is an issue for primitives that assume their receiver is valid and don't validate. Super sends require an explicit check to ensure receivers in super sends are unforwarded. e.g. super doSomethingWith: (self become: other) forwards the receiver self pushed on the stack. So we could avoid following non-pointer receivers. But this is too tricky, Instead, we always follow receivers. Methods must be unfollowed since bytecode access is direct with no read barrier. But this only needs to be done if the becomeEffectsFlags indicate that a CompiledMethod was becommed. The scheduler state must be followed, but only if the becomeEffectsFlags indicate that a pointer object was becommed." <option: #SpurObjectMemory> <inline: false> "For VM profiling" self flushAtCache. theBecomeEffectsFlags ~= 0 ifTrue: [(theBecomeEffectsFlags anyMask: BecameActiveClassFlag) ifTrue: [self flushBecommedClassesInMethodCache]. (theBecomeEffectsFlags anyMask: BecamePointerObjectFlag) ifTrue: [self followForwardingPointersInScheduler. self followForwardingPointersInSpecialObjectsArray]. (theBecomeEffectsFlags anyMask: BecamePointerObjectFlag + BecameCompiledMethodFlag) ifTrue: [self followForwardingPointersInProfileState. (theBecomeEffectsFlags anyMask: BecameCompiledMethodFlag) ifTrue: [self followForwardedMethodsInMethodCache. self followMethodNewMethodAndInstructionPointer]]]. + self followForwardingPointersInStackZone! - self followForwardingPointersInStackZone: theBecomeEffectsFlags! Item was changed: ----- Method: VMBasicConstants class>>nonUnderscoreNamesDefinedAtCompileTime (in category 'C translation') ----- nonUnderscoreNamesDefinedAtCompileTime "Answer the set of names for variables that should be defined at compile time (excepting those that begin with underscore, which we assume are defined at compile time). Some of these get default values during simulation, and hence get defaulted in the various initializeMiscConstants methods. But that they have values should /not/ cause the code generator to do dead code elimination based on their default values. In particular, methods marked with <option: ANameDefinedAtCompileTime> will be emitted within #if defined(ANameDefinedAtCompileTime)...#endif. And of course this is backwards. We'd like to define names that are defined at translation time. But doing so would entail defining (or referencing) hundreds of class and pool variables. This way is marginally more manageable." ^#(VMBIGENDIAN IMMUTABILITY STACKVM COGVM COGMTVM SPURVM PharoVM "Pharo vs Squeak" + TerfVM VM_TICKER "Terf vs Squeak & Qwaq/Teleplace/Terf/Virtend high-priority thread support" + VMBenchmarks "Primitives to measure the duration of fleeting operations" - TerfVM VM_TICKER "Terf vs Squeak & Qwaq/Teleplace/Terf high-priority thread support" EnforceAccessControl "Newspeak" CheckRememberedInTrampoline "IMMUTABILITY" BIT_IDENTICAL_FLOATING_POINT PLATFORM_SPECIFIC_FLOATING_POINT "Alternatives for using fdlibm for floating-point" + ITIMER_HEARTBEAT "older linux's woultn't allow a higher priority thread, hence no threaded heartbeat." - ITIMER_HEARTBEAT "older linux's woultn't allow a higher priority thread, hence no threaded heartbeat." TestingPrimitives + OBSOLETE_ALIEN_PRIMITIVES "Ancient crap in the IA32ABI plugin" - OBSOLETE_ALIEN_PRIMITIVES "Ancient crap in the IA32ABI plugin" LLDB "As of lldb-370.0.42 Swift-3.1, passing function parameters to printOopsSuchThat fails with Internal error [IRForTarget]: Couldn't rewrite one of the arguments of a function call. Turning off link time optimization with -fno-lto has no effect. hence we define some debugging functions as being <option: LLDB>" LRPCheck "Optional checking for long running primitives" "Plugin related" SQUEAK_BUILTIN_PLUGIN "ThreadedFFIPlugin related" ALLOCA_LIES_SO_SETSP_BEFORE_CALL PLATFORM_API_USES_CALLEE_POPS_CONVENTION STACK_ALIGN_BYTES + "processor related; see ThreadedFFIPlugin & src/plugins/SqueakFFIPrims/SqueakFFIPrims.c" - "processor related" ARM32 ARM64 i386 i486 i586 i686 X86 I386 x86_64 "os related" ACORN EPLAN9 UNIX WIN32 WIN64)!

1 0

VM Maker: VMMaker.oscog-eem.3295.mcz
by commits＠source.squeak.org 13 Jan '23

13 Jan '23

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.3295.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.3295 Author: eem Time: 13 January 2023, 12:09:05.276245 pm UUID: 63e2da98-74ac-444c-882e-5a2cd6a3f7f6 Ancestors: VMMaker.oscog-eem.3294 Change cloneObject: to answer nil on failure rather than 0, to match instantiateClass:indexableSize: et al. Make sure all uses of cloneObject: in plugins test the result appropriately. Make sure the head frame pointers are written back when cloning a context in primitiveClone. Fix a receiver of baseHeaderSize in the Cogit. =============== Diff against VMMaker.oscog-eem.3294 =============== Item was changed: ----- Method: CogObjectRepresentationFor32BitSpur>>genFetchRegArgsForPerformWithArguments: (in category 'primitive generators') ----- genFetchRegArgsForPerformWithArguments: sizeReg "The arguments are imn an array in Arg1Reg. Its size is in sizeReg. Load Arg0Reg and Arg1Reg with the first two slots. Since objects always have at least one slot and are aligned to 64-bits it is safe to load both args without checking." cogit + MoveMw: objectMemory baseHeaderSize r: Arg1Reg R: Arg0Reg; + MoveMw: objectMemory baseHeaderSize + self wordSize r: Arg1Reg R: Arg1Reg. - MoveMw: self baseHeaderSize r: Arg1Reg R: Arg0Reg; - MoveMw: self baseHeaderSize + self wordSize r: Arg1Reg R: Arg1Reg. ^0! Item was changed: ----- Method: CroquetPlugin>>primitiveOrthoNormInverseMatrix (in category 'transforms') ----- primitiveOrthoNormInverseMatrix <export: true> <primitiveMetadata: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> | srcOop dstOop src dst x y z rx ry rz | <var: #x type: #double> <var: #y type: #double> <var: #z type: #double> <var: #rx type: #double> <var: #ry type: #double> <var: #rz type: #double> srcOop := interpreterProxy stackValue: 0. ((interpreterProxy isWords: srcOop) and:[(interpreterProxy slotSizeOf: srcOop) = 16]) ifFalse: [^interpreterProxy primitiveFail]. dstOop := interpreterProxy cloneObject: srcOop. + dstOop ifNil: - dstOop = 0 ifTrue: [^interpreterProxy primitiveFail]. "reload srcOop in case of GC" self cppIf: #SPURVM ifFalse: [srcOop := interpreterProxy stackValue: 0]. src := self cCoerce: (interpreterProxy firstIndexableField: srcOop) to: #'float *'. dst := self cCoerce: (interpreterProxy firstIndexableField: dstOop) to: #'float *'. "Transpose upper 3x3 matrix" "dst at: 0 put: (src at: 0)." dst at: 1 put: (src at: 4). dst at: 2 put: (src at: 8). dst at: 4 put: (src at: 1). "dst at: 5 put: (src at: 5)." dst at: 6 put: (src at: 9). dst at: 8 put: (src at: 2). dst at: 9 put: (src at: 6). "dst at: 10 put: (src at: 10)." "Compute inverse translation vector" x := src at: 3. y := src at: 7. z := src at: 11. rx := (x * (dst at: 0)) + (y * (dst at: 1)) + (z * (dst at: 2)). ry := (x * (dst at: 4)) + (y * (dst at: 5)) + (z * (dst at: 6)). rz := (x * (dst at: 8)) + (y * (dst at: 9)) + (z * (dst at: 10)). dst at: 3 put: 0.0 - rx. dst at: 7 put: 0.0 - ry. dst at: 11 put: 0.0 - rz. ^interpreterProxy methodReturnValue: dstOop! Item was changed: ----- Method: CroquetPlugin>>primitiveTransformDirection (in category 'transforms') ----- primitiveTransformDirection <export: true> <primitiveMetadata: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> | x y z rx ry rz matrix vertex v3Oop | <var: #x type: #double> <var: #y type: #double> <var: #z type: #double> <var: #rx type: #double> <var: #ry type: #double> <var: #rz type: #double> matrix := self stackMatrix: 1. v3Oop := interpreterProxy stackValue: 0. (matrix notNil and: [(interpreterProxy isWords: v3Oop) and:[(interpreterProxy slotSizeOf: v3Oop) = 3]]) ifFalse: [^interpreterProxy primitiveFail]. vertex := self cCoerce: (interpreterProxy firstIndexableField: v3Oop) to: #'float *'. x := vertex at: 0. y := vertex at: 1. z := vertex at: 2. rx := (x * (matrix at: 0)) + (y * (matrix at: 1)) + (z * (matrix at: 2)). ry := (x * (matrix at: 4)) + (y * (matrix at: 5)) + (z * (matrix at: 6)). rz := (x * (matrix at: 8)) + (y * (matrix at: 9)) + (z * (matrix at: 10)). v3Oop := interpreterProxy cloneObject: v3Oop. + v3Oop ifNil: - v3Oop = 0 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoMemory]. vertex := self cCoerce: (interpreterProxy firstIndexableField: v3Oop) to: #'float *'. vertex at: 0 put: rx. vertex at: 1 put: ry. vertex at: 2 put: rz. ^interpreterProxy methodReturnValue: v3Oop! Item was changed: ----- Method: CroquetPlugin>>primitiveTransformVector3 (in category 'transforms') ----- primitiveTransformVector3 <export: true> <primitiveMetadata: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> | x y z rx ry rz rw matrix vertex v3Oop | <var: #x type: #double> <var: #y type: #double> <var: #z type: #double> <var: #rx type: #double> <var: #ry type: #double> <var: #rz type: #double> <var: #rw type: #double> matrix := self stackMatrix: 1. v3Oop := interpreterProxy stackValue: 0. (matrix notNil and: [(interpreterProxy isWords: v3Oop) and:[(interpreterProxy slotSizeOf: v3Oop) = 3]]) ifFalse: [^interpreterProxy primitiveFail]. vertex := self cCoerce: (interpreterProxy firstIndexableField: v3Oop) to: #'float *'. x := vertex at: 0. y := vertex at: 1. z := vertex at: 2. rx := (x * (matrix at: 0)) + (y * (matrix at: 1)) + (z * (matrix at: 2)) + (matrix at: 3). ry := (x * (matrix at: 4)) + (y * (matrix at: 5)) + (z * (matrix at: 6)) + (matrix at: 7). rz := (x * (matrix at: 8)) + (y * (matrix at: 9)) + (z * (matrix at: 10)) + (matrix at: 11). rw := (x * (matrix at: 12)) + (y * (matrix at: 13)) + (z * (matrix at: 14)) + (matrix at: 15). v3Oop := interpreterProxy cloneObject: v3Oop. + v3Oop ifNil: - v3Oop = 0 ifTrue: [^interpreterProxy primitiveFailFor: PrimErrNoMemory]. vertex := self cCoerce: (interpreterProxy firstIndexableField: v3Oop) to: #'float *'. rw = 1.0 ifTrue:[ vertex at: 0 put: rx. vertex at: 1 put: ry. vertex at: 2 put: rz. ] ifFalse:[ rw = 0.0 ifTrue:[rw := 0.0] ifFalse:[rw := 1.0 / rw]. vertex at: 0 put: rx * rw. vertex at: 1 put: ry * rw. vertex at: 2 put: rz * rw. ]. ^interpreterProxy methodReturnValue: v3Oop! Item was changed: ----- Method: CroquetPlugin>>primitiveTransposeMatrix (in category 'transforms') ----- primitiveTransposeMatrix - | srcOop dstOop src dst | <export: true> + <primitiveMetadata: #(FastCPrimitiveFlag FastCPrimitiveAlignForFloatsFlag)> + | srcOop dstOop src dst | + <var: #src type: #'float *'> + <var: #dst type: #'float *'> - <var: #src declareC:'float *src'> - <var: #dst declareC:'float *dst'> + srcOop := interpreterProxy stackValue: 0. + ((interpreterProxy isWords: srcOop) and:[(interpreterProxy slotSizeOf: srcOop) = 16]) ifFalse: + [^interpreterProxy primitiveFail]. - interpreterProxy methodArgumentCount = 0 - ifFalse:[^interpreterProxy primitiveFail]. - srcOop := interpreterProxy stackObjectValue: 0. - interpreterProxy failed ifTrue:[^nil]. - ((interpreterProxy isWords: srcOop) and:[(interpreterProxy slotSizeOf: srcOop) = 16]) - ifFalse:[^interpreterProxy primitiveFail]. dstOop := interpreterProxy cloneObject: srcOop. + dstOop ifNil: + [^interpreterProxy primitiveFailFor: PrimErrNoMemory]. + self cppIf: #SPURVM "reload srcOop in case of GC" + ifFalse: [srcOop := interpreterProxy stackValue: 0]. - "reload srcOop in case of GC" - srcOop := interpreterProxy stackObjectValue: 0. src := interpreterProxy firstIndexableField: srcOop. dst := interpreterProxy firstIndexableField: dstOop. "dst at: 0 put: (src at: 0)." dst at: 1 put: (src at: 4). dst at: 2 put: (src at: 8). dst at: 3 put: (src at: 12). dst at: 4 put: (src at: 1). "dst at: 5 put: (src at: 5)." dst at: 6 put: (src at: 9). dst at: 7 put: (src at: 13). dst at: 8 put: (src at: 2). dst at: 9 put: (src at: 6). "dst at: 10 put: (src at: 10)." dst at: 11 put: (src at: 14). dst at: 12 put: (src at: 3). dst at: 13 put: (src at: 7). dst at: 14 put: (src at: 11). "dst at: 15 put: (src at: 15)." + interpreterProxy methodReturnValue: dstOop! - interpreterProxy pop: 1. - ^interpreterProxy push: dstOop. - ! Item was changed: ----- Method: Interpreter>>primitiveClone (in category 'object access primitives') ----- primitiveClone "Return a shallow copy of the receiver." | newCopy | newCopy := self cloneObject: self stackTop. + newCopy ifNil: "not enough memory most likely" - newCopy = 0 ifTrue: "not enough memory most likely" [^self primitiveFail]. self pop: argumentCount + 1 thenPush: newCopy! Item was changed: ----- Method: InterpreterPrimitives>>primitiveClone (in category 'object access primitives') ----- primitiveClone "Return a shallow copy of the receiver." | rcvr newCopy | rcvr := self stackTop. (objectMemory isImmediate: rcvr) ifTrue: [newCopy := rcvr] ifFalse: [(argumentCount = 0 or: [(objectMemory isForwarded: rcvr) not]) + ifTrue: [newCopy := objectMemory cloneObject: rcvr]. + newCopy ifNil: "not enough memory most likely" + [^self primitiveFailFor: PrimErrNoMemory]]. + self methodReturnValue: newCopy! - ifTrue: [newCopy := objectMemory cloneObject: rcvr] - ifFalse: [newCopy := 0]. - newCopy = 0 ifTrue: "not enough memory most likely" - [^self primitiveFail]]. - self pop: argumentCount + 1 thenPush: newCopy! Item was changed: ----- Method: NewObjectMemory>>allocateChunkAfterGC: (in category 'allocation') ----- allocateChunkAfterGC: byteSize "Garbage collect and then allocate a chunk of the given size. Sender must be sure that the requested size includes enough space for the header word(s)." | newChunk enoughSpace | <inline: true> <var: #newChunk type: #usqInt> enoughSpace := self sufficientSpaceToAllocate: byteSize. enoughSpace ifFalse: ["signal that space is running low, but proceed with allocation if possible" self setSignalLowSpaceFlagAndSaveProcess]. (self oop: freeStart + byteSize isGreaterThan: reserveStart) ifTrue: + [^nil "Allocation failed. Client should e.g. fail the primtive"]. - [^0 "Allocation failed. Client should e.g. fail the primtive"]. "if we get here, there is enough space for allocation to succeed " newChunk := freeStart. freeStart := freeStart + byteSize. ^self oopForPointer: newChunk! Item was changed: ----- Method: NewObjectMemory>>cloneObject: (in category 'allocation') ----- cloneObject: obj "Return a shallow copy of the given object. May cause GC. Assume: Oop is a real object, not a small integer. Override to assert it's not a married context and maybe fix cloned methods." | extraHdrBytes bytes newChunk remappedOop fromIndex toIndex lastFrom newOop header hash | <inline: false> <var: #lastFrom type: #usqInt> <var: #fromIndex type: #usqInt> self assert: ((self isContext: obj) not or: [(coInterpreter isMarriedOrWidowedContext: obj) not]). self assert: (self isNonIntegerObject: obj). extraHdrBytes := self extraHeaderBytes: obj. bytes := self sizeBitsOf: obj. bytes := bytes + extraHdrBytes. "allocate space for the copy, remapping obj in case of a GC" self pushRemappableOop: obj. + "check it is safe to allocate this much memory. Return nil if not" + (self sufficientSpaceToAllocate: 2500 + bytes) ifFalse:[^nil]. - "check it is safe to allocate this much memory. Return 0 if not" - (self sufficientSpaceToAllocate: 2500 + bytes) ifFalse:[^0]. newChunk := self allocateChunk: bytes. remappedOop := self popRemappableOop. "copy old to new including all header words" toIndex := newChunk - self wordSize. "loop below uses pre-increment" fromIndex := (remappedOop - extraHdrBytes) - self wordSize. lastFrom := fromIndex + bytes. [fromIndex < lastFrom] whileTrue: [self longAt: (toIndex := toIndex + self wordSize) put: (self longAt: (fromIndex := fromIndex + self wordSize))]. newOop := newChunk + extraHdrBytes. "convert from chunk to oop" "fix base header: compute new hash and clear Mark and Root bits" hash := self newObjectHash. header := (self longAt: newOop) bitAnd: 16r1FFFF. "use old ccIndex, format, size, and header-type fields" header := header bitOr: ((hash << HashBitsOffset) bitAnd: HashBits). self longAt: newOop put: header. (self isCompiledMethodHeader: header) ifTrue: [coInterpreter maybeFixClonedCompiledMethod: newOop]. ^newOop ! Item was changed: ----- Method: ObjectMemory>>cloneObject: (in category 'allocation') ----- cloneObject: obj "Return a shallow copy of the given object. May cause GC" "Assume: Oop is a real object, not a small integer." | extraHdrBytes bytes newChunk remappedOop fromIndex toIndex lastFrom newOop header hash | <inline: false> <var: #lastFrom type: #usqInt> <var: #fromIndex type: #usqInt> self assert: (self isNonIntegerObject: obj). extraHdrBytes := self extraHeaderBytes: obj. bytes := self sizeBitsOf: obj. bytes := bytes + extraHdrBytes. "allocate space for the copy, remapping obj in case of a GC" self pushRemappableOop: obj. + "check it is safe to allocate this much memory. Return nil if not" + (self sufficientSpaceToAllocate: 2500 + bytes) ifFalse:[^nil]. - "check it is safe to allocate this much memory. Return 0 if not" - (self sufficientSpaceToAllocate: 2500 + bytes) ifFalse:[^0]. newChunk := self allocateChunk: bytes. remappedOop := self popRemappableOop. "copy old to new including all header words" toIndex := newChunk - self wordSize. "loop below uses pre-increment" fromIndex := (remappedOop - extraHdrBytes) - self wordSize. lastFrom := fromIndex + bytes. [fromIndex < lastFrom] whileTrue: [self longAt: (toIndex := toIndex + self wordSize) put: (self longAt: (fromIndex := fromIndex + self wordSize))]. newOop := newChunk + extraHdrBytes. "convert from chunk to oop" "fix base header: compute new hash and clear Mark and Root bits" hash := self newObjectHash. header := (self longAt: newOop) bitAnd: 16r1FFFF. "use old ccIndex, format, size, and header-type fields" header := header bitOr: ((hash << HashBitsOffset) bitAnd: HashBits). self longAt: newOop put: header. ^newOop ! Item was changed: ----- Method: SpurMemoryManager>>cloneObject: (in category 'allocation') ----- cloneObject: objOop | numSlots fmt newObj | numSlots := self numSlotsOf: objOop. fmt := self formatOf: objOop. numSlots > self maxSlotsForNewSpaceAlloc ifTrue: [newObj := self allocateSlotsInOldSpace: numSlots format: fmt classIndex: (self classIndexOf: objOop)] ifFalse: [newObj := self allocateSlots: numSlots format: fmt classIndex: (self classIndexOf: objOop)]. + newObj ifNotNil: + [(self isPointersFormat: fmt) + ifTrue: + [| hasYoung | + hasYoung := false. + 0 to: numSlots - 1 do: + [:i| | oop | + oop := self fetchPointer: i ofObject: objOop. + (self isNonImmediate: oop) ifTrue: + [(self isForwarded: oop) ifTrue: + [oop := self followForwarded: oop]. + ((self isNonImmediate: oop) + and: [self isYoungObject: oop]) ifTrue: + [hasYoung := true]]. + self storePointerUnchecked: i + ofObject: newObj + withValue: oop]. + (hasYoung + and: [(self isYoungObject: newObj) not]) ifTrue: + [scavenger remember: newObj]] + ifFalse: + [0 to: numSlots - 1 do: + [:i| + self storePointerUnchecked: i + ofObject: newObj + withValue: (self fetchPointer: i ofObject: objOop)]. + fmt >= self firstCompiledMethodFormat ifTrue: + [coInterpreter maybeFixClonedCompiledMethod: newObj. + ((self isOldObject: newObj) + and: [(self isYoungObject: objOop) or: [self isRemembered: objOop]]) ifTrue: + [scavenger remember: newObj]]]]. - newObj ifNil: - [^0]. - (self isPointersFormat: fmt) - ifTrue: - [| hasYoung | - hasYoung := false. - 0 to: numSlots - 1 do: - [:i| | oop | - oop := self fetchPointer: i ofObject: objOop. - (self isNonImmediate: oop) ifTrue: - [(self isForwarded: oop) ifTrue: - [oop := self followForwarded: oop]. - ((self isNonImmediate: oop) - and: [self isYoungObject: oop]) ifTrue: - [hasYoung := true]]. - self storePointerUnchecked: i - ofObject: newObj - withValue: oop]. - (hasYoung - and: [(self isYoungObject: newObj) not]) ifTrue: - [scavenger remember: newObj]] - ifFalse: - [0 to: numSlots - 1 do: - [:i| - self storePointerUnchecked: i - ofObject: newObj - withValue: (self fetchPointer: i ofObject: objOop)]. - fmt >= self firstCompiledMethodFormat ifTrue: - [coInterpreter maybeFixClonedCompiledMethod: newObj. - ((self isOldObject: newObj) - and: [(self isYoungObject: objOop) or: [self isRemembered: objOop]]) ifTrue: - [scavenger remember: newObj]]]. ^newObj! Item was changed: ----- Method: SpurMemoryManager>>outOfPlaceBecome:and:copyHashFlag: (in category 'become implementation') ----- outOfPlaceBecome: obj1 and: obj2 copyHashFlag: copyHashFlag <inline: #never> "in an effort to fix a compiler bug with two-way become post r3427" + "Allocate two new objects, n1 & n2. Copy the contents appropriately. Convert obj1 and obj2 + into forwarding objects pointing to n2 and n1 respectively. No need to check if cloneObject: + succeeds because an earlier pass over objects ensured that there is enough memory." - "Allocate two new objects, n1 & n2. Copy the contents appropriately. Convert - obj1 and obj2 into forwarding objects pointing to n2 and n1 respectively" | clone1 clone2 | clone1 := (self isContextNonImm: obj1) ifTrue: [coInterpreter cloneContext: obj1] ifFalse: [self cloneObject: obj1]. clone2 := (self isContextNonImm: obj2) ifTrue: [coInterpreter cloneContext: obj2] ifFalse: [self cloneObject: obj2]. (self isObjImmutable: obj1) ifTrue: [self setIsImmutableOf: clone1 to: true]. (self isObjImmutable: obj2) ifTrue: [self setIsImmutableOf: clone2 to: true]. copyHashFlag ifTrue: [self setHashBitsOf: clone1 to: (self rawHashBitsOf: obj1). self setHashBitsOf: clone2 to: (self rawHashBitsOf: obj2)] ifFalse: [self setHashBitsOf: clone1 to: (self rawHashBitsOf: obj2). self setHashBitsOf: clone2 to: (self rawHashBitsOf: obj1)]. self forward: obj1 to: clone2; forward: obj2 to: clone1. ((self isYoungObject: obj1) ~= (self isYoungObject: clone2) or: [(self isYoungObject: obj2) ~= (self isYoungObject: clone1)]) ifTrue: [becomeEffectsFlags := becomeEffectsFlags bitOr: OldBecameNewFlag]! Item was changed: ----- Method: StackInterpreterPrimitives>>cloneContext: (in category 'primitive support') ----- cloneContext: aContext | sz cloned spouseFP sp | <var: #spouseFP type: #'char *'> sz := objectMemory numSlotsOf: aContext. cloned := objectMemory eeInstantiateMethodContextSlots: sz. + self deny: cloned = 0. + 0 to: StackPointerIndex do: + [:i| + objectMemory + storePointerUnchecked: i + ofObject: cloned + withValue: (self externalInstVar: i ofContext: aContext)]. + MethodIndex to: ReceiverIndex do: + [:i| + objectMemory + storePointerUnchecked: i + ofObject: cloned + withValue: (objectMemory fetchPointer: i ofObject: aContext)]. + (self isStillMarriedContext: aContext) + ifTrue: + [spouseFP := self frameOfMarriedContext: aContext. + sp := (self stackPointerIndexForFrame: spouseFP) - 1. + 0 to: sp do: + [:i| + objectMemory + storePointerUnchecked: i + CtxtTempFrameStart + ofObject: cloned + withValue: (self temporary: i in: spouseFP)]] + ifFalse: + [sp := (self fetchStackPointerOf: aContext) - 1. + 0 to: sp do: + [:i| + objectMemory + storePointerUnchecked: i + CtxtTempFrameStart + ofObject: cloned + withValue: (objectMemory fetchPointer: i + CtxtTempFrameStart ofObject: aContext)]]. - cloned ~= 0 ifTrue: - [0 to: StackPointerIndex do: - [:i| - objectMemory - storePointerUnchecked: i - ofObject: cloned - withValue: (self externalInstVar: i ofContext: aContext)]. - MethodIndex to: ReceiverIndex do: - [:i| - objectMemory - storePointerUnchecked: i - ofObject: cloned - withValue: (objectMemory fetchPointer: i ofObject: aContext)]. - (self isStillMarriedContext: aContext) - ifTrue: - [spouseFP := self frameOfMarriedContext: aContext. - sp := (self stackPointerIndexForFrame: spouseFP) - 1. - 0 to: sp do: - [:i| - objectMemory - storePointerUnchecked: i + CtxtTempFrameStart - ofObject: cloned - withValue: (self temporary: i in: spouseFP)]] - ifFalse: - [sp := (self fetchStackPointerOf: aContext) - 1. - 0 to: sp do: - [:i| - objectMemory - storePointerUnchecked: i + CtxtTempFrameStart - ofObject: cloned - withValue: (objectMemory fetchPointer: i + CtxtTempFrameStart ofObject: aContext)]]]. ^cloned! Item was changed: ----- Method: StackInterpreterPrimitives>>primitiveClone (in category 'object access primitives') ----- primitiveClone "Return a shallow copy of the receiver. Special-case non-single contexts (because of context-to-stack mapping). Can't fail for contexts cuz of image context instantiation code (sigh)." <primitiveMetadata: #(PrimCallMayEndureCodeCompaction PrimCallNeedsNewMethod)> "because of cloneContext: below" | rcvr newCopy | rcvr := self stackTop. (objectMemory isImmediate: rcvr) ifTrue: [newCopy := rcvr] ifFalse: [(objectMemory isContextNonImm: rcvr) ifTrue: + [self externalWriteBackHeadFramePointers. + newCopy := self cloneContext: rcvr] - [newCopy := self cloneContext: rcvr] ifFalse: [(argumentCount = 0 or: [(objectMemory isForwarded: rcvr) not]) + ifTrue: [newCopy := objectMemory cloneObject: rcvr]]. + newCopy ifNil: - ifTrue: [newCopy := objectMemory cloneObject: rcvr] - ifFalse: [newCopy := 0]]. - newCopy = 0 ifTrue: [^self primitiveFailFor: PrimErrNoMemory]]. self methodReturnValue: newCopy!

1 0

VM Maker: VMMaker.oscog.seperateMarking-WoC.3305.mcz
by commits＠source.squeak.org 13 Jan '23

13 Jan '23

Tom Braun uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog.seperateMarking-WoC.3305.mcz ==================== Summary ==================== Name: VMMaker.oscog.seperateMarking-WoC.3305 Author: WoC Time: 13 January 2023, 12:50:43.423711 am UUID: 291d0777-24d3-47f4-8046-02acd6de34ad Ancestors: VMMaker.oscog.seperateMarking-WoC.3304 handle pinned objects during compaction - try to keep track of them during marking - abort compaction if we find one in the to be compacted segment - add assert to forward:to: to forbid forwarding pinned objects - naive approach to scheduling incremental compacts (needs more work, just an experiment) - added comment why we replace the pointer in the remembered set =============== Diff against VMMaker.oscog.seperateMarking-WoC.3304 =============== Item was changed: ----- Method: SpurCountingIncrementalMarker>>setIsMarkedOf: (in category 'header access') ----- setIsMarkedOf: objOop | segmentContainingObject | super setIsMarkedOf: objOop. self flag: #Todo. "we need a more efficient way to get the segment" segmentContainingObject := manager segmentManager segmentContainingObj: objOop. self setUsedMemory: (self getUsedMemoryOf: segmentContainingObject) + (manager bytesInBody: objOop) for: segmentContainingObject. self setLifeObjectCount: (self getLifeObjectCountOf: segmentContainingObject) + 1 + for: segmentContainingObject. + + (manager isPinned: objOop) + ifTrue: [segmentContainingObject containsPinned: true]! - for: segmentContainingObject! Item was changed: ----- Method: SpurIncremental2PhaseGarbageCollector>>doIncrementalCollect (in category 'as yet unclassified') ----- doIncrementalCollect | startTime | phase = InMarkingPhase ifTrue: [ | finishedMarking | marker isCurrentlyMarking + ifFalse: [self assert: manager allObjectsUnmarked. + manager segmentManager prepareForGlobalSweep]. - ifFalse: [self assert: manager allObjectsUnmarked]. coInterpreter cr; print: 'start marking '; tab; flush. finishedMarking := marker incrementalMarkObjects. "self assert: manager validObjectColors." finishedMarking ifTrue: [ "manager allPastSpaceObjectsDo: [:obj | self assert: (manager isWhite: obj)]." "when sweeping the mutator needs to allocate new objects black as we do not have any information about them. We only know if they should get swept after the next marking -> keep them alive for this cycle" self allocatorShouldAllocateBlack: true. compactor setInitialSweepingEntity. phase := InSweepingPhase. "marking is done and thus all forwarding from the last compaction references are resolved -> we can use the now free segments that were compacted during the last cycle" compactor freePastSegmentsAndSetSegmentToFill. compactor assertNoSegmentBeingCompacted. self assert: manager noObjectGrey. coInterpreter cr; print: 'finish marking '; tab; flush. startTime := coInterpreter ioUTCMicrosecondsNow. manager setCheckForLeaks: GCCheckFreeSpace + GCModeFull; runLeakCheckerFor: GCModeFull excludeUnmarkedObjs: true classIndicesShouldBeValid: true; checkFreeSpace: GCModeFull. manager clearLeakMapAndMapMarkedOrYoungObjects. coInterpreter checkStackIntegrity. coInterpreter cr; print: 'time for internal check: '; printNum: coInterpreter ioUTCMicrosecondsNow - startTime; tab; flush. 0 to: manager numSegments - 1 do: [:i | | segInfo | segInfo := manager segInfoAt: i. coInterpreter cr; print: 'occupation from marking: '; printNum: (compactor occupationOf: segInfo) * 100; tab; print: '('; printNum: (marker getLifeObjectCountOf: segInfo); print: ' objects -> ' ;printNum: (compactor sizeClaimedIn: segInfo) ; print: ' bytes)' ;flush]. manager printSegmentOccupationFromMarkedObjects. ^ self] ifFalse: [coInterpreter cr; print: 'finish marking pass'; tab; flush. "manager runLeakCheckerFor: GCModeIncremental"]]. phase = InSweepingPhase ifTrue: [ coInterpreter cr; print: 'start sweeping '; tab; flush. compactor incrementalSweepAndCompact ifTrue: [ self allocatorShouldAllocateBlack: false. self assert: manager allObjectsWhite. "self assert: manager allObjectsUnmarked." coInterpreter cr; print: 'finish sweeping '; tab; flush. startTime := coInterpreter ioUTCMicrosecondsNow. manager setCheckForLeaks: GCCheckFreeSpace + GCModeFull; runLeakCheckerFor: GCModeFull; checkFreeSpace: GCModeFull. coInterpreter cr; print: 'time for internal check: '; printNum: coInterpreter ioUTCMicrosecondsNow - startTime; tab; flush. phase := InMarkingPhase. + + fullGCWanted := false. ^ self]]! Item was added: + ----- Method: SpurIncrementalCompactingSweeper>>abortCompactionAt:in: (in category 'incremental compact') ----- + abortCompactionAt: entity in: segInfo + + <var: 'segInfo' type: #'SpurSegmentInfo *'> + "somebody allocated a new object we did not knew about at the moment of planning :( + -> it does not fit anymore and we cannot free the whole segment or the object is pinned. Make sure to + unmark the segment as beeing compacted as it would be completetly freed otherwise!!" + (manager isPinned: entity) + ifTrue: [coInterpreter cr; print: 'segments contains pinned object. '] + ifFalse: [coInterpreter cr; print: 'segments if full. ']. + coInterpreter cr; print: 'Abort compacting of: '; printHex: segInfo segStart ; tab; flush. + self + unmarkSegment: self currentSegment + asBeingCompactedAndSaveEndOfCompactionAddress: entity. + + "we need to sweep the rest of the segment. As the segment is not marked to be compacted + anymore sweepOrCompactFromCurrentObject will decide to sweep it. We want to start + sweeping from the current entity, therefore setting currentObject to it and we have to protect + it from beeing freed (with marking it) as it was marked previously and after us unmarking it here would + get collected incorrectly" + manager setIsMarkedOf: entity to: true. + currentObject := entity.! Item was changed: ----- Method: SpurIncrementalCompactingSweeper>>compactSegment:freeStart:segIndex: (in category 'incremental compact') ----- compactSegment: segInfo freeStart: initialFreeStart segIndex: segIndex <var: 'segInfo' type: #'SpurSegmentInfo *'> | fillStart | fillStart := initialFreeStart. self deny: segIndex = 0. "Cannot compact seg 0" manager segmentManager allEntitiesInSegment: segInfo exceptTheLastBridgeDo: [:entity | (manager isFreeObject: entity) ifTrue: [manager detachFreeObject: entity. currentsCycleSeenObjectCount := currentsCycleSeenObjectCount + 1. "To avoid confusing too much Spur (especially the leak/free checks), we mark the free chunk as a word object." manager set: entity classIndexTo: manager wordSizeClassIndexPun formatTo: manager wordIndexableFormat] ifFalse: + [ + (manager isPinned: entity) + ifTrue: [manager debugger]. + + (manager isMarked: entity) + ifTrue: [| bytesToCopy | + "note: we copy even forwarders if they are marked so they cannot get lost" + manager makeWhite: entity. + + "I really hat that this can happen :( . The marker will keep track of which segments contain pinned objects. + If the pinned object is created during sweeping and compacting, we cannot know about it while working at + our plan we did at the start of sweeping and compacting" + (manager isPinned: entity) + ifTrue: [self abortCompactionAt: entity in: segInfo]. - [ (manager isMarked: entity) - ifTrue: [manager makeWhite: entity. - "During the mutator runs new forwarding references can be created. Ignore them as they get resolved with the other - forwarders in this segment in the next marking pass" - (manager isForwarded: entity) - ifFalse:[| bytesToCopy | - "Copy the object in segmentToFill and replace it by a forwarder." - bytesToCopy := manager bytesInBody: entity. - - (self would: fillStart + bytesToCopy overflowSegment: segmentToFill) - ifFalse: [ - self handleWouldBeCompactionOverflow: entity in: segInfo. + bytesToCopy := manager bytesInBody: entity. + + (self would: fillStart + bytesToCopy overflowSegment: segmentToFill) + ifFalse: [ + self abortCompactionAt: entity in: segInfo. - ^ fillStart]. - - "let's make copying more expensive. Number is just a guess" - currentsCycleSeenObjectCount := currentsCycleSeenObjectCount + 100. - self migrate: entity sized: bytesToCopy to: fillStart. + ^ fillStart]. + + "let's make copying more expensive. Number is just a guess" + currentsCycleSeenObjectCount := currentsCycleSeenObjectCount + 100. + self migrate: entity sized: bytesToCopy to: fillStart. + + fillStart := fillStart + bytesToCopy. + self assert: (self oop: fillStart isLessThan: (segmentToFill segLimit - manager bridgeSize))] - fillStart := fillStart + bytesToCopy. - self assert: (self oop: fillStart isLessThan: (segmentToFill segLimit - manager bridgeSize))]] ifFalse: [self handleUnmarkedEntity: entity]]]. "we want to advance to the next segment from the bridge" currentObject := currentSegmentsBridge. ^ fillStart! Item was removed: - ----- Method: SpurIncrementalCompactingSweeper>>handleWouldBeCompactionOverflow:in: (in category 'compaction planning') ----- - handleWouldBeCompactionOverflow: entity in: segInfo - - "somebody allocated a new object we did not knew about at the moment of planning :( - -> it does not fit anymore and we cannot free the whole segment. Make sure to - unmark the segment as beeing compacted as it would be completetly freed otherwise!!" - coInterpreter cr; print: 'segments if full. Abort compacting of: '; printHex: segInfo segStart ; tab; flush. - self - unmarkSegment: self currentSegment - asBeingCompactedAndSaveEndOfCompactionAddress: entity. - - "we need to sweep the rest of the segment. As the segment is not marked to be compacted - anymore sweepOrCompactFromCurrentObject will decide to sweep it. We want to start - sweeping from the current entity, therefore setting currentObject to it and we have to protect - it from beeing freed (with marking it) as it was marked previously and after us unmarking it here would - get collected incorrectly" - manager setIsMarkedOf: entity to: true. - currentObject := entity.! Item was changed: ----- Method: SpurIncrementalCompactingSweeper>>initialize (in category 'initialize-release') ----- initialize isCurrentlyWorking := false. currentSegmentsIndex := 0. currentsCycleSeenObjectCount := 0. currentSegmentsBridge := nil. currentObject := nil. segmentToFill := nil. shouldCompact := false. currentCopyToPointer := nil. + maxObjectsToFree := InitialMaxObjectsToFree! - maxObjectsToFree := MaxObjectsToFree! Item was changed: ----- Method: SpurIncrementalCompactingSweeper>>migrate:sized:to: (in category 'incremental compact') ----- migrate: obj sized: bytesToCopy to: address | copy | self assert: (manager isPinned: obj) not. manager memcpy: address asVoidPointer _: (manager startOfObject: obj) asVoidPointer _: bytesToCopy. copy := manager objectStartingAt: address. (manager isRemembered: copy) ifTrue: + ["replace the pointer in the remembered set instead of leaving it there. It could get hidden inside the free chunk that will get + created after the next marking phase and the sweeper won't be able to find it and make the scavenger forget it." + scavenger remember: copy insteadOf: obj]. - [scavenger remember: copy insteadOf: obj]. manager forward: obj to: (manager objectStartingAt: address). ^ copy! Item was changed: SpurGarbageCollector subclass: #SpurIncrementalGarbageCollector + instanceVariableNames: 'phase allAtOnceMarker checkSetGCFlags stopTheWorldGC fullGCWanted' - instanceVariableNames: 'phase allAtOnceMarker checkSetGCFlags stopTheWorldGC' classVariableNames: 'InCompactingPhase InMarkingPhase InSweepingPhase' poolDictionaries: '' category: 'VMMaker-SpurGarbageCollector'! !SpurIncrementalGarbageCollector commentStamp: 'WoC 1/5/2023 21:36' prior: 0! A SpurIncrementalGarbageCollector is a garbage collection algorithm. The GC is a mark and sweep with an additional compaction if certain conditions are fulfilled. This class manages SpurIncrementalMarker and SpurIncrementalSweepAndCompact (which in turn manages SpurIncrementalCompactor and SpurIncrementalSweeper). The 3 classes implementing the GC are therefore SpurIncrementalMarker, SpurIncrementalSweeper and SpurIncrementalCompactor. Instance Variables allAtOnceMarker: <SpurAllAtOnceMarker> checkSetGCFlags: <Bool> phase: <Number (InMarkingPhase|InSweepingPhase|InCompactingPhase)> allAtOnceMarker - an instance of SpurAllAtOnceMarker. We sometimes need parts of the old (stop-the-world) gc algorithm. This is the marking algorithm we can use through static polymorphism checkSetGCFlags - should we check if it ok to set gc flags or not phase - in which phase is the gc algorithm at the moment. Is either InMarkingPhase, InSweepingPhase or InCompactingPhase ! Item was changed: ----- Method: SpurIncrementalGarbageCollector>>doIncrementalCollect (in category 'as yet unclassified') ----- doIncrementalCollect | startTime | phase = InMarkingPhase ifTrue: [ | finishedMarking | marker isCurrentlyMarking ifFalse: [self assert: manager allObjectsUnmarked]. coInterpreter cr; print: 'start marking '; tab; flush. finishedMarking := marker incrementalMarkObjects. "self assert: manager validObjectColors." finishedMarking ifTrue: [ manager allPastSpaceObjectsDo: [:obj | self assert: (manager isWhite: obj)]. "when sweeping the mutator needs to allocate new objects black as we do not have any information about them. We only know if they should get swept after the next marking -> keep them alive for this cycle" self allocatorShouldAllocateBlack: true. compactor setInitialSweepingEntity. phase := InSweepingPhase. "marking is done and thus all forwarding from the last compaction references are resolved -> we can use the now free segments that were compacted during the last cycle" compactor freePastSegmentsAndSetSegmentToFill. + manager segmentManager prepareForGlobalSweep. + self assert: manager noObjectGrey. coInterpreter cr; print: 'finish marking '; tab; flush. startTime := coInterpreter ioUTCMicrosecondsNow. manager setCheckForLeaks: GCCheckFreeSpace + GCModeFull; runLeakCheckerFor: GCModeFull excludeUnmarkedObjs: true classIndicesShouldBeValid: true; checkFreeSpace: GCModeFull. coInterpreter cr; print: 'time for internal check: '; printNum: coInterpreter ioUTCMicrosecondsNow - startTime; tab; flush. ^ self] ifFalse: [coInterpreter cr; print: 'finish marking pass'; tab; flush.manager runLeakCheckerFor: GCModeIncremental]]. phase = InSweepingPhase ifTrue: [ coInterpreter cr; print: 'start sweeping '; tab; flush. compactor incrementalSweep ifTrue: [ self allocatorShouldAllocateBlack: false. manager allOldSpaceObjectsDo: [:ea | self assert: (manager isWhite: ea) ]. "self assert: manager allObjectsUnmarked." coInterpreter cr; print: 'finish sweeping '; tab; flush. startTime := coInterpreter ioUTCMicrosecondsNow. manager setCheckForLeaks: GCCheckFreeSpace + GCModeFull; runLeakCheckerFor: GCModeFull; checkFreeSpace: GCModeFull. coInterpreter cr; print: 'time for internal check: '; printNum: coInterpreter ioUTCMicrosecondsNow - startTime; tab; flush. compactor assertNoSegmentBeingCompacted. phase := InCompactingPhase. ^ self]]. phase = InCompactingPhase ifTrue: [ "self cCode: 'raise(SIGINT)'." coInterpreter cr; print: 'start compacting '; tab; flush. compactor isCurrentlyCompacting ifFalse: [manager printFreeSpaceStatistics]. compactor incrementalCompact ifTrue: [ coInterpreter cr; print: 'finish compacting '; tab; flush. startTime := coInterpreter ioUTCMicrosecondsNow. manager setCheckForLeaks: GCCheckFreeSpace + GCModeFull; runLeakCheckerFor: GCModeFull; checkFreeSpace: GCModeFull. coInterpreter cr; print: 'time for internal check: '; printNum: coInterpreter ioUTCMicrosecondsNow - startTime; tab; flush. phase := InMarkingPhase. + fullGCWanted := false. + ^ self]]! Item was changed: ----- Method: SpurIncrementalGarbageCollector>>doScavenge: (in category 'scavenge') ----- doScavenge: tenuringCriterion "The inner shell for scavenge, abstrascted out so globalGarbageCollect can use it." <inline: false> manager doAllocationAccountingForScavenge. manager gcPhaseInProgress: ScavengeInProgress. manager pastSpaceStart: (scavenger scavenge: tenuringCriterion). self assert: (self oop: manager pastSpaceStart isGreaterThanOrEqualTo: scavenger pastSpace start andLessThanOrEqualTo: scavenger pastSpace limit). manager freeStart: scavenger eden start. manager gcPhaseInProgress: 0. manager resetAllocationAccountingAfterGC. + (fullGCWanted or: [self numSegmentsAboutToBeFreed > 0]) + ifTrue: [self incrementalCollect] + ! - self incrementalCollect! Item was changed: ----- Method: SpurIncrementalGarbageCollector>>initialize (in category 'initialize-release') ----- initialize super initialize. checkSetGCFlags := true. phase := InMarkingPhase. + fullGCWanted := false. + allAtOnceMarker := SpurAllAtOnceMarker new. stopTheWorldGC := SpurStopTheWorldGarbageCollector new. stopTheWorldGC marker: allAtOnceMarker. stopTheWorldGC compactor: SpurPlanningCompactor new! Item was changed: ----- Method: SpurIncrementalGarbageCollector>>sufficientSpaceAfterGC: (in category 'as yet unclassified') ----- sufficientSpaceAfterGC: numBytes | heapSizePostGC | self assert: numBytes = 0. self scavengingGCTenuringIf: TenureByAge. heapSizePostGC := manager segmentManager totalOldSpaceCapacity - manager totalFreeOldSpace. (heapSizePostGC - manager heapSizeAtPreviousGC) asFloat / manager heapSizeAtPreviousGC >= manager heapGrowthToSizeGCRatio + ifTrue: [fullGCWanted := true] "fullGC will attempt to shrink" - ifTrue: ["self fullGC"] "fullGC will attempt to shrink" ifFalse: "Also attempt to shrink if there is plenty of free space and no need to GC" [manager totalFreeOldSpace > (manager shrinkThreshold * 2) ifTrue: [manager attemptToShrink. ^true]]. self flag: #Todo. "we probably want here something more sophisticated, like tak into account how many objects survived tenuring in the near past and how much work is still to be done until marking is finished and the segments get freed. Until then just assume the compacted segments get freed soon enough" [self numSegmentsAboutToBeFreed = 0 "lets wait until we get more space" and: [manager totalFreeOldSpace < manager growHeadroom and: [(manager growOldSpaceByAtLeast: 0) notNil]]] whileTrue: [manager totalFreeOldSpace >= manager growHeadroom ifTrue: [^true]]. manager lowSpaceThreshold > manager totalFreeOldSpace ifTrue: "space is low" [manager lowSpaceThreshold: 0. "avoid signalling low space twice" ^false]. ^true! Item was changed: ----- Method: SpurMemoryManager>>forward:to: (in category 'become implementation') ----- forward: obj1 to: obj2 + + self assert: (self isPinned: obj1) not. + self set: obj1 classIndexTo: self isForwardedObjectClassIndexPun formatTo: self forwardedFormat. self cppIf: IMMUTABILITY ifTrue: [ self setIsImmutableOf: obj1 to: false ]. self storePointer: 0 ofForwarder: obj1 withValue: obj2. gc maybeModifyForwarder: obj1. "For safety make sure the forwarder has a slot count that includes its contents." (self rawNumSlotsOf: obj1) = 0 ifTrue: [self rawNumSlotsOf: obj1 put: 1]!

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev January 2023