On Fri, Oct 30, 2009 at 10:14:52AM -0300, Juan Vuletich wrote:
David T. Lewis wrote:
Juan's patches (VMMaker-BitBlt-AlphaFixes-jmv-M7407.cs on Mantis 7047) do resolve the problems in the VM, and the changes all look correct to me (but I have no experience with bitblt, so I'm just commenting on the fixes for type declarations and arithmetic overflow).
Has anyone else had a chance to review this? If there are no issues or concerns, I will add Juan's alpha fixes to VMMaker.
Dave
Good. Thanks!
Hi Juan,
There are a couple of spelling error in comments in your alpha patches for bitblt. I corrected them by editing the change set as follows:
#!/bin/sh sed 's/aritm/arithm/g' VMMaker-BitBlt-AlphaFixes-jmv-M7407.cs \ | sed 's/operarions/operations/g' \ > VMMaker-BitBlt-AlphaFixes-jmv-M7407-patched.cs
May I have your permission to use the edited version in VMMaker? This preserves your author initials and time stamps but corrects the minor spelling errors.
This may sound like a silly request, but I did not want to modify any methods with your initials without asking you first.
Thanks, Dave