On Thu, Dec 02, 2010 at 03:54:30PM -0800, Andreas Raab wrote:
On 12/2/2010 3:33 PM, David T. Lewis wrote:
So, I want to change the default definition of fum variable (to "static struct foo"). What do you think?
While you're at it, could you *please* give these variables reasonable names? I mean 'struct foo fum'? WTF?
Andreas,
Esteban was asking if it is OK to change the declaration from "struct foo" to "static struct foo", and the answer is yes, he should proceed with that change (or I'll commit it to VMMaker if Esteban prefers to handle it that way).
With respect to changing the names to something less whimsical, that's a fair point. However, it effects two classes and a dozen methods in VMMaker, as well as the external gnuify.awk script that has to be in sync with these. Given that we have two significant branches of VMMaker and two branches of the platform sources in need of convergence, this may not be a good time to introduce additional changes that require coordination. Can we do it a few months from now?
Change set attached, but I vote for waiting until next year to apply it.
Dave