On Fri, Jul 24, 2015 at 04:10:18PM -0700, Eliot Miranda wrote:
Hi Levente,
On Fri, Jul 24, 2015 at 3:46 PM, Levente Uzonyi leves@elte.hu wrote:
Hi Eliot,
Yes, the github version lacks that line. My pull request[1] has this fix, along with a few other fixes and improvments, but Tobias didn't like the image-sided SAN certificate validation scheme, so none of those have been merged. In the meanwhile I've started rewriting a few things, like logging, certificate serialization (so that it's accessible from the image), but I still haven't finished domain name validation.
OK, I'll keep the version of sqUnixOpenSSL.c in Cog unchanged except for the use of SQSSL_VERSION for the version number. Maybe you can integrate with the Cog version? I like using %p instead of %lx, and the use of (long)aSqInt variable is I think unnecessary. Whether sqInt is int or long it=ll get passed as a long to printf, so the noise is unnecessary.
Do you have installation instructions for LibreSSL and make flags for linux64 & linux32?
Hi Eliot,
It should not be an issue for 32-bit Spur, but just as a heads up the SqueakSSL plugin does not work for sizeof(sqInt) = 8. It does work for a 64-bit VM with 32-bit image. I'm guessing that there are some variables with default sqInt declarations that need to be explicitly declared int, though I have not yet looked into it further.
Again, not an issue for Squeak 4.6/5.0 Cog and Spur VMs.
Dave