Hi David,
On Wed, Feb 10, 2021 at 8:38 PM David T. Lewis lewis@mail.msen.com wrote:
On Mon, Feb 08, 2021 at 09:02:10PM -0800, Eliot Miranda wrote:
I ask anyone wishing to alter the system here to please contact me and
discuss
before making changes. It is extraordinarily expensive and frustrating
to have
to make changes of this kind to make sure that a signfiicantly more
complex VM
such as Terf's builds correctly.
Hi Eliot,
Just a heads up in case it is not showing in the automated buids. I am getting build failures, apparently related to these changes. The last working version for me is 9f1b4644e7396e473bd9bb4cf67f8a9d5a4e11d6
Thanks for the heads up. Looking at it now. The cogit files don't include sq.h so they don't pick up sq.h's default definition of EXPORT et al. I'm testing what happens if I move the def to sqMemoryAccess.h (so far so good on linux, but have to test on Windows & Mac). Putting them in sqMemoryAccess.h clearly shows an issue with the cogitFOO.c files, which include sqMemoryAccess.h *before* sqPlatformSpecific.h. That can't work, so if I do decide to move EXPORT et al to sqMemoryAccess.h I'll have to change the header file declarations of the cogit files to get sqPlatformSpecific.h before sqMemoryAccess.h. This is such a mess :-(.
I am working on Ubuntu 16.04 LTS and currently building from opensmalltalk-vm/build.linux64x64/squeak.stack.spur/build.debug
With the latest Cog branch the LOG shows:
In file included from /home/lewis/squeak/git/opensmalltalk-vm/platforms/Cross/vm/sqVirtualMachine.c:8: /home/lewis/squeak/git/opensmalltalk-vm/platforms/Cross/vm/sqAssert.h:24:14: error: expected function body after function declarator EXPORT(void) error(const char *); ^ /home/lewis/squeak/git/opensmalltalk-vm/platforms/Cross/vm/sqAssert.h:25:14: error: expected function body after function declarator EXPORT(void) warning(const char *); ^ /home/lewis/squeak/git/opensmalltalk-vm/platforms/Cross/vm/sqAssert.h:26:14: error: expected function body after function declarator EXPORT(void) warningat(const char *,int);
Dave