On Sat, Mar 19, 2011 at 04:39:05PM +0100, Igor Stasenko wrote:
On 19 March 2011 17:09, squeak-dev-noreply@lists.squeakfoundation.org wrote:
Dave Lewis uploaded a new version of VMMaker to project VM Maker: http://www.squeaksource.com/VMMaker/VMMaker-dtl.222.mcz
==================== Summary ====================
Name: VMMaker-dtl.222 Author: dtl Time: 19 March 2011, 11:09:09 am UUID: 809d5eb5-6f73-4e6a-a595-428ed4536dc0 Ancestors: VMMaker-dtl.221
Fix MiscPrimitivePluginTest to properly test behavior of #primitiveFindSubstring and verify presence of a fix in TMethod>>argConversionExprFor:stackIndex: that performs type checking on string arguments.
Dave, could you check it for oscog branch too?
Hi Igor,
Actually I was going to reply to your earlier question about tests that you can run in an image (without VMMaker) that provide coverage for the VM. But as soon as I looked at it I realized that I has screwed this one up, so I fixed it and this the change you see posted here.
There are a number of tests in the VMMaker package, mostly accumlated during bug fixing but also some stuff to support the work I did to support 64 and 32 bit images from a single code base (hence not immediately relevant for inclusion in oscog). The two tests that might be useful outside of VMMaker are JPEGReadWriter2PluginTest and MiscPrimitivePluginTest, so I am attaching fileouts for these two. Have a look and see if you thing they should go in the main Squeak/Pharo images, or stay in VMMaker(s). These two along with BitBltSimulationTest would also be suitable to include in oscog.
I have stayed away from committing anything directly to the oscog branch out of concern that it may lead to confusion between the two branches if my 'dtl' initials start showing up there. I do have some changes that can be applied to oscog (mostly to get rid of cosmetic differences between the two branches that clutter up the Montecello browser). I've sent a few of these to Eliot but I don't know if that is the preferred approach going forward. Advice welcome, as I do want to put some more effort into reconciling the code bases pretty soon.
Dave