Hi Ben,
can you tell me what path-related limits limits.h does define on win64? e.g. there should be something like POSIX_PATH_MAS or XOPEN_PATH_MAX, and if neither of these is available, and nothing else looks relevant we can define a default. I already put in a default; see platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c But can we do better on win64/win32?
On Fri, May 12, 2017 at 9:38 AM, Ben Coman btc@openinworld.com wrote:
Just to note that builds...
- Environment: FLAVOR=squeak.stack.spur, ARCH=win64x64,
CYG_ROOT=C:\cygwin64, CYG_SETUP=setup-x86_64.exe, MINGW_ARCH=x86_64
- Environment: FLAVOR=pharo.stack.spur, ARCH=win64x64,
CYG_ROOT=C:\cygwin64, CYG_SETUP=setup-x86_64.exe, MINGW_ARCH=x86_64 are currently failing due to... ../../platforms/Cross/plugins/B3DAcceleratorPlugin/ sqOpenGLRenderer.c:85:17: error: use of undeclared identifier 'PATH_MAX' char fileName[PATH_MAX+1];
The change from imageNameSize() to PATH_MAX seems to be from 11 days ago per... https://ci.appveyor.com/project/OpenSmalltalk/vm/build/1.0.637 "Add the B3DAcceleratorPlugin (OpenGL interface) to the 32-bit Mac build"
Diff... https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ 995e7aedc3b5aeb76904f92abbd8a7a1bcf8138f
cheers -ben