@ronsaldo pushed 1 commit.

ea78e18 Set the version of the metal shading language to use.

@ronsaldo pushed 1 commit.

24705af Use osx-metal1.1 instead macos-metal1.1.

@ronsaldo pushed 1 commit.

4380ab9 I added a workaround for the different versions of the metallib tool.

On Sat, Nov 10, 2018 at 11:24:46PM -0800, Ronie Salgado wrote:

Because OpenGL is being deprecated by Apple, use Metal instead of OpenGL for main VM window in OS X.

Very nice to see this :-)

Dave

@eliotmiranda pushed 1 commit.

e42d3d1 Update Makefile.rules

Superb work, Ronie. So thorough. Shame about the selector comparisons in doCommandBySelector:; I know the time isn't an issue but it's ugly :-) I suppose we could implement the selectors instead.

About platforms/iOS/vm/OSX/SqueakMainShaders.metal.inc , I agree, but the metal build tools were not working on CI, and I did not want to bump up the required version of XCode. So I ended copying the approach of offline compilation from SDL2. I just added the comment.

Well as for the doCommandBySelector; comparison, I copied most of the event related stuff from the sqSqueakOSXOpenGLView.m and sqSqueakOSXCGView.m . I think that someone else should refactor these parts in order to avoid code duplication.

Lets not allow this go stale. What is blocking it? Can the CI be bumped to check how it fits with recent movement of Cog branch. @eliotmiranda, are you satisfied with Ronnie's commit 6e1da75? @fniephaus, unless its blocking, lets move any macOS version bump to a separate issue. @johnmci, are you available to review? otherwise please advise us not to wait.

unless its blocking, can any macOS version bump be done in a separate issue?

Sure, no need to bump the version at all if it's not required by this change.

fniephaus commented on this pull request.

• // Alawys try to fill the texture with the pixels.

+ if ( fullScreendispBitsIndex ) { + [self loadTexturesFrom: fullScreendispBitsIndex subRectangle: (clippyIsEmpty ? rect : NSRectFromCGRect(clippy))]; + //[self loadTexturesFrom: fullScreendispBitsIndex subRectangle: rect]; + clippyIsEmpty = YES; + syncNeeded = NO; + } + + MTLRenderPassDescriptor *renderPassDescriptor = self.currentRenderPassDescriptor; + if(renderPassDescriptor != nil && self.currentDrawable) + { + currentCommandBuffer = [graphicsCommandQueue commandBuffer]; + currentRenderEncoder = [currentCommandBuffer renderCommandEncoderWithDescriptor: renderPassDescriptor]; + + // Set the viewport. + [currentRenderEncoder setViewport: (MTLViewport){0.0, 0.0, lastFrameSize.size.width, lastFrameSize.size.height}];

When I change this line to ```c [currentRenderEncoder setViewport: (MTLViewport){0.0, 0.0, lastFrameSize.size.width * 2, lastFrameSize.size.height * 2}]; ```

the problem I mentioned in https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/306#issuecomment-4532... goes away. But this is probably not the right fix.

Hi Ben,

On Thu, Jan 10, 2019 at 5:06 AM Ben Coman notifications@github.com wrote:

Please respond... @eliotmiranda https://github.com/eliotmiranda, are you satisfied with Ronnie's commit 6e1da75 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6e1da7500a653eb906606562145a8f863e25fab4 ?

yes

@johnmci https://github.com/johnmci, are you available to review as Fabio requested? otherwise please advise us not to wait. @fniephaus https://github.com/fniephaus, unless its blocking, can any macOS version bump be done in a separate issue?

_,,,^..^,,,_ best, Eliot

ronsaldo commented on this pull request.

• // Alawys try to fill the texture with the pixels.

+ if ( fullScreendispBitsIndex ) { + [self loadTexturesFrom: fullScreendispBitsIndex subRectangle: (clippyIsEmpty ? rect : NSRectFromCGRect(clippy))]; + //[self loadTexturesFrom: fullScreendispBitsIndex subRectangle: rect]; + clippyIsEmpty = YES; + syncNeeded = NO; + } + + MTLRenderPassDescriptor *renderPassDescriptor = self.currentRenderPassDescriptor; + if(renderPassDescriptor != nil && self.currentDrawable) + { + currentCommandBuffer = [graphicsCommandQueue commandBuffer]; + currentRenderEncoder = [currentCommandBuffer renderCommandEncoderWithDescriptor: renderPassDescriptor]; + + // Set the viewport. + [currentRenderEncoder setViewport: (MTLViewport){0.0, 0.0, lastFrameSize.size.width, lastFrameSize.size.height}];

Hi, sorry for taking too long. I was completely busy with my job. I just changed the code to use the size from the drawableSurface property, instead of the size of the window. Can you check whether this fixes the issue or not?