riscv64abicc.c for AlienInbox:Alien-Core-Kend-124 You can view, comment on, or merge this pull request online at:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648
-- Commit Summary --
* Works w current vm + Alien-Core-KenD-124.mcz
-- File Changes --
M platforms/Cross/plugins/IA32ABI/riscv64abicc.c (15)
-- Patch Links --
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/648.diff
@KenDickey pushed 1 commit.
fe89d2a2335093ff1808565eb62c420fe072c67a re-removed TARGET clause
@KenDickey pushed 1 commit.
f6aa4a3d8464792ef9c58736733e96dde988c402 Flag tweaks for riscv64
@krono commented on this pull request.
@@ -12093,7 +12093,7 @@ $as_echo "$build_arch" >&6; }
;;
riscv64) TARGET_ARCH="-march=rv64gcv -mabi=lp64d" - CFLAGS="-g -O2 -D__linux__ -D__riscv64__" + CFLAGS="-g -O2 -D__riscv64__"
@KenDickey Plesae, put the `configure` changes into `configure.ac` otherwise they are gone the next time autoconf runs…
@KenDickey pushed 1 commit.
d8cc654cb9d6681b6572bcd4512ad34160195a4b riscv64
@KenDickey pushed 1 commit.
098caeb8f4cd22d72f2c3f09b9995b4fc2463b2e removed unneeded compiler flags
@KenDickey commented on this pull request.
@@ -12093,7 +12093,7 @@ $as_echo "$build_arch" >&6; }
;;
riscv64) TARGET_ARCH="-march=rv64gcv -mabi=lp64d" - CFLAGS="-g -O2 -D__linux__ -D__riscv64__" + CFLAGS="-g -O2 -D__riscv64__"
Thanks. I believe I have all the compiler flag fixes in.
Tested 'Alien exampleCqsort' with images built from mvm's on build, build.debug, and build.assert branckes. AOK.
@eliotmiranda commented on this pull request.
@@ -12093,7 +12093,7 @@ $as_echo "$build_arch" >&6; }
;;
riscv64) TARGET_ARCH="-march=rv64gcv -mabi=lp64d" - CFLAGS="-g -O2 -D__linux__ -D__riscv64__" + CFLAGS="-g -O2 -D__riscv64__"
Ken, I feel uneasy with the unique solution to the offset of the thunk. I'd rather have riscv64 be consistent with all the other platforms and adjust the offset to the thunk in thunkEntry, not in specific code in Smalltalk. Can you live with that?
On 2022-08-03 15:01, Eliot Miranda wrote:
@ELIOTMIRANDA commented on this pull request.
..
Ken, I feel uneasy with the unique solution to the offset of the thunk. I'd rather have riscv64 be consistent with all the other platforms and adjust the offset to the thunk in thunkEntry, not in specific code in Smalltalk. Can you live with that?
Sure. Just remove the overwritten method. If you look at the latest, the offset is zero.
-KenD
On Wed, Aug 3, 2022 at 5:23 PM Ken Dickey ***@***.***> wrote:
On 2022-08-03 15:01, Eliot Miranda wrote:
@ELIOTMIRANDA commented on this pull request.
..
Ken, I feel uneasy with the unique solution to the offset of the thunk. I'd rather have riscv64 be consistent with all the other platforms and adjust the offset to the thunk in thunkEntry, not in specific code in Smalltalk. Can you live with that?
Sure. Just remove the overwritten method. If you look at the latest, the offset is zero.
OK. Fix thunkEntry to put back the offset and then I can merge the pull request.
_,,,^..^,,,_ best, Eliot
On 2022-08-04 12:09, Eliot Miranda wrote:
On Wed, Aug 3, 2022 at 5:23 PM Ken Dickey ***@***.***> wrote:
..
Sure. Just remove the overwritten method. If you look at the latest, the offset is zero.
OK. Fix thunkEntry to put back the offset and then I can merge the pull request.
riscv64abicc.c as pull request should have ... vmcc.thunkp = thunkp; ... which works fine without override of Callback>>addToThunkTable. No offset required in either place.
So color me confused.
I can re-push the Alien-Core-Kend without the #addToThunkTable override if you like, but the current pull requiest should work with Alien-Core-Kend.124 as is.
How about accepting the pull and the Alien-Code, let me re-retest, and we will fix any breakage from there.
Epsilon close, -KenD
@eliotmiranda approved this pull request.
@KenDickey pushed 1 commit.
8b80bc84face2d352bf01ddff6326a1fc3cad9a1 dump some registers on fault
Tested riscv64 partial register dump via SIGSEGV -- looks OS (sqUnixMain.c)
kill -s 11 <squeakPID>
Merged #648 into Cog.
vm-dev@lists.squeakfoundation.org
-
Eliot Miranda -
Ken Dickey
-
Tobias Pape