Hi Guys -
Making progress with the new build setup only to run into other issues ;-) This time it's RePlugin: It seems I'm having trouble with RePlugin's config.h (Cross/plugins/RePlugin/config.h) conflicting with the interpreter's config.h (win32/vm/config.h).
The generated RePlugin.c includes:
- sqVirtualMachine.h which includes - sqMemoryAccess.h which includes - config.h (from vm/config.h)
but RePlugin.c also includes
- internal.h which includes - config.h (from RePlugin/config.h)
Since my current search path setup prefers RePlugin/config.h over vm/config.h sqMemoryAccess complains loudly over the absence of various definitions. On the other, changing the search paths to prefer vm/config.h compiles - but ignoring the settings in RePlugin/config.h surely isn't the right thing to do, is it?
Any proposals on how to fix this?
Cheers, - Andreas
On Tue, Sep 05, 2006 at 01:14:17PM -0700, Andreas Raab wrote:
Hi Guys -
Making progress with the new build setup only to run into other issues ;-) This time it's RePlugin: It seems I'm having trouble with RePlugin's config.h (Cross/plugins/RePlugin/config.h) conflicting with the interpreter's config.h (win32/vm/config.h).
Cross/plugins/RePlugin/config.h appears to be junk. It defines four variables, none of which is actually used in the plugin (NEWLINE is used, but is defined elsewhere in another header). Furthermore, it claims to have been automatically generated by configure, which makes no sense for a file in platforms/Cross.
Dave
David T. Lewis wrote:
Cross/plugins/RePlugin/config.h appears to be junk. It defines four variables, none of which is actually used in the plugin (NEWLINE is used, but is defined elsewhere in another header). Furthermore, it claims to have been automatically generated by configure, which makes no sense for a file in platforms/Cross.
So should we remove it and change internal.h not to include it?
Cheers, - Andreas
On Wed, Sep 06, 2006 at 10:18:43AM -0700, Andreas Raab wrote:
David T. Lewis wrote:
Cross/plugins/RePlugin/config.h appears to be junk. It defines four variables, none of which is actually used in the plugin (NEWLINE is used, but is defined elsewhere in another header). Furthermore, it claims to have been automatically generated by configure, which makes no sense for a file in platforms/Cross.
So should we remove it and change internal.h not to include it?
Yes and no.
Both config.h and oldInternal.h can be deleted. No change should be made to internal.h, as it needs to include the real config.h.
But I am not the owner of RePlugin, and if such a person exists, s/he should take care of it. Otherwise I guess it's Tim by default ;)
Dave
vm-dev@lists.squeakfoundation.org
-
Andreas Raab -
David T. Lewis