Vm-dev March 2020

vm-dev@lists.squeakfoundation.org

31 participants
136 discussions

Squeak5.3 OK on ArmV8 Stack+Spur
by ken.dickey＠whidbey.com 17 Mar '20

17 Mar '20

You'all probably know this, but I just git-cloned OpenSmalltalk and built sqstkspur64ARMv8linuxht which interprets Squeak5.3 (and Cuis) just fine on a Chromebook 2. FYI, -KenD

3 2

Re: [Vm-dev] [squeak-dev] Squeak5.3 linux ARMv6 segfaults on startup
by Levente Uzonyi 17 Mar '20

17 Mar '20

(cc'd vm-dev for real) On Mon, 16 Mar 2020, Levente Uzonyi wrote: > Hi Bruce, > > (cc'd vm-dev list) > That looks interesting. > If you have a look at the output of > > git diff 0b4551db2e5c00f67502250d0336757ed12ab096 > f5ec3f4fa2b61af86bbc2b82a1dabe5bfafe8f4e > > you'll see that only the type declarations of a few methods changed, and the > only change is that int was rewritten to sqInt. > On 32-bit platforms sqInt is int, so that commit should make no difference at > all. > (just saw that Nicolas had a look at this as well) > > Are you sure that's the first bad commit? > > The next commit (0f0b5324b6e41cda7f92c335d45e563d41285ccd) contains multiple > arm specific changes according to its message. E.g.: > >> Fix old bug in ARM32 LoadEffectiveAddressMwrR >> Improve the ARM32 trampoline marshalling code fractionally. > >> A number of small improvements to context creation as part of > reversing the >> order of comparison of the SPReg with anythin g else, to suit ARMv8. > >> Get the ARMv5 "stop" instruction (BKPT) correct. > > Which version of gcc did you use to compile the VM? > > > Levente > > On Mon, 16 Mar 2020, Bruce O'Neel wrote: > >> >> Hi, >> >> So since I can seem to build things on my PI, I spent last evening running >> git bisects. What that came up with was below. The first bad commit does >> seem like somewhere things could go bad with 32 vs 64 bit, and, possibly >> unaligned access? Our main test case are the x86 and the x86-64 machines >> which are famous >> for doing unaligned access with few complaints. >> >> Now >> this http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.faqs/ka15414.ht… claims >> that as of ARMv6 unaligned access is allowed and done in hardware. One >> wonders if it is completely correctly done, and, this isn't something in >> Debian/Raspberian, or the hardware, or ???? >> >> Of course, that might be a rabbit hole as well. >> >> cheers >> >> bruce >> >> /work/share/tmp/opensmalltalk-vm$ git bisect good >> >> f5ec3f4fa2b61af86bbc2b82a1dabe5bfafe8f4e is the first bad commit >> >> commit f5ec3f4fa2b61af86bbc2b82a1dabe5bfafe8f4e >> >> Author: smalltalking <leves(a)caesar.elte.hu> >> >> Date: Wed Jan 8 10:55:18 2020 +0000 >> >> >> Fix type inconsistencies (int vs sqInt) (#464) >> >> >> >> * Fix type inconsistencies (int vs sqInt) >> >> >> >> Found by trying to compile with LTO enabled. >> >> The VM compiles with the updated types on linux with or without LTO >> enabled (the LTO VM is not functional). >> >> Didn't test with the OSes but changed the declarations in their files. >> >> Affected functions: >> >> - primInIOProcessEventsFlagAddress >> >> - ioGatherEntropy >> >> - GetAttributeString >> >> - primitivePluginBrowserReady >> >> - primitivePluginDestroyRequest >> >> - primitivePluginRequestFileHandle >> >> - primitivePluginRequestState >> >> - primitivePluginRequestURL >> >> - primitivePluginRequestURLStream >> >> - primitivePluginPostURL >> >> >> >> * Include sqMemoryAccess.h to have sqInt defined >> >> >> :040000 040000 1488890eae3ef3147710b08b2cdf07b98e57b763 >> d6f7b25507a86fe9c5e618ccd03088598d9bc852 M platforms >> >> :040000 040000 97c8f9d7a00839fa93d472a8840abec8c42ff45c >> 1e678e1e08e5badd258cce1a4a20d5c6243b39a8 M src >> >> >> >> >> Last good commit >> >> >> commit 0b4551db2e5c00f67502250d0336757ed12ab096 >> >> Merge: f219b7218 afbf9e015 >> >> Author: Fabio Niephaus <code(a)fniephaus.com> >> >> Date: Mon Jan 6 17:08:45 2020 +0100 >> >> >> Merge pull request #466 from OpenSmalltalk/dtl/build-script-patch [ci >> skip] >> >> >> >> Fix image MC loading glitch in image build scripts when checking pack… >> >> >> >> >> >> With the last good commit I have a working ARM COG vm. >> >> Image >> ----- >> /work/share/tmp/Squeak5.3-19431-32bit.image >> Squeak5.3 >> latest update: #19431 >> Current Change Set: HomeProject >> Image format 6521 (32 bit) >> >> Virtual Machine >> --------------- >> /work/share/tmp/opensmalltalk-vm/build.linux32ARMv6/squeak.cog.spur/build/squeak >> Open Smalltalk Cog[Spur] VM [CoInterpreterPrimitives >> VMMaker.oscog-eem.2597] >> Unix built on Mar 16 2020 09:27:25 Compiler: 6.3.0 20170516 >> platform sources revision VM: 202001061608 >> :/work/share/tmp/opensmalltalk-vm Date: Mon Jan 6 17:08:45 2020 CommitHash: >> 0b4551db2 Plugins: 202001061608 :/work/share/tmp/opensmalltalk-vm >> CoInterpreter VMMaker.oscog-eem.2597 uuid: >> 7a69be2e-f0d0-4d41-9854-65432d621fed Mar 16 2020 >> StackToRegisterMappingCogit VMMaker.oscog-eem.2597 uuid: >> 7a69be2e-f0d0-4d41-9854-65432d621fed Mar 16 2020 >> >> To Build A Similar Virtual Machine >> ---------------------------------- >> Visit https://github.com/OpenSmalltalk/opensmalltalk-vm; follow the >> "Clone or download" instructions, then read the top-level README.md >> and HowToBuild files in the top-level build directory for your >> platform(s), build.macos64x64/HowToBuild, build.win32x86/HowToBuild, etc. >> >> >> Image >> ----- >> /work/share/tmp/Squeak6.0alpha-19511-32bit.image >> Squeak6.0alpha >> latest update: #19511 >> Current Change Set: HomeProject >> Image format 6521 (32 bit) >> >> Virtual Machine >> --------------- >> /work/share/tmp/opensmalltalk-vm/build.linux32ARMv6/squeak.cog.spur/build/squeak >> Open Smalltalk Cog[Spur] VM [CoInterpreterPrimitives >> VMMaker.oscog-eem.2597] >> Unix built on Mar 16 2020 09:27:25 Compiler: 6.3.0 20170516 >> platform sources revision VM: 202001061608 >> :/work/share/tmp/opensmalltalk-vm Date: Mon Jan 6 17:08:45 2020 CommitHash: >> 0b4551db2 Plugins: 202001061608 :/work/share/tmp/opensmalltalk-vm >> CoInterpreter VMMaker.oscog-eem.2597 uuid: >> 7a69be2e-f0d0-4d41-9854-65432d621fed Mar 16 2020 >> StackToRegisterMappingCogit VMMaker.oscog-eem.2597 uuid: >> 7a69be2e-f0d0-4d41-9854-65432d621fed Mar 16 2020 >> >> To Build A Similar Virtual Machine >> ---------------------------------- >> Visit https://github.com/OpenSmalltalk/opensmalltalk-vm; follow the >> "Clone or download" instructions, then read the top-level README.md >> and HowToBuild files in the top-level build directory for your >> platform(s), build.macos64x64/HowToBuild, build.win32x86/HowToBuild, etc. >> >> Tiny Benchmarks >> --------------- >> 320,000,000 bytecodes/sec; 19,000,000 sends/sec >> >> >> 15 March 2020 23:39 tim Rowledge <tim(a)rowledge.org> wrote: >> >> >> > On 2020-03-15, at 1:11 PM, Bruce O'Neel wrote: >> > >> > >> > Hi, >> > >> > It looks like >> > >> > sudo apt-get install libgl1-mesa-dev >> > >> > replaces >> > >> > sudo apt-get install libgl-mesa-dev >> >> Looks like it; at least it built ok. Eventually we'll see if it works! >> >> >> tim >> -- >> tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim >> Oxymorons: Act naturally >> >> >> >> >> >> >

4 6

Re: [Vm-dev] [squeak-dev] Squeak5.3 linux ARMv6 segfaults on startup
by tim Rowledge 17 Mar '20

17 Mar '20

Oops. forward here where it belongs. > Begin forwarded message: > > From: tim Rowledge <tim(a)rowledge.org> > Subject: Re: [squeak-dev] [Vm-dev] Squeak5.3 linux ARMv6 segfaults on startup > Date: March 16, 2020 at 4:42:43 PM PDT > To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org> > > It looks like sometihng caused the CogARMCompiler>>#rotateable8bitImmediate:ifTrue:ifFalse: to get translated in a way that messes up the block args for the falseBlock (which are supposed to be the requird rotation and immediate values. > > What we get is > /* begin rotateable8bitImmediate:ifTrue:ifFalse: */ > if ((offset27 & 0xFF) == offset27) { > /* begin machineCodeAt:put: */ > aWord42 = addrnimmror(self_in_dispatchConcretize, destReg1, srcReg9, immediate5, rot5); > ((self_in_dispatchConcretize->machineCode))[0 / 4] = aWord42; > return 4; > } > for (i5 = 2; i5 <= 30; i5 += 2) { > if ((offset27 & (((0xFFU << i5) & 0xFFFFFFFFU) | (((usqInt)(0xFF)) >> (32 - i5)))) == offset27) { > /* begin machineCodeAt:put: */ > aWord42 = addrnimmror(self_in_dispatchConcretize, destReg1, srcReg9, immediate5, rot5); > ((self_in_dispatchConcretize->machineCode))[0 / 4] = aWord42; > return 4; > } > } > ... when we should get more like - > > /* begin rotateable8bitImmediate:ifTrue:ifFalse: */ > if ((offset27 & 0xFF) == offset27) { > /* begin machineCodeAt:put: */ > aWord37 = addrnimmror(self_in_dispatchConcretize, destReg1, srcReg7, offset27, 0U << 1); > ((self_in_dispatchConcretize->machineCode))[0 / 4] = aWord37; > (self_in_dispatchConcretize->machineCodeSize) = 4; > goto l204; > } > for (i4 = 2; i4 <= 30; i4 += 2) { > if ((offset27 & (((0xFFU << i4) & 0xFFFFFFFFU) | (((usqInt) 0xFF) >> (32 - i4)))) == offset27) { >>>>>>>>> rot4 = 32 - i4; <<<<<<<<<<< >>>>>>>>> immediate4 = (((usqInt) offset27) >> i4) | ((offset27 << (32 - i4)) & 0xFFFFFFFFU); <<<<<<<<<<< > /* begin machineCodeAt:put: */ > aWord37 = addrnimmror(self_in_dispatchConcretize, destReg1, srcReg7, immediate4, ((sqInt)((usqInt)(rot4) << 1))); > ((self_in_dispatchConcretize->machineCode))[0 / 4] = aWord37; > (self_in_dispatchConcretize->machineCodeSize) = 4; > goto l204; > } > } > (ignoring for a moment the desired change in the last couple of lines) > > The actual code for CogARMCompiler>>#rotateable8bitImmediate:ifTrue:ifFalse: hasn't changed since 2015 so it's some other part of the system at fault. Do I recall correctly that some changes were recently made in the translator stuff for type-fiddling? > > tim > -- > tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim > Don't diddle code to make it faster; find a better algorithm. > > > Begin forwarded message: > > From: tim Rowledge <tim(a)rowledge.org> > Subject: Re: [squeak-dev] [Vm-dev] Squeak5.3 linux ARMv6 segfaults on startup > Date: March 16, 2020 at 4:42:43 PM PDT > To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org> > Reply-To: The general-purpose Squeak developers list <squeak-dev(a)lists.squeakfoundation.org> > > It looks like sometihng caused the CogARMCompiler>>#rotateable8bitImmediate:ifTrue:ifFalse: to get translated in a way that messes up the block args for the falseBlock (which are supposed to be the requird rotation and immediate values. > > What we get is > /* begin rotateable8bitImmediate:ifTrue:ifFalse: */ > if ((offset27 & 0xFF) == offset27) { > /* begin machineCodeAt:put: */ > aWord42 = addrnimmror(self_in_dispatchConcretize, destReg1, srcReg9, immediate5, rot5); > ((self_in_dispatchConcretize->machineCode))[0 / 4] = aWord42; > return 4; > } > for (i5 = 2; i5 <= 30; i5 += 2) { > if ((offset27 & (((0xFFU << i5) & 0xFFFFFFFFU) | (((usqInt)(0xFF)) >> (32 - i5)))) == offset27) { > /* begin machineCodeAt:put: */ > aWord42 = addrnimmror(self_in_dispatchConcretize, destReg1, srcReg9, immediate5, rot5); > ((self_in_dispatchConcretize->machineCode))[0 / 4] = aWord42; > return 4; > } > } > ... when we should get more like - > > /* begin rotateable8bitImmediate:ifTrue:ifFalse: */ > if ((offset27 & 0xFF) == offset27) { > /* begin machineCodeAt:put: */ > aWord37 = addrnimmror(self_in_dispatchConcretize, destReg1, srcReg7, offset27, 0U << 1); > ((self_in_dispatchConcretize->machineCode))[0 / 4] = aWord37; > (self_in_dispatchConcretize->machineCodeSize) = 4; > goto l204; > } > for (i4 = 2; i4 <= 30; i4 += 2) { > if ((offset27 & (((0xFFU << i4) & 0xFFFFFFFFU) | (((usqInt) 0xFF) >> (32 - i4)))) == offset27) { >>>>>>>>> rot4 = 32 - i4; <<<<<<<<<<< >>>>>>>>> immediate4 = (((usqInt) offset27) >> i4) | ((offset27 << (32 - i4)) & 0xFFFFFFFFU); <<<<<<<<<<< > /* begin machineCodeAt:put: */ > aWord37 = addrnimmror(self_in_dispatchConcretize, destReg1, srcReg7, immediate4, ((sqInt)((usqInt)(rot4) << 1))); > ((self_in_dispatchConcretize->machineCode))[0 / 4] = aWord37; > (self_in_dispatchConcretize->machineCodeSize) = 4; > goto l204; > } > } > (ignoring for a moment the desired change in the last couple of lines) > > The actual code for CogARMCompiler>>#rotateable8bitImmediate:ifTrue:ifFalse: hasn't changed since 2015 so it's some other part of the system at fault. Do I recall correctly that some changes were recently made in the translator stuff for type-fiddling? > > tim > -- > tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim > Don't diddle code to make it faster; find a better algorithm. > > > > tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Any given program will expand to fill available memory.

1 0

Re: [Vm-dev] [squeak-dev] SHA512 squeak implementation?
by Robert 16 Mar '20

16 Mar '20

Resending with correct recipient addresses. My van-dev was wrong. Kindly, Robert On Thu, Mar 5, 2020 at 09:21, Robert via Squeak-dev <squeak-dev(a)lists.squeakfoundation.org> wrote: > Hello everyone, I could have sworn that someone mentioned a squeak implementation of SHA512 that’s out there somewhere, but in looking back over all the emails I failed to find any mention of it. > > If there is a SHA512 implementation anyone knows about, would you send me a link, please? > > Kindly, > Robert

5 26

Re: [Vm-dev] ProCrypto v1.1.1 Re: [squeak-dev] SHA512 squeak implementation?
by Robert 15 Mar '20

15 Mar '20

My image was still the large one. Here is the email with a smaller image to forward...Alright, another send, with a Smalltalk cheat sheet for newbies and a smaller resolution image so the email is not too large. Forward these links to folks, please! Cheers! Load doIt: Installer ss project: 'Cryptography'; install: 'ProCrypto-1-1-1'; install: 'ProCryptoTests-1-1-1'. k, r ProCrypto 1.1.1 flyer: https://www.dropbox.com/s/7y7ngnya9qeg5gf/ProCrypto-1-1-1.pdf?dl=0 Smalltalk Cheat Sheet: [https://www.dropbox.com/s/p4iz51a0qouv8wu/st-cheatsheet.pdf?dl=0](https://w… On 3/13/20 11:29 AM, Robert wrote: > Hey all'y'all, > > There is a new release of ProCrypto-1-1-1. I split out the Tests from all Crypto packages and created a Monticello config map to load all CryptoTests packages. > > Here is code to load all Cryptography packages and all CryptoTests packages:

2 6

VM Maker: Cog-eem.402.mcz
by commits＠source.squeak.org 12 Mar '20

12 Mar '20

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.402.mcz ==================== Summary ==================== Name: Cog-eem.402 Author: eem Time: 12 March 2020, 1:01:58.130173 pm UUID: 37e10bd3-aae4-4dfa-9f4b-d0a4ed0caa3d Ancestors: Cog-eem.401 Spur 32<->64 bit conversion. Fix a bug in testing formats in fillInObjects (how did this ever work??). Fix a bug with conversion and SistaV1/FullBlocks; the method header integer was not correctly mapped on 64->32 bit conversion. Update conversion to mark literals expanded from large immediates on 64->32 bit conversion as immutable, if it appears that literals are immutable in the source image. Do a better job of renaming, avoiding e.g. trunk6-64-32. =============== Diff against Cog-eem.401 =============== Item was removed: - ----- Method: Spur32to64BitImageConverter>>fileNameExtension (in category 'private-accessing') ----- - fileNameExtension - ^'-64'! Item was added: + ----- Method: Spur32to64BitImageConverter>>mapMethodHeaderOop: (in category 'bootstrap image') ----- + mapMethodHeaderOop: sourceSmallInteger + ^targetHeap integerObjectOf: (sourceHeap integerValueOf: sourceSmallInteger)! Item was added: + ----- Method: Spur32to64BitImageConverter>>rename: (in category 'private-accessing') ----- + rename: baseName + ^(baseName endsWith: '32') + ifTrue: [(baseName allButLast: 2), '64'] + ifFalse: [baseName, '-64']! Item was changed: SpurMtoNBitImageConverter subclass: #Spur64to32BitImageConverter + instanceVariableNames: 'numReadOnly numCompiledCode' - instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Cog-Bootstrapping'! Item was added: + ----- Method: Spur64to32BitImageConverter>>alterSystem (in category 'bootstrap image') ----- + alterSystem + super alterSystem. + self ensureAllLiteralsAreReadOnlyIfLiteralsAppearToBeReadOnly! Item was changed: ----- Method: Spur64to32BitImageConverter>>clone: (in category 'bootstrap image') ----- clone: sourceObj | targetObj format numSlots numBytes hash | format := sourceHeap formatOf: sourceObj. numSlots := sourceHeap numSlotsOf: sourceObj. format > sourceHeap lastPointerFormat ifTrue: [format < sourceHeap firstByteFormat ifTrue: [format = sourceHeap sixtyFourBitIndexableFormat ifTrue: [numSlots := (sourceHeap numSlotsOf: sourceObj) * 2] ifFalse: [(format between: sourceHeap firstLongFormat and: sourceHeap firstLongFormat + 1) ifTrue: [numSlots := (sourceHeap numSlotsOf: sourceObj) * 2 - (format bitAnd: 1). format := format bitClear: 1] ifFalse: [self error: 'bad format']]] ifFalse: [numBytes := sourceHeap numBytesOf: sourceObj. format < sourceHeap firstCompiledMethodFormat ifTrue: + [numCompiledCode := numCompiledCode + 1. + numSlots := numBytes + 3 // 4. - [numSlots := numBytes + 3 // 4. format := targetHeap byteFormatForNumBytes: numBytes] ifFalse: [numSlots := sourceHeap numPointerSlotsOf: sourceObj. numBytes := numBytes - (numSlots * sourceHeap bytesPerOop). format := (targetHeap byteFormatForNumBytes: numBytes) + sourceHeap firstCompiledMethodFormat - sourceHeap firstByteFormat. numSlots := numSlots + (targetHeap numSlotsForBytes: numBytes)]]]. targetObj := targetHeap allocateSlots: numSlots format: format classIndex: (sourceHeap classIndexOf: sourceObj). (hash := sourceHeap rawHashBitsOf: sourceObj) ~= 0 ifTrue: [targetHeap setHashBitsOf: targetObj to: hash]. (sourceHeap isImmutable: sourceObj) ifTrue: + [numReadOnly := numReadOnly + 1. + targetHeap setIsImmutableOf: targetObj to: true]. - [targetHeap setIsImmutableOf: targetObj to: true]. (sourceHeap isPinned: sourceObj) ifTrue: [targetHeap setIsPinnedOf: targetObj to: true]. self deny: (sourceHeap isRemembered: sourceObj). self deny: (sourceHeap isMarked: sourceObj). self deny: (sourceHeap isGrey: sourceObj). reverseMap at: targetObj put: sourceObj. ^map at: sourceObj put: targetObj! Item was added: + ----- Method: Spur64to32BitImageConverter>>ensureAllLiteralsAreReadOnlyIfLiteralsAppearToBeReadOnly (in category 'bootstrap image') ----- + ensureAllLiteralsAreReadOnlyIfLiteralsAppearToBeReadOnly + numReadOnly <= (numCompiledCode // 4) ifTrue: [^self]. + targetHeap allOldSpaceObjectsDo: + [:o| + (targetHeap isCompiledMethod: o) ifTrue: + [1 to: (targetHeap literalCountOf: o) do: + [:i| self recursivelySetReadOnlyIfLiteralNumber: (targetHeap fetchPointer: i ofObject: o)]]]! Item was removed: - ----- Method: Spur64to32BitImageConverter>>fileNameExtension (in category 'private-accessing') ----- - fileNameExtension - ^'-32'! Item was added: + ----- Method: Spur64to32BitImageConverter>>mapMethodHeaderOop: (in category 'bootstrap image') ----- + mapMethodHeaderOop: sourceSmallInteger + "This is tricky; the sign bit is a bytecocde set flag, and other than the sign bit + only the least significant 31 bits of a method header SmallInteger are significant." + | value | + value := sourceHeap integerValueOf: sourceSmallInteger. + self assert: (value noMask: 16rFFFFFFFC0000000). + ^targetHeap integerObjectOf: (value < 0 + ifTrue: [(value bitAnd: targetHeap maxSmallInteger) + targetHeap minSmallInteger] + ifFalse: [value])! Item was changed: ----- Method: Spur64to32BitImageConverter>>on: (in category 'public access') ----- on: imageName (sourceInterpreter := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur64BitMemoryManager)) openOn: imageName extraMemory: 0. sourceHeap := sourceInterpreter objectMemory. imageHeaderFlags := sourceInterpreter getImageHeaderFlags. savedWindowSize := sourceInterpreter savedWindowSize. targetInterpreter := StackInterpreterSimulator newWithOptions: #(ObjectMemory Spur32BitMemoryManager). targetHeap := targetInterpreter objectMemory. targetHeap allocateMemoryOfSize: sourceHeap oldSpaceSize * 5 // 8 "LargeInteger and Float objects are created for out-of-range immediates" newSpaceSize: 8 * 1024 * 1024 stackSize: 16 * 1024 codeSize: 0. targetHeap bootstrapping: true. + numCompiledCode := numReadOnly := 0. "these are used to guess if literals are read-only..." + self initMaps + ! - self initMaps! Item was added: + ----- Method: Spur64to32BitImageConverter>>recursivelySetReadOnlyIfLiteralNumber: (in category 'bootstrap image') ----- + recursivelySetReadOnlyIfLiteralNumber: aLiteral + (targetHeap isImmediate: aLiteral) ifTrue: [^self]. + (targetHeap isArrayNonImm: aLiteral) ifTrue: + [^0 to: (targetHeap numSlotsOf: aLiteral) - 1 do: + [:i| self recursivelySetReadOnlyIfLiteralNumber: (targetHeap fetchPointer: i ofObject: aLiteral)]]. + ((targetHeap isPureBitsNonImm: aLiteral) "could be ByteString, ByteArray, Large[Posi|Nega]tiveInteger, BoxedFloat64" + and: [(targetHeap isImmutable: aLiteral) not]) ifTrue: "could only be Large[Posi|Nega]tiveInteger, BoxedFloat64 expanded from SmallInteger, SmallFloat64..." + [targetHeap setIsImmutableOf: aLiteral to: true]! Item was added: + ----- Method: Spur64to32BitImageConverter>>rename: (in category 'private-accessing') ----- + rename: baseName + ^(baseName endsWith: '64') + ifTrue: [(baseName allButLast: 2), '32'] + ifFalse: [baseName, '-32']! Item was changed: ----- Method: SpurMtoNBitImageConverter>>bootstrapImageUsingFileDirectory: (in category 'public access') ----- bootstrapImageUsingFileDirectory: imageName | dirName baseName dir | dirName := FileDirectory dirPathFor: imageName. baseName := (imageName endsWith: '.image') ifTrue: [FileDirectory baseNameFor: imageName] ifFalse: [FileDirectory localNameFor: imageName]. dir := dirName isEmpty ifTrue: [FileDirectory default] ifFalse: [FileDirectory default on: dirName]. self on: (dir fullNameFor: baseName, '.image'). [self bootstrapImage] on: Halt do: [:ex| "suppress halts from the usual suspects (development time halts)" (#(fullGC compactImage) includes: ex signalerContext sender selector) ifTrue: [ex resume] ifFalse: [ex pass]]. + self writeSnapshot: (dir fullNameFor: (self rename: baseName), '.image') - self writeSnapshot: (dir fullNameFor: baseName, self fileNameExtension, '.image') headerFlags: imageHeaderFlags screenSize: savedWindowSize. + dir deleteFileNamed: (self rename: baseName), '.changes'; + copyFileNamed: baseName, '.changes' toFileNamed: (self rename: baseName), '.changes'! - dir deleteFileNamed: baseName, self fileNameExtension, '.changes'; - copyFileNamed: baseName, '.changes' toFileNamed: baseName, self fileNameExtension, '.changes'! Item was removed: - ----- Method: SpurMtoNBitImageConverter>>fileNameExtension (in category 'private-accessing') ----- - fileNameExtension - self subclassResponsibility! Item was changed: ----- Method: SpurMtoNBitImageConverter>>fillInCompiledMethod:from: (in category 'bootstrap image') ----- fillInCompiledMethod: targetObj from: sourceObj + | sourceOop targetOop offset | - | offset | "sourceInterpreter printOop: sourceOop" "targetInterpreter printOop: targetOop" + targetHeap + storePointerUnchecked: 0 + ofObject: targetObj + withValue: (self mapMethodHeaderOop: (sourceHeap fetchPointer: 0 ofObject: sourceObj)). + 1 to: (sourceHeap numPointerSlotsOf: sourceObj) - 1 do: + [:i| - 0 to: (sourceHeap numPointerSlotsOf: sourceObj) - 1 do: - [:i| | sourceOop targetOop | sourceOop := sourceHeap fetchPointer: i ofObject: sourceObj. targetOop := self mapSourceOop: sourceOop. targetHeap storePointerUnchecked: i ofObject: targetObj withValue: targetOop]. offset := (targetInterpreter startPCOfMethod: targetObj) - (sourceInterpreter startPCOfMethod: sourceObj). (sourceInterpreter startPCOfMethod: sourceObj) to: (sourceHeap numBytesOf: sourceObj) - 1 do: [:j| targetHeap storeByte: offset + j ofObject: targetObj withValue: (sourceHeap fetchByte: j ofObject: sourceObj)]! Item was changed: ----- Method: SpurMtoNBitImageConverter>>fillInObjects (in category 'bootstrap image') ----- fillInObjects "sourceInterpreter printOop: sourceObj" | i freeListsObject | {sourceHeap markStack. sourceHeap weaklingStack. sourceHeap mournQueue} do: [:obj| obj ~= sourceHeap nilObject ifTrue: [map at: obj put: (map at: sourceHeap nilObject)]]. i := 0. freeListsObject := sourceHeap freeListsObject. sourceHeap allObjectsDo: [:sourceObj| (i := i + 1) >= 10000 ifTrue: [Transcript nextPut: $.; flush. i := 0]. (map at: sourceObj ifAbsent: nil) ifNotNil: [:targetObj| | format classIndex | (targetHeap numSlotsOf: targetObj) > 0 ifTrue: "filter-out filtered objStack pages" [format := sourceHeap formatOf: sourceObj. + (sourceHeap isPointersFormat: format) - (targetHeap isPointersFormat: format) ifTrue: + [((sourceHeap isIndexableFormat: format) - [((targetHeap isIndexableFormat: format) and: [(classIndex := targetHeap classIndexOf: targetObj) <= ClassBlockClosureCompactIndex and: [classIndex >= ClassMethodContextCompactIndex]]) ifTrue: [self fillInPointerObjectWithPC: targetObj from: sourceObj] ifFalse: [self fillInPointerObject: targetObj from: sourceObj]] ifFalse: + [(sourceHeap isCompiledMethodFormat: format) - [(targetHeap isCompiledMethodFormat: format) ifTrue: [self fillInCompiledMethod: targetObj from: sourceObj] ifFalse: [sourceObj ~= freeListsObject ifTrue: [self fillInBitsObject: targetObj from: sourceObj]]]]] ifNil: [self assert: (self isUnmappedObject: sourceObj)]]! Item was added: + ----- Method: SpurMtoNBitImageConverter>>mapMethodHeaderOop: (in category 'bootstrap image') ----- + mapMethodHeaderOop: sourceSmallInteger + self subclassResponsibility! Item was added: + ----- Method: SpurMtoNBitImageConverter>>rename: (in category 'private-accessing') ----- + rename: baseName + self subclassResponsibility!

1 0

ImageSegment crash dumps (macos64)
by Nicolas Cellier 12 Mar '20

12 Mar '20

Hi all, just to inform that I experience random crash dumps when running all tests (not always but twice in 2 days). This happens in ImageSegmentTest both with 5.3 (EncoderV3) and 6.0 (SistaV1) image, so must be unrelated to those changes. The VM is recompiled with head revision of Cog branch

1 0

VM Maker: VMMaker.oscog-eem.2727.mcz
by commits＠source.squeak.org 11 Mar '20

11 Mar '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2727.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2727 Author: eem Time: 11 March 2020, 1:30:57.591349 pm UUID: 64327c90-1337-4d4d-889b-bfb75e5ad066 Ancestors: VMMaker.oscog-eem.2726 Actally fix a bogus failing assert over-zealously added to the VMMaker.oscog-eem.2724 commit (really this time). Fix in-image compilation and rename specialObjectsArrayAddress to specialObjectsOopAddress to match the other fooAddress accessors. =============== Diff against VMMaker.oscog-eem.2726 =============== Item was changed: ----- Method: CogObjectRepresentationFor64BitSpur>>maybeGenerateSelectorIndexDereferenceRoutine (in category 'initialization') ----- maybeGenerateSelectorIndexDereferenceRoutine "Generate the routine that converts selector indices into selector objects. It is called from the send trampolines. If the selector index is negative, convert it into a positive index into the special selectors array and index that. Otherwise, index the current method. The routine uses Extra0Reg & Extra1Reg, which are available, since they are not live at point of send." | jumpNegative jumpNotBlock jumpFullBlock | <var: 'jumpNegative' type: #'AbstractInstruction *'> <var: 'jumpNotBlock' type: #'AbstractInstruction *'> <var: 'jumpFullBlock' type: #'AbstractInstruction *'> cogit zeroOpcodeIndex. cogit CmpCq: 0 R: ClassReg. jumpNegative := cogit JumpLess: 0. cogit MoveMw: FoxMethod r: FPReg R: Extra0Reg; AddCq: 2 R: ClassReg; "Change selector index to 1-relative, skipping the method header" TstCq: MFMethodFlagIsBlockFlag R: Extra0Reg. jumpNotBlock := cogit JumpZero: 0. "If in a block, need to find the home method... If using full blocks, need to test the cpicHasMNUCaseOrCMIsFullBlock bit" cogit AndCq: methodZone zoneAlignment negated R: Extra0Reg. SistaV1BytecodeSet ifTrue: [self bitAndByteOffsetOfIsFullBlockBitInto: [:bitmask :byteOffset| jumpFullBlock := cogit MoveMb: byteOffset r: Extra0Reg R: Extra1Reg; TstCq: bitmask R: Extra1Reg; JumpNonZero: 0]]. cogit MoveM16: 0 r: Extra0Reg R: Extra1Reg; SubR: Extra1Reg R: Extra0Reg. jumpNotBlock jmpTarget: cogit Label. SistaV1BytecodeSet ifTrue: [jumpFullBlock jmpTarget: jumpNotBlock getJmpTarget]. cogit "Now fetch the method object and index with the literal index to retrieve the selector" AndCq: methodZone zoneAlignment negated R: Extra0Reg; MoveMw: (cogit offset: CogMethod of: #methodObject) r: Extra0Reg R: Extra1Reg; MoveXwr: ClassReg R: Extra1Reg R: ClassReg; RetN: 0. jumpNegative jmpTarget: cogit Label. cogit NegateR: ClassReg; LogicalShiftLeftCq: 1 R: ClassReg; + MoveAw: objectMemory specialObjectsOopAddress R: Extra0Reg; - MoveAw: objectMemory specialObjectsArrayAddress R: Extra0Reg; SubCq: 1 R: ClassReg; MoveMw: SpecialSelectors + 1 * objectMemory wordSize r: Extra0Reg R: Extra1Reg; "Index, including header size" MoveXwr: ClassReg R: Extra1Reg R: ClassReg; RetN: 0. ceDereferenceSelectorIndex := cogit methodZoneBase. cogit outputInstructionsForGeneratedRuntimeAt: ceDereferenceSelectorIndex; recordGeneratedRunTime: 'ceDereferenceSelectorIndex' address: ceDereferenceSelectorIndex; recordRunTimeObjectReferences! Item was changed: ----- Method: CurrentImageCoInterpreterFacade>>cogit: (in category 'initialize-release') ----- cogit: aCogit + | accessors | cogit := aCogit. cogit objectMemory ifNil: [cogit instVarNamed: 'objectMemory' put: objectMemory]. coInterpreter cogit: aCogit. (objectMemory respondsTo: #cogit:) ifTrue: [objectMemory cogit: aCogit]. (objectMemory respondsTo: #coInterpreter:) ifTrue: [objectMemory coInterpreter: coInterpreter]. coInterpreter setUpForUseByFacade: self. objectMemory setUpForUseByFacade: self. + accessors := CurrentImageCoInterpreterFacade organization listAtCategoryNamed: #accessing. coInterpreter class clusteredVariableNames do: + [:var| + (Symbol lookup: (var first = $C ifTrue: ['c', var allButFirst] ifFalse: [var]), 'Address') ifNotNil: + [:accessor| + (accessors includes: accessor) ifTrue: + [self perform: accessor]]]. - [:var| self perform: ((var first = $C ifTrue: ['c', var allButFirst] ifFalse: [var]), 'Address') asSymbol]. self initializeObjectMap! Item was added: + ----- Method: CurrentImageCoInterpreterFacade>>specialObjectsOopAddress (in category 'accessing') ----- + specialObjectsOopAddress + self subclassResponsibility! Item was removed: - ----- Method: CurrentImageCoInterpreterFacadeFor64BitSpurObjectRepresentation>>specialObjectsArrayAddress (in category 'accessing') ----- - specialObjectsArrayAddress - ^self addressForLabel: #specialObjectsOop! Item was added: + ----- Method: CurrentImageCoInterpreterFacadeFor64BitSpurObjectRepresentation>>specialObjectsOopAddress (in category 'accessing') ----- + specialObjectsOopAddress + ^self addressForLabel: #specialObjectsOop! Item was removed: - ----- Method: Spur64BitCoMemoryManager>>specialObjectsArrayAddress (in category 'trampoline support') ----- - specialObjectsArrayAddress - <api> - ^self cCode: [(self addressOf: specialObjectsOop) asUnsignedInteger] - inSmalltalk: [cogit simulatedVariableAddress: #specialObjectsOop in: self]! Item was added: + ----- Method: Spur64BitCoMemoryManager>>specialObjectsOopAddress (in category 'trampoline support') ----- + specialObjectsOopAddress + <api> + ^self cCode: [(self addressOf: specialObjectsOop) asUnsignedInteger] + inSmalltalk: [cogit simulatedVariableAddress: #specialObjectsOop in: self]! Item was changed: ----- Method: SpurMemoryManager>>relocateObjStackForPlanningCompactor:andContents: (in category 'compaction') ----- relocateObjStackForPlanningCompactor: objStack andContents: relocateContents "Relocate all objStack pages that comprise objStack, including contents if requested." | stackOrNil freeList next relocated result | objStack = nilObj ifTrue: [^objStack]. + self assert: (relocateContents ifTrue: [(self rawHashBitsOf: objStack) < ObjStackLimit] ifFalse: [(self rawHashBitsOf: objStack) = 0]). - self assert: (relocateContents or: [(self rawHashBitsOf: objStack) = 0]). stackOrNil := objStack. freeList := self fetchPointer: ObjStackFreex ofObject: objStack. [self assert: (self numSlotsOfAny: stackOrNil) = ObjStackPageSlots. "There are four fixed slots in an obj stack, and a Topx of 0 indicates empty, so if there were 5 slots in an oop stack, full would be 2, and the last 0-rel index is 4. Hence the last index is topx + fixed slots - 1, or topx + ObjStackNextx. The first two slots, Topx and Myx are not object references." next := self fetchPointer: ObjStackNextx ofObject: stackOrNil. relocated := compactor relocateObjectsInHeapEntity: stackOrNil from: ObjStackFreex to: ObjStackNextx + (relocateContents ifTrue: [self rawHashBitsOf: stackOrNil] ifFalse: [0]). stackOrNil = objStack ifTrue: [result := relocated]. next ~= 0] whileTrue: [stackOrNil := next]. [freeList ~= 0] whileTrue: [self assert: (self numSlotsOfAny: freeList) = ObjStackPageSlots. next := self fetchPointer: ObjStackFreex ofObject: freeList. compactor relocateObjectsInHeapEntity: freeList from: ObjStackFreex to: ObjStackFreex. freeList := next]. - self assert: (relocateContents or: [(self rawHashBitsOf: relocated) = 0]). ^relocated!

1 0

the seventh plague
by Robert 11 Mar '20

11 Mar '20

It's coming. Here are some words about it, with a caution. Pardon but I must inform. 𝑫𝑶𝑵'𝑻 𝑻𝑨𝑳𝑲!!! STOP TALKING TO PEOPLE OR BEING AROUND PEOPLE WHO TALK. 𝑷𝑼𝑻 𝑫𝑶𝑾𝑵 𝒀𝑶𝑼𝑹 𝑺𝑾𝑶𝑹𝑫...people die by the sword. 𝐄𝐳𝐞𝐤𝐢𝐞𝐥 𝟑𝟓:7-9 7 Thus will I make mount Seir most desolate, and 𝒄𝒖𝒕 𝒐𝒇𝒇 𝒇𝒓𝒐𝒎 𝒊𝒕 𝒉𝒊𝒎 𝒕𝒉𝒂𝒕 𝒑𝒂𝒔𝒔𝒆𝒕𝒉 𝒐𝒖𝒕 𝒂𝒏𝒅 𝒉𝒊𝒎 𝒕𝒉𝒂𝒕 𝒓𝒆𝒕𝒖𝒓𝒏𝒆𝒕𝒉 [𝒒𝒖𝒂𝒓𝒂𝒏𝒕𝒊𝒏𝒆]. 8 And I will fill his mountains with his slain men: in thy hills, and in thy valleys, and in all thy rivers, shall they fall that are slain with the sword. 9 I will make thee perpetual desolations, and thy cities shall not return: and ye shall know that I am the Lord.

2 1

Re: [Vm-dev] [squeak-dev] smalltalkCI Trunk broken: vmParameterAt:put: failed
by Eliot Miranda 10 Mar '20

10 Mar '20

Hi Tim, On Tue, Mar 10, 2020 at 1:46 PM tim Rowledge <tim(a)rowledge.org> wrote: > > > > On 2020-03-10, at 12:42 PM, Eliot Miranda <eliot.miranda(a)gmail.com> > wrote: > > > > Any stack traces? Which parameter, which value was being assigned, etc? > > > > "Something went wrong" is rather vague... > > On the ARMv6 vm it was logged as in SmalltalkImage>setGCParameters where > we read param 44 and set param 6. Haven't had time to try to remember how I > set up build/debug to go any further into it yet. And I can't for the life > of me see why /lib/arm-linux-gnueabihf/libc.so.6(vsprintf+0x80)[0x76c89228] > got involved... unless sometihng is/was broken in a trampoline thing? > Returning to completely nonsensical places usually doesn't work out so well. > If you run it in gdb what's the back trace from the crash and the top stack frame? (printExternalHeadFrame) Does it crash on Raspberry Pi 4? (I'd have to disinter my Pi 2 & 3...) _,,,^..^,,,_ best, Eliot

1 0

← Newer
1
...
7
8
9
10
11
12
13
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2020