Vm-dev March 2020

vm-dev@lists.squeakfoundation.org

31 participants
136 discussions

VM Maker: VMMaker.oscog-eem.2731.mcz
by commits＠source.squeak.org 22 Mar '20

22 Mar '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2731.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2731 Author: eem Time: 21 March 2020, 7:31:28.606014 pm UUID: 3c8dda9e-4706-4c3d-8c58-a284c47f5705 Ancestors: VMMaker.oscog-eem.2730 Fix a slip in the previous commit that only shows up during simulaiton. =============== Diff against VMMaker.oscog-eem.2730 =============== Item was changed: ----- Method: CoInterpreter>>compilationBreakpoint:classTag:isMNUCase: (in category 'debug support') ----- compilationBreakpoint: selectorOop classTag: classTag isMNUCase: isMNUCase <api> <cmacro: '(sel, classTag, isMNU) do { \ if (numBytesOf(sel) == (isMNU ? -breakSelectorLength : breakSelectorLength) \ && !!strncmp((char *)((sel) + BaseHeaderSize), breakSelector, (isMNU ? -breakSelectorLength : breakSelectorLength))) { \ suppressHeartbeatFlag = 1; \ compilationBreakpointFor(sel); \ } \ } while (0)'> | bsl i | isMNUCase ifTrue: [(breakSelectorLength = 18 "doesNotUnderstand: size" and: [(self strncmp: 'doesNotUnderstand:' _: breakSelector _: 18) == 0]) ifTrue: [(breakLookupClassTag < 0 or: [breakLookupClassTag = classTag]) ifTrue: [^self compilationBreakpointFor: selectorOop]]. bsl := breakSelectorLength negated] ifFalse: [bsl := breakSelectorLength]. + bsl = (objectMemory numBytesOf: selectorOop) ifTrue: - bsl = (self numBytesOf: selectorOop) ifTrue: [i := bsl. [i > 0] whileTrue: [(objectMemory byteAt: selectorOop + i + objectMemory baseHeaderSize - 1) = (breakSelector at: i) asInteger ifTrue: [((i := i - 1) = 0 and: [breakLookupClassTag < 0 or: [breakLookupClassTag = classTag]]) ifTrue: [self compilationBreakpointFor: selectorOop]] ifFalse: [i := 0]]]! Item was changed: ----- Method: CoInterpreter>>compilationBreakpoint:isMNUCase: (in category 'debug support') ----- compilationBreakpoint: selectorOop isMNUCase: isMNUCase <api> <cmacro: '(sel, isMNU) do { \ if (numBytesOf(sel) == (isMNU ? -breakSelectorLength : breakSelectorLength) \ && !!strncmp((char *)((sel) + BaseHeaderSize), breakSelector, (isMNU ? -breakSelectorLength : breakSelectorLength))) { \ suppressHeartbeatFlag = 1; \ compilationBreakpointFor(sel); \ } \ } while (0)'> | bsl i | bsl := isMNUCase ifTrue: [breakSelectorLength negated] ifFalse: [breakSelectorLength]. + bsl = (objectMemory numBytesOf: selectorOop) ifTrue: - bsl = (self numBytesOf: selectorOop) ifTrue: [i := bsl. [i > 0] whileTrue: [(objectMemory byteAt: selectorOop + i + objectMemory baseHeaderSize - 1) = (breakSelector at: i) asInteger ifTrue: [(i := i - 1) = 0 ifTrue: [self compilationBreakpointFor: selectorOop]] ifFalse: [i := 0]]]!

1 0

Re: [Vm-dev] [squeak-dev] Squeak5.3 linux ARMv6 segfaults on startup
by Tobias Pape 21 Mar '20

21 Mar '20

Hi > On 21.03.2020, at 10:51, Bruce O'Neel <bruce.oneel(a)pckswarms.ch> wrote: > > Hi, > > Tired with the PI2. Good news/bad news, it's not hardware or firmware. I see the same results. > > So clearly the VM I've built. now I get what you mean. The non-bitmap variant uses the Balloon-engine to do the rendering of the ttf curves to bits. Didn't we change something regarding this lately? Best regard -Tobas > > cheers > > bruce > > > > 21 March 2020 10:03 "Bruce O'Neel" <bruce.oneel(a)pckswarms.ch> wrote: > Hi Tim and others. > > Let's think about this a little differently. > > What do we know: > > 1. You, Ellot and I can build the VM on our respective PIs. > 2. In general this VM works fine, the only seemingly difference is on a few fonts. This, of course, is bizarre. > 3. We must be either seeing a difference in hardware, or in software, or in firmware. > > Now we start guessing. > > 1. I use my PI as a server. I installed Raspberian about 12 months ago, and, the only packages installed on top are samba, and then the 11 packages to make Squeak build. I'm lazy, I have not checked to see if there was a firmware update nor I have I updated firmware. > 2. I don't know about Ellot, but I have the impression you Tim use your PI more, right? Do you have more packages installed? > 3. Or, maybe it's some difference in hardware. My Pi 3 was bought in early 2019 and has the following dmesg bits. > > > > [ 0.000000] Linux version 4.19.66-v7+ (dom@buildbot) (gcc version 4.9.3 (crosstool-NG crosstool-ng-1.22.0-88-g8460611)) #1253 SMP Thu Aug 15 11:49:46 BST 2019 > [ 0.000000] CPU: ARMv7 Processor [410fd034] revision 4 (ARMv7), cr=10c5383d > [ 0.000000] CPU: div instructions available: patching division code > [ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache > [ 0.000000] OF: fdt: Machine model: Raspberry Pi 3 Model B Plus Rev 1.3 > > > [ 0.002345] CPU: Testing write buffer coherency: ok > [ 0.002830] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000 > [ 0.003495] Setting up static identity map for 0x100000 - 0x10003c > [ 0.003662] rcu: Hierarchical SRCU implementation. > [ 0.004476] smp: Bringing up secondary CPUs ... > [ 0.005337] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001 > [ 0.006262] CPU2: thread -1, cpu 2, socket 0, mpidr 80000002 > [ 0.007124] CPU3: thread -1, cpu 3, socket 0, mpidr 80000003 > [ 0.007246] smp: Brought up 1 node, 4 CPUs > [ 0.007326] SMP: Total of 4 processors activated (153.60 BogoMIPS). > [ 0.007350] CPU: All CPU(s) started in HYP mode. > [ 0.007371] CPU: Virtualization extensions available. > [ 0.008364] devtmpfs: initialized > [ 0.021572] VFP support v0.3: implementor 41 architecture 3 part 40 variant 3 rev 4 > > [ 0.090300] raspberrypi-firmware soc:firmware: Attached to firmware from 2019-08-15 12:06, variant start > [ 0.100128] raspberrypi-firmware soc:firmware: Firmware hash is 0e6daa5106dd4164474616408e0dc24f997ffcf3 > > [ 0.234849] bcm2708_fb soc:fb: FB found 1 display(s) > [ 0.245052] Console: switching to colour frame buffer device 80x30 > [ 0.252763] bcm2708_fb soc:fb: Registered framebuffer for display 0, size 640x480 > [ 0.260129] bcm2835-rng 3f104000.rng: hwrng registered > [ 0.263319] vc-mem: phys_addr:0x00000000 mem_base=0x3ec00000 mem_size:0x40000000(1024 MiB) > [ 0.269633] vc-sm: Videocore shared memory driver > > > I have a PI2 sitting around here somewhere. I'll see if I can get that running... > > Any other ideas? > > Thanks. > > bruce > > 21 March 2020 01:07 tim Rowledge <tim(a)rowledge.org> wrote: > > > > On 2020-03-20, at 6:16 AM, Bruce O'Neel wrote: > > > > > > I specialize in ridiculous. Good news, I guess, is that I dug up a monitor, and, walked it downstairs with a keyboard and mouse and attached it. The effect with the BitstreamVeraSans and ComicSans fonts are the same. Maybe it likes serfed fonts? > > I'm completely baffled by this. I don't get this effect with any ARM vm that I have that actually runs, with any image I have. > > > > > So that means that it is not some funky X11 over the wire problem with the Mac and Windows X11 servers problem. That's good. > > Guess so, though it just makes life weirder. > > > > > I have no idea then why. Are these fonts part of the image? Is it some funky binary format that for some reason Coq is mis-reading? > > Yes, the font glyphs are in-image. We've been using these ones for goodness knows how many years. > > > > > I built a stack VM and I get the same result with a Squeak 5.3 image. > > There*shouldn't* be any difference between the stack & cog vms. > > You could try building a VM with the fastbitblt turned off I suppose - > a quick hack is to find the BITBLT_FLAGS= -DENABLE_FAST_BLT and related lines in the Makefile in you squeak.cog.spur/build directory. I haven't actually built an ARM vm without that in years so I don't know it it even still works. > > > tim

2 1

VM Maker: VMMaker.oscog-eem.2730.mcz
by commits＠source.squeak.org 20 Mar '20

20 Mar '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2730.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2730 Author: eem Time: 20 March 2020, 1:44:08.110458 pm UUID: 7bdafef9-a92d-4d1d-b0c5-5008cb285687 Ancestors: VMMaker.oscog-eem.2729 Cogit: Refactor the compilation breakpoints so they don't take a selector length. Leave it up to CoInterpeeter to derive the byte length of the selector using numBytesOf:. Hence no longer mark lengthOf: as <api>. Use a writable method when setting cpicHasMNUCase: in cogExtendPIC:CaseNMethod:tag:isMNUCase:. ARMv8 is getting there... Slang: do constant folding in left and right shifts. =============== Diff against VMMaker.oscog-eem.2729 =============== Item was changed: ----- Method: CCodeGenerator>>generateShiftLeft:on:indent: (in category 'C translation') ----- generateShiftLeft: msgNode on: aStream indent: level "Generate a C bitShift. If the receiver type is unsigned avoid C99 undefined behaviour of left shifting negative values (what?!!?!!? such quiche eating idiocy to treat this like anything other than a truncated left shift) by casting signed receiver types to unsigned and back. If we can determine the result would overflow the word size, cast to a long integer." | rcvr arg castToLong type mustCastBackToSign mustCastToUnsigned canSuffixTheConstant typeIsUnsigned | + (self generateAsConstantExpression: msgNode on: aStream) ifTrue: + [^self]. rcvr := msgNode receiver. arg := msgNode args first. castToLong := false. (rcvr constantNumbericValueIfAtAllPossibleOrNilIn: self) ifNotNil: [:rcvrVal | (arg constantNumbericValueIfAtAllPossibleOrNilIn: self) ifNil: [castToLong := vmClass notNil and: [vmClass objectMemoryClass wordSize = 8]] ifNotNil: [:argVal | | valueBeyondInt | valueBeyondInt := 1 bitShift: 32. "The default type of const << N is int." castToLong := rcvrVal < valueBeyondInt and: [(rcvrVal bitShift: argVal) >= valueBeyondInt]]]. canSuffixTheConstant := rcvr isConstant and: [rcvr name isEmpty and: [rcvr value >= 0]]. canSuffixTheConstant ifTrue: [aStream nextPutAll: (self cLiteralForUnsignedInteger: rcvr value longlong: castToLong). aStream nextPutAll: ' << '. self emitCExpression: arg on: aStream indent: level. ^self]. type := self typeFor: rcvr in: currentMethod. castToLong := castToLong and: [(self sizeOfIntegralCType: type) < (self sizeOfIntegralCType: #usqLong)]. typeIsUnsigned := type first = $u. mustCastToUnsigned := typeIsUnsigned not or: [castToLong or: [(self sizeOfIntegralCType: type) < (self sizeOfIntegralCType: #usqInt)]]. mustCastBackToSign := typeIsUnsigned not. mustCastBackToSign ifTrue: [| promotedType | promotedType := castToLong ifTrue: [#sqLong] ifFalse: [(self sizeOfIntegralCType: type) < (self sizeOfIntegralCType: #sqInt) ifTrue: [#sqInt] ifFalse: [type]]. aStream nextPutAll: '(('; nextPutAll: promotedType; nextPut: $)]. mustCastToUnsigned ifTrue: [| unsigned | unsigned := castToLong ifTrue: [#usqLong] ifFalse: [(self sizeOfIntegralCType: type) < (self sizeOfIntegralCType: #usqLong) ifTrue: [#usqInt] ifFalse: [self unsignedTypeForIntegralType: type]]. aStream nextPutAll: '(('; nextPutAll: unsigned; nextPutAll: ')(']. self emitCExpression: rcvr on: aStream indent: level. mustCastToUnsigned ifTrue: [aStream nextPut: $)]. aStream nextPutAll: ' << '. self emitCExpression: arg on: aStream indent: level. mustCastToUnsigned ifTrue: [aStream nextPut: $)]. + mustCastBackToSign ifTrue: [aStream nextPut: $)]! - mustCastBackToSign ifTrue: [aStream nextPut: $)].! Item was changed: ----- Method: CCodeGenerator>>generateShiftRight:on:indent: (in category 'C translation') ----- generateShiftRight: msgNode on: aStream indent: level "Generate the C code for this message onto the given stream. Note that this generates a Logical Shift (unsigned), not an Arithmetic Shift (signed)." + | type typeIsSigned mustCastToUnsigned unsignedType | + (self generateAsConstantExpression: msgNode on: aStream) ifTrue: + [^self]. - | type typeIsUnsigned mustCastToUnsigned unsignedType | type := self typeFor: msgNode receiver in: currentMethod. + typeIsSigned := type first ~= $u. + mustCastToUnsigned := typeIsSigned or: - typeIsUnsigned := type first = $u. - mustCastToUnsigned := typeIsUnsigned not or: ["cast to usqInt if the int is shorter: we want to avoid UB related to a shift exceeeding bit width" (self sizeOfIntegralCType: type) < (self sizeOfIntegralCType: #usqInt)]. "If not unsigned cast it to unsigned." mustCastToUnsigned ifTrue: ["If the variable is a 64-bit type then don't cast it to usqInt (typically a 32-bit type)" unsignedType := (self sizeOfIntegralCType: type) < (self sizeOfIntegralCType: #usqLong) ifTrue: [#usqInt] ifFalse: [self unsignedTypeForIntegralType: type]. aStream nextPutAll: '(('; nextPutAll: unsignedType; nextPutAll: ')('. self emitCExpression: msgNode receiver on: aStream indent: level. aStream nextPutAll: '))'] ifFalse: [aStream nextPutAll: '('. self emitCExpression: msgNode receiver on: aStream indent: level. aStream nextPut: $)]. aStream nextPutAll: ' >> '. self emitCExpression: msgNode args first on: aStream indent: level! Item was removed: - ----- Method: CoInterpreter>>compilationBreak:point:classTag:isMNUCase: (in category 'debug support') ----- - compilationBreak: selectorOop point: selectorLength classTag: classTag isMNUCase: isMNUCase - <api> - <cmacro: '(sel, len, classTag, isMNU) do { \ - if ((len) == (isMNU ? -breakSelectorLength : breakSelectorLength) \ - && !!strncmp((char *)((sel) + BaseHeaderSize), breakSelector, (isMNU ? -breakSelectorLength : breakSelectorLength))) { \ - suppressHeartbeatFlag = 1; \ - compilationBreakpointFor(sel); \ - } \ - } while (0)'> - | bsl i | - isMNUCase - ifTrue: - [(breakSelectorLength = 18 "doesNotUnderastand: size" - and: [(self strncmp: 'doesNotUnderstand:' _: breakSelector _: 18) == 0]) ifTrue: - [(breakLookupClassTag < 0 or: [breakLookupClassTag = classTag]) ifTrue: - [^self compilationBreakpointFor: selectorOop]]. - bsl := breakSelectorLength negated] - ifFalse: [bsl := breakSelectorLength]. - bsl = selectorLength ifTrue: - [i := bsl. - [i > 0] whileTrue: - [(objectMemory byteAt: selectorOop + i + objectMemory baseHeaderSize - 1) = (breakSelector at: i) asInteger - ifTrue: - [((i := i - 1) = 0 - and: [breakLookupClassTag < 0 or: [breakLookupClassTag = classTag]]) ifTrue: - [self compilationBreakpointFor: selectorOop]] - ifFalse: [i := 0]]]! Item was removed: - ----- Method: CoInterpreter>>compilationBreak:point:isMNUCase: (in category 'debug support') ----- - compilationBreak: selectorOop point: selectorLength isMNUCase: isMNUCase - <api> - <cmacro: '(sel, len, isMNU) do { \ - if ((len) == (isMNU ? -breakSelectorLength : breakSelectorLength) \ - && !!strncmp((char *)((sel) + BaseHeaderSize), breakSelector, (isMNU ? -breakSelectorLength : breakSelectorLength))) { \ - suppressHeartbeatFlag = 1; \ - compilationBreakpointFor(sel); \ - } \ - } while (0)'> - | bsl i | - bsl := isMNUCase ifTrue: [breakSelectorLength negated] ifFalse: [breakSelectorLength]. - bsl = selectorLength ifTrue: - [i := bsl. - [i > 0] whileTrue: - [(objectMemory byteAt: selectorOop + i + objectMemory baseHeaderSize - 1) = (breakSelector at: i) asInteger - ifTrue: [(i := i - 1) = 0 ifTrue: - [self compilationBreakpointFor: selectorOop]] - ifFalse: [i := 0]]]! Item was added: + ----- Method: CoInterpreter>>compilationBreakpoint:classTag:isMNUCase: (in category 'debug support') ----- + compilationBreakpoint: selectorOop classTag: classTag isMNUCase: isMNUCase + <api> + <cmacro: '(sel, classTag, isMNU) do { \ + if (numBytesOf(sel) == (isMNU ? -breakSelectorLength : breakSelectorLength) \ + && !!strncmp((char *)((sel) + BaseHeaderSize), breakSelector, (isMNU ? -breakSelectorLength : breakSelectorLength))) { \ + suppressHeartbeatFlag = 1; \ + compilationBreakpointFor(sel); \ + } \ + } while (0)'> + | bsl i | + isMNUCase + ifTrue: + [(breakSelectorLength = 18 "doesNotUnderstand: size" + and: [(self strncmp: 'doesNotUnderstand:' _: breakSelector _: 18) == 0]) ifTrue: + [(breakLookupClassTag < 0 or: [breakLookupClassTag = classTag]) ifTrue: + [^self compilationBreakpointFor: selectorOop]]. + bsl := breakSelectorLength negated] + ifFalse: [bsl := breakSelectorLength]. + bsl = (self numBytesOf: selectorOop) ifTrue: + [i := bsl. + [i > 0] whileTrue: + [(objectMemory byteAt: selectorOop + i + objectMemory baseHeaderSize - 1) = (breakSelector at: i) asInteger + ifTrue: + [((i := i - 1) = 0 + and: [breakLookupClassTag < 0 or: [breakLookupClassTag = classTag]]) ifTrue: + [self compilationBreakpointFor: selectorOop]] + ifFalse: [i := 0]]]! Item was added: + ----- Method: CoInterpreter>>compilationBreakpoint:isMNUCase: (in category 'debug support') ----- + compilationBreakpoint: selectorOop isMNUCase: isMNUCase + <api> + <cmacro: '(sel, isMNU) do { \ + if (numBytesOf(sel) == (isMNU ? -breakSelectorLength : breakSelectorLength) \ + && !!strncmp((char *)((sel) + BaseHeaderSize), breakSelector, (isMNU ? -breakSelectorLength : breakSelectorLength))) { \ + suppressHeartbeatFlag = 1; \ + compilationBreakpointFor(sel); \ + } \ + } while (0)'> + | bsl i | + bsl := isMNUCase ifTrue: [breakSelectorLength negated] ifFalse: [breakSelectorLength]. + bsl = (self numBytesOf: selectorOop) ifTrue: + [i := bsl. + [i > 0] whileTrue: + [(objectMemory byteAt: selectorOop + i + objectMemory baseHeaderSize - 1) = (breakSelector at: i) asInteger + ifTrue: [(i := i - 1) = 0 ifTrue: + [self compilationBreakpointFor: selectorOop]] + ifFalse: [i := 0]]]! Item was changed: ----- Method: Cogit>>cog:selector: (in category 'jit - api') ----- cog: aMethodObj selector: aSelectorOop "Attempt to produce a machine code method for the bytecode method object aMethodObj. N.B. If there is no code memory available do *NOT* attempt to reclaim the method zone. Certain clients (e.g. ceSICMiss:) depend on the zone remaining constant across method generation." <api> <returnTypeC: #'CogMethod *'> | selector cogMethod | <var: #cogMethod type: #'CogMethod *'> (self exclude: aMethodObj selector: aSelectorOop) ifTrue: [^nil]. "In Newspeak we support anonymous accessors and hence tolerate the same method being cogged multiple times. But only if the method class association is nil." NewspeakVM ifTrue: [(coInterpreter methodHasCogMethod: aMethodObj) ifTrue: [cogMethod := coInterpreter cogMethodOf: aMethodObj. self deny: cogMethod selector = aSelectorOop. cogMethod selector = aSelectorOop ifTrue: [^cogMethod]. (coInterpreter methodClassAssociationOf: aMethodObj) ~= objectMemory nilObject ifTrue: [self cCode: 'extern void *firstIndexableField(sqInt)'. "Slang, au natural" self warnMultiple: cogMethod selectors: aSelectorOop. ^nil]]] ifFalse: [self deny: (coInterpreter methodHasCogMethod: aMethodObj)]. self deny: (objectMemory isOopCompiledMethod: (coInterpreter ultimateLiteralOf: aMethodObj)). selector := aSelectorOop = objectMemory nilObject ifTrue: [coInterpreter maybeSelectorOfMethod: aMethodObj] ifFalse: [aSelectorOop]. "coInterpreter stringOf: selector" selector ifNotNil: + [coInterpreter compilationBreakpoint: selector isMNUCase: false]. - [coInterpreter - compilationBreak: selector - point: (objectMemory lengthOf: selector) - isMNUCase: false]. aMethodObj = breakMethod ifTrue: [self halt: 'Compilation of breakMethod']. NewspeakVM ifTrue: [cogMethod := methodZone findPreviouslyCompiledVersionOf: aMethodObj with: aSelectorOop. cogMethod ifNotNil: [(coInterpreter methodHasCogMethod: aMethodObj) not ifTrue: [self assert: (coInterpreter rawHeaderOf: aMethodObj) = cogMethod methodHeader. cogMethod methodObject: aMethodObj. coInterpreter rawHeaderOf: aMethodObj put: cogMethod asInteger]. ^cogMethod]]. "If the generators for the alternate bytecode set are missing then interpret." (coInterpreter methodUsesAlternateBytecodeSet: aMethodObj) ifTrue: [(self numElementsIn: generatorTable) <= 256 ifTrue: [^nil]. bytecodeSetOffset := 256] ifFalse: [bytecodeSetOffset := 0]. objectRepresentation ensureNoForwardedLiteralsIn: aMethodObj. methodObj := aMethodObj. methodHeader := objectMemory methodHeaderOf: aMethodObj. receiverTags := objectMemory receiverTagBitsForMethod: methodObj. cogMethod := self compileCogMethod: aSelectorOop. (cogMethod asInteger between: MaxNegativeErrorCode and: -1) ifTrue: [cogMethod asInteger = InsufficientCodeSpace ifTrue: [coInterpreter callForCogCompiledCodeCompaction]. self maybeFreeCounters. "Right now no errors should be reported, so nothing more to do." "self reportError: (self cCoerceSimple: cogMethod to: #sqInt)." ^nil]. "self cCode: '' inSmalltalk: [coInterpreter printCogMethod: cogMethod. ""coInterpreter symbolicMethod: aMethodObj."" self assertValidMethodMap: cogMethod." "self disassembleMethod: cogMethod." "printInstructions := clickConfirm := true""]." ^cogMethod! Item was changed: ----- Method: Cogit>>cogExtendPIC:CaseNMethod:tag:isMNUCase: (in category 'in-line cacheing') ----- cogExtendPIC: cPIC CaseNMethod: caseNMethod tag: caseNTag isMNUCase: isMNUCase "Extend the cPIC with the supplied case. If caseNMethod is cogged dispatch direct to its unchecked entry-point. If caseNMethod is not cogged, jump to the fast interpreter dispatch, and if isMNUCase then dispatch to fast MNU invocation and mark the cPIC as having the MNU case for cache flushing." <var: #cPIC type: #'CogMethod *'> | operand target address | + coInterpreter compilationBreakpoint: cPIC selector classTag: caseNTag isMNUCase: isMNUCase. - coInterpreter - compilationBreak: cPIC selector - point: (objectMemory numBytesOf: cPIC selector) - classTag: caseNTag - isMNUCase: isMNUCase. self assert: (objectRepresentation inlineCacheTagIsYoung: caseNTag) not. "Caller patches to open pic if caseNMethod is young." self assert: (caseNMethod notNil and: [(objectMemory isYoung: caseNMethod) not]). (isMNUCase not and: [coInterpreter methodHasCogMethod: caseNMethod]) ifTrue: "this isn't an MNU and we have an already cogged method to jump to" [operand := 0. target := (coInterpreter cogMethodOf: caseNMethod) asInteger + cmNoCheckEntryOffset] ifFalse: [operand := caseNMethod. isMNUCase ifTrue: "this is an MNU so tag the CPIC header and setup a jump to the MNUAbort" + [(self writableMethodFor: cPIC) cpicHasMNUCase: true. - [cPIC cpicHasMNUCase: true. target := cPIC asInteger + (self sizeof: CogMethod)] ifFalse: "setup a jump to the interpretAborth so we can cog the target method" [target := cPIC asInteger + self picInterpretAbortOffset]]. "find the end address of the new case" address := self addressOfEndOfCase: cPIC cPICNumCases +1 inCPIC: cPIC. self rewriteCPICCaseAt: address tag: caseNTag objRef: operand target: target. "finally, rewrite the jump 3 instr before firstCPICCaseOffset to jump to the beginning of this new case" self rewriteCPIC: cPIC caseJumpTo: address - cPICCaseSize. "This also implicitly flushes the read/write mapped dual zone to the read/execute zone." backEnd flushICacheFrom: cPIC asUnsignedInteger to: cPIC asUnsignedInteger + closedPICSize. "update the header flag for the number of cases" (self writableMethodFor: cPIC) cPICNumCases: cPIC cPICNumCases + 1. self assertValidDualZoneFrom: cPIC asUnsignedInteger to: cPIC asUnsignedInteger + closedPICSize! Item was changed: ----- Method: Cogit>>cogMNUPICSelector:receiver:methodOperand:numArgs: (in category 'in-line cacheing') ----- cogMNUPICSelector: selector receiver: rcvr methodOperand: methodOperand numArgs: numArgs <api> "Attempt to create a one-case PIC for an MNU. The tag for the case is at the send site and so doesn't need to be generated." <returnTypeC: #'CogMethod *'> | startAddress writablePIC actualPIC | ((objectMemory isYoung: selector) or: [(objectRepresentation inlineCacheTagForInstance: rcvr) = self picAbortDiscriminatorValue]) ifTrue: [^0]. + coInterpreter compilationBreakpoint: selector classTag: (objectMemory fetchClassTagOf: rcvr) isMNUCase: true. - coInterpreter - compilationBreak: selector - point: (objectMemory numBytesOf: selector) - classTag: (objectMemory fetchClassTagOf: rcvr) - isMNUCase: true. self assert: endCPICCase0 notNil. "get memory in the code zone for the CPIC; if that fails we return an error code for the sender to use to work out how to blow up" startAddress := methodZone allocate: closedPICSize. startAddress = 0 ifTrue: [coInterpreter callForCogCompiledCodeCompaction. ^0]. self maybeBreakGeneratingFrom: startAddress to: startAddress + closedPICSize - 1. writablePIC := self writableMethodFor: startAddress. "memcpy the prototype across to our allocated space; because anything else would be silly" self codeMemcpy: writablePIC _: cPICPrototype _: closedPICSize. self fillInCPICHeader: writablePIC numArgs: numArgs numCases: 1 hasMNUCase: true selector: selector. self configureMNUCPIC: (actualPIC := self cCoerceSimple: startAddress to: #'CogMethod *') methodOperand: methodOperand numArgs: numArgs delta: startAddress - cPICPrototype asUnsignedInteger. "This also implicitly flushes the read/write mapped dual zone to the read/execute zone." backEnd flushICacheFrom: startAddress to: startAddress + closedPICSize. self assert: (backEnd callTargetFromReturnAddress: startAddress + missOffset) = (self picAbortTrampolineFor: numArgs). self assertValidDualZoneFrom: startAddress to: startAddress + closedPICSize. ^actualPIC! Item was changed: ----- Method: Cogit>>cogOpenPICSelector:numArgs: (in category 'in-line cacheing') ----- cogOpenPICSelector: selector numArgs: numArgs "Create an Open PIC. Temporarily create a direct call of ceSendFromOpenPIC:. Should become a probe of the first-level method lookup cache followed by a call of ceSendFromOpenPIC: if the probe fails." <returnTypeC: #'CogMethod *'> | startAddress codeSize mapSize end | + coInterpreter compilationBreakpoint: selector isMNUCase: false. - coInterpreter - compilationBreak: selector - point: (objectMemory numBytesOf: selector) - isMNUCase: false. startAddress := methodZone allocate: openPICSize. startAddress = 0 ifTrue: [^self cCoerceSimple: InsufficientCodeSpace to: #'CogMethod *']. methodLabel address: startAddress; dependent: nil. "stack allocate the various collections so that they are effectively garbage collected on return." self allocateOpcodes: 100 bytecodes: 0. self compileOpenPIC: selector numArgs: numArgs. self computeMaximumSizes. methodLabel concretizeAt: startAddress. codeSize := self generateInstructionsAt: startAddress + (self sizeof: CogMethod). mapSize := self generateMapAt: startAddress + openPICSize - 1 start: startAddress + cmNoCheckEntryOffset. self assert: entry address - startAddress = cmEntryOffset. self assert: (methodZone roundUpLength: (self sizeof: CogMethod) + codeSize) + (methodZone roundUpLength: mapSize) <= openPICSize. end := self outputInstructionsAt: startAddress + (self sizeof: CogMethod). self fillInOPICHeader: (self writableMethodFor: startAddress) numArgs: numArgs selector: selector. ^self cCoerceSimple: startAddress to: #'CogMethod *'! Item was changed: ----- Method: Cogit>>cogPICSelector:numArgs:Case0Method:Case1Method:tag:isMNUCase: (in category 'in-line cacheing') ----- cogPICSelector: selector numArgs: numArgs Case0Method: case0CogMethod Case1Method: case1MethodOrNil tag: case1Tag isMNUCase: isMNUCase "Attempt to create a two-case PIC for case0CogMethod and case1Method,case1Tag. The tag for case0CogMethod is at the send site and so doesn't need to be generated. case1Method may be any of - a Cog method; link to its unchecked entry-point - a CompiledMethod; link to ceInterpretMethodFromPIC: - a CompiledMethod; link to ceMNUFromPICMNUMethod:receiver:" <var: #case0CogMethod type: #'CogMethod *'> <returnTypeC: #'CogMethod *'> | startAddress writablePIC actualPIC | (objectMemory isYoung: selector) ifTrue: [^self cCoerceSimple: YoungSelectorInPIC to: #'CogMethod *']. + coInterpreter compilationBreakpoint: selector classTag: case1Tag isMNUCase: isMNUCase. - coInterpreter - compilationBreak: selector - point: (objectMemory numBytesOf: selector) - classTag: case1Tag - isMNUCase: isMNUCase. "get memory in the code zone for the CPIC; if that fails we return an error code for the sender to use to work out how to blow up" startAddress := methodZone allocate: closedPICSize. startAddress = 0 ifTrue: [^self cCoerceSimple: InsufficientCodeSpace to: #'CogMethod *']. self maybeBreakGeneratingFrom: startAddress to: startAddress + closedPICSize - 1. writablePIC := self writableMethodFor: startAddress. "memcpy the prototype across to our allocated space; because anything else would be silly" self codeMemcpy: writablePIC _: cPICPrototype _: closedPICSize. self fillInCPICHeader: writablePIC numArgs: numArgs numCases: 2 hasMNUCase: isMNUCase selector: selector. self configureCPIC: (actualPIC := self cCoerceSimple: startAddress to: #'CogMethod *') Case0: case0CogMethod Case1Method: case1MethodOrNil tag: case1Tag isMNUCase: isMNUCase numArgs: numArgs delta: startAddress - cPICPrototype asUnsignedInteger. "This also implicitly flushes the read/write mapped dual zone to the read/execute zone." backEnd flushICacheFrom: startAddress to: startAddress + closedPICSize. self assert: (backEnd callTargetFromReturnAddress: startAddress + missOffset) = (self picAbortTrampolineFor: numArgs). self assertValidDualZoneFrom: startAddress to: startAddress + closedPICSize. ^actualPIC! Item was changed: ----- Method: Cogit>>setSelectorOf:to: (in category 'jit - api') ----- setSelectorOf: cogMethod to: aSelectorOop <api> "If a method is compiled to machine code via a block entry it won't have a selector. A subsequent send can find the method and hence fill in the selector." <var: #cogMethod type: #'CogMethod *'> "self disassembleMethod: cogMethod" + coInterpreter compilationBreakpoint: aSelectorOop isMNUCase: false. - coInterpreter - compilationBreak: aSelectorOop - point: (objectMemory numBytesOf: aSelectorOop) - isMNUCase: false. self assert: cogMethod cmType = CMMethod. (self writableMethodFor: cogMethod) selector: aSelectorOop. (objectMemory isYoung: aSelectorOop) ifTrue: [methodZone ensureInYoungReferrers: cogMethod]! Item was removed: - ----- Method: CurrentImageCoInterpreterFacade>>compilationBreak:point:classTag:isMNUCase: (in category 'debug support') ----- - compilationBreak: aString point: length classTag: classTag isMNUCase: isMNUCase - ^self! Item was removed: - ----- Method: CurrentImageCoInterpreterFacade>>compilationBreak:point:isMNUCase: (in category 'debug support') ----- - compilationBreak: aString point: length isMNUCase: isMNUCase - ^self! Item was added: + ----- Method: CurrentImageCoInterpreterFacade>>compilationBreakpoint:classTag:isMNUCase: (in category 'debug support') ----- + compilationBreakpoint: selectorOop classTag: classTag isMNUCase: isMNUCase + ^self! Item was added: + ----- Method: CurrentImageCoInterpreterFacade>>compilationBreakpoint:isMNUCase: (in category 'debug support') ----- + compilationBreakpoint: aString isMNUCase: isMNUCase + ^self! Item was changed: ----- Method: ObjectMemory>>lengthOf: (in category 'object access') ----- lengthOf: oop "Return the number of indexable bytes or words in the given object. Assume the argument is not an integer. For a CompiledMethod, the size of the method header (in bytes) should be subtracted from the result." - <api> | header | <inline: true> header := self baseHeader: oop. ^self lengthOf: oop baseHeader: header format: (self formatOfHeader: header)! Item was changed: ----- Method: SpurMemoryManager>>lengthOf: (in category 'object access') ----- lengthOf: objOop "Answer the number of indexable units in the given object. For a CompiledMethod, the size of the method header (in bytes) should be subtracted from the result." - <api> <inline: true> ^self lengthOf: objOop format: (self formatOf: objOop)!

1 0

Re: [Vm-dev] [squeak-dev] Squeak5.3 linux ARMv6 segfaults on startup
by Eliot Miranda 19 Mar '20

19 Mar '20

Hi All, apologies; this is my bug. Having revived my Raspberry 3 build machine I've just reproduced the crash and can see that it's a code generator bug. The very first JITted method executed answers SmalltalkImage current. The code generated for this should be 0x4018e8: ldr r0, [pc, #8] ; 0x4018f8 0x4018ec: ldr r7, [r0, #8] 0x4018f0: mov r5, r7 0x4018f4: mov pc, lr but is alas 0x4018e8: ldr r0, [pc, #8] ; 0x4018f8 0x4018ec: ldr r7, [r0, #-0] 0x4018f0: mov r5, r7 0x4018f4: mov pc, lr I have to find out why this does't fail in the simulator (or find out that it does and that my recollection of having tested 32-bit ARM recently is, in fact, a self-serving hallucination). Hopefully normal service should be restored presently. But it does mean releasing an updated Squeak5.3 release with a fixed VM. Again, apologies. On Sat, Mar 7, 2020 at 10:10 PM tim Rowledge <tim(a)rowledge.org> wrote: > Oh pooh. > > Download the release zip; extract, cd into the directory, run ./squeak.sh; > boom. > > The image is fine and runs OK with a slightly older VM build > (5.0-201912311458). > > > > > tim > -- > tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim > Useful Latin Phrases:- Mellita, domi adsum. = Honey, I'm home. > > > > -- _,,,^..^,,,_ best, Eliot

3 6

VM Maker: VMMakerUI-eem.24.mcz
by commits＠source.squeak.org 19 Mar '20

19 Mar '20

Eliot Miranda uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-eem.24.mcz ==================== Summary ==================== Name: VMMakerUI-eem.24 Author: eem Time: 18 March 2020, 8:25:42.426065 pm UUID: 5fc86166-7b2a-4bd4-ba0f-53b4cff19d47 Ancestors: VMMakerUI-eem.23 VMMaker.oscog-eem.2729: Allow setting a break block either in the coInterpreter or the cogit (so processor et al are in scope). =============== Diff against VMMakerUI-eem.23 =============== Item was changed: ----- Method: CogVMSimulator>>utilitiesMenu: (in category '*VMMakerUI-user interface') ----- utilitiesMenu: aMenuMorph aMenuMorph add: 'toggle transcript' action: #toggleTranscript; add: 'clone VM' action: #cloneSimulationWindow; addLine; add: 'print head frame' action: [self printFrame: cogit headFramePointer WithSP: cogit headStackPointer]; add: 'short print head frame & callers' action: [self shortPrintFrameAndCallers: cogit headFramePointer]; add: 'long print head frame & callers' action: [self printFrameAndCallers: cogit headFramePointer SP: cogit headFramePointer]; add: 'print frame...' action: [(self promptHex: 'print frame') ifNotNil: [:fp| self printFrame: fp]]; add: 'inspect frame...' action: [(self promptHex: 'inspect frame') ifNotNil: [:fp| (CogFrameInspector on: self) framePointer: fp; open]]; add: 'print call stack' action: #printCallStack; add: 'print stack call stack' action: #printStackCallStack; add: 'print stack call stack of...' action: [(self promptHex: 'frame') ifNotNil: [:fp| self printStackCallStackOf: fp]]; add: 'print call stack of...' action: [(self promptHex: 'context or process oop') ifNotNil: [:obj| self printCallStackOf: obj]]; add: 'print call stack of frame...' action: [(self promptHex: 'frame') ifNotNil: [:fp| self printCallStackFP: fp]]; add: 'print all stacks' action: #printAllStacks; add: 'write back local ptrs' action: [stackPointer := localSP. framePointer := localFP. instructionPointer := localIP. self writeBackHeadFramePointers]; add: 'write back mc ptrs' action: [stackPointer := cogit processor sp. framePointer := cogit processor fp. instructionPointer := cogit processor pc. self externalWriteBackHeadFramePointers]; addLine; add: 'print rump C stack' action: [self printRumpCStack]; add: 'print registers' action: [cogit processor printRegistersOn: transcript]; add: 'print register map' action: [cogit printRegisterMapOn: transcript]; add: 'disassemble method/trampoline...' action: [(self promptHex: 'pc') ifNotNil: [:pc| cogit disassembleCodeAt: pc]]; add: 'disassemble method/trampoline at pc' action: [cogit disassembleCodeAt: (((cogit codeEntryFor: cogit processor pc) isNil and: [(cogit methodZone methodFor: cogit processor pc) isNil]) ifTrue: [instructionPointer] ifFalse: [cogit processor pc])]; add: 'disassemble ext head frame method' action: [cogit disassembleMethod: (self frameMethod: framePointer)]; add: 'print oop...' action: [(self promptHex: 'print oop') ifNotNil: [:oop| self printOop: oop]]; add: 'long print oop...' action: [(self promptHex: 'print oop') ifNotNil: [:oop| self longPrintOop: oop]]; add: 'print context...' action: [(self promptHex: 'print context') ifNotNil: [:oop| self printContext: oop]]; add: 'symbolic method...' action: [(self promptHex: 'method bytecodes') ifNotNil: [:oop| self symbolicMethod: oop]]; addLine; add: 'inspect object memory' target: objectMemory action: #inspect; add: 'run leak checker' action: [Cursor execute showWhile: [self runLeakChecker]]; add: 'inspect cointerpreter' action: #inspect; add: 'inspect cogit' target: cogit action: #inspect; add: 'inspect method zone' target: cogit methodZone action: #inspect; add: 'inspect head frame' action: [CogHeadFrameInspector openFor: self]; add: 'inspect processor' action: [CogProcessorAlienInspector openFor: self]. self isThreadedVM ifTrue: [aMenuMorph add: 'inspect thread manager' target: self threadManager action: #inspect]. aMenuMorph addLine; add: 'print cog methods' target: cogMethodZone action: #printCogMethods; add: 'print cog methods with prim...' action: [(self promptNum: 'prim index') ifNotNil: [:pix| cogMethodZone printCogMethodsWithPrimitive: pix]]; add: 'print cog methods with selector...' action: [|s| s := UIManager default request: 'selector'. s notEmpty ifTrue: [s = 'nil' ifTrue: [s := nil]. cogMethodZone methodsDo: [:m| (s ifNil: [m selector = objectMemory nilObject] ifNotNil: [(objectMemory numBytesOf: m selector) = s size and: [(self strncmp: s _: (m selector + objectMemory baseHeaderSize) _: (objectMemory numBytesOf: m selector)) = 0]]) ifTrue: [cogit printCogMethod: m]]]]; add: 'print cog methods with method...' action: [(self promptHex: 'method') ifNotNil: [:methodOop| cogMethodZone printCogMethodsWithMethod: methodOop]]; add: 'print cog method for...' action: [(self promptHex: 'pc') ifNotNil: [:pc| cogit printCogMethodFor: pc]]; add: 'print cog method header for...' action: [(self promptHex: 'pc') ifNotNil: [:pc| cogit printCogMethodHeaderFor: pc]]; add: 'print trampoline table' target: cogit action: #printTrampolineTable; add: 'print prim trace log' action: #dumpPrimTraceLog; add: 'report recent instructions' target: cogit action: #reportLastNInstructions; add: (cogit printRegisters ifTrue: ['no print registers each instruction'] ifFalse: ['print registers each instruction']) action: [cogit printRegisters: cogit printRegisters not]; add: (cogit printInstructions ifTrue: ['no print instructions each instruction'] ifFalse: ['print instructions each instruction']) action: [cogit printInstructions: cogit printInstructions not]; addLine; add: (cogit singleStep ifTrue: ['no single step'] ifFalse: ['single step']) action: [cogit singleStep: cogit singleStep not]; add: 'click step' action: [cogit setClickStepBreakBlock]; add: 'set break pc', cogit breakPC menuPrompt, '...-ve to disable or remove' action: [cogit promptForBreakPC]; add: 'set break count...' action: [|s| s := UIManager default request: 'break count (dec)'. s notEmpty ifTrue: [breakCount := Integer readFrom: s readStream]]; add: 'set break selector...' action: [|s| s := UIManager default request: 'break selector (MNU:foo for MNU)'. s notEmpty ifTrue: [(s size > 4 and: [s beginsWith: 'MNU:']) ifTrue: [self setBreakMNUSelector: (s allButFirst: 4)] ifFalse: [self setBreakSelector: s]]]; + add: 'set break block in coInterpreter...' action: [| s | - add: 'set break block...' action: [| s | s := UIManager default request: 'break block' initialAnswer: (cogit breakBlock ifNotNil: [:bb| bb sourceString copyReplaceAll: 't1' with: 'address'] ifNil: '[:address| false]'). + s notEmpty ifTrue: [self setBreakBlockFromString: s for: self]]; + add: 'set break block in cogit...' action: [| s | + s := UIManager default + request: 'break block' + initialAnswer: (cogit breakBlock + ifNotNil: [:bb| bb sourceString copyReplaceAll: 't1' with: 'address'] + ifNil: '[:address| false]'). + s notEmpty ifTrue: [self setBreakBlockFromString: s for: cogit]]; - s notEmpty ifTrue: [self setBreakBlockFromString: s]]; add: 'set cogit break method...' action: [(self promptHex: 'cogit breakMethod') ifNotNil: [:bm| cogit setBreakMethod: bm]]; add: (printBytecodeAtEachStep ifTrue: ['no print bytecode each bytecode'] ifFalse: ['print bytecode each bytecode']) action: [self ensureDebugAtEachStepBlock. printBytecodeAtEachStep := printBytecodeAtEachStep not]; add: (printFrameAtEachStep ifTrue: ['no print frame each bytecode'] ifFalse: ['print frame each bytecode']) action: [self ensureDebugAtEachStepBlock. printFrameAtEachStep := printFrameAtEachStep not]. ^aMenuMorph!

1 0

VM Maker: VMMaker.oscog-eem.2729.mcz
by commits＠source.squeak.org 19 Mar '20

19 Mar '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2729.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2729 Author: eem Time: 18 March 2020, 8:11:20.738684 pm UUID: b57f3688-aef5-4b14-9b59-ee1fd0fd6d53 Ancestors: VMMaker.oscog-eem.2728 Interpreters: rip out the check alloc filler support in the interests of simplicity. Though useful in theory, this faclity has never been used successfully to find a bug in all the years it's been available (and we can always put it back). Rip out the debugPrimCallStackOffset support. I can't remember what this was supposed to do. It is confusing. Spur: Don't update become effect flags for identical oops that will later be filtered out in the loops oiver the arrays. Don't queue a WeakArray for finalization more than once (i.e. if its already in the queue there's no point adding it again). Cogit: fix genExternalizePointersForPrimitiveCall & genLoadCStackPointersForPrimCall for the SPReg ~= NativeSPReg regime. Localise code to the primitive generator invocation block in compilePrimitive Slang: rewrite TAssignmentNode>>emitValueExpansionOn:level:generator: in the same style as the recent rewrite of TReturnNode>>emitValueExpansionOn:level:generator: Simulation: Fix simulating leaf calls in teh context of a primitive invocation. ARMv8 has generated cache flushing code which is executed potentilly during a become primitive. Making simulateLeafCallOf: restore stack,frame,and link registers prevents this breaking asserts in handleCallOrJumpSimulationTrap:. Don't bother to print endless zeros on the rump C stack. Allow settingt a break block either in teh coInterpreter or the cogit (so processor et al are in scope). Fix receiver in canBeImmutable:. Fix strncpy:_:_: for CArray receivers. Correctly simulate getModuleName in e.g. LargeIntegersPlugin. Most of the above advance productizing the ARMv8 JIT. =============== Diff against VMMaker.oscog-eem.2728 =============== Item was changed: ----- Method: CoInterpreter class>>initializeMiscConstants (in category 'initialization') ----- initializeMiscConstants super initializeMiscConstants. COGVM := true. MinBackwardJumpCountForCompile := 40. MaxNumArgs := 15. PrimCallNeedsNewMethod := 1. PrimCallNeedsPrimitiveFunction := 2. PrimCallMayCallBack := 4. PrimCallOnSmalltalkStack := 8. PrimCallCollectsProfileSamples := 16. + "CheckAllocationFillerAfterPrimCall := 32. this has never been successfully used in all the years we've had it; nuking it" - CheckAllocationFillerAfterPrimCall := 32. PrimCallDoNotJIT := 64. PrimTraceLogSize := 256. "Room for 256 selectors. Must be 256 because we use a byte to hold the index" TraceBufferSize := 256 * 3. "Room for 256 events" TraceContextSwitch := self objectMemoryClass basicNew integerObjectOf: 1. TraceBlockActivation := self objectMemoryClass basicNew integerObjectOf: 2. TraceBlockCreation := self objectMemoryClass basicNew integerObjectOf: 3. TraceIncrementalGC := self objectMemoryClass basicNew integerObjectOf: 4. TraceFullGC := self objectMemoryClass basicNew integerObjectOf: 5. TraceCodeCompaction := self objectMemoryClass basicNew integerObjectOf: 6. TraceOwnVM := self objectMemoryClass basicNew integerObjectOf: 7. TraceDisownVM := self objectMemoryClass basicNew integerObjectOf: 8. TraceThreadSwitch := self objectMemoryClass basicNew integerObjectOf: 9. TracePreemptDisowningThread := self objectMemoryClass basicNew integerObjectOf: 10. TraceVMCallback := self objectMemoryClass basicNew integerObjectOf: 11. TraceVMCallbackReturn := self objectMemoryClass basicNew integerObjectOf: 12. TraceStackOverflow := self objectMemoryClass basicNew integerObjectOf: 13. TracePrimitiveFailure := self objectMemoryClass basicNew integerObjectOf: 14. TracePrimitiveRetry := self objectMemoryClass basicNew integerObjectOf: 15. TraceIsFromMachineCode := 1. TraceIsFromInterpreter := 2. CSCallbackEnter := 3. CSCallbackLeave := 4. CSEnterCriticalSection := 5. CSExitCriticalSection := 6. CSResume := 7. CSSignal := 8. CSSuspend := 9. CSWait := 10. CSYield := 11. CSCheckEvents := 12. CSThreadSchedulingLoop := 13. CSOwnVM := 14. CSThreadBind := 15. CSSwitchIfNeccessary := 16. TraceSources := CArrayAccessor on: #('?' 'm' 'i' 'callbackEnter' 'callbackLeave' 'enterCritical' 'exitCritical' 'resume' 'signal' 'suspend' 'wait' 'yield' 'eventcheck' 'threadsched' 'ownVM' 'bindToThread' 'switchIfNecessary'). "this is simulation only" RumpCStackSize := 4096! Item was removed: - ----- Method: CoInterpreter>>getCheckAllocFiller (in category 'cog jit support') ----- - getCheckAllocFiller - <api> - ^checkAllocFiller! Item was changed: ----- Method: CoInterpreter>>primitivePropertyFlagsForSpur: (in category 'cog jit support') ----- primitivePropertyFlagsForSpur: primIndex <inline: true> "Answer any special requirements of the given primitive. Spur always needs to set primitiveFunctionPointer and newMethod so primitives can retry on failure due to forwarders." | baseFlags | self cCode: [] inSmalltalk: [#(mcprimHashMultiply: primitiveExternalCall primitiveCalloutToFFI)]. "For senders..." primIndex = PrimNumberHashMultiply ifTrue: [^PrimCallOnSmalltalkStack]. baseFlags := PrimCallNeedsPrimitiveFunction + PrimCallNeedsNewMethod. profileSemaphore ~= objectMemory nilObject ifTrue: [baseFlags := baseFlags bitOr: PrimCallCollectsProfileSamples]. (primIndex = PrimNumberExternalCall "#primitiveExternalCall" or: [primIndex = PrimNumberFFICall "#primitiveCalloutToFFI"]) ifTrue: "For callbacks" + [baseFlags := baseFlags bitOr: PrimCallMayCallBack]. - [baseFlags := baseFlags bitOr: PrimCallMayCallBack. - checkAllocFiller ifTrue: - [baseFlags := baseFlags bitOr: CheckAllocationFillerAfterPrimCall]]. ^baseFlags! Item was changed: SharedPool subclass: #CogMethodConstants instanceVariableNames: '' + classVariableNames: 'CMBlock CMClosedPIC CMFree CMMaxUsageCount CMMethod CMOpenPIC CompletePrimitive EncounteredUnknownBytecode InsufficientCodeSpace MaxLiteralCountForCompile MaxMethodSize MaxNegativeErrorCode MaxNumArgs MaxStackCheckOffset MethodTooBig NotFullyInitialized PrimCallCollectsProfileSamples PrimCallDoNotJIT PrimCallMayCallBack PrimCallNeedsNewMethod PrimCallNeedsPrimitiveFunction PrimCallOnSmalltalkStack ShouldNotJIT UnfailingPrimitive UnimplementedPrimitive YoungSelectorInPIC' - classVariableNames: 'CMBlock CMClosedPIC CMFree CMMaxUsageCount CMMethod CMOpenPIC CheckAllocationFillerAfterPrimCall CompletePrimitive EncounteredUnknownBytecode InsufficientCodeSpace MaxLiteralCountForCompile MaxMethodSize MaxNegativeErrorCode MaxNumArgs MaxStackCheckOffset MethodTooBig NotFullyInitialized PrimCallCollectsProfileSamples PrimCallDoNotJIT PrimCallMayCallBack PrimCallNeedsNewMethod PrimCallNeedsPrimitiveFunction PrimCallOnSmalltalkStack ShouldNotJIT UnfailingPrimitive UnimplementedPrimitive YoungSelectorInPIC' poolDictionaries: '' category: 'VMMaker-JIT'! Item was changed: ----- Method: CogVMSimulator>>primitiveExecuteMethodArgsArray (in category 'control primitives') ----- primitiveExecuteMethodArgsArray + (InitializationOptions at: #haltOnExecuteMethod ifAbsent: [true]) ifTrue: + [self halt: thisContext selector]. - self halt: thisContext selector. ^super primitiveExecuteMethodArgsArray! Item was changed: ----- Method: CogVMSimulator>>printRumpCStackTo: (in category 'rump c stack') ----- printRumpCStackTo: address + | start | self assert: (self isOnRumpCStack: address). + start := heapBase - self rumpCStackSize. + [start < address and: [(objectMemory longAt: start) = 0]] whileTrue: + [start := start + objectMemory wordSize]. + start := start - (3 * objectMemory wordSize) max: heapBase - self rumpCStackSize. address + to: start - to: heapBase - self rumpCStackSize by: objectMemory wordSize negated do: [:addr| | label | self printHex: addr. addr = cogit processor sp ifTrue: [label := ' sp']. addr = cogit processor fp ifTrue: [label := (label ifNil: [''] ifNotNil: [label, ',']), 'fp']. addr = CStackPointer ifTrue: [label := (label ifNil: [''] ifNotNil: [label, ',']), 'CSP']. addr = CFramePointer ifTrue: [label := (label ifNil: [''] ifNotNil: [label, ',']), 'CFP']. label ifNil: [self tab] ifNotNil: [self print: ' ', label, '->']. + self tab; printHex: (objectMemory longAt: addr); cr]. + heapBase - self rumpCStackSize < start ifTrue: + [self print: 'zeros...'; cr]! - self tab; printHex: (objectMemory longAt: addr); cr]! Item was removed: - ----- Method: CogVMSimulator>>setBreakBlockFromString: (in category 'UI') ----- - setBreakBlockFromString: aString - | bString block | - bString := aString withBlanksTrimmed. - bString first = $- ifTrue: - [^cogit breakBlock: nil]. - bString first ~= $[ ifTrue: - [bString := '[:_address|', bString, ']']. - block := [Compiler evaluate: bString for: self logged: false] - on: Error - do: [:ex| - UIManager default warn: ex messageText. - ^self]. - cogit breakBlock: block! Item was added: + ----- Method: CogVMSimulator>>setBreakBlockFromString:for: (in category 'UI') ----- + setBreakBlockFromString: aString for: coInterpreterOrCogit + | bString block | + bString := aString withBlanksTrimmed. + bString first = $- ifTrue: + [^cogit breakBlock: nil]. + bString first ~= $[ ifTrue: + [bString := '[:_address|', bString, ']']. + block := [Compiler evaluate: bString for: coInterpreterOrCogit logged: false] + on: Error + do: [:ex| + UIManager default warn: ex messageText. + ^self]. + cogit breakBlock: block. + (atEachStepBlock notNil and: [atEachStepBlock home selector == #useCogitBreakBlockIfNone]) ifTrue: + [atEachStepBlock := nil]! Item was changed: ----- Method: Cogit class>>declareCVarsIn: (in category 'translation') ----- declareCVarsIn: aCCodeGenerator | backEnd | backEnd := CogCompilerClass basicNew. #( 'coInterpreter' 'objectMemory' 'methodZone' 'objectRepresentation' 'cogBlockMethodSurrogateClass' 'cogMethodSurrogateClass' 'nsSendCacheSurrogateClass' 'threadManager' 'processor' 'lastNInstructions' 'simulatedAddresses' 'simulatedTrampolines' 'simulatedVariableGetters' 'simulatedVariableSetters' 'processorFrameValid' 'printRegisters' 'printInstructions' 'clickConfirm' 'singleStep') do: [:simulationVariableNotNeededForRealVM| aCCodeGenerator removeVariable: simulationVariableNotNeededForRealVM]. NewspeakVM ifFalse: [#( 'selfSendTrampolines' 'dynamicSuperSendTrampolines' 'implicitReceiverSendTrampolines' 'outerSendTrampolines' 'ceEnclosingObjectTrampoline' 'numIRCs' 'indexOfIRC' 'theIRCs') do: [:variableNotNeededInNormalVM| aCCodeGenerator removeVariable: variableNotNeededInNormalVM]]. aCCodeGenerator removeConstant: #COGMTVM. "this should be defined at compile time" aCCodeGenerator addHeaderFile:'<stddef.h>'; "for e.g. offsetof" addHeaderFile:'"sqCogStackAlignment.h"'; addHeaderFile:'"dispdbg.h"'; "must precede cointerp.h & cogit.h otherwise NoDbgRegParms gets screwed up" addHeaderFile:'"cogmethod.h"'. NewspeakVM ifTrue: [aCCodeGenerator addHeaderFile:'"nssendcache.h"']. aCCodeGenerator addHeaderFile:'#if COGMTVM'; addHeaderFile:'"cointerpmt.h"'; addHeaderFile:'#else'; addHeaderFile:'"cointerp.h"'; addHeaderFile:'#endif'; addHeaderFile:'"cogit.h"'. aCCodeGenerator var: #ceGetFP declareC: 'usqIntptr_t (*ceGetFP)(void)'; var: #ceGetSP declareC: 'usqIntptr_t (*ceGetSP)(void)'; var: #ceCaptureCStackPointers declareC: 'void (*ceCaptureCStackPointers)(void)'; var: #ceEnterCogCodePopReceiverReg declareC: 'void (*ceEnterCogCodePopReceiverReg)(void)'; var: #realCEEnterCogCodePopReceiverReg declareC: 'void (*realCEEnterCogCodePopReceiverReg)(void)'; var: #ceCallCogCodePopReceiverReg declareC: 'void (*ceCallCogCodePopReceiverReg)(void)'; var: #realCECallCogCodePopReceiverReg declareC: 'void (*realCECallCogCodePopReceiverReg)(void)'; var: #ceCallCogCodePopReceiverAndClassRegs declareC: 'void (*ceCallCogCodePopReceiverAndClassRegs)(void)'; var: #realCECallCogCodePopReceiverAndClassRegs declareC: 'void (*realCECallCogCodePopReceiverAndClassRegs)(void)'; var: #postCompileHook declareC: 'void (*postCompileHook)(CogMethod *)'; var: #openPICList declareC: 'CogMethod *openPICList = 0'; var: #maxMethodBefore type: #'CogBlockMethod *'; var: 'enumeratingCogMethod' type: #'CogMethod *'. aCCodeGenerator var: #ceTryLockVMOwner declareC: '#if COGMTVM\usqIntptr_t (*ceTryLockVMOwner)(void)'; var: #ceUnlockVMOwner declareC: 'void (*ceUnlockVMOwner)(void)\#endif /* COGMTVM */'. backEnd numCheckLZCNTOpcodes > 0 ifTrue: [aCCodeGenerator var: #ceCheckLZCNTFunction declareC: 'static usqIntptr_t (*ceCheckLZCNTFunction)(void)']. backEnd numCheckFeaturesOpcodes > 0 ifTrue: [aCCodeGenerator var: #ceCheckFeaturesFunction declareC: 'static usqIntptr_t (*ceCheckFeaturesFunction)(void)']. backEnd numICacheFlushOpcodes > 0 ifTrue: [aCCodeGenerator var: #ceFlushICache declareC: 'static void (*ceFlushICache)(usqIntptr_t from, usqIntptr_t to)']. aCCodeGenerator var: #ceFlushDCache declareC: '#if DUAL_MAPPED_CODE_ZONE\static void (*ceFlushDCache)(usqIntptr_t from, usqIntptr_t to)\#endif'; var: #codeToDataDelta declareC: '#if DUAL_MAPPED_CODE_ZONE\static sqInt codeToDataDelta\#else\# define codeToDataDelta 0\#endif'. aCCodeGenerator declareVar: 'aMethodLabel' type: #'AbstractInstruction'; "Has to come lexicographically before backEnd & methodLabel" var: #backEnd declareC: 'AbstractInstruction * const backEnd = &aMethodLabel'; var: #methodLabel declareC: 'AbstractInstruction * const methodLabel = &aMethodLabel'. self declareC: #(abstractOpcodes stackCheckLabel blockEntryLabel blockEntryNoContextSwitch stackOverflowCall sendMiss entry noCheckEntry selfSendEntry dynSuperEntry fullBlockNoContextSwitchEntry fullBlockEntry picMNUAbort picInterpretAbort endCPICCase0 endCPICCase1 cPICEndOfCodeLabel) as: #'AbstractInstruction *' in: aCCodeGenerator. aCCodeGenerator declareVar: #cPICPrototype type: #'CogMethod *'; declareVar: #blockStarts type: #'BlockStart *'; declareVar: #fixups type: #'BytecodeFixup *'; declareVar: #methodZoneBase type: #usqInt. aCCodeGenerator var: #ordinarySendTrampolines declareC: 'sqInt ordinarySendTrampolines[NumSendTrampolines]'; var: #superSendTrampolines declareC: 'sqInt superSendTrampolines[NumSendTrampolines]'. BytecodeSetHasDirectedSuperSend ifTrue: [aCCodeGenerator var: #directedSuperSendTrampolines declareC: 'sqInt directedSuperSendTrampolines[NumSendTrampolines]'; var: #directedSuperBindingSendTrampolines declareC: 'sqInt directedSuperBindingSendTrampolines[NumSendTrampolines]']. NewspeakVM ifTrue: [aCCodeGenerator var: #selfSendTrampolines declareC: 'sqInt selfSendTrampolines[NumSendTrampolines]'; var: #dynamicSuperSendTrampolines declareC: 'sqInt dynamicSuperSendTrampolines[NumSendTrampolines]'; var: #implicitReceiverSendTrampolines declareC: 'sqInt implicitReceiverSendTrampolines[NumSendTrampolines]'; var: #outerSendTrampolines declareC: 'sqInt outerSendTrampolines[NumSendTrampolines]']. aCCodeGenerator var: #trampolineAddresses declareC: 'static char *trampolineAddresses[NumTrampolines*2]'; var: #objectReferencesInRuntime declareC: 'static usqInt objectReferencesInRuntime[NumObjRefsInRuntime+1]'; var: #labelCounter type: #int; var: #traceFlags declareC: 'int traceFlags = 8 /* prim trace log on by default */'; var: #cStackAlignment declareC: 'const int cStackAlignment = STACK_ALIGN_BYTES'. aCCodeGenerator + declareVar: #minValidCallAddress type: #'usqIntptr_t'. - declareVar: #minValidCallAddress type: #'usqIntptr_t'; - declareVar: #debugPrimCallStackOffset type: #'usqIntptr_t'. aCCodeGenerator vmClass generatorTable ifNotNil: [:bytecodeGenTable| aCCodeGenerator var: #generatorTable declareC: 'static BytecodeDescriptor generatorTable[', bytecodeGenTable size printString, ']', (self tableInitializerFor: bytecodeGenTable in: aCCodeGenerator)]. "In C the abstract opcode names clash with the Smalltalk generator syntactic sugar. Most of the syntactic sugar is inlined, but alas some remains. Rename the syntactic sugar to avoid the clash." (self organization listAtCategoryNamed: #'abstract instructions') do: [:s| aCCodeGenerator addSelectorTranslation: s to: 'g', (aCCodeGenerator cFunctionNameFor: s)]. aCCodeGenerator addSelectorTranslation: #halt: to: 'haltmsg'. self declareFlagVarsAsByteIn: aCCodeGenerator! Item was changed: ----- Method: Cogit class>>mustBeGlobal: (in category 'translation') ----- mustBeGlobal: var "Answer if a variable must be global and exported. Used for inst vars that are accessed from VM support code." ^#('ceBaseFrameReturnTrampoline' 'ceCaptureCStackPointers' 'ceCheckForInterruptTrampoline' ceEnterCogCodePopReceiverReg realCEEnterCogCodePopReceiverReg ceCallCogCodePopReceiverReg realCECallCogCodePopReceiverReg ceCallCogCodePopReceiverAndClassRegs realCECallCogCodePopReceiverAndClassRegs 'ceReturnToInterpreterTrampoline' 'ceCannotResumeTrampoline' ceTryLockVMOwner ceUnlockVMOwner 'cmEntryOffset' 'cmNoCheckEntryOffset' 'cmDynSuperEntryOffset' 'cmSelfSendEntryOffset' 'missOffset' 'cbEntryOffset' 'cbNoSwitchEntryOffset' 'blockNoContextSwitchOffset' breakPC ceGetFP ceGetSP cFramePointerInUse + traceFlags traceStores) - traceFlags traceStores debugPrimCallStackOffset) includes: var! Item was changed: ----- Method: Cogit>>codeMemmove:_:_: (in category 'generate machine code - dual mapped zone support') ----- codeMemmove: dest _: src _: bytes "Move memory (copy allowing for overlap), applying the codeToDataDelta. This is used for code compaction and so works on readable addresses (delta is required)." "production uses the macro..." + <cmacro: '(dest,src,bytes) memmove((char *)(dest)+codeToDataDelta,src,bytes)'> - <cmacro: '(dest,src,bytes) memmove((dest)+codeToDataDelta,src,bytes)'> self codeWriteBreakpoint: dest. "simulation writes twice if simulating dual mapping..." codeToDataDelta ~= 0 ifTrue: [objectMemory memmove: dest asUnsignedInteger + codeToDataDelta _: src _: bytes]. + objectMemory memmove: dest _: src _: bytes. + "and as a convenience, relocate the breakPC if it is in this method" + (breakPC notNil and: [breakPC between: src and: src + bytes - 1]) ifTrue: + [breakPC := breakPC - (src - dest)]! - objectMemory memmove: dest _: src _: bytes! Item was changed: ----- Method: Cogit>>genExternalizePointersForPrimitiveCall (in category 'trampoline support') ----- genExternalizePointersForPrimitiveCall - self MoveR: FPReg Aw: coInterpreter framePointerAddress. backEnd hasLinkRegister ifTrue: + [self MoveR: LinkReg Aw: coInterpreter instructionPointerAddress] + ifFalse: "Set coInterpreter stackPointer to the topmost argument, skipping the return address." - ["Set coInterpreter stackPointer to the topmost argument, skipping the return address." - self MoveR: SPReg Aw: coInterpreter stackPointerAddress. - self MoveR: LinkReg Aw: coInterpreter instructionPointerAddress] - ifFalse: [self PopR: TempReg. "get retpc" + self MoveR: TempReg Aw: coInterpreter instructionPointerAddress]. + ^backEnd genSaveStackPointers! - self MoveR: TempReg Aw: coInterpreter instructionPointerAddress. - "Set coInterpreter stackPointer to the topmost argument, skipping the return address." - self MoveR: SPReg Aw: coInterpreter stackPointerAddress]. - ^0! Item was changed: ----- Method: Cogit>>genLoadCStackPointersForPrimCall (in category 'trampoline support') ----- genLoadCStackPointersForPrimCall + <inline: #always> + cFramePointerInUse + ifTrue: [backEnd genLoadCStackPointers] + ifFalse: [backEnd genLoadCStackPointer]! - debugPrimCallStackOffset = 0 - ifTrue: - [self MoveAw: self cStackPointerAddress R: SPReg] - ifFalse: - [self MoveAw: self cStackPointerAddress R: TempReg. - self SubCq: debugPrimCallStackOffset R: TempReg. - self MoveR: TempReg R: SPReg]. - cFramePointerInUse ifTrue: - [self MoveAw: self cFramePointerAddress R: FPReg]. - ^0! Item was changed: ----- Method: Cogit>>handleCallOrJumpSimulationTrap: (in category 'simulation only') ----- handleCallOrJumpSimulationTrap: aProcessorSimulationTrap <doNotGenerate> | evaluable function memory result savedFramePointer savedStackPointer savedArgumentCount leaf retpc | evaluable := simulatedTrampolines at: aProcessorSimulationTrap address ifAbsent: [self errorProcessingSimulationTrap: aProcessorSimulationTrap in: simulatedTrampolines]. function := evaluable isBlock ifTrue: ['aBlock; probably some plugin primitive'] ifFalse: [evaluable receiver == backEnd ifTrue: [^self handleABICallOrJumpSimulationTrap: aProcessorSimulationTrap evaluable: evaluable]. evaluable selector]. function ~~ #ceBaseFrameReturn: ifTrue: [coInterpreter assertValidExternalStackPointers]. (backEnd wantsNearAddressFor: function) ifTrue: [^self perform: function with: aProcessorSimulationTrap]. memory := coInterpreter memory. aProcessorSimulationTrap type == #call ifTrue: [(leaf := coInterpreter mcprims includes: function) ifTrue: [processor simulateLeafCallOf: aProcessorSimulationTrap address nextpc: aProcessorSimulationTrap nextpc memory: memory. retpc := processor leafRetpcIn: memory] ifFalse: [processor simulateCallOf: aProcessorSimulationTrap address nextpc: aProcessorSimulationTrap nextpc memory: memory. retpc := processor retpcIn: memory]. self recordInstruction: {'(simulated call of '. aProcessorSimulationTrap address. '/'. function. ')'}] ifFalse: [leaf := false. processor simulateJumpCallOf: aProcessorSimulationTrap address memory: memory. retpc := processor retpcIn: memory. "sideways call; the primitive has pushed a return address." self recordInstruction: {'(simulated jump to '. aProcessorSimulationTrap address. '/'. function. ')'}]. savedFramePointer := coInterpreter framePointer. savedStackPointer := coInterpreter stackPointer. savedArgumentCount := coInterpreter argumentCount. result := ["self halt: evaluable selector." clickConfirm ifTrue: [(self confirm: 'skip run-time call?') ifFalse: [clickConfirm := false. self halt]]. evaluable valueWithArguments: (processor postCallArgumentsNumArgs: evaluable numArgs in: memory)] on: ReenterMachineCode do: [:ex| ex return: ex returnValue]. coInterpreter assertValidExternalStackPointers. "Verify the stack layout assumption compileInterpreterPrimitive: makes, provided we've not called something that has built a frame, such as closure value or evaluate method, or switched frames, such as primitiveSignal, primitiveWait, primitiveResume, primitiveSuspend et al." (function beginsWith: 'primitive') ifTrue: + [coInterpreter primFailCode = 0 - [coInterpreter checkForLastObjectOverwrite. - coInterpreter primFailCode = 0 ifTrue: [(#( primitiveClosureValue primitiveClosureValueWithArgs primitiveClosureValueNoContextSwitch primitiveFullClosureValue primitiveFullClosureValueWithArgs primitiveFullClosureValueNoContextSwitch primitiveSignal primitiveWait primitiveResume primitiveSuspend primitiveYield primitiveExecuteMethodArgsArray primitiveExecuteMethod primitivePerform primitivePerformWithArgs primitivePerformInSuperclass primitiveTerminateTo primitiveStoreStackp primitiveDoPrimitiveWithArgs) includes: function) ifFalse: ["This is a rare case (e.g. in Scorch where a married context's sender is set to nil on trapTrpped and hence the stack layout is altered." (function == #primitiveSlotAtPut and: [objectMemory isContext: (coInterpreter frameReceiver: coInterpreter framePointer)]) ifFalse: [self assert: savedFramePointer = coInterpreter framePointer. self assert: savedStackPointer + (savedArgumentCount * objectMemory wordSize) = coInterpreter stackPointer]]] ifFalse: [self assert: savedFramePointer = coInterpreter framePointer. self assert: savedStackPointer = coInterpreter stackPointer]]. result ~~ #continueNoReturn ifTrue: [self recordInstruction: {'(simulated return to '. processor retpcIn: memory. ')'}. leaf ifTrue: [processor simulateLeafReturnIn: memory] ifFalse: [processor simulateReturnIn: memory]. self assert: processor pc = retpc. processor smashCallerSavedRegistersWithValuesFrom: 16r80000000 by: objectMemory wordSize in: memory]. self assert: (result isInteger "an oop result" or: [result == coInterpreter or: [result == objectMemory or: [#(nil continue continueNoReturn) includes: result]]]). processor cResultRegister: (result ifNil: [0] ifNotNil: [result isInteger ifTrue: [result] ifFalse: [16rF00BA222]]) "coInterpreter cr. processor sp + 32 to: processor sp - 32 by: -4 do: [:sp| sp = processor sp ifTrue: [coInterpreter print: 'sp->'; tab] ifFalse: [coInterpreter printHex: sp]. coInterpreter tab; printHex: (coInterpreter longAt: sp); cr]"! Item was changed: ----- Method: Cogit>>setInterpreter: (in category 'initialization') ----- setInterpreter: aCoInterpreter "Initialization of the code generator in the simulator. These objects already exist in the generated C VM or are used only in the simulation." <doNotGenerate> coInterpreter := aCoInterpreter. objectMemory := aCoInterpreter objectMemory. threadManager := aCoInterpreter threadManager. "N.B. may be nil" methodZone := self class methodZoneClass new. objectRepresentation := objectMemory objectRepresentationClass forCogit: self methodZone: methodZone. methodZone setInterpreter: aCoInterpreter objectRepresentation: objectRepresentation cogit: self. generatorTable := self class generatorTable. processor := ProcessorClass new. simulatedAddresses := Dictionary new. coInterpreter class clusteredVariableNames do: [:cvn| self simulatedAddressFor: (cvn first = $C ifTrue: ['get', cvn] ifFalse: [cvn]) asSymbol]. simulatedTrampolines := Dictionary new. simulatedVariableGetters := Dictionary new. simulatedVariableSetters := Dictionary new. traceStores := 0. traceFlags := (self class initializationOptions at: #recordPrimTrace ifAbsent: [true]) ifTrue: [8] "record prim trace on by default (see Cogit class>>decareCVarsIn:)" ifFalse: [0]. - debugPrimCallStackOffset := 0. singleStep := printRegisters := printInstructions := clickConfirm := false. backEnd := CogCompilerClass for: self. methodLabel := CogCompilerClass for: self. (literalsManager := backEnd class literalsManagerClass new) cogit: self. ordinarySendTrampolines := CArrayAccessor on: (Array new: NumSendTrampolines). superSendTrampolines := CArrayAccessor on: (Array new: NumSendTrampolines). BytecodeSetHasDirectedSuperSend ifTrue: [directedSuperSendTrampolines := CArrayAccessor on: (Array new: NumSendTrampolines). directedSuperBindingSendTrampolines := CArrayAccessor on: (Array new: NumSendTrampolines). directedSendUsesBinding := false]. NewspeakVM ifTrue: [selfSendTrampolines := CArrayAccessor on: (Array new: NumSendTrampolines). dynamicSuperSendTrampolines := CArrayAccessor on: (Array new: NumSendTrampolines). implicitReceiverSendTrampolines := CArrayAccessor on: (Array new: NumSendTrampolines). outerSendTrampolines := CArrayAccessor on: (Array new: NumSendTrampolines)]. "debug metadata" objectReferencesInRuntime := CArrayAccessor on: (Array new: NumObjRefsInRuntime). runtimeObjectRefIndex := 0. "debug metadata" trampolineAddresses := CArrayAccessor on: (Array new: NumTrampolines * 2). trampolineTableIndex := 0. extA := numExtB := extB := 0. compilationTrace ifNil: [compilationTrace := self class initializationOptions at: #compilationTrace ifAbsent: [0]]. debugOpcodeIndices := self class initializationOptions at: #debugOpcodeIndices ifAbsent: [Set new]. debugBytecodePointers := self class initializationOptions at: #debugBytecodePointers ifAbsent: [Set new]. self class initializationOptions at: #breakPC ifPresent: [:pc| breakPC := pc]! Item was changed: ----- Method: Cogit>>simulateLeafCallOf: (in category 'simulation only') ----- simulateLeafCallOf: someFunction "Simulate execution of machine code that leaf-calls someFunction, answering the result returned by someFunction." "CogProcessorAlienInspector openFor: coInterpreter" <doNotGenerate> + | priorSP priorPC priorLR spOnEntry bogusRetPC | - | priorSP priorPC spOnEntry bogusRetPC | self recordRegisters. priorSP := processor sp. priorPC := processor pc. + priorLR := backEnd hasLinkRegister ifTrue: [processor lr]. processor setFramePointer: coInterpreter getCFramePointer stackPointer: coInterpreter getCStackPointer; simulateLeafCallOf: someFunction nextpc: (bogusRetPC := 16rBADF00D5 roundTo: backEnd codeGranularity) memory: coInterpreter memory. spOnEntry := processor sp. self recordInstruction: {'(simulated call of '. someFunction. ')'}. + [[processor pc between: 0 and: methodZone zoneEnd] whileTrue: - [processor pc between: 0 and: methodZone zoneEnd] whileTrue: [[singleStep ifTrue: [self recordProcessing. self maybeBreakAt: processor pc. processor singleStepIn: coInterpreter memory minimumAddress: guardPageSize readOnlyBelow: methodZone zoneEnd] ifFalse: [processor runInMemory: coInterpreter memory minimumAddress: guardPageSize readOnlyBelow: methodZone zoneEnd]] on: ProcessorSimulationTrap, Error do: [:ex| | retpc | processor pc = bogusRetPC ifTrue: [self recordInstruction: {'(simulated (real) return to '. processor pc. ')'}. ^processor cResultRegister]. ex class == ProcessorSimulationTrap ifTrue: [ex type == #read ifTrue: [self handleReadSimulationTrap: ex. ex resume: processor]. ex type == #write ifTrue: [self handleWriteSimulationTrap: ex. ex resume: processor]. ex type == #return ifTrue: [retpc := processor leafRetpcIn: coInterpreter memory. self assert: retpc = bogusRetPC. processor simulateLeafReturnIn: coInterpreter memory. self recordInstruction: {'(simulated return to '. retpc. ')'}. ^processor cResultRegister]]. ex pass]]. processor pc = bogusRetPC ifTrue: [self recordInstruction: {'(simulated (real) return to '. processor pc. ')'}]. + ^processor cResultRegister] + ensure: + [processor sp: priorSP. + processor pc: priorPC. + priorLR ifNotNil: [:lr| processor lr: lr]]! - ^processor cResultRegister! Item was removed: - ----- Method: CurrentImageCoInterpreterFacade>>getCheckAllocFiller (in category 'cog jit support') ----- - getCheckAllocFiller - ^coInterpreter getCheckAllocFiller ifNil: [false]! Item was removed: - ----- Method: ImageLeakChecker>>checkAllocFiller (in category 'no-op overrides') ----- - checkAllocFiller - <inline: #always> - ^false! Item was changed: ----- Method: InterpreterPlugin>>getModuleName (in category 'initialize') ----- getModuleName "Note: This is hardcoded so it can be run from Squeak. The module name is used for validating a module *after* it is loaded to check if it does really contain the module we're thinking it contains. This is important!!" <returnTypeC:'const char*'> <export: true> ^self cCode: [moduleName] inSmalltalk: + [| string index | + string := ((self class codeGeneratorClass new pluginClass: self class) variableDeclarationStringsForVariable: 'moduleName') first. + index := (string indexOfSubCollection: 'moduleName = "') + 14. + (string copyFrom: index to: (string indexOf: $" startingAt: index + 1) - 1), '(i)']! - [self class codeGeneratorClass new pluginClass: self class]! Item was changed: ----- Method: InterpreterPrimitives>>canBeImmutable: (in category 'object access primitives') ----- canBeImmutable: oop <option: #IMMUTABILITY> | scheduler processLists | self assert: (objectMemory isNonImmediate: oop). "For now we fail the primitive for contexts to we ensure there are no immutable contexts. Later we can consider having immutable contexts and send cannotReturn callback when returning to an immutable context. That would mean that setting a context to immutable would require a divorce and returns to immutable context are necessarily across stack pages" (objectMemory isContext: oop) ifTrue: [ ^ false ]. "Weak structures can't be immutable" (objectMemory isEphemeron: oop) ifTrue: [^ false]. (objectMemory isWeakNonImm: oop) ifTrue: [^ false]. "No clue what is going on for semaphores so they can't be immutable" (objectMemory isSemaphoreObj: oop) ifTrue: [^ false]. "Simple version of process management: we forbid Process and LinkedList instances to be immutable as well as the Processor and the array of activeProcess" + scheduler := self fetchPointer: ValueIndex ofObject: (objectMemory splObj: SchedulerAssociation). - scheduler := self fetchPointer: ValueIndex ofObject: (self splObj: SchedulerAssociation). processLists := objectMemory fetchPointer: ProcessListsIndex ofObject: scheduler. oop = scheduler ifTrue: [ ^ false ]. oop = processLists ifTrue: [ ^ false ]. "Is it a linkedList ?" (objectMemory classIndexOf: (objectMemory fetchPointer: 1 ofObject: processLists)) = (objectMemory classIndexOf: oop) ifTrue: [ ^ false ]. "is it a Process ?" (objectMemory classIndexOf: (objectMemory fetchPointer: ActiveProcessIndex ofObject: scheduler)) = (objectMemory classIndexOf: oop) ifTrue: [ ^ false ]. "The rest of the code is relative to process management: the Processor (the active process scheduler) can't be immutable, as well as all the objects relative to Process management " "scheduler := self fetchPointer: ValueIndex ofObject: (self splObj: SchedulerAssociation). processLists := objectMemory fetchPointer: ProcessListsIndex ofObject: scheduler. ((objectMemory formatOf: oop) = objectMemory nonIndexablePointerFormat) ifFalse: [ (objectMemory isArrayNonImm: oop) ifFalse: [ ^ true ]. ^ (oop = processLists) not ]. (objectMemory numSlotsOf: oop) >= 2 ifFalse: [ ^ true ]. ""is the oop the scheduler itself ?"" oop = scheduler ifTrue: [ ^ false ]. 1 to: (objectMemory numSlotsOf: processLists) do: [ :i | ""is the oop one of the linked lists ?"" (list := processLists at: i) = oop ifTrue: [^ false]. ""is the oop one of the runnable process ?"" first := objectMemory fetchPointer: FirstLinkIndex ofObject: list. first = objectMemory nilObject ifFalse: [ last := objectMemory fetchPointer: LastLinkIndex ofObject: list. link := first. [ link = last ] whileFalse: [ link = oop ifTrue: [ ^ false ]. link := objectMemory fetchPointer: NextLinkIndex ofObject: link. ] ] ]." ^ true! Item was changed: ----- Method: NewObjectMemory>>allInstancesOf: (in category 'primitive support') ----- allInstancesOf: aBehavior "Attempt to answer all instances of aBehavior, failing if there is not enough room." | count container fillPointer obj byteSize afterPreAllocatedObject | "Allocate a large header Array of sufficient size to require a large header. Reset its size later." container := self instantiateClass: (self splObj: ClassArray) indexableSize: self minLargeHeaderSize. self sizeHeader: container putBodySize: 0. afterPreAllocatedObject := freeStart. freeStart := fillPointer := (self firstFixedField: container) asInteger. count := 0. obj := self firstObject. [self oop: obj isLessThan: container] whileTrue: [(self isFreeObject: obj) ifFalse: [(self fetchClassOfNonImm: obj) = aBehavior ifTrue: [count := count + 1. fillPointer < reserveStart ifTrue: [self longAt: fillPointer put: obj. fillPointer := fillPointer + self bytesPerOop]]]. obj := self accessibleObjectAfter: obj]. + fillPointer >= reserveStart ifTrue: "didn't fit; answer instance count so large enough container can be allocated." + [^self integerObjectOf: count]. - fillPointer >= reserveStart ifTrue: "didn't fit. refill with allocation check pattern and answer count." - [self maybeFillWithAllocationCheckFillerFrom: freeStart to: fillPointer. - ^self integerObjectOf: count]. byteSize := fillPointer - (self firstFixedField: container) asInteger. self sizeHeader: container putBodySize: byteSize. - "Need to refill with the allocation check pattern if we shortened the object." - fillPointer < afterPreAllocatedObject ifTrue: - [self maybeFillWithAllocationCheckFillerFrom: fillPointer to: afterPreAllocatedObject]. freeStart := fillPointer. ^container! Item was removed: - ----- Method: NewObjectMemory>>checkAllocFiller (in category 'allocation') ----- - checkAllocFiller - <doNotGenerate> - "in the Spur bootstrap coInterpreter may not be initialized..." - ^coInterpreter notNil and: [coInterpreter checkAllocFiller]! Item was changed: ----- Method: NewObjectMemory>>initializeMemoryFirstFree: (in category 'initialization') ----- initializeMemoryFirstFree: firstFree "Initialize endOfMemory to the top of oop storage space, reserving some space for forwarding blocks, and set freeStart from which space is allocated." "Note: The amount of space reserved for forwarding blocks should be chosen to ensure that incremental compactions can usually be done in a single pass. However, there should be enough forwarding blocks so a full compaction can be done in a reasonable number of passes, say ten. (A full compaction requires N object-moving passes, where N = number of non-garbage objects / number of forwarding blocks). di 11/18/2000 Re totalObjectCount: Provide a margin of one byte per object to be used for forwarding pointers at GC time. Since fwd blocks are 8 bytes, this means an absolute worst case of 8 passes to compact memory. In most cases it will be adequate to do compaction in a single pass. " | fwdBlockBytes totalReserve | "reserve space for forwarding blocks and the interpreter. We can sacrifice forwarding block space at the cost of slower compactions but we cannot safely sacrifice interpreter allocation headroom." fwdBlockBytes := totalObjectCount bitAnd: WordMask - self wordSize + 1. totalReserve := fwdBlockBytes + coInterpreter interpreterAllocationReserveBytes. (self oop: memoryLimit - totalReserve isLessThan: firstFree + self baseHeaderSize) ifTrue: ["reserve enough space for a minimal free block of BaseHeaderSize bytes. We are apparently in an emergency situation here because we have no space for reserve and forwarding blocks. But a full GC will occur immediately in sufficientSpaceAfterGC: which will grow memory and restore the reserve." fwdBlockBytes := memoryLimit - (firstFree + self baseHeaderSize)]. "set endOfMemory reserveStart and freeStart" self setEndOfMemory: memoryLimit - fwdBlockBytes. reserveStart := endOfMemory - coInterpreter interpreterAllocationReserveBytes. freeStart := firstFree. "bytes available for oops" scavengeThreshold := freeStart + edenBytes min: reserveStart. - self maybeFillWithAllocationCheckFillerFrom: freeStart to: scavengeThreshold. self assert: (self oop: freeStart isLessThan: reserveStart). "We would like to assert this but can't because in GC situations it may be false. It is established by sufficientSpaceToAllocate: and sufficientSpaceAfterGC:" false ifTrue: [self assert: (self oop: reserveStart isLessThan: endOfMemory)]. self assert: (self oop: endOfMemory isLessThan: memoryLimit)! Item was removed: - ----- Method: NewObjectMemory>>maybeFillWithAllocationCheckFillerFrom:to: (in category 'allocation') ----- - maybeFillWithAllocationCheckFillerFrom: start to: end - "Fill free memory with a bit pattern for checking if the last object has been overwritten." - <inline: true> - <var: 'start' type: #usqInt> - <var: 'end' type: #usqInt> - <var: 'p' type: #usqInt> - self checkAllocFiller ifTrue: - [start to: end by: self wordSize do: - [:p| self longAt: p put: p]]! Item was changed: ----- Method: NewObjectMemory>>shorten:toIndexableSize: (in category 'allocation') ----- shorten: obj toIndexableSize: nSlots "Reduce the number of indexable fields in obj, a pointer object, to nSlots. Convert the unused residual to a free chunk. Word and byte indexable objects are not changed. Answer the number of bytes returned to free memory, which may be zero if no change was possible." | deltaBytes desiredLength fixedFields fmt hdr totalLength indexableFields | <api> (self isPointersNonImm: obj) ifFalse: [^0]. nSlots > 0 ifFalse: [^0]. "no change if nSlots is zero, error if nSlots is negative" hdr := self baseHeader: obj. fmt := self formatOfHeader: hdr. totalLength := self lengthOf: obj baseHeader: hdr format: fmt. fixedFields := self fixedFieldsOf: obj format: fmt length: totalLength. indexableFields := totalLength - fixedFields. nSlots >= indexableFields ifTrue: [^0]. "no change, or error if attempting to increase size into next chunk" desiredLength := fixedFields + nSlots. deltaBytes := (totalLength - desiredLength) * self wordSize. obj + self baseHeaderSize + (totalLength * self wordSize) = freeStart ifTrue: "Shortening the last object. Need to reduce freeStart." + [freeStart := obj + self baseHeaderSize + (desiredLength * self wordSize)] - [self maybeFillWithAllocationCheckFillerFrom: obj + self baseHeaderSize + (desiredLength * self wordSize) to: freeStart. - freeStart := obj + self baseHeaderSize + (desiredLength * self wordSize)] ifFalse: "Shortening some interior object. Need to create a free block." [self setSizeOfFree: obj + self baseHeaderSize + (desiredLength * self wordSize) to: deltaBytes]. (self headerType: obj) caseOf: { [HeaderTypeSizeAndClass] -> [self longAt: (obj - (self baseHeaderSize * 2)) put: (self sizeHeader: obj) - deltaBytes]. [HeaderTypeClass] -> [self longAt: obj put: ((hdr bitClear: SizeMask) bitOr: (hdr bitAnd: SizeMask) - deltaBytes)]. [HeaderTypeShort] -> [self longAt: obj put: ((hdr bitClear: SizeMask) bitOr: (hdr bitAnd: SizeMask) - deltaBytes)] }. ^deltaBytes! Item was changed: ----- Method: SimpleStackBasedCogit>>compileInterpreterPrimitive:flags: (in category 'primitive generators') ----- compileInterpreterPrimitive: primitiveRoutine flags: flags "Compile a call to an interpreter primitive. Call the C routine with the usual stack-switching dance, test the primFailCode and then either return on success or continue to the method body." <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> | jmp jmpSamplePrim continuePostSamplePrim jmpSampleNonPrim continuePostSampleNonPrim | <var: #jmp type: #'AbstractInstruction *'> <var: #jmpSamplePrim type: #'AbstractInstruction *'> <var: #jmpSampleNonPrim type: #'AbstractInstruction *'> <var: #continuePostSamplePrim type: #'AbstractInstruction *'> <var: #continuePostSampleNonPrim type: #'AbstractInstruction *'> "Save processor fp, sp and return pc in the interpreter's frame stack and instruction pointers" self genExternalizePointersForPrimitiveCall. "Switch to the C stack." self genLoadCStackPointersForPrimCall. (flags anyMask: PrimCallCollectsProfileSamples) ifTrue: ["Test nextProfileTick for being non-zero and call checkProfileTick if so" objectMemory wordSize = 4 ifTrue: [self MoveAw: coInterpreter nextProfileTickAddress R: TempReg. self MoveAw: coInterpreter nextProfileTickAddress + objectMemory wordSize R: ClassReg. self OrR: TempReg R: ClassReg] ifFalse: [self MoveAw: coInterpreter nextProfileTickAddress R: TempReg. self CmpCq: 0 R: TempReg]. "If set, jump to record sample call." jmpSampleNonPrim := self JumpNonZero: 0. continuePostSampleNonPrim := self Label]. "Old full prim trace is in VMMaker-eem.550 and prior" self recordPrimTrace ifTrue: [self genFastPrimTraceUsing: ClassReg and: SendNumArgsReg]. "Clear the primFailCode and set argumentCount" self MoveCq: 0 R: TempReg. self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. methodOrBlockNumArgs ~= 0 ifTrue: [self MoveCq: methodOrBlockNumArgs R: TempReg]. self MoveR: TempReg Aw: coInterpreter argumentCountAddress. "If required, set primitiveFunctionPointer and newMethod" (flags anyMask: PrimCallNeedsPrimitiveFunction) ifTrue: [self MoveCw: primitiveRoutine asInteger R: TempReg. primSetFunctionLabel := self MoveR: TempReg Aw: coInterpreter primitiveFunctionPointerAddress]. (flags anyMask: PrimCallNeedsNewMethod+PrimCallMayCallBack) ifTrue: ["The ceActivateFailingPrimitiveMethod: machinery can't handle framelessness." (flags anyMask: PrimCallMayCallBack) ifTrue: [needsFrame := true]. methodLabel addDependent: (self annotateAbsolutePCRef: (self MoveCw: methodLabel asInteger R: ClassReg)). self MoveMw: (self offset: CogMethod of: #methodObject) r: ClassReg R: TempReg. self MoveR: TempReg Aw: coInterpreter newMethodAddress]. "Invoke the primitive" self PrefetchAw: coInterpreter primFailCodeAddress. (flags anyMask: PrimCallMayCallBack) ifTrue: "Sideways call the C primitive routine so that we return through cePrimReturnEnterCogCode." ["On Spur ceActivateFailingPrimitiveMethod: would like to retry if forwarders are found. So insist on PrimCallNeedsPrimitiveFunction being set too." self assert: (flags anyMask: PrimCallNeedsPrimitiveFunction). backEnd + genMarshallNArgs: 0 arg: nil arg: nil arg: nil arg: nil; - genMarshallNArgs: 0 arg: 0 arg: 0 arg: 0 arg: 0; genSubstituteReturnAddress: ((flags anyMask: PrimCallCollectsProfileSamples) ifTrue: [cePrimReturnEnterCogCodeProfiling] ifFalse: [cePrimReturnEnterCogCode]). primInvokeInstruction := self JumpFullRT: primitiveRoutine asInteger. jmp := jmpSamplePrim := continuePostSamplePrim := nil] ifFalse: ["Call the C primitive routine." backEnd genMarshallNArgs: 0 arg: 0 arg: 0 arg: 0 arg: 0. primInvokeInstruction := self CallFullRT: primitiveRoutine asInteger. backEnd genRemoveNArgsFromStack: 0. (flags anyMask: PrimCallCollectsProfileSamples) ifTrue: [self assert: (flags anyMask: PrimCallNeedsNewMethod). "Test nextProfileTick for being non-zero and call checkProfileTick if so" objectMemory wordSize = 4 ifTrue: [self MoveAw: coInterpreter nextProfileTickAddress R: TempReg. self MoveAw: coInterpreter nextProfileTickAddress + objectMemory wordSize R: ClassReg. self OrR: TempReg R: ClassReg] ifFalse: [self MoveAw: coInterpreter nextProfileTickAddress R: TempReg. self CmpCq: 0 R: TempReg]. "If set, jump to record sample call." jmpSamplePrim := self JumpNonZero: 0. continuePostSamplePrim := self Label]. objectRepresentation maybeCompileRetryOnPrimitiveFail: primitiveIndex. - self maybeCompileAllocFillerCheck. "Switch back to the Smalltalk stack. Stack better be in either of these two states: success: stackPointer -> result (was receiver) arg1 ... argN return pc failure: receiver arg1 ... stackPointer -> argN return pc In either case we can push the instructionPointer or load it into the LinkRegister to reestablish the return pc" self MoveAw: coInterpreter instructionPointerAddress R: (backEnd hasLinkRegister ifTrue: [LinkReg] ifFalse: [ClassReg]). backEnd genLoadStackPointers. "Test primitive failure" self MoveAw: coInterpreter primFailCodeAddress R: TempReg. backEnd hasLinkRegister ifFalse: [self PushR: ClassReg]. "Restore return pc on CISCs" self flag: 'ask concrete code gen if move sets condition codes?'. self CmpCq: 0 R: TempReg. jmp := self JumpNonZero: 0. "Fetch result from stack" self MoveMw: (backEnd hasLinkRegister ifTrue: [0] ifFalse: [objectMemory wordSize]) r: SPReg R: ReceiverResultReg. self RetN: objectMemory wordSize]. "return to caller, popping receiver" (flags anyMask: PrimCallCollectsProfileSamples) ifTrue: ["The sample is collected by cePrimReturnEnterCogCode for external calls" jmpSamplePrim ifNotNil: ["Call ceCheckProfileTick: to record sample and then continue." jmpSamplePrim jmpTarget: self Label. self assert: (flags anyMask: PrimCallNeedsNewMethod). self CallFullRT: (self cCode: [#ceCheckProfileTick asUnsignedIntegerPtr] inSmalltalk: [self simulatedTrampolineFor: #ceCheckProfileTick]). "reenter the post-primitive call flow" self Jump: continuePostSamplePrim]. "Null newMethod and call ceCheckProfileTick: to record sample and then continue. ceCheckProfileTick will map null/0 to coInterpreter nilObject" jmpSampleNonPrim jmpTarget: self Label. self MoveCq: 0 R: TempReg. self MoveR: TempReg Aw: coInterpreter newMethodAddress. self CallFullRT: (self cCode: [#ceCheckProfileTick asUnsignedIntegerPtr] inSmalltalk: [self simulatedTrampolineFor: #ceCheckProfileTick]). "reenter the post-primitive call flow" self Jump: continuePostSampleNonPrim]. jmp ifNotNil: ["Jump to restore of receiver reg and proceed to frame build for failure." jmp jmpTarget: self Label. "Restore receiver reg from stack. If on RISCs ret pc is in LinkReg, if on CISCs ret pc is on stack." self MoveMw: objectMemory wordSize * (methodOrBlockNumArgs + (backEnd hasLinkRegister ifTrue: [0] ifFalse: [1])) r: SPReg R: ReceiverResultReg]. ^0! Item was changed: ----- Method: SimpleStackBasedCogit>>compilePrimitive (in category 'primitive generators') ----- compilePrimitive "Compile a primitive. If possible, performance-critical primtiives will be generated by their own routines (primitiveGenerator). Otherwise, if there is a primitive at all, we call the C routine with the usual stack-switching dance, test the primFailCode and then either return on success or continue to the method body." <inline: false> + | primitiveDescriptor primitiveRoutine flags | - | code opcodeIndexAtPrimitive primitiveDescriptor primitiveRoutine flags | <var: #primitiveDescriptor type: #'PrimitiveDescriptor *'> <var: #primitiveRoutine declareC: 'void (*primitiveRoutine)(void)'> primitiveIndex = 0 ifTrue: [^0]. - code := 0. - "Note opcodeIndex so that compileFallbackToInterpreterPrimitive: - can discard arg load instructions for unimplemented primitives." - opcodeIndexAtPrimitive := opcodeIndex. "If a descriptor specifies an argument count (by numArgs >= 0) then it must match for the generated code to be correct. For example for speed many primitives use ResultReceiverReg instead of accessing the stack, so the receiver better be at numArgs down the stack. Use the interpreter version if not." ((primitiveDescriptor := self primitiveGeneratorOrNil) notNil and: [primitiveDescriptor primitiveGenerator notNil + and: [(primitiveDescriptor primNumArgs < 0 "means generator doesn't care" - and: [(primitiveDescriptor primNumArgs < 0 "means don't care" or: [primitiveDescriptor primNumArgs = (coInterpreter argumentCountOf: methodObj)])]]) ifTrue: + [| opcodeIndexAtPrimitive code | + "Note opcodeIndex so that any arg load instructions + for unimplemented primitives can be discarded." + opcodeIndexAtPrimitive := opcodeIndex. + code := objectRepresentation perform: primitiveDescriptor primitiveGenerator. - [code := objectRepresentation perform: primitiveDescriptor primitiveGenerator]. - (code < 0 and: [code ~= UnimplementedPrimitive]) ifTrue: "Generator failed, so no point continuing..." - [^code]. - code = UnfailingPrimitive ifTrue: - [^0]. - "If the machine code verison handles all cases the only reason to call the interpreter - primitive is to reap the primitive error code. Don't bother if it isn't used." - (code = CompletePrimitive - and: [(self methodUsesPrimitiveErrorCode: methodObj header: methodHeader) not]) ifTrue: - [^0]. - "Discard any arg load code generated by the primitive generator." - code = UnimplementedPrimitive ifTrue: - [opcodeIndex := opcodeIndexAtPrimitive]. + (code < 0 and: [code ~= UnimplementedPrimitive]) ifTrue: "Generator failed, so no point continuing..." + [^code]. + "If the primitive can never fail then there is nothing more that needs to be done." + code = UnfailingPrimitive ifTrue: + [^0]. + "If the machine code version handles all cases the only reason to call the interpreter + primitive is to reap the primitive error code. Don't bother if it isn't used." + (code = CompletePrimitive + and: [(self methodUsesPrimitiveErrorCode: methodObj header: methodHeader) not]) ifTrue: + [^0]. + "Discard any arg load code generated by the primitive generator." + code = UnimplementedPrimitive ifTrue: + [opcodeIndex := opcodeIndexAtPrimitive]]. + flags := coInterpreter primitivePropertyFlags: primitiveIndex. (flags anyMask: PrimCallDoNotJIT) ifTrue: [^ShouldNotJIT]. (flags anyMask: PrimCallOnSmalltalkStack) ifTrue: [self assert: flags = PrimCallOnSmalltalkStack. ^self compileMachineCodeInterpreterPrimitive: (self cCoerceSimple: (coInterpreter mcprimFunctionForPrimitiveIndex: primitiveIndex) to: 'void (*)(void)')]. ((primitiveRoutine := coInterpreter functionPointerForCompiledMethod: methodObj primitiveIndex: primitiveIndex) = 0 "no primitive" or: [primitiveRoutine = (self cCoerceSimple: #primitiveFail to: 'void (*)(void)')]) ifTrue: [^self genFastPrimFail]. minValidCallAddress := minValidCallAddress min: primitiveRoutine asUnsignedInteger. ^self compileInterpreterPrimitive: primitiveRoutine flags: flags! Item was changed: ----- Method: SimpleStackBasedCogit>>genPrimReturnEnterCogCodeEnilopmart: (in category 'initialization') ----- genPrimReturnEnterCogCodeEnilopmart: profiling "Generate the substitute return code for an external or FFI primitive call. On success simply return, extracting numArgs from newMethod. On primitive failure call ceActivateFailingPrimitiveMethod: newMethod." | jmpSample continuePostSample jmpFail | <var: #jmpSample type: #'AbstractInstruction *'> <var: #continuePostSample type: #'AbstractInstruction *'> <var: #jmpFail type: #'AbstractInstruction *'> self zeroOpcodeIndex. backEnd hasVarBaseRegister ifTrue: [self MoveCq: self varBaseAddress R: VarBaseReg]. "Must happen sometime" profiling ifTrue: ["Test nextProfileTick for being non-zero and call checkProfileTick: if so. N.B. nextProfileTick is 64-bits so 32-bit systems need to test both halves." objectMemory wordSize = 4 ifTrue: [self MoveAw: coInterpreter nextProfileTickAddress R: TempReg. self MoveAw: coInterpreter nextProfileTickAddress + objectMemory wordSize R: ClassReg. self OrR: TempReg R: ClassReg] ifFalse: [self MoveAw: coInterpreter nextProfileTickAddress R: TempReg. self CmpCq: 0 R: TempReg]. "If set, jump to record sample call." jmpSample := self JumpNonZero: 0. continuePostSample := self Label]. - self maybeCompileAllocFillerCheck. - "Test primitive failure" self MoveAw: coInterpreter primFailCodeAddress R: TempReg. self flag: 'ask concrete code gen if move sets condition codes?'. self CmpCq: 0 R: TempReg. jmpFail := self JumpNonZero: 0. "Switch back to the Smalltalk stack. Stack better be in either of these two states: success: stackPointer -> result (was receiver) arg1 ... argN return pc failure: receiver arg1 ... stackPointer -> argN return pc We push the instructionPointer to reestablish the return pc in the success case, but leave it to ceActivateFailingPrimitiveMethod: to do so in the failure case." backEnd hasLinkRegister ifTrue: [backEnd genLoadStackPointers. "Switch back to Smalltalk stack." backEnd hasPCRegister ifTrue: [self PopR: ReceiverResultReg. "Pop result from stack" self MoveAw: coInterpreter instructionPointerAddress R: PCReg] "Return" ifFalse: [self MoveMw: 0 r: SPReg R: ReceiverResultReg. "Fetch result from stack" self MoveAw: coInterpreter instructionPointerAddress R: LinkReg. "Get ret pc" self RetN: objectMemory wordSize]] "Return, popping result from stack" ifFalse: [self MoveAw: coInterpreter instructionPointerAddress R: ClassReg. "Get return pc" backEnd genLoadStackPointers. "Switch back to Smalltalk stack." self MoveMw: 0 r: SPReg R: ReceiverResultReg. "Fetch result from stack" self MoveR: ClassReg Mw: 0 r: SPReg. "Restore return pc" self RetN: 0]. "Return, popping result from stack" "Primitive failed. Invoke C code to build the frame and continue." jmpFail jmpTarget: (self MoveAw: coInterpreter newMethodAddress R: SendNumArgsReg). "Reload sp with CStackPointer; easier than popping args of checkProfileTick." self MoveAw: self cStackPointerAddress R: SPReg. self compileCallFor: #ceActivateFailingPrimitiveMethod: numArgs: 1 arg: SendNumArgsReg arg: nil arg: nil arg: nil resultReg: NoReg regsToSave: self emptyRegisterMask. "On Spur ceActivateFailingPrimitiveMethod: may retry the primitive and return if successful. So continue by returning to the caller. Switch back to the Smalltalk stack. Stack should be in this state: success: stackPointer -> result (was receiver) arg1 ... argN return pc We can push the instructionPointer or load it into the LinkRegister to reestablish the return pc" self MoveAw: coInterpreter instructionPointerAddress R: (backEnd hasLinkRegister ifTrue: [LinkReg] ifFalse: [ClassReg]). backEnd genLoadStackPointers. backEnd hasLinkRegister ifTrue: [self MoveMw: 0 r: SPReg R: ReceiverResultReg] "Fetch result from stack" ifFalse: [self MoveMw: objectMemory wordSize r: SPReg R: ReceiverResultReg. "Fetch result from stack" self PushR: ClassReg]. "Restore return pc on CISCs" self RetN: objectMemory wordSize. "return to caller, popping receiver" profiling ifTrue: ["Call ceCheckProfileTick: to record sample and then continue. newMethod should be up-to-date. Need to save and restore the link reg around this call." jmpSample jmpTarget: self Label. backEnd saveAndRestoreLinkRegAround: [self CallFullRT: (self cCode: '(usqIntptr_t)ceCheckProfileTick' inSmalltalk: [self simulatedTrampolineFor: #ceCheckProfileTick])]. self Jump: continuePostSample]! Item was removed: - ----- Method: SimpleStackBasedCogit>>maybeCompileAllocFillerCheck (in category 'primitive generators') ----- - maybeCompileAllocFillerCheck - "If allocCheckFiller is true, words in newSpace from freeStart to scavengeThreshold - are filled with their address, and after each call of a plugin primitive, the VM checks - that freeStart points to a word containing the value of freeStart. This is a simple - check for primitives overwriting the ends of an object." - | jmpOk | - <var: #jmpOk type: #'AbstractInstruction *'> - coInterpreter getCheckAllocFiller ifTrue: - [self MoveAw: objectMemory freeStartAddress R: ClassReg. - self MoveMw: 0 r: ClassReg R: TempReg. - self CmpR: ClassReg R: TempReg. - jmpOk := self JumpZero: 0. - self MoveCq: PrimErrWritePastObject R: TempReg. - self MoveR: TempReg Aw: coInterpreter primFailCodeAddress. - jmpOk jmpTarget: self Label]! Item was changed: ----- Method: SpurGenerationScavenger>>newSpaceStart:newSpaceBytes:survivorBytes: (in category 'initialization') ----- newSpaceStart: startAddress newSpaceBytes: totalBytes survivorBytes: requestedSurvivorBytes | actualEdenBytes survivorBytes | survivorBytes := requestedSurvivorBytes truncateTo: manager allocationUnit. actualEdenBytes := totalBytes - survivorBytes - survivorBytes truncateTo: manager allocationUnit. self assert: totalBytes - actualEdenBytes - survivorBytes - survivorBytes < manager allocationUnit. "for tenuring we require older objects below younger objects. since allocation grows up this means that the survivor spaces must precede eden." pastSpace start: startAddress; limit: startAddress + survivorBytes. futureSpace start: pastSpace limit; limit: pastSpace limit + survivorBytes. eden start: futureSpace limit; limit: startAddress + totalBytes. self assert: self futureSpace limit <= (startAddress + totalBytes). self assert: self eden start \\ manager allocationUnit + (self eden limit \\ manager allocationUnit) = 0. self assert: self pastSpace start \\ manager allocationUnit + (self pastSpace limit \\ manager allocationUnit) = 0. self assert: self futureSpace start \\ manager allocationUnit + (self futureSpace limit \\ manager allocationUnit) = 0. self initFutureSpaceStart. - manager initSpaceForAllocationCheck: (self addressOf: eden) limit: eden limit. tenuringProportion := 0.9! Item was removed: - ----- Method: SpurMemoryManager>>checkAllocFiller (in category 'allocation') ----- - checkAllocFiller - <doNotGenerate> - "in the Spur bootstrap coInterpreter may not be initialized..." - ^coInterpreter notNil and: [coInterpreter checkAllocFiller]! Item was changed: ----- Method: SpurMemoryManager>>containsOnlyValidBecomeObjects:and:twoWay:copyHash: (in category 'become implementation') ----- containsOnlyValidBecomeObjects: array1 and: array2 twoWay: isTwoWay copyHash: copyHash "Answer 0 if neither array contains an object inappropriate for the become operation. Otherwise answer an informative error code for the first offending object found: Can't become: immediates => PrimErrInappropriate Shouldn't become pinned objects => PrimErrObjectIsPinned. Shouldn't become immutable objects => PrimErrNoModification. Can't copy hash into immediates => PrimErrInappropriate. Two-way become may require memory to create copies => PrimErrNoMemory. As a side-effect unforward any forwarders in the two arrays if answering 0." <inline: true> | fieldOffset effectsFlags oop1 oop2 size | fieldOffset := self lastPointerOf: array1. effectsFlags := size := 0. "array1 is known to be the same size as array2" [fieldOffset >= self baseHeaderSize] whileTrue: [oop1 := self longAt: array1 + fieldOffset. (self isOopForwarded: oop1) ifTrue: [oop1 := self followForwarded: oop1. self longAt: array1 + fieldOffset put: oop1]. self ifOopInvalidForBecome: oop1 errorCodeInto: [:errCode| ^errCode]. - effectsFlags := effectsFlags bitOr: (self becomeEffectFlagsFor: oop1). oop2 := self longAt: array2 + fieldOffset. (self isOopForwarded: oop2) ifTrue: [oop2 := self followForwarded: oop2. self longAt: array2 + fieldOffset put: oop2]. isTwoWay ifTrue: [self ifOopInvalidForBecome: oop2 errorCodeInto: [:errCode| ^errCode]. + oop1 ~= oop2 ifTrue: + [size := size + (self bytesInObject: oop1) + (self bytesInObject: oop2). + effectsFlags := (effectsFlags + bitOr: (self becomeEffectFlagsFor: oop1)) + bitOr: (self becomeEffectFlagsFor: oop2)]] - size := size + (self bytesInObject: oop1) + (self bytesInObject: oop2). - effectsFlags := effectsFlags bitOr: (self becomeEffectFlagsFor: oop2)] ifFalse: [(copyHash and: [(self isImmediate: oop2) or: [self isImmutable: oop2]]) ifTrue: + [^PrimErrInappropriate]. + oop1 ~= oop2 ifTrue: + [effectsFlags := effectsFlags bitOr: (self becomeEffectFlagsFor: oop1)]]. - [^PrimErrInappropriate]]. fieldOffset := fieldOffset - self bytesPerOop]. size >= (totalFreeOldSpace + (scavengeThreshold - freeStart)) ifTrue: [^PrimErrNoMemory]. "only set flags after checking all args." becomeEffectsFlags := effectsFlags. ^0! Item was changed: ----- Method: SpurMemoryManager>>doScavenge: (in category 'gc - scavenging') ----- doScavenge: tenuringCriterion "The inner shell for scavenge, abstrascted out so globalGarbageCollect can use it." <inline: false> self doAllocationAccountingForScavenge. gcPhaseInProgress := ScavengeInProgress. pastSpaceStart := scavenger scavenge: tenuringCriterion. self assert: (self oop: pastSpaceStart isGreaterThanOrEqualTo: scavenger pastSpace start andLessThanOrEqualTo: scavenger pastSpace limit). freeStart := scavenger eden start. - self initSpaceForAllocationCheck: (self addressOf: scavenger eden) limit: scavengeThreshold. gcPhaseInProgress := 0. self resetAllocationAccountingAfterGC! Item was removed: - ----- Method: SpurMemoryManager>>initSpaceForAllocationCheck:limit: (in category 'allocation') ----- - initSpaceForAllocationCheck: aNewSpace limit: limit - <var: 'aNewSpace' type: #'SpurNewSpaceSpace *'> - <var: 'limit' type: #usqInt> - memory ifNotNil: - [self checkAllocFiller ifTrue: - [aNewSpace start - to: limit - 1 - by: self wordSize - do: [:p| self longAt: p put: p]]]! Item was changed: ----- Method: SpurMemoryManager>>initializeNewSpaceVariables (in category 'gc - scavenging') ----- initializeNewSpaceVariables <inline: #never> freeStart := scavenger eden start. pastSpaceStart := scavenger pastSpace start. scavengeThreshold := scavenger eden limit - (scavenger edenBytes // 64) - coInterpreter interpreterAllocationReserveBytes. newSpaceStart := scavenger pastSpace start min: scavenger futureSpace start. + self assert: newSpaceStart < scavenger eden start! - self assert: newSpaceStart < scavenger eden start. - self initSpaceForAllocationCheck: (self addressOf: scavenger eden) limit: scavengeThreshold! Item was changed: ----- Method: SpurMemoryManager>>queueMourner: (in category 'weakness and ephemerality') ----- queueMourner: anEphemeronOrWeakArray + "Add the ephemeron or weak array to the queue." - "Add the ephemeron to the queue and make it non-ephemeral, to avoid subsequent firing. - Alas this means that other ephemerons on the same object not identified in this sccavenge - or GC will not fire until later. But that's life." self assert: ((self isNonImmediate: anEphemeronOrWeakArray) and: [(self formatOf: anEphemeronOrWeakArray) = self ephemeronFormat or: [(self formatOf: anEphemeronOrWeakArray) = self weakArrayFormat]]). self deny: ((self formatOf: anEphemeronOrWeakArray) = self ephemeronFormat and: [self is: anEphemeronOrWeakArray onObjStack: mournQueue]). self ensureRoomOnObjStackAt: MournQueueRootIndex. + "There is no point queueing weak arrays more than once. Note that it should be impossible + for ephemerons to be enqueued more than once since they are turned into non-ephemerons + in the relevant sender. Alas this means that other ephemerons on the same object not + identified in this scavenge or GC will not fire until later. But that's life." + (self isEphemeron: anEphemeronOrWeakArray) ifFalse: + [(self is: anEphemeronOrWeakArray onObjStack: mournQueue) ifTrue: + [^self]]. self push: anEphemeronOrWeakArray onObjStack: mournQueue! Item was changed: InterpreterPrimitives subclass: #StackInterpreter (excessive size, no diff calculated) Item was changed: ----- Method: StackInterpreter>>callExternalPrimitive: (in category 'plugin primitive support') ----- callExternalPrimitive: functionID "Call the external plugin function identified. In the VM this is an address; see StackInterpreterSimulator for its version." <var: #functionID declareC: 'void (*functionID)()'> "Spur needs the primitiveFunctionPointer to be set correctly for accurate following of forwarders on primitive failure." objectMemory hasSpurMemoryManagerAPI ifTrue: [primitiveFunctionPointer := functionID]. + self dispatchFunctionPointer: functionID! - self dispatchFunctionPointer: functionID. - self maybeFailForLastObjectOverwrite.! Item was removed: - ----- Method: StackInterpreter>>checkAllocFiller (in category 'primitive support') ----- - checkAllocFiller - "If allocCheckFiller is true, words in newSpace from freeStart to scavengeThreshold - are filled with their address, and after each call of a plugin primitive, the VM checks - that freeStart points to a word containing the value of freeStart. This is a simple - check for primitives overwriting the ends of an object." - <cmacro: '() GIV(checkAllocFiller)'> - ^checkAllocFiller! Item was removed: - ----- Method: StackInterpreter>>checkForLastObjectOverwrite (in category 'simulation') ----- - checkForLastObjectOverwrite - <doNotGenerate> - | freeStart | - checkAllocFiller ifTrue: - [self assert: ((freeStart := objectMemory freeStart) >= objectMemory scavengeThreshold - or: [(objectMemory longAt: freeStart) = freeStart])]! Item was changed: ----- Method: StackInterpreter>>initialize (in category 'initialization') ----- initialize "Here we can initialize the variables C initializes to zero. #initialize methods do /not/ get translated." super initialize. primitiveDoMixedArithmetic := true. "whether we authorize primitives to perform mixed arithmetic or not" - checkAllocFiller := false. "must precede initializeObjectMemory:" stackLimit := 0. "This is also the initialization flag for the stack system." stackPage := overflowedPage := 0. extraFramesToMoveOnOverflow := 0. bytecodeSetSelector := 0. highestRunnableProcessPriority := 0. nextPollUsecs := 0. nextWakeupUsecs := 0. tempOop := tempOop2 := theUnknownShort := 0. interruptPending := false. inIOProcessEvents := 0. fullScreenFlag := 0. sendWheelEvents := deferDisplayUpdates := false. displayBits := displayWidth := displayHeight := displayDepth := 0. pendingFinalizationSignals := statPendingFinalizationSignals := 0. globalSessionID := 0. jmpDepth := 0. longRunningPrimitiveStartUsecs := longRunningPrimitiveStopUsecs := 0. maxExtSemTabSizeSet := false. debugCallbackInvokes := debugCallbackPath := debugCallbackReturns := 0. statForceInterruptCheck := statStackOverflow := statCheckForEvents := statProcessSwitch := statIOProcessEvents := statStackPageDivorce := statIdleUsecs := 0! Item was removed: - ----- Method: StackInterpreter>>maybeFailForLastObjectOverwrite (in category 'primitive support') ----- - maybeFailForLastObjectOverwrite - <inline: true> - checkAllocFiller ifTrue: - [(objectMemory freeStart < objectMemory scavengeThreshold - and: [(objectMemory longAt: objectMemory freeStart) ~= objectMemory freeStart]) ifTrue: - [self primitiveFailFor: PrimErrWritePastObject]]! Item was removed: - ----- Method: StackInterpreter>>setCheckAllocFiller: (in category 'primitive support') ----- - setCheckAllocFiller: aBool - "If allocCheckFiller is true, words in newSpace from freeStart to scavengeThreshold - are filled with their address, and after each call of a plugin primitive, the VM checks - that freeStart points to a word containing the value of freeStart. This is a simple - check for primitives overwriting the ends of an object." - checkAllocFiller := aBool! Item was changed: ----- Method: StackInterpreter>>slowPrimitiveResponse (in category 'primitive support') ----- slowPrimitiveResponse "Invoke a normal (non-quick) primitive. Called under the assumption that primFunctionPointer has been preloaded." | nArgs savedFramePointer savedStackPointer | <inline: true> <var: #savedFramePointer type: #'char *'> <var: #savedStackPointer type: #'char *'> self assert: (objectMemory isOopForwarded: (self stackValue: argumentCount)) not. self assert: objectMemory remapBufferCount = 0. FailImbalancedPrimitives ifTrue: [nArgs := argumentCount. savedStackPointer := stackPointer. savedFramePointer := framePointer]. self initPrimCall. self dispatchFunctionPointer: primitiveFunctionPointer. self assert: (self maybeLeakCheckExternalPrimCall: newMethod). self maybeRetryPrimitiveOnFailure. - self maybeFailForLastObjectOverwrite. (FailImbalancedPrimitives and: [self successful and: [framePointer = savedFramePointer and: [(self isMachineCodeFrame: framePointer) not]]]) ifTrue:"Don't fail if primitive has done something radical, e.g. perform:" [stackPointer ~= (savedStackPointer + (nArgs * objectMemory wordSize)) ifTrue: [self flag: 'Would be nice to make this a message send of e.g. unbalancedPrimitive to the current process or context'. "This is necessary but insufficient; the result may still have been written to the stack. At least we'll know something is wrong." self failUnbalancedPrimitive. stackPointer := savedStackPointer]]. "If we are profiling, take accurate primitive measures" nextProfileTick > 0 ifTrue: [self checkProfileTick: newMethod]. ^self successful! Item was changed: ----- Method: TAssignmentNode>>emitValueExpansionOn:level:generator: (in category 'C code generation') ----- emitValueExpansionOn: aStream level: level generator: aCodeGen + | stmtList lastStmt copiedStatements | - | stmtList lastStmt copy | self assert: (expression isSend and: [expression isValueExpansion]). stmtList := expression receiver. lastStmt := stmtList statements last. lastStmt = variable ifTrue: [^expression emitCCodeOn: aStream level: level generator: aCodeGen]. + copiedStatements := stmtList copy. + copiedStatements statements - copy := stmtList copy. - copy statements at: stmtList statements size put: (TAssignmentNode new setVariable: variable expression: lastStmt). + expression copy + receiver: copiedStatements; + emitCCodeOn: aStream level: level generator: aCodeGen! - (TSendNode new - setSelector: expression selector - receiver: copy - arguments: expression args) - emitCCodeOn: aStream level: level generator: aCodeGen.! Item was changed: ----- Method: VMClass>>strncpy:_:_: (in category 'C library simulation') ----- strncpy: dest _: src _: n <doNotGenerate> "implementation of strncpy(3). See e.g. https://manpages.debian.org/stretch/manpages-dev/strncpy.3.en.html The C version always takes an address; the simulation allows a String, ByteArray, CArray or address within the simulation object memory (Positive Integer)" | getBlock setBlock count | count := n. "Determine the source and destination access blocks based on the parameter type" getBlock := src isCollection ifTrue: [count := count min: src size. src isString ifTrue: [[ :idx | src basicAt: idx]] "basicAt: answers integers" ifFalse: [src class == ByteArray ifTrue: [[ :idx | src at: idx]]]] ifFalse: [src isInteger ifTrue: [[ :idx | self byteAt: src + idx - 1]] ifFalse: [src isCArray ifTrue: [[ :idx | src at: idx - 1]]]]. getBlock ifNil: [self error: 'unhandled type of source string']. setBlock := dest isCollection ifTrue: [dest isString ifTrue: [[ :idx | dest basicAt: idx put: (getBlock value: idx)]] "basicAt:put: stores integers" ifFalse: [dest class == ByteArray ifTrue: [[ :idx | dest at: idx put: (getBlock value: idx)]]]] ifFalse: [dest isInteger ifTrue: + [[ :idx | self byteAt: dest + idx - 1 put: (getBlock value: idx)]] + ifFalse: + [dest isCArray ifTrue: + [[ :idx | dest at: idx - 1 put: (getBlock value: idx)]]]]. - [[ :idx | self byteAt: dest + idx - 1 put: (getBlock value: idx)]]]. setBlock ifNil: [self error: 'unhandled type of destination string']. 1 to: count do: setBlock. "SVr4, 4.3BSD, C89, C99 require the remainder of the buffer be filled with nulls" getBlock := [:idx| 0]. count + 1 to: n do: setBlock. ^dest!

1 0

VM Maker: Cog-eem.403.mcz
by commits＠source.squeak.org 19 Mar '20

19 Mar '20

Eliot Miranda uploaded a new version of Cog to project VM Maker: http://source.squeak.org/VMMaker/Cog-eem.403.mcz ==================== Summary ==================== Name: Cog-eem.403 Author: eem Time: 18 March 2020, 7:50:06.183956 pm UUID: c4cc1b44-d173-48eb-949c-bcc3155191d4 Ancestors: Cog-eem.402 Add abstract accessors for the link register on processors that have it. =============== Diff against Cog-eem.402 =============== Item was added: + ----- Method: MIPSSimulator>>lr (in category 'accessing-abstract') ----- + lr + ^self ra! Item was added: + ----- Method: MIPSSimulator>>lr: (in category 'accessing-abstract') ----- + lr: address + self ra: address!

1 0

Still Failing: OpenSmalltalk/opensmalltalk-vm#1973 (Cog - 102b0fa)
by Travis CI 18 Mar '20

18 Mar '20

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1973 Status: Still Failing Duration: 30 mins and 25 secs Commit: 102b0fa (Cog) Author: Eliot Miranda Message: CogVM source as per VMMaker.oscog-eem.2728 Slang: Fix a bug with value expansions. The original code elided the value[:value:]* send when inlining a literal block evaluation whose block didn't end in return. When dispatchConcretize, and all concretize mehtods invoked there-in were changed to answer the number of bytes of generated code, rather than each concretize mehtod assigning the number of bytes of generated code individually, this bug surfaced, and invalid code was produced. Amazing that this affected only ARMv5. Fix a bogus failing assert over-zealously added to VMMaker.oscog-eem.2724. View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/aa688da5c4db...10… View the full build log and details: https://travis-ci.org/github/OpenSmalltalk/opensmalltalk-vm/builds/66376381… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] 102b0f: CogVM source as per VMMaker.oscog-eem.2728
by Eliot Miranda 18 Mar '20

18 Mar '20

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 102b0fa831e2f793620a9a4cf94369d696e7920f https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/102b0fa831e2f79362… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2020-03-17 (Tue, 17 Mar 2020) Changed paths: M build.linux32ARMv6/HowToBuild M build.linux32ARMv6/newspeak.cog.spur/build.debug/mvm M build.linux32ARMv6/squeak.cog.spur/build.debug/mvm M build.linux32ARMv7/newspeak.cog.spur/build.debug/mvm M build.linux32x86/pharo.sista.spur/build.assert.itimerheartbeat/mvm M build.linux64ARMv8/squeak.cog.spur/build.assert/mvm M build.linux64ARMv8/squeak.cog.spur/build.debug/mvm M build.linux64ARMv8/squeak.cog.spur/build/mvm M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M platforms/Cross/vm/sqAtomicOps.h M scripts/revertIfEssentiallyUnchanged M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstack64src/vm/validImage.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M spurstacksrc/vm/validImage.c M src/plugins/DESPlugin/DESPlugin.c M src/plugins/DSAPrims/DSAPrims.c M src/plugins/MD5Plugin/MD5Plugin.c M src/plugins/SHA256Plugin/SHA256Plugin.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2728 Slang: Fix a bug with value expansions. The original code elided the value[:value:]* send when inlining a literal block evaluation whose block didn't end in return. When dispatchConcretize, and all concretize mehtods invoked there-in were changed to answer the number of bytes of generated code, rather than each concretize mehtod assigning the number of bytes of generated code individually, this bug surfaced, and invalid code was produced. Amazing that this affected only ARMv5. Fix a bogus failing assert over-zealously added to VMMaker.oscog-eem.2724.

1 0

VM Maker: VMMaker.oscog-eem.2728.mcz
by commits＠source.squeak.org 18 Mar '20

18 Mar '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2728.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2728 Author: eem Time: 17 March 2020, 6:33:59.809562 pm UUID: 9d29dbcb-8c21-4d75-a8cc-c2af3fd75b03 Ancestors: VMMaker.oscog-eem.2727 Slang: Fix a bug with value expansions. The original code elided the value[:value:]* send when inlining a literal block evaluation whose block didn't end in return. When dispatchConcretize, and all concretize mehtods invoked there-in were changed to answer the number of bytes of generated code, rather than each concretize mehtod assigning the number of bytes of generated code individually, this bug surfaced, and invalid code was produced. Amazing that this affected only ARMv5. Nuke an obsolete pragma in an genForwardersInlinedIdenticalOrNotIf:. Nuke an unsent method in ObjectMemory. =============== Diff against VMMaker.oscog-eem.2727 =============== Item was removed: - ----- Method: ObjectMemory>>isObjMutable: (in category 'header access') ----- - isObjMutable: anOop - <inline: true> - ^(self isObjImmutable: anOop) not! Item was changed: ----- Method: SistaRegisterAllocatingCogit>>genForwardersInlinedIdenticalOrNotIf: (in category 'bytecode generators') ----- genForwardersInlinedIdenticalOrNotIf: orNot "Override to count inlined branches if followed by a conditional branch. We borrow the following conditional branch's counter and when about to inline the comparison we decrement the counter (without writing it back) and if it trips simply abort the inlining, falling back to the normal send which will then continue to the conditional branch which will trip and enter the abort." | nextPC postBranchPC targetBytecodePC branchDescriptor counterReg fixup jumpEqual jumpNotEqual counterAddress countTripped unforwardArg unforwardRcvr argReg rcvrReg regMask rcvrConstant argConstant | <var: #fixup type: #'BytecodeFixup *'> <var: #countTripped type: #'AbstractInstruction *'> - <var: #label type: #'AbstractInstruction *'> <var: #branchDescriptor type: #'BytecodeDescriptor *'> <var: #jumpEqual type: #'AbstractInstruction *'> <var: #jumpNotEqual type: #'AbstractInstruction *'> ((coInterpreter isOptimizedMethod: methodObj) or: [needsFrame not]) ifTrue: [^super genForwardersInlinedIdenticalOrNotIf: orNot]. regMask := 0. self extractMaybeBranchDescriptorInto: [ :descr :next :postBranch :target | branchDescriptor := descr. nextPC := next. postBranchPC := postBranch. targetBytecodePC := target ]. unforwardRcvr := (self ssValue: 1) mayBeAForwarder. unforwardArg := self ssTop mayBeAForwarder. (unforwardRcvr not and: [unforwardArg not]) ifTrue: [unforwardRcvr := true. "TODO: use genVanilla with profiling counters (not implemented). ^self genVanillaInlinedIdenticalOrNotIf: orNot"]. self assert: (unforwardArg or: [unforwardRcvr]). "We use reg for non annotable constants to avoid duplicating objRef." rcvrConstant := objectRepresentation isUnannotatableConstant: (self ssValue: 1). argConstant := objectRepresentation isUnannotatableConstant: self ssTop. "If an operand is an annotable constant, it may be forwarded, so we need to store it into a register so the forwarder check can jump back to the comparison after unforwarding the constant. However, if one of the operand is an unnanotable constant, does not allocate a register for it (machine code will use operations on constants)." rcvrReg:= argReg := NoReg. self allocateEqualsEqualsRegistersArgNeedsReg: argConstant not rcvrNeedsReg: rcvrConstant not into: [ :rcvr :arg | rcvrReg:= rcvr. argReg := arg ]. argReg ~= NoReg ifTrue: [ regMask := self registerMaskFor: argReg ]. rcvrReg ~= NoReg ifTrue: [ regMask := regMask bitOr: (self registerMaskFor: rcvrReg) ]. "Only interested in inlining if followed by a conditional branch." (branchDescriptor isBranchTrue or: [branchDescriptor isBranchFalse]) ifFalse: [^ self genIdenticalNoBranchArgIsConstant: argConstant rcvrIsConstant: rcvrConstant argReg: argReg rcvrReg: rcvrReg orNotIf: orNot]. unforwardArg ifTrue: [ objectRepresentation genEnsureOopInRegNotForwarded: argReg scratchReg: TempReg ]. unforwardRcvr ifTrue: [ objectRepresentation genEnsureOopInRegNotForwarded: rcvrReg scratchReg: TempReg ]. counterReg := self allocateRegNotConflictingWith: regMask. self genExecutionCountLogicInto: [ :cAddress :countTripBranch | counterAddress := cAddress. countTripped := countTripBranch ] counterReg: counterReg. self assert: (unforwardArg or: [ unforwardRcvr ]). self genCmpArgIsConstant: argConstant rcvrIsConstant: rcvrConstant argReg: argReg rcvrReg: rcvrReg. self ssPop: 2. orNot == branchDescriptor isBranchTrue "orNot is true for ~~" ifFalse: [ fixup := (self ensureNonMergeFixupAt: postBranchPC) asUnsignedInteger. self JumpZero: (self ensureNonMergeFixupAt: targetBytecodePC) asUnsignedInteger ] ifTrue: [ fixup := (self ensureNonMergeFixupAt: targetBytecodePC) asUnsignedInteger. self JumpZero: (self ensureNonMergeFixupAt: postBranchPC) asUnsignedInteger ]. self genFallsThroughCountLogicCounterReg: counterReg counterAddress: counterAddress. self Jump: fixup. countTripped jmpTarget: self Label. "inlined version of #== ignoring the branchDescriptor if the counter trips to have normal state for the optimizer" self ssPop: -2. self genCmpArgIsConstant: unforwardArg not rcvrIsConstant: unforwardRcvr not argReg: argReg rcvrReg: rcvrReg. self ssPop: 2. "This code necessarily directly falls through the jumpIf: code which pops the top of the stack into TempReg. We therefore directly assign the result to TempReg to save one move instruction" jumpEqual := orNot ifFalse: [self JumpZero: 0] ifTrue: [self JumpNonZero: 0]. self genMoveFalseR: TempReg. jumpNotEqual := self Jump: 0. jumpEqual jmpTarget: (self genMoveTrueR: TempReg). jumpNotEqual jmpTarget: self Label. self ssPushRegister: TempReg. (self fixupAt: nextPC) notAFixup ifTrue: [ branchReachedOnlyForCounterTrip := true ]. ^ 0! Item was changed: ----- Method: TReturnNode>>emitValueExpansionOn:level:generator: (in category 'C code generation') ----- emitValueExpansionOn: aStream level: level generator: aCodeGen + | stmtList lastStmt copiedStatements | - | stmtList lastStmt copy | self assert: (expression isSend and: [expression isValueExpansion]). stmtList := expression receiver. lastStmt := stmtList statements last. lastStmt isReturn ifTrue: [^expression emitCCodeOn: aStream level: level generator: aCodeGen]. + copiedStatements := stmtList copy. + copiedStatements statements - copy := stmtList copy. - copy statements at: stmtList statements size put: (TReturnNode new setExpression: lastStmt). + expression copy + receiver: copiedStatements; + emitCCodeOn: aStream level: level generator: aCodeGen! - copy emitCCodeOn: aStream level: level generator: aCodeGen!

1 0

← Newer
1
...
6
7
8
9
10
11
12
13
14
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2020