Vm-dev March 2020

vm-dev@lists.squeakfoundation.org

31 participants
136 discussions

[CRASH] oops, DES core dumped again
by Robert 05 Mar '20

05 Mar '20

Hello, I am sad to see another core dump. I re-added the crypto plugins to my installation of 5.3 vm. I went and ran my rabbit.image and ran the Profile on the Cryptography tests. The vm went boom! I have attached a link to the crash.dmp file and it looks like it is a DES issue. https://www.dropbox.com/s/092alrhyvct7lmf/crash.dmp?dl=0 k, r

1 1

[CI REQUEST] add running of Cryptography load to CI
by Robert 05 Mar '20

05 Mar '20

Hello vmers, Now that the community has helped me to issue a new version of Cryptography-v5.3-rww.mcz, released to the Cryptography project, and also a repaired plugins package: CryptographyPlugins-nice.17. All tests are green, with and without the plugins. With the plugins, an increase of 226% in profile speed, of the crypto tests, has been seen. As it is a core component to the security facet of squeak, it is my feeling that it should be regularly tested. I hope you would be able to help us in this regard! The linux64 plugins are available here: https://www.dropbox.com/sh/yhv253rwrhq0q5p/AAB7PKP2KPiGpDnIyule2h_Ia?dl=0. Kindly, rabbit

1 1

Broken: OpenSmalltalk/opensmalltalk-vm#1971 (Cog - 051a0fe)
by Travis CI 05 Mar '20

05 Mar '20

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1971 Status: Broken Duration: 26 mins and 49 secs Commit: 051a0fe (Cog) Author: Eliot Miranda Message: CogVm source as per VMMaker.oscog-eem.2722 Interpreter: Fix compilation of primitiveHighBit on MSVC. We take the address of a variable by using (self addressOf: var), not "var address". Change the signature of the core selector send breakpointing routines from taking the receiver to taking a class tag. (Requires corresponding changes in platforms/Cross/vm/dispdbg.h). Add an accessor for breakLookupClassTag and add couldBeContext:. Comment fetchClassTagOf:. [This was all to track down a bug with ARMv8 do do with register save/restore across the call in ceScheduleScavengeTrampoline that caused contexts to appear where blocks were expected]. Fix printMethodFieldForPrintContext: to always print the method oop frst and the cogMethod, if any, afterwards. Fix asserts in frameCallerContext: and mapStackPages when a frame context may be forwarded as part of scavenging. Cogit: rename the accessor for codeToDataDelta to getCodeToDataDelta to allow codeToDataDelta to be defined as 0 in the non DUAL_MAPPED_CODE_ZONE regime. Consequently find and fix a slip in NewspeakCogMethod class>>initialize. Don't attempt to take the address of 0 in the DUAL_MAPPED_CODE_ZONE regime. Fix genLoadCStackPointer(s) to use NativeSPReg Fix followForwardedLiteralsIn:, mapObjectReferencesInMachineCodeForXXX, and storeLiteral:atAnnotatedAddress:using: for the DUAL_MAPPED_CODE_ZONE regime. Don't bother to rewrite the selector in a linked super send; this causes overwriting of the selector index in 64-bit implementations, and hence may cause an assert failure. So it's a waste of effort and provokes an error. Plugins: Fix the BitBlt bug for convex shape fill. The problem is that we are taking source one word too early (thus from previous row). This happens when taking hdir=-1 and it is related to preload (again!!). Last thing: on 64bits, mask1 and mask2 have been declared int64... But we only want 32 bit masks. That is why I have protected with the bitAnd: AllOnes View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/b0ed4fa33c6b...05… View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/658474554?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

[OpenSmalltalk/opensmalltalk-vm] 051a0f: CogVm source as per VMMaker.oscog-eem.2722
by Eliot Miranda 05 Mar '20

05 Mar '20

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 051a0fe56561b586c8e36f8c2950efd391059605 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/051a0fe56561b586c8… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M nsspur64src/vm/cogit.h M nsspur64src/vm/cogitX64SysV.c M nsspur64src/vm/cogitX64WIN64.c M nsspur64src/vm/cointerp.c M nsspur64src/vm/cointerp.h M nsspur64src/vm/gcc3x-cointerp.c M nsspursrc/vm/cogit.h M nsspursrc/vm/cogitARMv5.c M nsspursrc/vm/cogitIA32.c M nsspursrc/vm/cogitMIPSEL.c M nsspursrc/vm/cointerp.c M nsspursrc/vm/cointerp.h M nsspursrc/vm/gcc3x-cointerp.c M nsspurstack64src/vm/gcc3x-interp.c M nsspurstack64src/vm/interp.c M nsspurstacksrc/vm/gcc3x-interp.c M nsspurstacksrc/vm/interp.c M platforms/Cross/vm/dispdbg.h M platforms/Mac OS/vm/sqMacMemory.c M platforms/unix/vm/sqUnixMemory.c M platforms/unix/vm/sqUnixSpurMemory.c M platforms/win32/vm/sqWin32Alloc.c M platforms/win32/vm/sqWin32SpurAlloc.c M spur64src/vm/cogit.h M spur64src/vm/cogitX64SysV.c M spur64src/vm/cogitX64WIN64.c M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cogitX64SysV.c M spurlowcode64src/vm/cogitX64WIN64.c M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cogitARMv5.c M spurlowcodesrc/vm/cogitIA32.c M spurlowcodesrc/vm/cogitMIPSEL.c M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cogitX64SysV.c M spursista64src/vm/cogitX64WIN64.c M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cogitARMv5.c M spursistasrc/vm/cogitIA32.c M spursistasrc/vm/cogitMIPSEL.c M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cogitARMv5.c M spursrc/vm/cogitIA32.c M spursrc/vm/cogitMIPSEL.c M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstack64src/vm/validImage.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M spurstacksrc/vm/validImage.c M src/vm/cogit.h M src/vm/cogitARMv5.c M src/vm/cogitIA32.c M src/vm/cogitMIPSEL.c M src/vm/cointerp.c M src/vm/cointerp.h M src/vm/cointerpmt.c M src/vm/cointerpmt.h M src/vm/gcc3x-cointerp.c M src/vm/gcc3x-cointerpmt.c M stacksrc/vm/gcc3x-interp.c M stacksrc/vm/interp.c Log Message: ----------- CogVm source as per VMMaker.oscog-eem.2722 Interpreter: Fix compilation of primitiveHighBit on MSVC. We take the address of a variable by using (self addressOf: var), not "var address". Change the signature of the core selector send breakpointing routines from taking the receiver to taking a class tag. (Requires corresponding changes in platforms/Cross/vm/dispdbg.h). Add an accessor for breakLookupClassTag and add couldBeContext:. Comment fetchClassTagOf:. [This was all to track down a bug with ARMv8 do do with register save/restore across the call in ceScheduleScavengeTrampoline that caused contexts to appear where blocks were expected]. Fix printMethodFieldForPrintContext: to always print the method oop frst and the cogMethod, if any, afterwards. Fix asserts in frameCallerContext: and mapStackPages when a frame context may be forwarded as part of scavenging. Cogit: rename the accessor for codeToDataDelta to getCodeToDataDelta to allow codeToDataDelta to be defined as 0 in the non DUAL_MAPPED_CODE_ZONE regime. Consequently find and fix a slip in NewspeakCogMethod class>>initialize. Don't attempt to take the address of 0 in the DUAL_MAPPED_CODE_ZONE regime. Fix genLoadCStackPointer(s) to use NativeSPReg Fix followForwardedLiteralsIn:, mapObjectReferencesInMachineCodeForXXX, and storeLiteral:atAnnotatedAddress:using: for the DUAL_MAPPED_CODE_ZONE regime. Don't bother to rewrite the selector in a linked super send; this causes overwriting of the selector index in 64-bit implementations, and hence may cause an assert failure. So it's a waste of effort and provokes an error. Plugins: Fix the BitBlt bug for convex shape fill. The problem is that we are taking source one word too early (thus from previous row). This happens when taking hdir=-1 and it is related to preload (again!!). Last thing: on 64bits, mask1 and mask2 have been declared int64... But we only want 32 bit masks. That is why I have protected with the bitAnd: AllOnes

1 0

VM Maker: VMMaker.oscog-eem.2722.mcz
by commits＠source.squeak.org 05 Mar '20

05 Mar '20

Eliot Miranda uploaded a new version of VMMaker to project VM Maker: http://source.squeak.org/VMMaker/VMMaker.oscog-eem.2722.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2722 Author: eem Time: 4 March 2020, 3:53:28.328412 pm UUID: 53079d01-9f06-4934-8aa2-6a6ecc80dc4e Ancestors: VMMaker.oscog-eem.2721 Interpreter: Fix compilation of primitiveHighBit on MSVC. We take the address of a variable by using (self addressOf: var), not "var address". =============== Diff against VMMaker.oscog-eem.2721 =============== Item was changed: ----- Method: InterpreterPrimitives>>primitiveHighBit (in category 'arithmetic integer primitives') ----- primitiveHighBit | integerReceiverOop leadingZeroCount highestBitZeroBased | integerReceiverOop := self stackTop. "Convert the receiver Oop to use a single tag bit" + objectMemory numSmallIntegerTagBits > 1 ifTrue: + [integerReceiverOop := (integerReceiverOop >>> (self numSmallIntegerTagBits-1) bitOr: 1)]. - objectMemory numSmallIntegerTagBits > 1 - ifTrue: [integerReceiverOop := (integerReceiverOop >>> (self numSmallIntegerTagBits-1) bitOr: 1)]. self cppIf: #'__GNUC__' defined ifTrue: ["Note: in gcc, result is undefined if input is zero (for compatibility with BSR fallback when no CLZ instruction available). but input is never zero because we pass the oop with tag bits set, so we are safe" objectMemory wordSize = 4 ifTrue: [leadingZeroCount := self __builtin_clz: integerReceiverOop] ifFalse: [leadingZeroCount := self __builtin_clzll: integerReceiverOop]. leadingZeroCount = 0 ifTrue: ["highBit is not defined for negative Integer" self primitiveFail] ifFalse: ["Nice bit trick: 1-based high-bit is (32 - clz) - 1 to account for tag bit. This is like two-complement - clz - 1 on 5 bits, or in other words a bit-invert operation clz ^16r1F" self pop: 1 thenPushInteger: (leadingZeroCount bitXor: (BytesPerWord * 8 - 1))]. ^self]. self cppIf: #'__GNUC__' defined not & (#'_MSC_VER' defined | #'__ICC' defined) ifTrue: ["In MSVC, _lzcnt and _lzcnt64 builtins do not fallback to BSR when not supported by CPU Instead of messing with __cpuid() we always use the BSR intrinsic" "Trick: we test the oop sign rather than the integerValue. Assume oop are signed (so far, they are, sqInt are signed)" integerReceiverOop < 0 ifTrue: [self primitiveFail] ifFalse: [ + "Setting this variable is useless, but VMMaker will generate an automatic initialization at a worse place if this isn't initialized explicitly." - "Setting this variable is useless, but VMMaker will generate it at a worse place" highestBitZeroBased := 0. "We do not even test the return value, because integerReceiverOop is never zero" self cCode: [objectMemory wordSize = 4 + ifTrue: [self _BitScanReverse: (self addressOf: highestBitZeroBased) _: integerReceiverOop] + ifFalse: [self _BitScanReverse64: (self addressOf: highestBitZeroBased) _: integerReceiverOop]] - ifTrue: [self _BitScanReverse: highestBitZeroBased address _: integerReceiverOop] - ifFalse: [self _BitScanReverse64: highestBitZeroBased address _: integerReceiverOop]] inSmalltalk: [highestBitZeroBased := integerReceiverOop highBit - 1]. "thanks to the tag bit, the +1 operation for getting 1-based rank is not necessary" self pop: 1 thenPushInteger: highestBitZeroBased]. ^self]. self cppIf: #'__GNUC__' defined not & #'_MSC_VER' defined not & #'__ICC' defined not ifTrue: ["not gcc/clang, nor MSVC/ICC, you have to implement if your compiler provide useful builtins" self cCode: [self primitiveFail] inSmalltalk: "Simulate so that the simulatror is closer to the actual VM" [integerReceiverOop < 0 ifTrue: [self primitiveFail] ifFalse: [self pop: 1 thenPushInteger: integerReceiverOop highBit - 1]]]!

1 0

[5.3] merge squeak scripts request
by Robert 04 Mar '20

04 Mar '20

I have 2 scripts to launch squeak. One came from the 5.3 release, named 'squeak'. The other is from somewhere, named 'squeak.sh' which supports a file dialog to request the image to run. I have attached the 2 scripts. I was hoping someone could merge the file selection, from 'squeak.sh', into the 5.3 script, 'squeak'. tyk, r

2 2

[5.3] linux64x64 Crypto plugins
by Robert 04 Mar '20

04 Mar '20

Hello everyone, I was able to generate these 3 plugins, for Crypto, on my linux64x64 system. I verified that these plugins are loaded in the released 5.3 vm, when I run the Crypto tests (minus CryptoRC2Test>>#testARC2, which seg-faults the vm). After running, doing 'Smalltalk listLoadedModules' results in: #('MD5Plugin CryptographyPlugins-eem.14 (e)' 'DESPlugin CryptographyPlugins-eem.14 (e)' 'SHA256Plugin CryptographyPlugins-eem.14 (e)' 'DSAPrims CryptographyPlugins-eem.14 (i)' 'UUIDPlugin VMMaker.oscog-eem.2721 (e)' 'ZipPlugin VMMaker.oscog-eem.2721 (i)' 'B2DPlugin VMMaker.oscog-eem.2721 (i)' 'BitBltPlugin VMMaker.oscog-eem.2721 (i)' 'SocketPlugin VMMaker.oscog-eem.2721 (i)' 'CroquetPlugin VMMaker.oscog-eem.2721 (i)' 'FilePlugin VMMaker.oscog-eem.2721 (i)' 'LargeIntegers v2.0 VMMaker.oscog-eem.2721 (i)' 'MiscPrimitivePlugin VMMaker.oscog-eem.2721 (i)' 'SecurityPlugin VMMaker.oscog-eem.2721 (i)') So the Crypto plugins are loaded. As I only have plugins for linux64x64, I welcome any plugin contributions for other platforms, to be collected within the following Dropbox folder. https://www.dropbox.com/sh/yhv253rwrhq0q5p/AAB7PKP2KPiGpDnIyule2h_Ia?dl=0 tyk, r

1 1

[interrogative] CryptographyPlugins-eem.14
by Robert 04 Mar '20

04 Mar '20

I launched my new vmmaker image *yes* and I see that the CryptographyPlugins-eem.14 is loaded. *AWESOME* I forget how to look at what Plugins are generated externally. Squeak Slack is fairly quiet, may I ask a few questions? Is there an easy way to explore this for the presence of the Cryptography plugins? Which directory would be holding them on the filesystem? In which directory do we generate binding files? Which side of which is what? TYK, r

4 17

Selecting distributed plugins
by Nicolas Cellier 03 Mar '20

03 Mar '20

Hi all, Robert kindly asked me whether it would be possible to include DES and MD5 plugins in OpenSmalltalk VM distribution. We currently generate src/plugins code for those 2, but don't compile them. This raises the question: who decides which plugin gets included/compiled/distributed or not? On which criterion?

3 3

Errored: OpenSmalltalk/opensmalltalk-vm#1970 (202003021730 - 6a0bc96)
by Travis CI 03 Mar '20

03 Mar '20

Build Update for OpenSmalltalk/opensmalltalk-vm ------------------------------------- Build: #1970 Status: Errored Duration: 25 mins and 33 secs Commit: 6a0bc96 (202003021730) Author: Fabio Niephaus Message: Restore pumpRunLoopEventSendAndSignal: for Squeak @guillep introduced some additional logic to filter out events that do not correspond to the VM window. The about panel and the fullscreen frame are also alien windows, but were not receiving any events because of this change. As a consequence, these events will forever remain in the queue and therefore, the buttons of the fullscreen frame and about panel cannot be clicked. This commit reverts all changes back to the previous version that consumes all events and forwards them to NSApp. In order to avoid breaking PharoVM, we do all of this behind an `#ifdef PharoVM`. Relevant changes: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/295 https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/300 View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/202003021730 View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/657644632?utm_m… -- You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev March 2020