Vm-dev June 2021

vm-dev@lists.squeakfoundation.org

14 participants
74 discussions

[OpenSmalltalk/opensmalltalk-vm] Bintray has reached end-of-life, where can we download the bleeding-edge releases now? (#564)
by Christoph Thiede 13 Aug '21

13 Aug '21

Is it possible to migrate to GitHub prereleases? Also, the badge in the README should be updated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/564

2 2

Re: [Vm-dev] Aarch64 number bug
by ken.dickey＠whidbey.com 04 Aug '21

04 Aug '21

> "If the community valued its primary execution technology then it would > be the case that a few members were competent enough to startup the > simulation environment and debug this. " Unfortunately, my attempt to build a VM simulator on aarch64 fails due to a divide by zero bug. Perhaps because 16r8000000000000000 printStringHex. ==> '0' You may be over-estimating my ability to debug this sort of thing. ------------------- In the wider context, my suggestion is to declare, say the first week in July, as "VM Appreciation Week". The observation being that OpenSmalltalk is common to Cuis, Squeak, and Pharo. OpenSmalltalk is open source. OpenSmalltalk is a _Commons_. A "commons" in our case is a shared resource which is managed by its users. To be better managers (or managers at all, rather than just freeloaders), we should take some time to experience it. [a] Build and run a/the simulator, [b] Build a VM. Participation means knowing the resource in order to be able to sustain it. ------------------- OK, so raising awareness to become visible in the right way. There are a few speed bumps to be overcome first. One desires that Joe or Jane coder be able to do [a] and [b] above. Building VMMaker on Linux/x86-64 I get a large number of merge dialogs and then: vvv===vvv This virtual machine is too old to support correct versions of the FloatArray>>at:[put:] primitives 238 and 239. FloatArray subclasses will not behave correctly and FloatArray[64]Test tests will fail. Please upgrade your VM. You may continue and upgrade later or abort and upgrade now. ^^^===^^^ But if I try to build a VM, I run into a number of problems (notes attached; the "included too late" bug shows up in the arm build as well). It is difficult to see today how Joe or Jane can build a VM if like me their knowledge of build mechanics is fairly shallow. Like you all, I have a very busy life. Among other things, given a destabalized climate I am now tending my garden to raise food. On the other hand, I am happy to spend time supporting the OpenSmalltalk Commons as, yes, this _is_ important to me. I don't feel that I have the skillset to fix the current speed bumps, but I certainly would like to declare a "VM Appreciation Week" sometime soon and welcome a discussion on how we engender a better stewardship of our commons.. -KenD

6 12

[OpenSmalltalk/opensmalltalk-vm] Fix include order (#562)
by Nicolas Cellier 02 Aug '21

02 Aug '21

This enables the linux builds again, while preserving windows and macos builds. That is a fix for https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/560 If this is compatible with TERF VM, then it should be merged ASAP, the builds are red for too long. (we'll have to inquire next point of failure...) You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/562 -- Commit Summary -- * always include <stdio.h> **BEFORE** defining fseeko/ftello * Discard the EXPORT from sqAssert.h for declaring VM functions * Make sure that config.h is included first * Generate source with VMMaker.oscog-nice.2957 so as to restore sqConfig.h inclusion at top * try and omit HAVE_CONFIG_H for compiling getVersion -- File Changes -- M platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c (3) M platforms/Cross/plugins/IA32ABI/xabicc.c (5) M platforms/Cross/plugins/SoundCodecPrims/sqSoundCodecPluginBasicPrims.c (4) M platforms/Cross/plugins/Squeak3D/b3dInit.c (3) M platforms/Cross/plugins/Squeak3D/b3dMain.c (3) M platforms/Cross/plugins/SurfacePlugin/SurfacePlugin.c (4) M platforms/Cross/vm/sqAssert.h (11) M platforms/Cross/vm/sqHeapMap.c (4) M platforms/Cross/vm/sqSCCSVersion.h (2) M platforms/Cross/vm/sqVirtualMachine.c (3) M platforms/unix/config/getversion.c (1) M platforms/unix/plugins/FileAttributesPlugin/faSupport.c (3) M platforms/unix/vm/aio.c (12) M platforms/unix/vm/sqUnixVMProfile.c (5) M platforms/win32/vm/sqPlatformSpecific.h (1) M spur64src/vm/cogit.h (2) M spur64src/vm/cogitARMv8.c (8) M spur64src/vm/cogitX64SysV.c (8) M spur64src/vm/cogitX64WIN64.c (8) M spur64src/vm/cointerp.c (49) M spur64src/vm/cointerp.h (4) M spur64src/vm/cointerpmt.c (31) M spur64src/vm/cointerpmt.h (3) M spur64src/vm/gcc3x-cointerp.c (49) M spur64src/vm/gcc3x-cointerpmt.c (31) M spurlowcode64src/vm/cogit.h (3) M spurlowcode64src/vm/cogitARMv8.c (16) M spurlowcode64src/vm/cogitX64SysV.c (12) M spurlowcode64src/vm/cogitX64WIN64.c (12) M spurlowcode64src/vm/cointerp.c (53) M spurlowcode64src/vm/cointerp.h (5) M spurlowcode64src/vm/gcc3x-cointerp.c (53) M spurlowcodesrc/vm/cogit.h (3) M spurlowcodesrc/vm/cogitARMv5.c (12) M spurlowcodesrc/vm/cogitIA32.c (12) M spurlowcodesrc/vm/cogitMIPSEL.c (16) M spurlowcodesrc/vm/cointerp.c (57) M spurlowcodesrc/vm/cointerp.h (5) M spurlowcodesrc/vm/gcc3x-cointerp.c (57) M spurlowcodestack64src/vm/gcc3x-interp.c (25) M spurlowcodestack64src/vm/interp.c (25) M spurlowcodestacksrc/vm/gcc3x-interp.c (25) M spurlowcodestacksrc/vm/interp.c (25) M spursista64src/vm/cogit.h (2) M spursista64src/vm/cogitARMv8.c (12) M spursista64src/vm/cogitX64SysV.c (8) M spursista64src/vm/cogitX64WIN64.c (8) M spursista64src/vm/cointerp.c (49) M spursista64src/vm/cointerp.h (4) M spursista64src/vm/gcc3x-cointerp.c (49) M spursistasrc/vm/cogit.h (2) M spursistasrc/vm/cogitARMv5.c (8) M spursistasrc/vm/cogitIA32.c (8) M spursistasrc/vm/cogitMIPSEL.c (14) M spursistasrc/vm/cointerp.c (49) M spursistasrc/vm/cointerp.h (2) M spursistasrc/vm/gcc3x-cointerp.c (49) M spursrc/vm/cogit.h (2) M spursrc/vm/cogitARMv5.c (8) M spursrc/vm/cogitIA32.c (8) M spursrc/vm/cogitMIPSEL.c (10) M spursrc/vm/cointerp.c (57) M spursrc/vm/cointerp.h (4) M spursrc/vm/cointerpmt.c (81) M spursrc/vm/cointerpmt.h (5) M spursrc/vm/gcc3x-cointerp.c (57) M spursrc/vm/gcc3x-cointerpmt.c (81) M spurstack64src/vm/gcc3x-interp.c (25) M spurstack64src/vm/interp.c (25) M spurstack64src/vm/validImage.c (17) M spurstacksrc/vm/gcc3x-interp.c (25) M spurstacksrc/vm/interp.c (25) M spurstacksrc/vm/validImage.c (17) M src/plugins/Squeak3D/Squeak3D.c (8) M src/vm/cogit.h (2) M src/vm/cogitARMv5.c (8) M src/vm/cogitIA32.c (8) M src/vm/cogitMIPSEL.c (12) M src/vm/cointerp.c (10) M src/vm/cointerp.h (2) M src/vm/gcc3x-cointerp.c (10) M stacksrc/vm/gcc3x-interp.c (12) M stacksrc/vm/interp.c (12) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/562.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/562.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/562

9 19

[OpenSmalltalk/opensmalltalk-vm] For epoll aio, close and reopen the epoll fd in forked child process (#552)
by David T Lewis 24 Jul '21

24 Jul '21

Factor the epoll initiation out of aioInit into new epollInit function and invoke it via pthread_atfork in the child process after a fork. Prevents misdelivery of events from the common kernel epoll structures. You can view, comment on, or merge this pull request online at: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/552 -- Commit Summary -- * For epoll aio, close and reopen the epoll fd in forked child process -- File Changes -- M platforms/unix/vm/aio.c (23) -- Patch Links -- https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/552.patch https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/552.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/552

2 3

[OpenSmalltalk/opensmalltalk-vm] build.win64x64 fails: No rule to make target 'build/vm/ADPCMCodecPlugin.lib' (#568)
by Jakob Reschke 13 Jul '21

13 Jul '21

I want to learn about plugin development and intended to start with a VM build first. Using Cygwin 64 bits with mingw64-x86_64-clang, I build from the build.win64x64/squeak.cog.spur directory. The build fails at this point; notably it is not a compiler error, but a make error: ``` ... rm -f build/vm/ADPCMCodecPlugin.ignore make BUILD=build \ -f /cygdrive/c/Squeak/Wincred-Plugin/opensmalltalk-vm/build.win64x64/common/Makefile.plugin \ build/vm/ADPCMCodecPlugin.lib make[1]: Entering directory '/cygdrive/c/Squeak/Wincred-Plugin/opensmalltalk-vm/build.win64x64/squeak.cog.spur' make[1]: *** No rule to make target 'build/vm/ADPCMCodecPlugin.lib'. Stop. make[1]: Leaving directory '/cygdrive/c/Squeak/Wincred-Plugin/opensmalltalk-vm/build.win64x64/squeak.cog.spur' make: *** [../common/Makefile:280: build/vm/ADPCMCodecPlugin.lib] Error 2 ``` I think I followed all the instructions of the main README.md and build.win64x64/HowToBuild. What can I do to deal with this issue and get the build going? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/568

3 6

[OpenSmalltalk/opensmalltalk-vm] How to build on Win32 using WSL/Ubuntu | Missing headers (#510)
by Christoph Thiede 09 Jul '21

09 Jul '21

`build.win32x86/HowToBuild` describes how we can build the VM using cygwin. However, I have installed WSL instead. When running `mvm`, it gives me: ``` ../../platforms/win32/vm/sqWin32Utils.c:11:10: fatal error: Windows.h: No such file or directory ``` What do I have to do to enable mingw to find these header files? Any help is appreciated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/510

7 20

VM Maker Inbox: VMMaker.oscog-eem.2765.mcz
by commits＠source.squeak.org 09 Jul '21

09 Jul '21

Eliot Miranda uploaded a new version of VMMaker to project VM Maker Inbox: http://source.squeak.org/VMMakerInbox/VMMaker.oscog-eem.2765.mcz ==================== Summary ==================== Name: VMMaker.oscog-eem.2765 Author: eem Time: 23 June 2020, 6:41:19.556484 pm UUID: 91b9976e-60b9-4b5c-a2f8-b621dd454a07 Ancestors: VMMaker.oscog-eem.2764 Spur: Rewrite the revised followForwardedObjectFields:toDepth: soi it can be correctly inlined. Slang: Change the order of application of ensureConditionalAssignmentsAreTransformedIn: so it is always the last thing done in tryToInlineMethodsIn:. Straight-forward optimization of bindVariablesIn: in the common case of methods being inlined swith unchanged parameters. =============== Diff against VMMaker.oscog-eem.2764 =============== Item was changed: ----- Method: Spur32BitCoMemoryManager>>followForwardedObjectFields:toDepth: (in category 'as yet unclassified') ----- followForwardedObjectFields: objOop toDepth: depth "Follow pointers in the object to depth. Answer if any forwarders were found. How to avoid cyclic structures?? A temporary mark bit? eem 6/22/2020 no need since depth is always finite." <api> <inline: false> + | found fmt limit | - | oop found fmt | found := false. self assert: ((self isPointers: objOop) or: [self isOopCompiledMethod: objOop]). fmt := self formatOf: objOop. + limit := (self numPointerSlotsOf: objOop format: fmt) - 1. "It is essential to skip the first field of a method because it may be a reference to a Cog method in the method zone, not a real object at all." ((self isCompiledMethodFormat: fmt) ifTrue: [1] ifFalse: [0]) + to: limit + do: [:i| | oop | - to: (self numPointerSlotsOf: objOop format: fmt) - 1 - do: [:i| oop := self fetchPointer: i ofObject: objOop. (self isNonImmediate: oop) ifTrue: [(self isForwarded: oop) ifTrue: [found := true. oop := self followForwarded: oop. self storePointer: i ofObject: objOop withValue: oop]. (depth > 0 and: [(self hasPointerFields: oop) and: [self followForwardedObjectFields: oop toDepth: depth - 1]]) ifTrue: [found := true]]]. ^found! Item was changed: ----- Method: Spur64BitCoMemoryManager>>followForwardedObjectFields:toDepth: (in category 'forwarding') ----- followForwardedObjectFields: objOop toDepth: depth "Follow pointers in the object to depth. Answer if any forwarders were found. How to avoid cyclic structures?? A temporary mark bit? eem 6/22/2020 no need since depth is always finite." <api> <inline: false> + | found fmt limit | - | oop found fmt | found := false. self assert: ((self isPointers: objOop) or: [self isOopCompiledMethod: objOop]). fmt := self formatOf: objOop. + limit := (self numPointerSlotsOf: objOop format: fmt) - 1. "It is essential to skip the first field of a method because it may be a reference to a Cog method in the method zone, not a real object at all." ((self isCompiledMethodFormat: fmt) ifTrue: [1] ifFalse: [0]) + to: limit + do: [:i| | oop | - to: (self numPointerSlotsOf: objOop format: fmt) - 1 - do: [:i| oop := self fetchPointer: i ofObject: objOop. (self isNonImmediate: oop) ifTrue: [(self isForwarded: oop) ifTrue: [found := true. oop := self followForwarded: oop. self storePointer: i ofObject: objOop withValue: oop]. (depth > 0 and: [(self hasPointerFields: oop) and: [self followForwardedObjectFields: oop toDepth: depth - 1]]) ifTrue: [found := true]]]. ^found! Item was changed: ----- Method: TMethod>>exitVar:label:in: (in category 'inlining') ----- exitVar: exitVar label: exitLabel in: aCodeGen "Replace each return statement in this method with an assignment to the exit variable followed by either a return or a goto to the given label. Answer if a goto was generated." "Optimization: If exitVar is nil, the return value of the inlined method is not being used, so don't add the assignment statement." | labelUsed map elisions eliminateReturnSelfs | labelUsed := false. map := Dictionary new. elisions := Set new. "Conceivably one might ^self from a struct class and mean it. In most cases though ^self means `get me outta here, fast'. So unless this method is from a VMStruct class, elide any ^self's" eliminateReturnSelfs := ((definingClass inheritsFrom: VMClass) and: [definingClass isStructClass]) not and: [returnType = #void or: [returnType = #sqInt]]. parseTree nodesDo: [:node | | replacement | node isReturn ifTrue: [self transformReturnSubExpression: node toAssignmentOf: exitVar andGoto: exitLabel unless: eliminateReturnSelfs into: [:rep :labelWasUsed| replacement := rep. labelWasUsed ifTrue: [labelUsed := true]] in: aCodeGen. "replaceNodesIn: is strictly top-down, so any replacement for ^expr ifTrue: [...^fu...] ifFalse: [...^bar...] will prevent replacement of either ^fu or ^bar. The corollary is that ^expr ifTrue: [foo] ifFalse: [^bar] must be transformed into expr ifTrue: [^foo] ifFalse: [^bar]" (node expression isConditionalSend and: [node expression hasExplicitReturn]) ifTrue: [elisions add: node. (node expression args reject: [:arg| arg endsWithReturn]) do: [:nodeNeedingReturn| self transformReturnSubExpression: nodeNeedingReturn statements last toAssignmentOf: exitVar andGoto: exitLabel unless: eliminateReturnSelfs into: [:rep :labelWasUsed| replacement := rep. + labelWasUsed ifTrue: [labelUsed := true]] + in: aCodeGen. - labelWasUsed ifTrue: [labelUsed := true]]. map at: nodeNeedingReturn statements last put: replacement]] ifFalse: [map at: node put: (replacement ifNil: [TLabeledCommentNode new setComment: 'return ', node expression printString])]]]. map isEmpty ifTrue: [self deny: labelUsed. ^false]. "Now do a top-down replacement for all returns that should be mapped to assignments and gotos" parseTree replaceNodesIn: map. "Now it is safe to eliminate the returning ifs..." elisions isEmpty ifFalse: [| elisionMap | elisionMap := Dictionary new. elisions do: [:returnNode| elisionMap at: returnNode put: returnNode expression]. parseTree replaceNodesIn: elisionMap]. "Now flatten any new statement lists..." parseTree nodesDo: [:node| | list | (node isStmtList and: [node statements notEmpty and: [node statements last isStmtList]]) ifTrue: [list := node statements last statements. node statements removeLast; addAllLast: list]]. ^labelUsed! Item was changed: ----- Method: TMethod>>inlineFunctionCall:in: (in category 'inlining') ----- inlineFunctionCall: aSendNode in: aCodeGen "Answer the body of the called function, substituting the actual parameters for the formal argument variables in the method body. Assume caller has established that: 1. the method arguments are all substitutable nodes, and 2. the method to be inlined contains no additional embedded returns." | sel meth doNotRename argsForInlining substitutionDict | + aCodeGen maybeBreakForInlineOf: aSendNode in: self. sel := aSendNode selector. meth := (aCodeGen methodNamed: sel) copy. meth ifNil: [^self inlineBuiltin: aSendNode in: aCodeGen]. doNotRename := Set withAll: args. argsForInlining := aSendNode argumentsForInliningCodeGenerator: aCodeGen. meth args with: argsForInlining do: [ :argName :exprNode | exprNode isLeaf ifTrue: [doNotRename add: argName]]. (meth statements size = 2 and: [meth statements first isSend and: [meth statements first selector == #flag:]]) ifTrue: [meth statements removeFirst]. meth renameVarsForInliningInto: self except: doNotRename in: aCodeGen. meth renameLabelsForInliningInto: self. self addVarsDeclarationsAndLabelsOf: meth except: doNotRename. substitutionDict := Dictionary new: meth args size * 2. meth args with: argsForInlining do: [ :argName :exprNode | + (exprNode isVariable and: [exprNode name = argName]) ifFalse: + [substitutionDict at: argName put: exprNode]. - substitutionDict at: argName put: exprNode. (doNotRename includes: argName) ifFalse: [locals remove: argName]]. meth parseTree bindVariablesIn: substitutionDict. ^meth parseTree endsWithReturn ifTrue: [meth parseTree copyWithoutReturn] ifFalse: [meth parseTree]! Item was changed: ----- Method: TMethod>>tryToInlineMethodsIn: (in category 'inlining') ----- tryToInlineMethodsIn: aCodeGen "Expand any (complete) inline methods sent by this method. Set the complete flag when all inlining has been done. Answer if something was inlined." | didSomething statementLists | "complete ifTrue: [^false]." self definedAsMacro ifTrue: [complete ifTrue: [^false]. ^complete := true]. - self ensureConditionalAssignmentsAreTransformedIn: aCodeGen. didSomething := self tryToInlineMethodStatementsIn: aCodeGen statementListsInto: [:stmtLists| statementLists := stmtLists]. didSomething := (self tryToInlineMethodExpressionsIn: aCodeGen) or: [didSomething]. + self ensureConditionalAssignmentsAreTransformedIn: aCodeGen. didSomething ifTrue: [writtenToGlobalVarsCache := nil]. complete ifFalse: [self checkForCompletenessIn: aCodeGen. complete ifTrue: [didSomething := true]]. "marking a method complete is progress" ^didSomething! Item was changed: ----- Method: TStmtListNode>>bindVariablesIn: (in category 'transformations') ----- bindVariablesIn: aDictionary + aDictionary notEmpty ifTrue: + [statements := statements collect: [:s| s bindVariablesIn: aDictionary]]! - statements := statements collect: [ :s | s bindVariablesIn: aDictionary ].!

2 1

[OpenSmalltalk/opensmalltalk-vm] Aarch64 integer compare bug (#<) (#571)
by Ken Dickey 05 Jul '21

05 Jul '21

16r80000000 < 16r8000000000000000. "==> false " [Intel reports true] -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/571

7 14

Aarch64 number bug
by ken.dickey＠whidbey.com 02 Jul '21

02 Jul '21

16r80000000 < 16r8000000000000000. "==> false" FYI, -KenD

3 3

VM Maker: VMMakerUI-mt.38.mcz
by commits＠source.squeak.org 30 Jun '21

30 Jun '21

Marcel Taeumel uploaded a new version of VMMakerUI to project VM Maker: http://source.squeak.org/VMMaker/VMMakerUI-mt.38.mcz ==================== Summary ==================== Name: VMMakerUI-mt.38 Author: mt Time: 30 June 2021, 3:01:50.858141 pm UUID: a1b136c4-ecdf-284c-91da-d1427695bc02 Ancestors: VMMakerUI-eem.37 Adds updater and update entry to Squeak menu in world-main docking bar. Needs Morphic-mt.1775 to show up. Uses update map "update.oscog" for the update. =============== Diff against VMMakerUI-eem.37 =============== Item was added: + ----- Method: TheWorldMainDockingBar>>updateVMMaker (in category '*VMMakerUI-updater') ----- + updateVMMaker + <updater: 'Update VMMaker'> + + | updater | + updater := MCMcmUpdater + updateMapNamed: 'update.oscog' + repository: 'http://source.squeak.org/VMMaker'. + updater lastUpdateMap ifEmpty: [ + "If this is the first time that you use the updater, start at 5.mcm to avoid loading old code." + updater lastUpdateMap at: updater repository put: 5]. + updater doUpdate: true.! Item was added: + (PackageInfo named: 'VMMakerUI') postscript: 'TheWorldMainDockingBar updateInstances. "Adds updater for VMMaker to Squeak menu"'!

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev June 2021