Vm-dev June 2021

vm-dev@lists.squeakfoundation.org

14 participants
74 discussions

Re: [Vm-dev] Aarch64 number bug
by ken.dickey＠whidbey.com 29 Jun '21

29 Jun '21

Small progress. The stack interpreter and cog VMs share the LargeIntegers plugin, but stack: (16r8000000000000000 * 16) printStringHex."--> '80000000000000000' " cog: (16r8000000000000000 * 16) printStringHex." --> '0' " I was able to build a SpurVMMaker.image using the stack-interpreter VM and would like to invoke: StackToRegisterMappingCogit genAndDis: Integer class>>#xReadFrom:base: But have had zero success in building the required GdbARMv8Plugin [Linux/aarch64]. Can some kind soul who actually knows how to deal with the fragile and complex C environment help me out? Thanks much, -KenD

2 1

serious bugs with keyboard events in recent updates
by Eliot Miranda 28 Jun '21

28 Jun '21

Hi All, is anyone seeing Character>>doesNotUnderratand: #bitShift: errors as a result of recent updates? It appears that an event's fifth element is now a Character, not mouse buttons plus metakey state codes. There seems to be some confusion somewhere in creating events. I'm trying to understand if this is an image level bug or a VM bug. Here are the definitions in sq.h which show that modifiers are not always in the same place in every event: #define EventTypeMouse 1 /* mouse input event */ typedef struct sqMouseEvent { sqIntptr_t type; /* EventTypeMouse */ usqIntptr_t timeStamp; /* time stamp */ sqIntptr_t x; /* mouse position x */ sqIntptr_t y; /* mouse position y */ sqIntptr_t buttons; /* combination of xxxButtonBit */ 5 sqIntptr_t modifiers; /* combination of xxxKeyBit */ sqIntptr_t nrClicks; /* number of clicks in button downs - was reserved1 */ sqIntptr_t windowIndex; /* host window structure */ } sqMouseEvent; #define EventTypeKeyboard 2 /* keyboard input event */ typedef struct sqKeyboardEvent { sqIntptr_t type; /* EventTypeKeyboard */ usqIntptr_t timeStamp; /* time stamp */ sqIntptr_t charCode; /* character code in Mac Roman encoding */ sqIntptr_t pressCode; /* press code; any of EventKeyXXX */ 4 sqIntptr_t modifiers; /* combination of xxxKeyBit */ sqIntptr_t utf32Code; /* UTF-32 unicode value */ sqIntptr_t reserved1; /* reserved for future use */ sqIntptr_t windowIndex; /* host window structure */ } sqKeyboardEvent; #define EventTypeDragDropFiles 3 /* drop files event */ typedef struct sqDragDropFilesEvent { sqIntptr_t type; /* EventTypeDropFiles */ usqIntptr_t timeStamp; /* time stamp */ sqIntptr_t dragType; /* one of DragXXX (see below) */ sqIntptr_t x; /* mouse position x */ sqIntptr_t y; /* mouse position y */ 5 sqIntptr_t modifiers; /* combination of xxxKeyBit */ sqIntptr_t numFiles; /* number of files in transaction */ sqIntptr_t windowIndex; /* host window structure */ } sqDragDropFilesEvent; Is the bug that the VM has modifiers and utf32Code in the wrong order in sqKeyboardEvent? Or is it an image level bug? _,,,^..^,,,_ best, Eliot

1 0

RS FEC stabilized. All tests #Green!
by Robert Withers 27 Jun '21

27 Jun '21

Hi y'all, Progress. I managed to fix the remaining GF fields, including QRCode and the various Aztec fields. Verified with the RS Java code. Loading the latest ProCrypto-1-1-1 and ProCryptoTests-1-1-1 will load the latest RSFEC. > Installer ss > project: 'Cryptography'; > install: 'ProCrypto-1-1-1'; > install: 'ProCryptoTests-1-1-1'; > install: 'CryptographyRSPlugin'. Currently all methods are pluganized except for { #encode: #runEuclideanAlgorithm:..., #dividePoly... & @decode:twoS: }. I am getting segfaults on those primitives when called. Investigating... > - 41541 tallies, 53540 msec. > > ((116473 - 53540) / 116473) asFloat * 100 > 54% SpeedUp > > **Leaves** > > Unpluganized > 24.7% {13224ms} RSFECDecoderWithPlugin>>decode:twoS: > 3.0% {1587ms} RSFECDecoderWithPlugin>>runEuclideanAlgorithmPoly:poly:rDegrees: > > Pluganized > 16.9% {9045ms} RSFECGenericGFPoly class>>newField:coefficients: > 6.2% {3311ms} RSFECDecoderWithPlugin>>primFindErrorLocationsDegree:coefficients:fieldSize:expTable:logTable: > 4.2% {2245ms} RSFECGenericGFPolyWithPlugin>>addOrSubtractPoly: > 2.5% {1317ms} RSFECDecoderWithPlugin>>findErrorMagnitudes:errorLocations: > 1.7% {887ms} RSFECGenericGFWithPlugin>>log: > 1.1% {583ms} RSFECGenericGFPolyWithPlugin>>degree > > Other > 8.2% {4414ms} LargePositiveInteger(Integer)>>bitShift: > 5.8% {3115ms} SecureHashAlgorithm>>finalHash > 5.2% {2775ms} ByteArray class(Behavior)>>new: > 5.1% {2705ms} LargePositiveInteger>>+ > 3.1% {1639ms} SecureHashAlgorithm>>hashInteger:seed: > 2.4% {1260ms} SecureRandom>>nextRandom160 > 1.6% {833ms} SmallInteger(Magnitude)>>between:and: > 1.5% {786ms} ByteArray>>unsignedLongAt:put:bigEndian: -- --- Kindly, Robert

1 0

Recipe for mergine fix_include_order
by David T. Lewis 26 Jun '21

26 Jun '21

Here is my current recipe for merging the fix_include_order and dtl/epoll-forksqueak branches into the main Cog branch to produce a functioning VM on Linux (and hopefully Cygwin): $ cd <somewhere>/opensmalltalk-vm #my working git folder $ git reset --hard origin/Cog Now in an up to date VMMaker image: merge VMMaker.oscog-nice.2957 from inbox into into VMMaker.oscog-eem.2973 generated all sources $ tar czvf ../src.tgz *src* #save all previously generated sources $ git reset --hard Cog $ git merge fix_include_order $ tar xzvf ../src.tgz # reapply the sources that should not be included in merge $ git reset `git status | grep 'both modified' | sed s/'.*modified:'//` #discard changes as resolved $ git commit $ git merge dtl/epoll-forksqueak $ tar xzvf ../src.tgz $ git commit . -m 'restore sources' $ git push #if all of the above worked as expected HTH, Dave

1 0

In porting Java code a hotspot error
by Robert Withers 26 Jun '21

26 Jun '21

Below is some Java code, with a comment, from ZXing's ReedSolomon error correction. It points out a hotspot bug with a workaround. What would be the Squeak code to calculate the denominator? I'm guessing that this hotspot bug does not exist in Squeak. I tried this code and it fails: > denominator = field > multiply: denominator > by: (field > addOrSubtract: 1 > by: (field > multiply: (errorLocations at: j) > by: xiInverse)). Notice the commented out code in the first 2 lines of the java comment. The computation seems to revolve around > field addOrSubtract: 1 by: term or > (term & 0x1) == 0 ? term | 1 : term & ~1; Here is the Java code. > //denominator = field.multiply(denominator, > // GenericGF.addOrSubtract(1, field.multiply(errorLocations[j], xiInverse))); > // Above should work but fails on some Apple and Linux JDKs due to a Hotspot bug. > // Below is a funny-looking workaround from Steven Parkes > int term = field.multiply(errorLocations[j], xiInverse); > int termPlus1 = (term & 0x1) == 0 ? term | 1 : term & ~1; > denominator = field.multiply(denominator, termPlus1); -- --- Kindly, Robert

1 0

Build failed: opensmalltalk-vm 1.0.2460
by AppVeyor 23 Jun '21

23 Jun '21

1 0

Re: [Vm-dev] [OpenSmalltalk/opensmalltalk-vm] CogVM source as per VMMaker.oscog-eem.2970 (b0fc229)
by Fabio Niephaus 23 Jun '21

23 Jun '21

Well spotted! I've removed it with https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8a0d54a1725dd8389c…. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b0fc22902a86197a31…

1 0

[OpenSmalltalk/opensmalltalk-vm] 8a0d54: Remove extra double quote to fix compilation
by Fabio Niephaus 23 Jun '21

23 Jun '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 8a0d54a1725dd8389c1c36d09c120fdf7d760cd1 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8a0d54a1725dd8389c… Author: Fabio Niephaus <code(a)fniephaus.com> Date: 2021-06-23 (Wed, 23 Jun 2021) Changed paths: M platforms/win32/vm/sqWin32Window.c Log Message: ----------- Remove extra double quote to fix compilation The quote was introduced in https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b0fc22902a86197a31…

1 0

Build failed: opensmalltalk-vm 1.0.2459
by AppVeyor 23 Jun '21

23 Jun '21

1 0

[OpenSmalltalk/opensmalltalk-vm] 733d39: CogVM source as per VMMaker.oscog-eem.2973
by Eliot Miranda 23 Jun '21

23 Jun '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: 733d39cd4a36ac4683267df116688534e9d508fc https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/733d39cd4a36ac4683… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M spur64src/vm/cogit.h M spur64src/vm/cointerp.c M spur64src/vm/cointerp.h M spur64src/vm/cointerpmt.c M spur64src/vm/cointerpmt.h M spur64src/vm/gcc3x-cointerp.c M spur64src/vm/gcc3x-cointerpmt.c M spurlowcode64src/vm/cogit.h M spurlowcode64src/vm/cointerp.c M spurlowcode64src/vm/cointerp.h M spurlowcode64src/vm/gcc3x-cointerp.c M spurlowcodesrc/vm/cogit.h M spurlowcodesrc/vm/cointerp.c M spurlowcodesrc/vm/cointerp.h M spurlowcodesrc/vm/gcc3x-cointerp.c M spurlowcodestack64src/vm/gcc3x-interp.c M spurlowcodestack64src/vm/interp.c M spurlowcodestacksrc/vm/gcc3x-interp.c M spurlowcodestacksrc/vm/interp.c M spursista64src/vm/cogit.h M spursista64src/vm/cointerp.c M spursista64src/vm/cointerp.h M spursista64src/vm/gcc3x-cointerp.c M spursistasrc/vm/cogit.h M spursistasrc/vm/cointerp.c M spursistasrc/vm/cointerp.h M spursistasrc/vm/gcc3x-cointerp.c M spursrc/vm/cogit.h M spursrc/vm/cointerp.c M spursrc/vm/cointerp.h M spursrc/vm/cointerpmt.c M spursrc/vm/cointerpmt.h M spursrc/vm/gcc3x-cointerp.c M spursrc/vm/gcc3x-cointerpmt.c M spurstack64src/vm/gcc3x-interp.c M spurstack64src/vm/interp.c M spurstack64src/vm/validImage.c M spurstacksrc/vm/gcc3x-interp.c M spurstacksrc/vm/interp.c M spurstacksrc/vm/validImage.c Log Message: ----------- CogVM source as per VMMaker.oscog-eem.2973 Oops! The new SpurMemoryManager>shorten:toIndexableSize: needs marking as <api>. Rename bytesInObject: to bytesInBody: to indicate that it's a heap thang.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev June 2021