Vm-dev June 2021

vm-dev@lists.squeakfoundation.org

14 participants
74 discussions

Re: [Vm-dev] Reed Solomon plugins & performance slow down
by Levente Uzonyi 06 Jun '21

06 Jun '21

Hi Robert, I see the following potential causes: In #findErrorLocationsDegree:coefficients:count:fieldSize:result: the return value in ambiguous. You make the primitive fail if not enough errors are found. But after the send, you don't check for failure but simply send #methodReturnReceiver. Instead, you should either check for primitive failure after the send or make #findErrorLocationsDegree:coefficients:count:fieldSize:result: return boolean value: the method was successful or not. E.g. when numErrors = 1, return true, in the other branch, return e = numErrors. (If slang doesn't support boolean types, just use 0 and 1). In the actual primitive method, check for the value returned by that method and fail the primitive when needed. Once the primitive has failed, you ought to return from it. I see the above pattern in other methods too (marking the primitive as failed in a not-top-level method without checking for failure outside). Those need to be fixed as well. Another potential issue I see is that the validation of the arguments is not complete. E.g.: #stackIntegerValue: may have already set the primitive to failed if the argument was not an integer. So, before continuing, that has to be checked. Another possible but unlikely problem is that you assume that both result and coefficients have at least one field. But that may not be true which can result in segfaults. Levente

4 14

Reed Solomon plugins & performance slow down
by Robert Withers 03 Jun '21

03 Jun '21

Hey all'y'all, I got the plugins working correctly. Published to Cryptography. The plugins are attached. Unfortunately profiling indicates a slow down. The leaves did change from GaloisField methods to GaloisFieldPoly methods. I will work on pluginizing the GFPoly methods, such as #evaluateAt: & #multiplyByMonomialDegree:coefficient:... Here are the results without plugins (135 seconds): > WITHOUT PLUGINS > > - 132032 tallies, 135390 msec. > > **Tree** > -------------------------------- > Process: (40) 57626: nil > -------------------------------- > > **Leaves** > 16.9% {22843ms} RSFECGenericGF>>exp: > 9.2% {12450ms} RSFECGenericGF>>maskValue: > 8.6% {11659ms} RSFECGenericGF>>addOrSubtract:by: > 7.2% {9806ms} RSFECGenericGF>>log: > 6.6% {8958ms} RSFECGenericGF>>normalizeIndex: > 4.9% {6578ms} RSFECGenericGF>>multiply:by: > 2.3% {3130ms} RSErasureGalois>>maskValue: > 2.3% {3118ms} RSFECGenericGFPoly>>evaluateAt: > 1.6% {2175ms} RSErasureGalois>>normalizeIndex: > 1.3% {1718ms} RSFECGenericGFPoly>>addOrSubtractPoly: > 1.3% {1702ms} RSFECGenericGFPoly>>multiplyByMonomialDegree:coefficient: > 1.2% {1606ms} RSErasureGalois>>log: > 1.1% {1516ms} RSErasureGalois>>galoisMultiply:by: And here are the results with plugins (152 seconds): > WITH PLUGINS > > - 149040 tallies, 152531 msec. > > **Tree** > -------------------------------- > Process: (40) 89223: nil > -------------------------------- > > **Leaves** > 27.9% {42565ms} RSFECGenericGFWithPlugin>>addOrSubtract:by: > 17.3% {26440ms} RSFECGenericGFPoly>>evaluateAt: > 8.5% {12926ms} RSFECGenericGFWithPlugin>>maskValue: > 7.3% {11062ms} RSFECGenericGFPoly>>multiplyByMonomialDegree:coefficient: > 6.5% {9854ms} RSFECGenericGFPoly>>addOrSubtractPoly: > 5.6% {8598ms} RSFECGenericGFWithPlugin>>multiply:by: > 2.6% {4032ms} RSErasureGaloisWithPlugin>>galoisMultiply:by: > 2.4% {3601ms} RSErasureGaloisWithPlugin>>addOrSubtract:by: > 2.1% {3137ms} RSErasureGaloisWithPlugin>>maskValue: > 1.6% {2436ms} RSFECGenericGFPoly>>multiplyPoly: -- --- Kindly, Robert

2 13

[OpenSmalltalk/opensmalltalk-vm] ce0b42: and another one. [ci skip]
by Eliot Miranda 01 Jun '21

01 Jun '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: ce0b4204fc994b503091f710c323e10c4bdc137c https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/ce0b4204fc994b5030… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-06-01 (Tue, 01 Jun 2021) Changed paths: R platforms/unix/vm/feedback.h Log Message: ----------- and another one. [ci skip]

1 0

[OpenSmalltalk/opensmalltalk-vm] b68608: Nuke unused and empty file. [ci skip]
by Eliot Miranda 01 Jun '21

01 Jun '21

Branch: refs/heads/Cog Home: https://github.com/OpenSmalltalk/opensmalltalk-vm Commit: b68608ce4a2792204cd42a9351d3251ceb2c31f0 https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/b68608ce4a2792204c… Author: Eliot Miranda <eliot.miranda(a)gmail.com> Date: 2021-06-01 (Tue, 01 Jun 2021) Changed paths: R platforms/unix/vm/sqUnixWindow.h Log Message: ----------- Nuke unused and empty file. [ci skip]

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Vm-dev June 2021