Hi guys,
For a while now I have been trying to use FFI on the latest Etoys image, but something seemed to be broken on the Etoys image. I never took the time to look at it deeply until today. I think found the cause of this problem. It seems the Parser is not parsing external functions correctly. I fixed this by modifying the last line of Parser>>#externalFunctionDeclaration to add the pragma for the primitive 120 instead of simply returning 120 (I copied it from a squeak image). Now it seems to be working correctly and I think it doesn't have any undesirable side effect, although I'm not 100% sure. I published the change on etoysinbox. I don't know if somebody finds this useful but if you think it makes no harm, I'll be happy to move it to etoys.
Thanks! Richo
On 31.12.2010, at 04:08, Ricardo Moran wrote:
Hi guys,
For a while now I have been trying to use FFI on the latest Etoys image, but something seemed to be broken on the Etoys image. I never took the time to look at it deeply until today. I think found the cause of this problem. It seems the Parser is not parsing external functions correctly. I fixed this by modifying the last line of Parser>>#externalFunctionDeclaration to add the pragma for the primitive 120 instead of simply returning 120 (I copied it from a squeak image). Now it seems to be working correctly and I think it doesn't have any undesirable side effect, although I'm not 100% sure. I published the change on etoysinbox. I don't know if somebody finds this useful but if you think it makes no harm, I'll be happy to move it to etoys.
SInce we do not use FFI in Etoys (we don't even ship the plugin) this should be safe. Feel free to commit.
- Bert -
Great! Thanks
Richo
On Fri, Dec 31, 2010 at 8:50 AM, Bert Freudenberg bert@freudenbergs.dewrote:
On 31.12.2010, at 04:08, Ricardo Moran wrote:
Hi guys,
For a while now I have been trying to use FFI on the latest Etoys image, but something seemed to be broken on the Etoys image. I never took the time to look at it deeply until today. I think found the cause of this problem. It seems the Parser is not parsing external functions correctly. I fixed this by modifying the last line of Parser>>#externalFunctionDeclaration to add the pragma for the primitive 120 instead of simply returning 120 (I copied it from a squeak image). Now it seems to be working correctly and I think it doesn't have any undesirable side effect, although I'm not 100% sure. I published the change on etoysinbox. I don't know if somebody finds this useful but if you think it makes no harm, I'll be happy to move it to etoys.
SInce we do not use FFI in Etoys (we don't even ship the plugin) this should be safe. Feel free to commit.
- Bert -
etoys-dev mailing list etoys-dev@squeakland.org http://lists.squeakland.org/mailman/listinfo/etoys-dev
etoys-dev@lists.squeakfoundation.org
-
Bert Freudenberg -
Ricardo Moran