Re: [etoys-dev] [etoys-notify] [JIRA] Commented: (SQ-852) Reverb can't be stopped in project created on Windows 7
On 18.07.2011, at 17:38, Karl Ramberg (JIRA) wrote:
[ http://tracker.squeakland.org/browse/SQ-852 ]
Karl Ramberg commented on SQ-852:
I'm not sure why it initializes the process on every start...
It shouldn't, IMHO.
- Bert -
On Mon, Jul 18, 2011 at 5:44 PM, Bert Freudenberg bert@freudenbergs.dewrote:
On 18.07.2011, at 17:38, Karl Ramberg (JIRA) wrote:
[ http://tracker.squeakland.org/browse/SQ-852 ]
Karl Ramberg commented on SQ-852:
I'm not sure why it initializes the process on every start...
It shouldn't, IMHO.
- Bert -
I tested commenting out the initialization and it works just the same. It's just the PlayerProcess that needs to be started not SoundPlayer it self. Can you think of a situation where SoundPlayer it self will need initialization ?
Karl
On 18.07.2011, at 18:27, karl ramberg wrote:
On Mon, Jul 18, 2011 at 5:44 PM, Bert Freudenberg bert@freudenbergs.de wrote: On 18.07.2011, at 17:38, Karl Ramberg (JIRA) wrote:
[ http://tracker.squeakland.org/browse/SQ-852 ]
Karl Ramberg commented on SQ-852:
I'm not sure why it initializes the process on every start...
It shouldn't, IMHO.
- Bert -
I tested commenting out the initialization and it works just the same. It's just the PlayerProcess that needs to be started not SoundPlayer it self. Can you think of a situation where SoundPlayer it self will need initialization ?
Karl
No. It's really unusual to call a class-side initializer more than once.
- Bert -
On Mon, Jul 18, 2011 at 10:00 PM, Bert Freudenberg bert@freudenbergs.dewrote:
On 18.07.2011, at 18:27, karl ramberg wrote:
On Mon, Jul 18, 2011 at 5:44 PM, Bert Freudenberg bert@freudenbergs.dewrote:
On 18.07.2011, at 17:38, Karl Ramberg (JIRA) wrote:
[ http://tracker.squeakland.org/browse/SQ-852 ]
Karl Ramberg commented on SQ-852:
I'm not sure why it initializes the process on every start...
It shouldn't, IMHO.
- Bert -
I tested commenting out the initialization and it works just the same. It's just the PlayerProcess that needs to be started not SoundPlayer it self. Can you think of a situation where SoundPlayer it self will need initialization ?
Karl
No. It's really unusual to call a class-side initializer more than once.
- Bert -
Ok, so I'll remove the call to initialize and uncomment the preference code in initialize.
karl
On 19.07.2011, at 02:22, karl ramberg wrote:
On Mon, Jul 18, 2011 at 10:00 PM, Bert Freudenberg bert@freudenbergs.de wrote:
On 18.07.2011, at 18:27, karl ramberg wrote:
Can you think of a situation where SoundPlayer it self will need initialization ?
Karl
No. It's really unusual to call a class-side initializer more than once.
- Bert -
Ok, so I'll remove the call to initialize and uncomment the preference code in initialize.
karl
I vaguely remember this having to do with the MPEG player. It may change the default SamplingRate. We should check that it does not do this anymore.
- Bert -
On Tue, Jul 19, 2011 at 11:18 AM, Bert Freudenberg bert@freudenbergs.dewrote:
On 19.07.2011, at 02:22, karl ramberg wrote:
On Mon, Jul 18, 2011 at 10:00 PM, Bert Freudenberg bert@freudenbergs.dewrote:
On 18.07.2011, at 18:27, karl ramberg wrote:
Can you think of a situation where SoundPlayer it self will need initialization ?
Karl
No. It's really unusual to call a class-side initializer more than once.
- Bert -
Ok, so I'll remove the call to initialize and uncomment the preference code in initialize.
karl
I vaguely remember this having to do with the MPEG player. It may change the default SamplingRate. We should check that it does not do this anymore.
- Bert -
I ran one of the few mpg1 video files I could find and it did not change
the SamplingRate. I'll looks some more but very few people use the mpeg plugin I think...
Karl
etoys-dev@lists.squeakfoundation.org
-
Bert Freudenberg -
karl ramberg