The pink rectangle that pop up on a viewerline on mouseover was offset when the viewerline showed a color or graphic tile. This it a fix for that. Karl
'From OLPC2.0 of ''24 October 2006'' [latest update: #1364] on 16 June 2007 at 11:32:58 pm'!
!ViewerLine methodsFor: 'slot' stamp: 'k 6/16/2007 23:29'! addSetterFeedback "Add screen feedback showing what would be torn off to make a setter"
| aMorph | aMorph _ RectangleMorph new bounds: ((submorphs third topLeft - (2@1)) corner: (submorphs last bottomRight) + (2@0)). aMorph height:(submorphs third height + 1). aMorph beTransparent; borderWidth: 2; borderColor: (Color r: 1.0 g: 0.548 b: 0.452); lock. ActiveWorld addHighlightMorph: aMorph for: nil! !
Nice catch, Karl! Your fix has now been pushed to the olpc-etoys update stream.
Thanks,
-- Scott
On Jun 16, 2007, at 2:42 PM, karl wrote:
The pink rectangle that pop up on a viewerline on mouseover was offset when the viewerline showed a color or graphic tile. This it a fix for that. Karl 'From OLPC2.0 of ''24 October 2006'' [latest update: #1364] on 16 June 2007 at 11:32:58 pm'!
!ViewerLine methodsFor: 'slot' stamp: 'k 6/16/2007 23:29'! addSetterFeedback "Add screen feedback showing what would be torn off to make a setter"
| aMorph | aMorph _ RectangleMorph new bounds: ((submorphs third topLeft - (2@1)) corner: (submorphs last bottomRight) + (2@0)). aMorph height:(submorphs third height + 1). aMorph beTransparent; borderWidth: 2; borderColor: (Color r: 1.0 g: 0.548 b: 0.452); lock. ActiveWorld addHighlightMorph: aMorph for: nil! !
Etoys mailing list Etoys@lists.laptop.org http://lists.laptop.org/listinfo/etoys
Scott Wallace wrote:
Nice catch, Karl! Your fix has now been pushed to the olpc-etoys update stream.
Thanks,
-- Scott
Thanks for feedback :-)
There seems to be some other issues with the feedback rectangle where they sometimes surround all the tiles to pick up and sometimes they don't.
Like in the Basic category the rectangle does not surround the last tile in the 'make sound' viewer line.
And in the Tests category the rectangle surrounds all tiles in the 'overlaps' line but not in the 'overlaps any' line.
Also the color of the rectangle change between a magenta and a orange one. What are the rules for that ?
I can look into these issues.
Karl
On Jun 16, 2007, at 2:42 PM, karl wrote:
The pink rectangle that pop up on a viewerline on mouseover was offset when the viewerline showed a color or graphic tile. This it a fix for that. Karl 'From OLPC2.0 of ''24 October 2006'' [latest update: #1364] on 16 June 2007 at 11:32:58 pm'!
!ViewerLine methodsFor: 'slot' stamp: 'k 6/16/2007 23:29'! addSetterFeedback "Add screen feedback showing what would be torn off to make a setter"
| aMorph | aMorph _ RectangleMorph new bounds: ((submorphs third topLeft -
(2@1)) corner: (submorphs last bottomRight) + (2@0)). aMorph height:(submorphs third height + 1). aMorph beTransparent; borderWidth: 2; borderColor: (Color r: 1.0 g: 0.548 b: 0.452); lock. ActiveWorld addHighlightMorph: aMorph for: nil! !
Etoys mailing list Etoys@lists.laptop.org http://lists.laptop.org/listinfo/etoys
etoys-dev@lists.squeakfoundation.org