On 27.05.2011, at 13:04, commits@source.squeak.org wrote:
Karl Ramberg uploaded a new version of Etoys to project Etoys: http://source.squeak.org/etoys/Etoys-kfr.71.mcz
==================== Summary ====================
Name: Etoys-kfr.71 Author: kfr Time: 27 May 2011, 3:04:38 pm UUID: 10a6974c-fc1d-4d4a-997e-0d382c3bfbef Ancestors: Etoys-kfr.70
Put Kedama object in category UserObjects
=============== Diff against Etoys-kfr.70 ===============
Item was changed: ----- Method: KedamaExamplerPlayer>>copyAllMethodsAgain2 (in category 'debug support') ----- copyAllMethodsAgain2
| c result | c _ turtles class. result _ (ClassBuilder new) name: c name inEnvironment: c environment subclassOf: c superclass type: c typeOfClass instanceVariableNames: KedamaTurtleVectorPlayer2 instanceVariablesString classVariableNames: KedamaTurtleVectorPlayer2 classVariablesString poolDictionaries: KedamaTurtleVectorPlayer2 sharedPoolsString
category: 'UserObjects'.
turtles class copyAllCategoriesUnobtrusivelyFrom: KedamaTurtleVectorPlayer2. sequentialStub ifNotNil: [sequentialStub class copyAllCategoriesUnobtrusivelyFrom: KedamaSequenceExecutionStub].category: c category.
!
This should use "Object categoryForUniclasses", not hard-code the category name.
Also, did you test this works after loading the project? Meaning my analysis of #declareAndPossiblyRename: was wrong?
- Bert -
Ah, I'll do the not hard coded version.
Projects seem to work fine after this change I'll admit to only brief testing of this...
Karl
On Fri, May 27, 2011 at 4:21 PM, Bert Freudenberg bert@freudenbergs.dewrote:
On 27.05.2011, at 13:04, commits@source.squeak.org wrote:
Karl Ramberg uploaded a new version of Etoys to project Etoys: http://source.squeak.org/etoys/Etoys-kfr.71.mcz
==================== Summary ====================
Name: Etoys-kfr.71 Author: kfr Time: 27 May 2011, 3:04:38 pm UUID: 10a6974c-fc1d-4d4a-997e-0d382c3bfbef Ancestors: Etoys-kfr.70
Put Kedama object in category UserObjects
=============== Diff against Etoys-kfr.70 ===============
Item was changed: ----- Method: KedamaExamplerPlayer>>copyAllMethodsAgain2 (in category
'debug support') -----
copyAllMethodsAgain2
| c result | c _ turtles class. result _ (ClassBuilder new) name: c name inEnvironment: c environment subclassOf: c superclass type: c typeOfClass instanceVariableNames: KedamaTurtleVectorPlayer2
instanceVariablesString
classVariableNames: KedamaTurtleVectorPlayer2
classVariablesString
poolDictionaries: KedamaTurtleVectorPlayer2
sharedPoolsString
category: 'UserObjects'.
category: c category. turtles class copyAllCategoriesUnobtrusivelyFrom:
KedamaTurtleVectorPlayer2.
sequentialStub ifNotNil: [sequentialStub class
copyAllCategoriesUnobtrusivelyFrom: KedamaSequenceExecutionStub].
!
This should use "Object categoryForUniclasses", not hard-code the category name.
Also, did you test this works after loading the project? Meaning my analysis of #declareAndPossiblyRename: was wrong?
- Bert -
etoys-dev mailing list etoys-dev@squeakland.org http://lists.squeakland.org/mailman/listinfo/etoys-dev
On 28.05.2011, at 02:21, karl ramberg wrote:
Ah, I'll do the not hard coded version.
Projects seem to work fine after this change I'll admit to only brief testing of this...
Karl
What I meant is do the Kedama player classes get put into the UserObjects category when loaded from an "old" project, or into Morphic-Imports as before. Brief testing is fine :)
- Bert -
On Fri, May 27, 2011 at 4:21 PM, Bert Freudenberg bert@freudenbergs.de wrote:
On 27.05.2011, at 13:04, commits@source.squeak.org wrote:
Karl Ramberg uploaded a new version of Etoys to project Etoys: http://source.squeak.org/etoys/Etoys-kfr.71.mcz
==================== Summary ====================
Name: Etoys-kfr.71 Author: kfr Time: 27 May 2011, 3:04:38 pm UUID: 10a6974c-fc1d-4d4a-997e-0d382c3bfbef Ancestors: Etoys-kfr.70
Put Kedama object in category UserObjects
=============== Diff against Etoys-kfr.70 ===============
Item was changed: ----- Method: KedamaExamplerPlayer>>copyAllMethodsAgain2 (in category 'debug support') ----- copyAllMethodsAgain2
| c result | c _ turtles class. result _ (ClassBuilder new) name: c name inEnvironment: c environment subclassOf: c superclass type: c typeOfClass instanceVariableNames: KedamaTurtleVectorPlayer2 instanceVariablesString classVariableNames: KedamaTurtleVectorPlayer2 classVariablesString poolDictionaries: KedamaTurtleVectorPlayer2 sharedPoolsString
category: 'UserObjects'.
category: c category. turtles class copyAllCategoriesUnobtrusivelyFrom: KedamaTurtleVectorPlayer2. sequentialStub ifNotNil: [sequentialStub class copyAllCategoriesUnobtrusivelyFrom: KedamaSequenceExecutionStub].
!
This should use "Object categoryForUniclasses", not hard-code the category name.
Also, did you test this works after loading the project? Meaning my analysis of #declareAndPossiblyRename: was wrong?
- Bert -
etoys-dev mailing list etoys-dev@squeakland.org http://lists.squeakland.org/mailman/listinfo/etoys-dev
As usual you are right :-) I changed #declareAndPossiblyRename: as well.
Karl
On Sat, May 28, 2011 at 11:43 AM, Bert Freudenberg bert@freudenbergs.dewrote:
On 28.05.2011, at 02:21, karl ramberg wrote:
Ah, I'll do the not hard coded version.
Projects seem to work fine after this change I'll admit to only brief testing of this...
Karl
What I meant is do the Kedama player classes get put into the UserObjects category when loaded from an "old" project, or into Morphic-Imports as before. Brief testing is fine :)
- Bert -
On Fri, May 27, 2011 at 4:21 PM, Bert Freudenberg bert@freudenbergs.dewrote:
On 27.05.2011, at 13:04, commits@source.squeak.org wrote:
Karl Ramberg uploaded a new version of Etoys to project Etoys: http://source.squeak.org/etoys/Etoys-kfr.71.mcz
==================== Summary ====================
Name: Etoys-kfr.71 Author: kfr Time: 27 May 2011, 3:04:38 pm UUID: 10a6974c-fc1d-4d4a-997e-0d382c3bfbef Ancestors: Etoys-kfr.70
Put Kedama object in category UserObjects
=============== Diff against Etoys-kfr.70 ===============
Item was changed: ----- Method: KedamaExamplerPlayer>>copyAllMethodsAgain2 (in category
'debug support') -----
copyAllMethodsAgain2
| c result | c _ turtles class. result _ (ClassBuilder new) name: c name inEnvironment: c environment subclassOf: c superclass type: c typeOfClass instanceVariableNames: KedamaTurtleVectorPlayer2
instanceVariablesString
classVariableNames: KedamaTurtleVectorPlayer2
classVariablesString
poolDictionaries: KedamaTurtleVectorPlayer2
sharedPoolsString
category: 'UserObjects'.
category: c category. turtles class copyAllCategoriesUnobtrusivelyFrom:
KedamaTurtleVectorPlayer2.
sequentialStub ifNotNil: [sequentialStub class
copyAllCategoriesUnobtrusivelyFrom: KedamaSequenceExecutionStub].
!
This should use "Object categoryForUniclasses", not hard-code the category name.
Also, did you test this works after loading the project? Meaning my analysis of #declareAndPossiblyRename: was wrong?
- Bert -
etoys-dev mailing list etoys-dev@squeakland.org http://lists.squeakland.org/mailman/listinfo/etoys-dev
etoys-dev mailing list etoys-dev@squeakland.org http://lists.squeakland.org/mailman/listinfo/etoys-dev
etoys-dev@lists.squeakfoundation.org