On Apr 4, 2007, at 15:13 , Takashi Yamamiya wrote:
Bert,
you need to make sure the VM compiles even without the headers and libraries present. We need to have configure-time checks for all needed headers and libraries, and disable the plugin if those are not present. I see you check for the headers, but not for the libraries. There is an AC_PLUGIN_CHECK_LIB macro for this, see doc/ HowToBuildFromSource.txt
OK. I added a couple of AC_CHECK_LIBs because using both AC_TRY_COMPILE and AC_PLUGIN_CHECK_LIB caused an error in disablePlugin.c. This is somewhat ugly though, it seems to work well. I'm completely novice about the syntax of acinclude.m4, so please check it.
Yeah, I'm not quite sure how to do it better than that ... I think it's good enough for now. Maybe Ian will refine it when moving to the trunk :)
The proper way to make sure ogg or speex is installed would be in sugar-jhbuild sanitycheck.
I'll take a look at that.
I discussed this with Marco P. G. on IRC. He had an issue with adding this as a prerequisite for each Sugar developer. To which I replied that IMO every Sugar developer should be able to rely on certain media libraries. Which he found okay for ogg vorbis, but maybe not for speex. Speex already is on the OLPC, but that may be by accident. There is no definitive list of what the platform will support. Worse, there is no such list at all. Maybe a post to Sugar list would be in order ...
- Bert -