Philippe,

Am 06.09.18 um 17:22 schrieb Philippe Marschall:

Something like

self handler charSet is probably better than hard coding utf-8.

agreed. Although WAHtmlErorHandler doesn't implement #handler. So I ended up with this:

response

internalError;

contentType: ((WAMimeType textHtml) charset: self requestContext charSet);

Thanks for your tip.

For the record: if the error handler gets rendered as a child in the component tree, that setting of charset is not necessary, but it is necessare if the Error handler is the main component. Special characters might be wrong then if the server side is not using utf-8. It may even have such strange effects like a Firefox on Mac using a 1252 code page (which I thought is Windows specific...).

Joachim

Cheers Philippe

On Thu, Sep 6, 2018 at 3:24 PM Johan Brichau johan@inceptive.be wrote:

...

Something along these lines: E.g. In the handleDefault: method:

     errorDialog := WARenderCanvas builder
                                     fullDocument: true;
                                     rootBlock: [ :root | root beHtml5; title: anException description ];
                                     render: [ :html |  … whatever you want ... ].

     self requestContext respond: [ :response |
             response
                     internalError;
                     contentType: ((WAMimeType textHtml) charset: 'utf-8’);
                     nextPutAll: errorDialog ]

warning: coded in email editor ;) Take a look at WAHtmlErrorHandler as well

cheers Johan

...

On 6 Sep 2018, at 14:50, jtuchel@objektfabrik.de wrote:

Hi there,

I must be sitting on my brain at the moment...

How do I set the charset=utf-8 header in a WAHtmlErrorHandler subclass?

Joachim

---

seaside mailing list seaside@lists.squeakfoundation.org http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

---

seaside mailing list seaside@lists.squeakfoundation.org http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

---

seaside mailing list seaside@lists.squeakfoundation.org http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

Thanks!

Am 08.09.2018 um 17:14 schrieb Philippe Marschall philippe.marschall@gmail.com:

On Fri, Sep 7, 2018 at 7:57 AM jtuchel@objektfabrik.de jtuchel@objektfabrik.de wrote:

...

Philippe,

...

Am 06.09.18 um 17:22 schrieb Philippe Marschall: Something like

self handler charSet is probably better than hard coding utf-8.

agreed. Although WAHtmlErorHandler doesn't implement #handler. So I ended up with this:

    response

        internalError;

        contentType: ((WAMimeType textHtml) charset: self requestContext charSet);

Thanks for your tip.

https://github.com/SeasideSt/Seaside/issues/998

Cheers Philippe _______________________________________________ seaside mailing list seaside@lists.squeakfoundation.org http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/seaside

On Fri, Sep 7, 2018 at 7:59 AM jtuchel@objektfabrik.de jtuchel@objektfabrik.de wrote:

Thanks Johan,

Am 06.09.18 um 15:24 schrieb Johan Brichau:

Something along these lines: self requestContext respond: [ :response | response internalError; contentType: ((WAMimeType textHtml) charset: 'utf-8’);

This was exactly what was missing. WAMimeType>>#charset:

btw: I just noticed Seaside has implementers of charset: and charSet: unfortunately not in a way that you can always use either one. Maybe a candidate for a "next time we do some cleanup" list.

That has been known for a while :-(

https://github.com/SeasideSt/Seaside/issues/745

Cheers Philippe